insert (2)

>>>>     tag = readCurrentXmlTag();
>>>>     cout<<"tag is : "<<endl;  //??????????????
>>>>     while(  tag != "/branch")

Instead do

   while(  (tag = readCurrentXmlTag())  != "/branch")
   

With that the while will read the next tag at begin of each cycle.

>>>> I am implementing alex idea

The q. is a follow up of http:Q_24809171.html.

It is to parse a XML tree into a Tree class. The "idea" was to handle all children of a node (leafs or branches) in a loop rather than to handle siblings with a recursive call. Then the recursive call only happens for a new branch.

Right. Thanks for clarifying, Alex.

i changed it to
 while(  (tag = readCurrentXmlTag())  != "/branch")
    {
        cout<<"tag is : "<<endl;  //??????????????

        key = readCurrentXmlKey(tag);
    .........
}

tag is still empty. It is supposed to be "branch".


XmlTag-> read line :   <branch>
before return, Tag : branch
tag is :
XmlKey-> read line :      <attribute name="latin_name" value="Acanthocephala

>>>> tag is still empty. It is supposed to be "branch".

Remember there are initial tags which were not parsed. That's why your old code had a loop

    do
    {
        tag = readCurrentXmlTag();  // <branch> of <leaf>
        cout<<"tag is :"<<tag<<endl<<endl;
 
    }while ( tag.compare("")==0);

which was to ignore all definitions that do not belong to tree.

You can put that loop into a function 'ignoreInitialTags()' and call it once in parseXML. Or - maybe better - simply do

while(  (tag = readCurrentXmlTag())  != "/branch")
    {
        cout<<"tag is : "<<endl;  //??????????????
        if (tag.empty()) continue;   // ignores all tags other than branch, leaf, /branch, /leaf

        key = readCurrentXmlKey(tag);
    .........
}

   cout<<"tag is : "<<endl;  //??????????????  
it must be empty because i forgot the tag variable hihi.
 Working on the program now :)

>>>> it must be empty because i forgot the tag variable hihi.
Good catch ;-)

please tell me my bugs in this bugs

void Tree::parseXMLNode( TreeNode &parentNode)
{
    cout<<"Beginning of parseXMLNode"<<endl;
    string tag;
    string key;
    TreeNode child;

    while(  (tag = readCurrentXmlTag()) != "/branch")
    {
        cout<<"tag is : "<<tag<<endl;  

        key = readCurrentXmlKey(tag);
   
        if(!key.empty())
        {
            child.key = key;
            parentNode.children.push_back(child);
        }
        if(tag == "branch")
        {
            TreeNode &childRef = parentNode.children.back();

            draw();
            cout<<"childRef key is "<<childRef.key<<endl;
            parseXMLNode(childRef);
        }
        else if( tag =="leaf")
        {
            draw();
            parseXMLNode(parentNode);

            tag == readCurrentXmlTag();
            if(tag == "/leaf")
            {
                continue;
            }
        }
    }
    cout<<"current parent is : "<<parentNode.key<<endl<<endl;
    return;
}
 

u mean like this

void Tree::parseXMLNode( TreeNode &parentNode)
{
    cout<<"Beginning of parseXMLNode"<<endl;
    string tag;
    string key;
    TreeNode child;

    while(  (tag = readCurrentXmlTag()) != "/branch")
    {
        cout<<"**tag is : "<<tag<<endl;  
        key = readCurrentXmlKey(tag);
   
        if( key.empty())
        {
            cout << "empty key after readCurrentXmlKey(" << tag << ") " << endl;
            exit(1);
        }
       
        child.key = key;
        parentNode.children.push_back(child);
       
        if(tag == "branch")
        {
            TreeNode &childRef = parentNode.children.back();

            draw();
            cout<<"childRef key is "<<childRef.key<<endl;
            parseXMLNode(childRef);
        }
        else if( tag =="leaf")
        {
            draw();
            tag == readCurrentXmlTag();
            if(tag == "/leaf")
            {
                continue;
            }
            else
            {
                cout<<"****tag is :"<<tag<<endl;
                cout<<"Missing /leaf tag"<<endl;
            }
        }
    }
    cout<<"current parent is : "<<parentNode.key<<endl<<endl;
    return;
}

by the way, where are u from Alex?

>>>> u mean like this
Yes, though you need to handle the error, not simply go on. I. e. you best exit the program as there is no real chance to recover from those errors. Same is if you have errors when reading the tags. BUT, consider that EOF is not an error, i. e. after the last /branch the xml file necessarily must close somehow ;-)

>>>> by the way, where are u from Alex?
I am from Tuebingen, Germany.

i read your profile, but i can't understand your contact ...

The first part of the contact is info@

Did you compile the code? Any problems?

That thread is one of the last ones I will participate on. But it shouldn't become so long as the last one ;-)

when i comment out draw() in parseXMLNode, it can't display the tree after finish insertion. Also, It run infinitely with the real input file. So i am working in those issue.
can i email u for helps after u leave EE? hihi

>>>> can i email u for helps after u leave EE? hihi
Did you already make a test? ;-)

>>>> it can't display the tree after finish insertion. Also, It run infinitely with the real input file.
check your function where you read the file. You must check for eof before checking for fail - I mean to remember that you check for !input_stream - cause eof is also a fail condition. In case of eof you must return without error.

Always look at the call stack when debugging. For each new (sub-)branch in the xml you need one parseXMLNode call. And with the last /branch the *only* remaining parseXMLNode should return in the parseXML function.

i haven't tested your email before you grant.

i have checked my code. It works on sample input file. However, for the original input file, it can reach to the line number 128423 of 993119 lines. Please help.

#include <stdio.h>
#include <string>
#include <vector>
#include <fstream>
 
#include <iostream>
using namespace std;
 
 
struct TreeNode
{
    std::string key;
    std::vector<TreeNode> children;
};
 
class Tree
{
    // the one and only root node
    TreeNode root;
    ifstream fin;
 
public:  
    bool    ignoreStartTags();
    bool    parseXML();
    void    draw();
 
private:
    void    parseXMLNode(TreeNode &parentNode);
    string  readCurrentXmlTag();
    string  readCurrentXmlKey(string tag); 
    void    drawNode(TreeNode & parentNode, int indent);
};
 
 
string Tree:: readCurrentXmlKey(string tag)
{
    string key;
    char array[100];
    int counter = 0; 
    string str;
 
    if( tag == "branch" || tag == "leaf")
    {
        counter = 3;
    }
    else if(tag =="attribute") 
    {
        counter = 2;
    }
    else if( tag == "/leaf")
    {
        counter = 0;
    }
 
    if( !fin.eof())
    {
        for(int i = 0; i < counter; i ++)
        {
            fin.getline(array,100);
            
            str = array;
            if( str.empty())
            {
                cout<<"in break"<<endl;
                break;
            } 
            cout<<"XmlKey-> read line : "<<array<<endl;
 
            if( i == 0)
            {
                char * pch;
                char delims[]= "=\"" ;           //"<=\">"; //get " must use \" to distingusih between newline and " 
 
                pch = strtok(array,delims);
              //  printf("1st~~~~~%s\n",pch);
                while(pch != NULL)
                {
                    if( strcmp(pch,"latin_name") ==0 ) 
                    {
                        pch = strtok(NULL,delims);
                      //  printf("2nd~~~~~%s\n",pch);
                        pch = strtok(NULL,delims);
                      //  printf("3rd~~~~~%s\n",pch);  
 
                        key = pch;
                        //cout<<Value<<endl;
                        break;
                    }
                    pch = strtok(NULL,delims);
 
                }//end of  strtok while
            }// end of if counter == 0
        }//end of for
        cout<<"key is :"<<key<<endl;
 
    }// end of file    
    return key;
} 
bool Tree::ignoreStartTags()
{
    char array[1000]; 
    fin.open("Treeinput.txt",ios_base::in); 
    if (!fin) 
    {
        cout << "Fail to open file!!!."<< endl;
        return false;
    }
    else
    {
        // just ignore the first 8 lines
        for( int i = 0; i< 8; i++)
        {
            fin.getline(array,100);
        }
        return true;
    } 
} 
 
 
void Tree::drawNode ( TreeNode &parentNode, int indent)
{
    int i=0,j=0;
    indent ++;
     
    for( j =0; j <indent; j++)
    {
        cout<<"+";
    } 
    cout<<"\""<<parentNode.key<<"\""<<"  "<<endl;
    
    if( parentNode.children.size()== 0)
    {
        return;
    }
    else
    {
        for(int i = 0; i <parentNode.children.size();i++)
        {
            drawNode(parentNode.children[i],indent);
        }
    }
}
 
 
void Tree::draw()
{
    int indent = 0;
    cout<<endl<<"start display tree"<<endl;
    drawNode(root,indent);
}
 
bool Tree::parseXML() 
{
    string tag;
   //here in that function we put the loop you now have at begin of parseXMLNode
   //in case of read errors or missin g tags it return false
    
    if( !ignoreStartTags()) return false; 
    tag = readCurrentXmlTag(); 
    // read root key
    string key = readCurrentXmlKey(tag); 
    if( key.empty()) return false;
    root.key =key; 
    // now the root node is complete like any other parent node...
    parseXMLNode(root);
    return true;
} 
string Tree::readCurrentXmlTag()
{
    string Tag;
    char array[100];
    string str;
    
    if( !fin.eof())
    {
        fin.getline(array,100);
         
        str = array;
        if( str.empty() || str == "/tree" || str == "  ")
        {
            return Tag;
        } 
        cout<<endl<<"XmlTag-> read line : "<<array<<endl; 
        char tmp[100];
        strcpy(tmp,array);
 
        char * pch;
        char delims[]= "< >" ;          
 
        pch = strtok(array,delims);
        while(pch != NULL)
        {
            if( strcmp(pch,"branch")==0 || strcmp (pch,"/branch")== 0||
                strcmp(pch,"leaf")== 0 || strcmp (pch,"/leaf")== 0 || strcmp(pch,"attribute") == 0)
            {
                Tag = pch;   
                break;
            }
            pch = strtok(NULL,delims);
 
        }//end of  strtok while
        
        if(Tag =="/branch")
        {
           // beforePreviousCurrentTag = Tag;
            cout<<"--->Tag is /branch"<<endl;
        } 
        cout<<"before return, Tag : "<<Tag<<endl;
        return Tag;
    }
    else
    {
        fin.close();
        //exit(1);
        return Tag;
    }  
}
void Tree::parseXMLNode( TreeNode &parentNode)
{
    cout<<"Beginning of parseXMLNode"<<endl;
    string tag;
    string key;
    TreeNode child; 
    while(  (tag = readCurrentXmlTag()) != "/branch")
    {
        if(tag.empty() || tag == "/tree")
        {
            return;
        } 
        cout<<"**tag is : "<<tag<<endl;  
        key = readCurrentXmlKey(tag);
   
        if( key.empty())
        {
            cout << "empty key after readCurrentXmlKey(" << tag << ") " << endl;
            return;
        }
        
        child.key = key;
        parentNode.children.push_back(child);
        
        if(tag == "branch")
        {
            TreeNode &childRef = parentNode.children.back(); 
            //draw();
            cout<<"childRef key is "<<childRef.key<<endl;
            parseXMLNode(childRef);
        }
        else if( tag =="leaf")
        {
            //draw();
            tag == readCurrentXmlTag();
            if(tag == "/leaf")
            {
                continue;
            }
            else
            {
                cout<<"****tag is :"<<tag<<endl;
                cout<<"Missing /leaf tag"<<endl;
            }
        }
    }
    cout<<"current parent is : "<<parentNode.key<<endl<<endl;
    return;
}
 
int main()
{
    Tree tree;
    tree.parseXML();
   
    tree.draw();
 
    return 1;
}

                                              

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:
118:
119:
120:
121:
122:
123:
124:
125:
126:
127:
128:
129:
130:
131:
132:
133:
134:
135:
136:
137:
138:
139:
140:
141:
142:
143:
144:
145:
146:
147:
148:
149:
150:
151:
152:
153:
154:
155:
156:
157:
158:
159:
160:
161:
162:
163:
164:
165:
166:
167:
168:
169:
170:
171:
172:
173:
174:
175:
176:
177:
178:
179:
180:
181:
182:
183:
184:
185:
186:
187:
188:
189:
190:
191:
192:
193:
194:
195:
196:
197:
198:
199:
200:
201:
202:
203:
204:
205:
206:
207:
208:
209:
210:
211:
212:
213:
214:
215:
216:
217:
218:
219:
220:
221:
222:
223:
224:
225:
226:
227:
228:
229:
230:
231:
232:
233:
234:
235:
236:
237:
238:
239:
240:
241:
242:
243:
244:
245:
246:
247:
248:
249:
250:
251:
252:
253:
254:
255:
256:
257:
258:
259:
260:
261:
262:
263:
264:
265:
266:
267:
268:
269:
270:
271:
272:
273:
274:
275:
276:
277:
278:
279:
280:
281:
282:
283:
284:
285:
286:
287:
288:
289:
290:
291:
292:
293:
294:
295:

>>>> It works on sample input file.

Can you post your sample input file again (as a code snippet).

>>>> it can reach to the line number 128423 of 993119 lines.
Is there any special at this line? Or do you have memory problems?

You have a std::vector<TreeNode> children for each node. That probably is some 100 bytes for an average node or more.

Can you check the memory while your prog is running?

I can't run your program with the big inputfile before evening when I am at my appartment. But even than I only have a notebook as I am not at my home office but at my project's site.

how can i check the memory ? I attach my sample input file in code snippet
I run it on vmware virtual machine which has 1032 MB

here is line 128423

 <leaf>
              <attribute name="latin_name" value="Platyarthrus haplophthalmoides haplophthalmoides"/>
              <attribute name="common_name" value=""/>
              <attribute name="rank" value="Subspecies"/>
             </leaf>

and here is those lines at the end of the real input file

<leaf>
    <attribute name="latin_name" value="Pentastomida"/>
    <attribute name="common_name" value="pentastomes"/>
    <attribute name="rank" value="Subphylum"/>
   </leaf>
  </branch>
 </branch>
</tree>

you can run my program in the evening because it takes a while. I will come back later at Germany night time. Thanks a lot.

>>>> </tree>
Do you already handle taht?


>>>> run it on vmware virtual machine which has 1032 MB
Hmm. I assume you were running a debug version what means double memory for each piece of memory allocated at runtime.

Is it Windows platform? If yes, you should be able to start the taskmanager (CTRL+ALT+DEL or CTRL+ALT-INSERT) which has a performance tab where you could check the memory currently used (and size of swap file).

In any case a xml with 1 million lines probably is too big for your vmware environment. Can you post the full assignment so taht I could check whether the size of the input file is made intentionally so big in order to force your program to use minimal structures, e. g.

struct TreeNode
{
     char* szText;
     TreeNode* rightSibling;
     TreeNode* firstChild;
};

would have less overhead as your current node structure but could used alternatively with little changes.

You could try whether the following program would run:

#include <iostream>
#include <string>
#include <fstream>
#include <vector>

int main(int nargs, char* szargs[])
{
    if (nargs != 2)
    {
         std::cout << "usage: " << szargs[0] << " <path_to_xml_file> " << std::endl;
         return 1;
    }
    std::string line;
    std::ifstream ifs(szargs[1]);
    if (!ifs)
    {
         std::cout << "file " << szargs[1] << " couldn't be opened " << std::endl;
         return 2;
    }
    std::vector<std::string> > alllines;
    while (std::getline(ifs, line))
    {
         alllines.push_back(line);      
    }
    std::cout << "# of lines read: " << alllines.size() << std::endl;
    return 0;
}

It only reads the full xml to memory. In case the space of your programs was limited you might get problems here as well, or differently said, if the above wouldn't run there is no chance to process the tree program using your current environment.

>>>> std::vector<std::string> > alllines;
Should be
std::vector<std::string> alllines;

here is the output of your program

C:\OPENGL\Debug>testMemory C:\OpenGL\TreeinputBK.txt
# of lines read: 993119

It is windows platform Alex. In my code, I add condition to handle /tree already.

It worked.  Below are the last lines of output:

++++++++"Pseudechiniscus suillus facettalis"
++++++++"Pseudechiniscus suillus suillus"
+++++++"Pseudechiniscus victor"
+++++"Echiniscoididae"
++++++"Echiniscoides"
+++++++"Echiniscoides higginsi"
+++++++"Echiniscoides hoepneri"
+++++++"Echiniscoides pollocki"
+++++++"Echiniscoides sigismundi"
++++++++"Echiniscoides sigismundi galliensis"
++++++++"Echiniscoides sigismundi groenlandicus"
++++++++"Echiniscoides sigismundi hispaniensis"
++++++++"Echiniscoides sigismundi mediterranicus"
++++++++"Echiniscoides sigismundi sigismundi"
+++++"Oreellidae"
++++++"Oreella"
+++++++"Oreella minor"
+++++++"Oreella mollis"
+++++++"Oreella vilucensis"
+++"Mesotardigrada"
++++"Thermozodiidae"
+++++"Thermozodium"
++++++"Thermozodium esakii"
+++"Pentastomida"

could you please post the code? how can mine doesn't work?

>>>> could you please post the code?

I made a copy-paste of your last posted code.

>>>> how can mine doesn't work?

I run it on XP with a Core2Duo 2 x 2.1 GHz and 2 GB RAM. It finally needed about 35 MB memory and it lasted more than one hour. I assume your VM could not provide enough resources. Do you run it from the IDE, from command line or from explorer?

What you can do:

- I assume you have a home cumputer not running in a VM. Build the program there and try it. If you don't have a compiler get you the Visual Studio 2008 express edition.

- Remove all cout statements or put them between #ifdef _DEBUG - #endif or replace them by calls to OutputDebugString().

- In the drawNode use a ostringstream instead of cout and write the line to an output file.

- Build a release version of the program and run it from the command line.

BTW, your sample xml is not properly ended. It doesn't close all open branches with </branch> and there is no </tree>.

I run it from IDE. Let me make change as your recommendations. I wonder one more thing in my code

 if( str.empty() || str == "/tree" || str == "  ")

I include str == "  " because I see it get "  " during debugging. However, I don't know how it that value. Please explain. Thanks.

>>>> I include str == "  "

Sometimes there are space characters in text files especially when edited manually.

You should add a function trim which removes trailing blanks:

std::string & trim(std::string & s)
{
    int len = (int)s.size();
    while (len > 0 && isspace(s[--len]))
           s.resize(len);
    return s;
}

With that you can use trim(str) instead of str and it would remove the trailing blanks.

   

It still gets stuck the line 128423. I run it on  windows vista Pentium Dual Core 2.50Ghz, 3 GB as administrator.

>>>> It still gets stuck the line 128423.
What happens exactly? Any error message? How do you know the line number if you removed all teh cout statements? Try to run it in a dos box (copy the .exe from Release or Debug to the place where the xml files resides).
But increase the buffers of the dos box (5000). That way you'll get your output directly to the console.

I compile it and get the exe file. Then I copy both exe file and input file to vista system and run. I am using the Textpad to open the input file with Line Number feature. Output file last line is Platyarthrus haplophthalmoides haplophthalmoides. So i can get line number  is  128423

also , no error message

>>>> Output file last line is Platyarthrus haplophthalmoides haplophthalmoides

How to you produce the outputfile?

When running it in the IDE in Debug Mode you could set a break-point after final draw. Then you either should have a debug assertion somehow or it successfully reaches the breakpoint. In teh last case the *additional* console window should show you the last output lines.

here is how i make output file

=====
 
void Tree::drawNode ( TreeNode &parentNode, int indent)
{
    int i=0,j=0;
    indent ++;
     
    for( j =0; j <indent; j++)
    {
        cout<<"+";

        fout<<"+";
    }
    cout<<"\""<<parentNode.key<<"\""<<"  "<<endl;

    fout<<"\""<<parentNode.key<<"\""<<"  "<<endl;

    if( parentNode.children.size()== 0)
    {
        return;
    }
    else
    {
        for(int i = 0; i <parentNode.children.size();i++)
        {
            drawNode(parentNode.children[i],indent);
        }
    }
}
 
 
void Tree::draw()
{
    int indent = 0;
    cout<<endl<<"start display tree"<<endl;

    fout.open("Treeoutput.txt", ios::out );

    drawNode(root,indent);

    fout.close();
}

>>>> //draw();

The call of draw in parseXmlNode hopefully was commented ?


Note, your code was not the same than the one I have used. I took it from #25734089 which only outputs to cout.

I would suggest you take that code, build it, copy exe and inputfile to some (new) folder and run it from the console like

   treetest > output.txt

what would put all output into the output.txt.

     

i use #25734089 code
>>>> //draw();

The call of draw in parseXmlNode hopefully was commented ?
--> i commented out those draw() in parseXmlNode.
treetest > output.txt  produce same output file. I post the latest code here. You can try it.

#include <stdio.h>
#include <string>
#include <vector>
#include <fstream>
 
#include <iostream>
using namespace std;
 
 
struct TreeNode
{
    std::string key;
    std::vector<TreeNode> children;
};
 
class Tree
{
    // the one and only root node
    TreeNode root;
    ifstream fin; 
    ofstream fout;
 
public:  
    bool    ignoreStartTags();
    bool    parseXML();
    void    draw();
 
private:
    void    parseXMLNode(TreeNode &parentNode);
    string  readCurrentXmlTag();
    string  readCurrentXmlKey(string tag); 
    void    drawNode(TreeNode & parentNode, int indent);
    string & trim(std::string & s);
};
 
 
string & Tree :: trim(std::string & s)
{
    int len = (int)s.size();
    while (len > 0 && isspace(s[--len]))
           s.resize(len);
    return s;
} 
string Tree:: readCurrentXmlKey(string tag)
{
    string key;
    char array[100];
    int counter = 0; 
    string str;
 
    if( tag == "branch" || tag == "leaf")
    {
        counter = 3;
    }
    else if(tag =="attribute") 
    {
        counter = 2;
    }
    else if( tag == "/leaf")
    {
        counter = 0;
    }
 
    if( !fin.eof())
    {
        for(int i = 0; i < counter; i ++)
        {
            fin.getline(array,100);
            
            str = array; 
            if( str.empty())
            {
              //  cout<<"in break"<<endl;
                break;
            } 
            //cout<<"XmlKey-> read line : "<<array<<endl;
 
            if( i == 0)
            {
                char * pch;
                char delims[]= "=\"" ;           //"<=\">"; //get " must use \" to distingusih between newline and " 
 
                pch = strtok(array,delims);
              //  printf("1st~~~~~%s\n",pch);
                while(pch != NULL)
                {
                    if( strcmp(pch,"latin_name") ==0 ) 
                    {
                        pch = strtok(NULL,delims);
                      //  printf("2nd~~~~~%s\n",pch);
                        pch = strtok(NULL,delims);
                      //  printf("3rd~~~~~%s\n",pch);  
 
                        key = pch;
                        //cout<<Value<<endl;
                        break;
                    }
                    pch = strtok(NULL,delims);
 
                }//end of  strtok while
            }// end of if counter == 0
        }//end of for
       // cout<<"key is :"<<key<<endl;
 
    }// end of file    
    return key;
} 
bool Tree::ignoreStartTags()
{
    char array[1000]; 
    fin.open("Treeinput.txt",ios_base::in); 
    if (!fin) 
    {
        cout << "Fail to open file!!!."<< endl;
        return false;
    }
    else
    {
        // just ignore the first 8 lines
        for( int i = 0; i< 8; i++)
        {
            fin.getline(array,100);
        }
        return true;
    } 
} 
 
 
void Tree::drawNode ( TreeNode &parentNode, int indent)
{
    int i=0,j=0;
    indent ++;
     
    for( j =0; j <indent; j++)
    {
        cout<<"+"; 
        fout<<"+";
    } 
    cout<<"\""<<parentNode.key<<"\""<<"  "<<endl; 
    fout<<"\""<<parentNode.key<<"\""<<"  "<<endl; 
    if( parentNode.children.size()== 0)
    {
        return;
    }
    else
    {
        for(int i = 0; i <parentNode.children.size();i++)
        {
            drawNode(parentNode.children[i],indent);
        }
    }
}
 
 
void Tree::draw()
{
    int indent = 0;
    cout<<endl<<"start display tree"<<endl; 
    fout.open("Treeoutput.txt", ios::out ); 
    drawNode(root,indent); 
    fout.close();
}
 
bool Tree::parseXML() 
{
    string tag;
   //here in that function we put the loop you now have at begin of parseXMLNode
   //in case of read errors or missin g tags it return false
    
    if( !ignoreStartTags()) return false; 
    tag = readCurrentXmlTag(); 
    // read root key
    string key = readCurrentXmlKey(tag); 
    if( key.empty()) return false;
    root.key =key; 
    // now the root node is complete like any other parent node...
    parseXMLNode(root);
    return true;
} 
string Tree::readCurrentXmlTag()
{
    string Tag;
    char array[100];
    string str;
    
    if( !fin.eof())
    {
        fin.getline(array,100);
         
        str = array; 
        trim(str); 
        if( str.empty() || str == "/tree" || str == "  ")
        {
            return Tag;
        } 
        //cout<<endl<<"XmlTag-> read line : "<<array<<endl; 
        char tmp[100];
        strcpy(tmp,array);
 
        char * pch;
        char delims[]= "< >" ;          
 
        pch = strtok(array,delims);
        while(pch != NULL)
        {
            if( strcmp(pch,"branch")==0 || strcmp (pch,"/branch")== 0||
                strcmp(pch,"leaf")== 0 || strcmp (pch,"/leaf")== 0 || strcmp(pch,"attribute") == 0)
            {
                Tag = pch;   
                break;
            }
            pch = strtok(NULL,delims);
 
        }//end of  strtok while
        
        if(Tag =="/branch")
        {
          
          //  cout<<"--->Tag is /branch"<<endl;
        } 
        //cout<<"before return, Tag : "<<Tag<<endl;
        return Tag;
    }
    else
    {
        fin.close();
        //exit(1);
        return Tag;
    }  
}
void Tree::parseXMLNode( TreeNode &parentNode)
{
   // cout<<"Beginning of parseXMLNode"<<endl;
    string tag;
    string key;
    TreeNode child; 
    while(  (tag = readCurrentXmlTag()) != "/branch")
    {
        if(tag.empty() || tag == "/tree")
        {
            return;
        } 
        //cout<<"**tag is : "<<tag<<endl;  
        key = readCurrentXmlKey(tag);
   
        if( key.empty())
        {
            cout << "empty key after readCurrentXmlKey(" << tag << ") " << endl;
            return;
        }
        
        child.key = key;
        parentNode.children.push_back(child);
        
        if(tag == "branch")
        {
            TreeNode &childRef = parentNode.children.back(); 
            //draw();
            //cout<<"childRef key is "<<childRef.key<<endl;
            parseXMLNode(childRef);
        }
        else if( tag =="leaf")
        {
            //draw();
            tag == readCurrentXmlTag();
            if(tag == "/leaf")
            {
                continue;
            }
            else
            {
               // cout<<"****tag is :"<<tag<<endl;
               // cout<<"Missing /leaf tag"<<endl;
            }
        }
    }
    //cout<<"current parent is : "<<parentNode.key<<endl<<endl;
    return;
}
 
int main()
{
    Tree tree;
    tree.parseXML();
   
    tree.draw(); 
    
 
    return 1;
}

                                              

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:
118:
119:
120:
121:
122:
123:
124:
125:
126:
127:
128:
129:
130:
131:
132:
133:
134:
135:
136:
137:
138:
139:
140:
141:
142:
143:
144:
145:
146:
147:
148:
149:
150:
151:
152:
153:
154:
155:
156:
157:
158:
159:
160:
161:
162:
163:
164:
165:
166:
167:
168:
169:
170:
171:
172:
173:
174:
175:
176:
177:
178:
179:
180:
181:
182:
183:
184:
185:
186:
187:
188:
189:
190:
191:
192:
193:
194:
195:
196:
197:
198:
199:
200:
201:
202:
203:
204:
205:
206:
207:
208:
209:
210:
211:
212:
213:
214:
215:
216:
217:
218:
219:
220:
221:
222:
223:
224:
225:
226:
227:
228:
229:
230:
231:
232:
233:
234:
235:
236:
237:
238:
239:
240:
241:
242:
243:
244:
245:
246:
247:
248:
249:
250:
251:
252:
253:
254:
255:
256:
257:
258:
259:
260:
261:
262:
263:
264:
265:
266:
267:
268:
269:
270:
271:
272:
273:
274:
275:
276:
277:
278:
279:
280:
281:
282:
283:
284:
285:
286:
287:
288:
289:
290:
291:
292:
293:
294:
295:
296:
297:
298:
299:
300:
301:
302:

>>>> treetest > output.txt  produce same output file.

Shouldn't. Firstly all your debug outputs should be included in the output.txt. That probably is more than that of the final draw and might give you a clue why it breaks.

You might download the xml using the link you gave in the previous question. Make a diff to the one you were using. BTW, I hope your program is using 'Multibyte Character Set' and not UNICODE?

good morning Alex,
I commented all cout. How so can I have all debug output? Let me download the xml file and try it again.

after i removed all commments, I get this info before it stop

XmlTag-> read line :             <branch>
before return, Tag : branch
**tag is : branch
XmlKey-> read line :              <attribute name="latin_name" value="Platyarthrus haplophthalmoides"/>
XmlKey-> read line :              <attribute name="common_name" value=""/>
XmlKey-> read line :              <attribute name="rank" value="Species"/>
key is :Platyarthrus haplophthalmoides
childRef key is Platyarthrus haplophthalmoides

XmlTag-> read line :              <leaf>
before return, Tag : leaf
**tag is : leaf
XmlKey-> read line :               <attribute name="latin_name" value="Platyarthrus haplophthalmoides haplophthalmoides"
in break
key is :Platyarthrus haplophthalmoides haplophthalmoides

start display tree
...
   
which trace to
        if( str.empty())
            {
                cout<<"in break"<<endl;
                break;
            }

>>>> How so can I have all debug output?
First goal is to find out why your code doesn't work and mine worked.

So, take the code from #25734089 and the xml file from the link. That is what I used.

Run it from the command line so that all output was wriiten to text file.

after i removed all commments, I get this info before it stop

XmlTag-> read line :             <branch>
before return, Tag : branch
**tag is : branch
XmlKey-> read line :              <attribute name="latin_name" value="Platyarthrus haplophthalmoides"/>
XmlKey-> read line :              <attribute name="common_name" value=""/>
XmlKey-> read line :              <attribute name="rank" value="Species"/>
key is :Platyarthrus haplophthalmoides
childRef key is Platyarthrus haplophthalmoides

XmlTag-> read line :              <leaf>
before return, Tag : leaf
**tag is : leaf
XmlKey-> read line :               <attribute name="latin_name" value="Platyarthrus haplophthalmoides haplophthalmoides"
in break
key is :Platyarthrus haplophthalmoides haplophthalmoides

start display tree
...
   
which trace to
        if( str.empty())
            {
                cout<<"in break"<<endl;
                break;
            }

Hmmm.

Replace

>>>>            fin.getline(array,100);
>>>>            str = array;

by

      getline(fin, str);

I used an elder compiler which may not complain if the inputline was longer than 100. But maybe your compiler was not so *gentle* and may have returned an empty string.

Replace

>>>>            fin.getline(array,100);
>>>>            str = array;

by

      getline(fin, str);

gives output below:
XmlTag-> read line :  <branch>
before return, Tag : branch
XmlKey-> read line : ÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌ
XmlKey-> read line : ÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌ
XmlKey-> read line : ÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌÌ
key is :

start display tree
+""  

i think i found solution. let me double check first hihi

i got it.Can you guess how? Can i ask one more general question about this program before i close it :)

>>>> i got it.Can you guess how?

You increased the array[100] by array[1000] ?

you are right :) I increase array[100] to array [200]

N1
   N11
       L111
       L112
       L113
   N12
   N13
       N131
          L1311
       N132
          L1321


. By using your idea,no matter how many leafs  such as L111, L112, L113... recursive function will return N11 address because those leafs are taken care of a loop.
  By using Ike idea, let say we have 3 leafs L111, L112,L113.
             After it done L113, recursive function return N11 address
            After it done L112, recursive function return N11 address
           After it done L111, recursive function return N11 address

Am i right? Thanks a lot.

>>>>  By using Ike idea, let say we have 3 leafs L111, L112,L113.

After detetecting /leaf L113 recursive function returns. Parent is N11.
Then L112 recursive function returns as well (after having called recursive leaf function for L113). Parent is N11.
Then L111 recursive function returns as well (after having called recursive leaf function for L112). Parent is N11.
Then N11 recursive function returns as well  (after having called recursive leaf function for L112). Parent is N1.
Then new branch will be detected in N11 and recursive call for N12. Parent is N1.

Following Ike's idea you have two parsing functions, parseXMLNode and parseXMLLeaf.

The parseXMLNode

   - checks for branch tag at the beginning what is a sub branch and calls recursively parseXMLNode
   - checks for leaf tag at the beginning what is a leaf and calls parseLeafNode
   - both calls will return some time
   - now it gets difficult!
   - next tag must be /branch what is the end of the own (current) branch
   - checks for branch tag which would be a sibling and calls recursively parseXMLNode (same parent)
   - return

The parseXMLLeaf

   - next tag must be /leaf what is the end of the own (current) leaf
   - checks for leaf tag which would be a sibling and calls recursively parseXMLLeaf (same parent)
   - return

You could also do with one function but it makes the whole thing more difficult.

The main point in parseXMLNode following Ike's way is to have two recursive kind of calls, one for going down and one for going same level.

The idea here was to do all same level nodes/leafs in a loop what is much simpler.