Question

c++ '||' operator confusion

Asked by: Uncle13

I'm newish to c++ and I'm having some confusion about how the 'or'/'||' operator works
more specifically in the if statement I use an or operator so that if nameofgame isn't "Go" or "go" the condition will execute
But it's not working out. It works if I use only one like if (nameofgame != "go") but I've seen examples in books that check two things with 'or'. I've tried just about every combination of the two but it doesn't work (ie. if (nameofgame != "go" || nameofgame!="Go"),etc).
What have I done wrong?

#include <iostream>
#include <string> 
using namespace std; 
//string nameofgame; 
void rewardmsg(string nameofgame)
{
			//cout << nameofgame + "2" << endl;
			const string reward = "You're right!! The name of this game is "+nameofgame+"!";
			// second and fourth lines of reward message
			const string spaces(reward.size(), ' ');
			const string second = "* " + spaces + " *";
			// 1st and fifth lines of reward message
			const string first(second.size(), '*');
			cout << endl;
			cout << first << endl;
			cout << second << endl;
			cout << "* " << reward << " *" << endl;
			cout << second << endl;
			cout << first << endl;
}
	 
int main ()
{
	string row(19, '.');
	for (int i = 0; i < 19; ++i) { cout << row << endl; } // make a board
	cout << "What is the name of the game? ";
	string nameofgame;
	cin >> nameofgame;
	//cout << nameofgame + "1" << endl;
	//rewardmsg(nameofgame);
	if (nameofgame != "Go" || "go")
			cout << "Incorrect!." << endl; 
	else 
		
			rewardmsg(nameofgame);
		 
	return 0;
}
                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-11-03 at 15:20:07ID24869318
Tags

newbie question

,

c++

,

or

Topic

C++ Programming Language

Participating Experts
4
Points
50
Comments
19

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. conditional operator syntax
    I have string that contains information i want after the sixth comma, but the code i've written here won't return true for the if statement and goes into an infinite loop. Is the conditional operator syntax inaccurate? intCommaCount = 0 x = 0 Do While intCommaCount < 6 ...
  2. dynamic operator in IF condition
    Hi! I have a condition something like below where the comp_operator variable is dynamic and get's values such as "==", "<=" ">=" etc... But when I am using like this....it's throwing error.... Can anybody help me? if($row['remainingpoint...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: themrrobertPosted on 2009-11-03 at 15:29:01ID: 25735044

Try this

#include <iostream>
#include <string> 
using namespace std; 
//string nameofgame; 
void rewardmsg(string nameofgame)
{
			//cout << nameofgame + "2" << endl;
			const string reward = "You're right!! The name of this game is "+nameofgame+"!";
			// second and fourth lines of reward message
			const string spaces(reward.size(), ' ');
			const string second = "* " + spaces + " *";
			// 1st and fifth lines of reward message
			const string first(second.size(), '*');
			cout << endl;
			cout << first << endl;
			cout << second << endl;
			cout << "* " << reward << " *" << endl;
			cout << second << endl;
			cout << first << endl;
}
	 
int main ()
{
	string row(19, '.');
	for (int i = 0; i < 19; ++i) { cout << row << endl; } // make a board
	cout << "What is the name of the game? ";
	string nameofgame;
	cin >> nameofgame;
	//cout << nameofgame + "1" << endl;
	//rewardmsg(nameofgame);
	if ((nameofgame != "Go") || (nameofgame != "go"))
			cout << "Incorrect!." << endl; 
	else 
		
			rewardmsg(nameofgame);
		 
	return 0;
}

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:

Select allOpen in new window

 

by: themrrobertPosted on 2009-11-03 at 15:30:19ID: 25735053

I used:

if ( (nameofgame != "Go") || (nameofgame != "go") )


And we don't use periods "." after exclamation marks "!" typically.

 

by: JimUPosted on 2009-11-03 at 15:30:22ID: 25735055

Couple different ways to do it:
if (!(nameofgame == "Go" || nameofgame == "go"))

This would also work, using && operator:
if (nameofgame != "Go" && nameofgame != "go")

Also consider the possibility of making nameofgame all upper or lower case before doing the comparison as that would handle any combination of upper and lower case with only one comparison.

 

by: Uncle13Posted on 2009-11-03 at 15:32:55ID: 25735065

Tried that too, didn't work :(

 

by: JimUPosted on 2009-11-03 at 15:41:36ID: 25735119

What didn't work?

 

by: IbanUlovPosted on 2009-11-03 at 15:46:25ID: 25735154

Next code works:

#include <iostream>
#include <string> 
using namespace std; 
//string nameofgame; 
void rewardmsg(string nameofgame)
{
			//cout << nameofgame + "2" << endl;
			const string reward = "You're right!! The name of this game is "+nameofgame+"!";
			// second and fourth lines of reward message
			const string spaces(reward.size(), ' ');
			const string second = "* " + spaces + " *";
			// 1st and fifth lines of reward message
			const string first(second.size(), '*');
			cout << endl;
			cout << first << endl;
			cout << second << endl;
			cout << "* " << reward << " *" << endl;
			cout << second << endl;
			cout << first << endl;
}
	 
int main ()
{
	string row(19, '.');
	for (int i = 0; i < 19; ++i) { cout << row << endl; } // make a board
	cout << "What is the name of the game? ";
	string nameofgame;
	cin >> nameofgame;
	//cout << nameofgame + "1" << endl;
	//rewardmsg(nameofgame);
	if ((nameofgame!= "Go") && (nameofgame != "go"))
			cout << "Incorrect!." << endl; 
	else 
		
			rewardmsg(nameofgame);
		 
	return 0;
}

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:

Select allOpen in new window

 

by: Uncle13Posted on 2009-11-03 at 15:46:41ID: 25735155

I tried all the ways everyone suggested it still comes out the same every time. Maybe i'm just crazy does it compile for you?

 

by: JimUPosted on 2009-11-03 at 15:48:54ID: 25735168

Incidentally, if you want to convert it all to one case then you can do something like:

transform(nameofgame.begin(), nameofgame.end(), nameofgame.begin(), static_cast<int(*)(int)>(toupper));

Then the comparison is just:
if (nameofname != "GO")

If you use that then you will need to add these includes if you don't have them already:
#include <algorithm>
#include <cctype>

 

by: themrrobertPosted on 2009-11-03 at 15:49:34ID: 25735174

This code doesn't work?


#include <iostream>
#include <string> 
using namespace std; 
//string nameofgame; 
void rewardmsg(string nameofgame)
{
			//cout << nameofgame + "2" << endl;
			const string reward = "You're right!! The name of this game is "+nameofgame+"!";
			// second and fourth lines of reward message
			const string spaces(reward.size(), ' ');
			const string second = "* " + spaces + " *";
			// 1st and fifth lines of reward message
			const string first(second.size(), '*');
			cout << endl;
			cout << first << endl;
			cout << second << endl;
			cout << "* " << reward << " *" << endl;
			cout << second << endl;
			cout << first << endl;
}
	 
int main ()
{
	string row(19, '.');
	for (int i = 0; i < 19; ++i) { cout << row << endl; } // make a board
	cout << "What is the name of the game? ";
	string nameofgame;
	cin >> nameofgame;
	//cout << nameofgame + "1" << endl;
	//rewardmsg(nameofgame);
	if ((nameofgame!= "Go\n") && (nameofgame != "go\n"))
			cout << "Incorrect!." << endl; 
	else 
		
			rewardmsg(nameofgame);
		 
	return 0;
}
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:

Select allOpen in new window

 

by: Uncle13Posted on 2009-11-03 at 15:49:43ID: 25735176

*does it run correctly
It should run the function if I enter "go" or "Go" but it won't
I know I could flip it around, but I'm curious why it won't work the way i tried it and the way you've all recommended.

 

by: themrrobertPosted on 2009-11-03 at 15:52:54ID: 25735196

This code works for me.

#include <iostream> 
#include <string.h> 
using namespace std; 
//string nameofgame; 
void rewardmsg(string nameofgame)
{
			//cout << nameofgame + "2" << endl;
			const string reward = "You're right!! The name of this game is "+nameofgame+"!";
			// second and fourth lines of reward message
			const string spaces(reward.size(), ' ');
			const string second = "* " + spaces + " *";
			// 1st and fifth lines of reward message
			const string first(second.size(), '*');
			cout << endl;
			cout << first << endl;
			cout << second << endl;
			cout << "* " << reward << " *" << endl;
			cout << second << endl;
			cout << first << endl;
}
	 
int main ()
{
	string row(19, '.');
	for (int i = 0; i < 19; ++i) { cout << row << endl; } // make a board
	cout << "What is the name of the game? ";
	string nameofgame;
	cin >> nameofgame;
	//cout << nameofgame + "1" << endl;
	//rewardmsg(nameofgame);
	if ((nameofgame!= "Go") && (nameofgame != "go"))
			cout << "Incorrect!." << endl; 
	else 
		
			rewardmsg(nameofgame);
		 
	return 0;
}
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:

Select allOpen in new window

 

by: Uncle13Posted on 2009-11-03 at 15:53:19ID: 25735199

nvm xD I think I made a compiling mistake xD
o my xD sorry bout that

 

by: themrrobertPosted on 2009-11-03 at 15:54:43ID: 25735206

You can't use || with !='s


 

by: themrrobertPosted on 2009-11-03 at 15:57:22ID: 25735218

Well you can, but since you are giving the user an ERROR based on BOTH being wrong,

Go != go OR go != go = 1

If (1 )

cout << incorrect.



get it?

 

by: Uncle13Posted on 2009-11-03 at 16:00:34ID: 31649724

Ahh thanks that's what I was wondering about

 

by: Infinity08Posted on 2009-11-03 at 23:26:11ID: 25737135

Didn't JimU answer this first in http:#25735055 ?

 

by: themrrobertPosted on 2009-11-20 at 19:37:30ID: 25876345

I agree he eluded to it, but he did not answer the original question or correct the code first.

Also it was only 50 pts i think everyone was in it for charity. I know i was.

^_^

 

by: Infinity08Posted on 2009-11-21 at 03:24:29ID: 25877474

>> but he did not answer the original question or correct the code first.

I think that's exactly what he did. Did you look at his post http:#25735055 ?
Anyway, apparently, neither the author, nor JimU are interested in fixing this, so i'll just disappear in the background :)

 

by: JimUPosted on 2009-11-21 at 08:50:13ID: 25878513

As long as he got an answer.  I had unsubscribed after the "it didn't work" post (since it contained no further information).

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...