[x]
Posted via EE Mobile

Search, ask, and monitor your questions on the go with EE Mobile. Visit Experts Exchange from your mobile device and never be out of touch again.
07/25/2008 at 01:22PM PDT, ID: 23596723
[x]
Attachment Details
[x]
The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

  • The Grade of the Solution
  • The Zone Rank of the Expert Providing the Solution
  • The Number of Author and Expert Comments
  • The Number of Experts Contributing
  • The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!
8.0

The following needs to be rewritten.

Asked by mathieu_cupryk in C# Programming Language, Microsoft Visual C#.Net

I have the following code can somehelp me shorten it:
        public static decimal LoadDiscounts(System.Data.DataRow dr, System.Data.DataRow drPLH)
        {
            Decimal dec = 0.00M;
            dec = (Decimal)dr.ItemArray[2];
            if (dr.ItemArray[0].ToString() == "01") // Wheat
            {

                switch (dr.ItemArray[3].ToString())
                {
                    case "DAMP":
                        dec += Decimal.Parse(drPLH["WHT_DAMP_DISC_AMT"].ToString());
                         break;
                       
                    case "DAMP STONE":
                        dec += Decimal.Parse(drPLH["WHT_DAMP_DISC_AMT"].ToString()) + Decimal.Parse(drPLH["WHT_TOUGH_DISC_AMT"].ToString());
                         break;
                       
                    case "STONE":
                        dec += Decimal.Parse(drPLH["WHT_STONE_DISC_AMT"].ToString());
                         break;
                   
                    case "STRAIGHT":
                        // dr.ItemArray[2] = dr.ItemArray[2];  // not needed
                        break;
                    case "TOUGH":
                        dec += Decimal.Parse(drPLH["WHT_TOUGH_DISC_AMT"].ToString());
                         break;
                    case "TOUGH STONE":
                        dec += Decimal.Parse(drPLH["WHT_TOUGH_DISC_AMT"].ToString()) + Decimal.Parse(drPLH["WHT_STONE_DISC_AMT"].ToString());
                        break;
                }
            }

           
            if (dr.ItemArray[0].ToString() == "02") // Durum
            {
                switch (dr.ItemArray[3].ToString())
                {
                    case "DAMP":
                        dec += Decimal.Parse(drPLH["DURUM_DAMP_DISC_AMT"].ToString());
                        break;

                    case "DAMP STONE":
                        dec += Decimal.Parse(drPLH["DURUM_DAMP_DISC_AMT"].ToString()) + Decimal.Parse(drPLH["DURUM_TOUGH_DISC_AMT"].ToString());
                        break;

                    case "STONE":
                        dec += Decimal.Parse(drPLH["DURUM_STONE_DISC_AMT"].ToString());
                        break;

                    case "STRAIGHT":
                        // dr.ItemArray[2] = dr.ItemArray[2];  // not needed
                        break;
                    case "TOUGH":
                        dec += Decimal.Parse(drPLH["DURUM_TOUGH_DISC_AMT"].ToString());
                        break;
                    case "TOUGH STONE":
                        dec += Decimal.Parse(drPLH["DURUM_TOUGH_DISC_AMT"].ToString()) + Decimal.Parse(drPLH["DURUM_STONE_DISC_AMT"].ToString());
                        break;
                }
            }


            if (dr.ItemArray[0].ToString() == "04") // Barley
            {
                switch (dr.ItemArray[3].ToString())
                {
                    case "DAMP":
                          dec += Decimal.Parse(drPLH["BLY_DAMP_DISC_AMT"].ToString());
                        break;

                    case "DAMP STONE":
                            dec += Decimal.Parse(drPLH["BLY_DAMP_DISC_AMT"].ToString()) + Decimal.Parse(drPLH["BLY_TOUGH_DISC_AMT"].ToString());
                        break;

                    case "STONE":
                        dec += Decimal.Parse(drPLH["BLY_STONE_DISC_AMT"].ToString());
                        break;

                    case "STRAIGHT":
                        // dr.ItemArray[2] = dr.ItemArray[2];  // not needed
                        break;
                    case "TOUGH":
                        dec += Decimal.Parse(drPLH["BLY_TOUGH_DISC_AMT"].ToString());
                        break;
                    case "TOUGH STONE":
                        dec += Decimal.Parse(drPLH["BLY_TOUGH_DISC_AMT"].ToString()) + Decimal.Parse(drPLH["BLY_STONE_DISC_AMT"].ToString());
                        break;
                }
            }


            if (dr.ItemArray[0].ToString() == "64") // DesBarley
            {
                switch (dr.ItemArray[3].ToString())
                {
                    case "DAMP":
                        dec += Decimal.Parse(drPLH["DESIGTD_BLY_DAMP_DISC_AMT"].ToString());
                        break;

                    case "DAMP STONE":
                        dec += Decimal.Parse(drPLH["DESIGTD_BLY_DAMP_DISC_AMT"].ToString()) + Decimal.Parse(drPLH["DESIGTD_BLY_TOUGH_DISC_AMT"].ToString());
                        break;
                   case "STRAIGHT":
                        // dr.ItemArray[2] = dr.ItemArray[2];  // not needed
                        break;
                    case "TOUGH":
                        dec += Decimal.Parse(drPLH["DESIGTD_BLY_TOUGH_DISC_AMT"].ToString());
                        break;
                }
            }

            return dec;
        }
   
    }
I appreciate it.
 
Keywords: The following needs to be rewritten.
Title
1 Need the following rewritten so it does…
2 Rewrite the method.
 
Loading Advertisement...
 
[+][-]07/25/08 01:38 PM, ID: 22092105

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 30-day free trial to view this Expert Comment or ask the Experts your question.

 
[+][-]07/25/08 01:38 PM, ID: 22092109

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 30-day free trial to view this Expert Comment or ask the Experts your question.

 
[+][-]07/27/08 11:06 AM, ID: 22099130

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 30-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]07/27/08 11:50 AM, ID: 22099210

Experts Exchange has a courteous staff of administrators who help members get the most out of the website by means of administrative comments like this one.

Start your 30-day free trial to view this Administrative Comment or ask the Experts your question.

 
[+][-]07/27/08 11:52 AM, ID: 22099214

View this solution now by starting your 30-day free trial. Setting up your free trial is quick, easy, and secure. We will return you to this solution, unlocked, when you're done.

 

About this solution

Zones: C# Programming Language, Microsoft Visual C#.Net
Sign Up Now!
Solution Provided By: mathieu_cupryk
Participating Experts: 1
Solution Grade: A
 
 
 
Loading Advertisement...
20090824-EE-VQP-74 / EE_QW_2_20070628