	[x] Posted via EE Mobile
	Search, ask, and monitor your questions on the go with EE Mobile. Visit Experts Exchange from your mobile device and never be out of touch again.

Question

	[x] Attachment Details

[x]

The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

The Grade of the Solution
The Zone Rank of the Expert Providing the Solution
The Number of Author and Expert Comments
The Number of Experts Contributing
The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!

8.8

Can we condense this code? Is this the best way?

Asked by ProWebNetworks in C# Programming Language, Microsoft Visual C#.Net

I am trying to load a combo box with the entries from a recordset. I have found that i needed to create a class to store the values, but i think the class is convoluted and too much code. Any suggestions? I also added the override string into the class because it was simply presenting object names previously.

When I try to set the selected item to a specific value in code, it does not set. I think because the string override is only being present and not stored, so I am not doing this right.

If someone has an easier solution, you dont need to fix my code if there is better code for accomplishing this.

I am looking to load IDs, and Text from a recordset into a combobox, then have the ID show when I reference the .SelectedItem of the cbo.

Thanks!

View the Solution FREE for 30 Days

         
           
             1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:

           
           
             public class ComboTank
        {
            //need these variables to be used as storage of values
            public string cboValue="";
            public string cboDisplay="";
 
            public string struct_cboValue
            {
                get { return cboValue; }
            }
 
            public string struct_cboDisplay
            {
                get { return cboDisplay; }
            }
          
 
            public ComboTank(string ComboValue, string ComboDisplay)
            {
                cboValue = ComboValue;
                cboDisplay = ComboDisplay;
            }
 
          public override string ToString()
            {
                return struct_cboValue;
            }
 
 
        }
 
 
 
        private void Load_cboTax1()
        {
            cboTax1.Items.Clear();
            SqlConnection cbocn = new SqlConnection(PubVar.dbConn);
            cbocn.Open();
 
            SqlCommand cbocmd = new SqlCommand(PubVar.dbConn, cbocn);
            cbocmd.CommandText = "sp_LookupTaxCodes";
            cbocmd.CommandType = CommandType.StoredProcedure;
 
 
            DataTable cbotbl = new DataTable();
            SqlDataReader cbordr = cbocmd.ExecuteReader();
            
            cboTax1.DisplayMember = "struct_cboDisplay";
            cboTax1.ValueMember = "struct_cboValue";
 
 
            while (cbordr.Read())
            {
 
 
                cboTax1.Items.Add(new ComboTank(cbordr["TxCode"].ToString(), cbordr["DisplayValue"].ToString()));
 
            }
 
 
        }

           
         

20091021-EE-VQP-81 - Hierarchy / EE_QW_3_20080625

Hall of Fame

1. abel587,372
2. ragi0017424,858
3. TheLearn...350,594
4. Idle_Mind289,976
5. anarki_ji...289,340
6. jaime_oliv...246,139
7. MogalManic237,860
8. Dhaest234,933
9. kaufmed219,888
10. Fernando...208,644
11. daveamour176,106
12. guru_sami165,122
13. angelIII160,742
14. emoreau157,530
15. pivar152,031
16. mas_oz...150,888
17. daryal132,690
18. djjaries123,873
19. philipjonat...119,218
20. p_davis114,393
21. mrjoltcola113,138
22. ToddBeau...108,018
23. nmarun107,525
24. jinal104,197
25. Omego2K102,314

1. TheLearn...2,682,701
2. gregoryyo...1,422,807
3. jaime_oliv...1,367,459
4. Fernando...1,016,700
5. AlexFM994,109
6. Idle_Mind986,482
7. ragi0017829,921
8. angelIII733,688
9. gauthampj726,247
10. anarki_ji...720,610
11. dstanley9713,657
12. TheAvenger653,871
13. abel624,502
14. JimBrandley596,614
15. emoreau565,778
16. Dhaest557,024
17. Zephyr__442,269
18. MogalManic381,587
19. p_davis370,522
20. REA_AN...366,519
21. carl_tawn359,852
22. surajguptha359,057
23. Desp351,128
24. sumix328,743
25. _TAD_318,360

Can we condense this code? Is this the best way?

Asked by ProWebNetworks in C# Programming Language, Microsoft Visual C#.Net

About this solution