Question

Spring binding not reflected in the controller

Asked by: radsa

Hi
In my JSP, i used the spring:bind tag to bind the objects to a hashmap

After the changes to the jsp page in the browser, the onSubmit method of the Controller does not have the changes. Below are my code. Could some body please let me know what went wrong. Thanks in advance.

JSP code
<%@ include file="/WEB-INF/jsp/include.jsp" %>
<%@ taglib prefix="form" uri="http://www.springframework.org/tags/form" %>
<%@ include file="header.jsp" %>
<html>
<head>
</head>
<body>
	<form:form method="post" commandName="commandMap">
	<table width="100%" bgcolor="f8f8ff" style="border-collapse: collapse">
		<tr bgcolor="#00FFFF">
			<td width="20%" align="LEFT">Options</td>
			<td align="CENTER"><c:out value="${commandMap.model['userName']}"/> - <c:out value="${commandMap.model['userRole']}"/></td>
			<c:set var="userConfig" value="NONE"></c:set>
			<c:if test="${commandMap.model['userConfig'] != null}">
				<c:set var="userConfig" value="${commandMap.model['userConfig']}"></c:set>
			</c:if>
			<td align="RIGHT">Configuration-<a href= "/Validation/configManagementMain.htm"><c:out value="${userConfig}"/></a></td>
		</tr>
 
		<tr>
			<td width="20%">
			<%@ include file="menu.jsp" %>
			</td>
	 		<td width="80%">
	 		 <table>
	 		   <tr>
	 			<td width="100%">
	 				<jsp:include page="navigation.jsp">
	 		    		<jsp:param value="Home -> View Configuration Management" name="nav"/>
	 				</jsp:include>	
	 			</td>
	 		   </tr>
	 		   <tr align="right">
	 			<td>
					<INPUT TYPE="SUBMIT" OnClick="" VALUE="Update"> 			
					<INPUT TYPE="BUTTON" OnClick="cancel()" VALUE="Cancel">
	 			</td>
	 		   </tr>
	 		   <tr><td> </td></tr>
	 		   <tr>
	 		   	<td>
	 		   		Support Notification Distribution List
	 		   	</td>
	 		   </tr>
	 		   <tr>
	 		   	<td>
	 		   	<spring:bind path="commandMap.model['config'].supportNotificationDistribution">
					<input type="text" id="distList"
					readonly name="distList" value="${commandMap.model['config'].supportNotificationDistribution}">
					<INPUT TYPE="BUTTON" OnClick="addContact()" VALUE="Add Contact">
				</spring:bind>
				</td>
	 		   </tr>
	 		   <tr>
	 		   	<td>Notification Subject</td>
	 		   </tr>
	 		   <tr>
	 		   	<td>
	 		   	<spring:bind path="commandMap.model['config'].supportNotificationSubject">
	 		   	
					<input type="text" id="notificationSubject"
					name="notificationSubject" value="${commandMap.model['config'].supportNotificationSubject}">
				</spring:bind>
				</td>
	 		   </tr>
			   <tr>
	 		   	<td>Notification Header</td>
	 		   </tr>
	 		   <tr>
	 		   	<td>
	 		   	<spring:bind path="commandMap.model['config'].supportNotificationSubject">
	 		   		<textarea rows="5" cols="10" name="notificationBody">
	 		   			<c:out value="${commandMap.model['config'].supportNotificationBody}"/>
		 		   	</textarea>
		 		   	
		 		  </spring:bind>
	 			</td>
	 		   </tr>
			   <tr>
	 		   	<td>Invalid Plate Report Location</td>
	 		   </tr>
	 		   <tr>
	 		   	<td>
	 		   		<input type="file" name="browse" value"value" style="display: none;"/>
	 		   		<spring:bind path="commandMap.model['config'].invalidPlateReportLocation">	 
						<input type="text" id="plateReportLoc" name="plateReportLoc" readonly name="plateReportLoc" value="${commandMap.model['config'].invalidPlateReportLocation}">
						 
					</spring:bind> 
					<input type="button" onClick='javascript: browse.click(); file.value=browse.value;' value="Select Directory"/> 
	 			</td>
	 		   </tr>
	 		   <tr>
	 		   	<td>Select Results</td>
	 		   </tr>
	 		   <tr>
	 		   	<td>
	 		   		<table border="1">
	 		   		 <tr>
	 		   			<th>Test Name</th>
	 		   			<th>Test Description</th>
	 		   			<th>Validation ON/OFF</th>
	 		   			<th>Test Parameters</th>
	 		   		 </tr>
	 		   		 
					<c:forEach var="test" items="${commandMap.model['config'].tests}" varStatus="testIndex">
					
						<tr>
							
							<td>${test.testName}</td>
					 		<td>${test.testDesc}</td>
					 		<td>
						 	<spring:bind path="commandMap.model['config'].tests[${testIndex.index}].valTestOnOffFlag"> 
						       <input type="hidden" name="_<c:out value="${status.expression}"/>">
						       <input type="checkbox" name="<c:out value="${status.expression}"/>" value="true"
						            <c:if test="${status.value}">checked</c:if>/>
						    </spring:bind>
					 		</td>
					 		<c:if test="${test.testValue.valueType=='LIST'}">
					 			<c:set var="hrefUrl" value="/Validation/modifyListTest.htm?testName=${test.testValue}" />
					 		</c:if> 
					 		<c:if test="${test.testValue.valueType=='SINGLE'}">
					 			<c:set var="hrefUrl" value="/Validation/modifyMinMaxTest.htm?testName=${test.testValue}" />
					 		</c:if> 
					 		<c:if test="${test.testValue.valueType=='MINMAX'}">
					 			<c:set var="hrefUrl" value="/Validation/modifySingleTest.htm?configName=${test.testValue}" />
					 		</c:if> 
					 		
							<td><a href= "<c:out value='${hrefUrl}'/>">${test.testValue}</a></td>
						</tr>
					 </c:forEach>
	 		   		</table>
	 		   	</td>
	 		   </tr>
	 		   <tr><td> </td></tr>
	 		   <tr align="right">
	 			<td>
					<INPUT TYPE="SUBMIT" OnClick="" VALUE="Update"> 			
					<INPUT TYPE="BUTTON" OnClick="cancel()" VALUE="Cancel">
	 			</td>
	 		   </tr>
	 		 </table>
	 		</td>
		</tr>
	</table>
	</form:form>
	</body>
	</html>
<%@ include file="footer.jsp" %>
 
OnSubmit method of the Controller code
 
   protected ModelAndView onSubmit(Object command) throws ServletException {
    	HashMapCommand commandMap = (HashMapCommand)command;
    	Configuration config = (Configuration)commandMap.getModel().get("config");
    	Session.getConfigrationManager().getConfigDAO().modifyConfiguration(config);
        return new ModelAndView(new RedirectView(getSuccessView()));
    }
  
the bean servlet xml for the controller
 
     <bean name="/modifyConfigManagement.htm" class="com.pcone.pac.web.ModifyConfigController">
        <property name="sessionForm">
            <value>true</value>
        </property>
        <property name="commandName">
            <value>commandMap</value>
        </property>
        <property name="commandClass">
            <value>com.pcone.pac.bean.HashMapCommand</value>
        </property>
        <property name="formView">
            <value>modifyConfigManagement</value>
        </property>
        <property name="successView" value="viewConfigManagement.htm"/>
        <property name="validator">
            <bean class="com.pcone.pac.service.ConfigValidator"/>
        </property>
    </bean>

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:
118:
119:
120:
121:
122:
123:
124:
125:
126:
127:
128:
129:
130:
131:
132:
133:
134:
135:
136:
137:
138:
139:
140:
141:
142:
143:
144:
145:
146:
147:
148:
149:
150:
151:
152:
153:
154:
155:
156:
157:
158:
159:
160:
161:
162:
163:
164:
165:
166:
167:
168:
169:
170:
171:
172:
173:
174:
175:
176:
177:
178:
179:

Select all Open in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

Plus...

30 Day FREE access, no risk, no obligation
Collaborate with the world's top tech experts
Unlimited access to our exclusive solution database
Never be left without tech help again

Subscribe Now

Asked On: 2009-09-17 at 16:00:54ID24741808
Topics: Java Server Pages (JSP)
,; Spring
,; Apache Tomcat Application Server
Participating Experts: 1
Points: 500
Comments: 20

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

"The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
"Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
"Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Free Tech Articles

WARNING: 5 Reasons why you should NEVER fix a computer for free.
It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
SCCM OSD Basic troubleshooting
SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
Create a Win7 Gadget
This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
Outlook continually prompting for username and password
There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
Backup Exchange 2010 Information Store using Windows Backup
There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

Avoiding Bugs in Microsoft Access
Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
Top 10 Best New Features in Visio 2010
Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
IT Consultant Business Secrets Revealed
Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
Disaster Recovery and Business Continuity
Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
Organize Your Visio Diagrams with Containers and Lists
Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
How to Us Objects, Properties, Events and Methods in Microsoft Access
Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Watch More

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

by: dravidnsrPosted on 2009-09-17 at 22:09:45ID: 25363042

which value is not binding ?? is all vaue is not binding ??
which controller ur using ???

by: dravidnsrPosted on 2009-09-17 at 23:40:18ID: 25363302

<<<<<<<<< this is ur code ...

<spring:bind path="commandMap.model['config'].supportNotificationDistribution">
<input type="text" id="distList" readonly name="distList" value="${commandMap.model['config'].supportNotificationDistribution}">
<INPUT TYPE="BUTTON" OnClick="addContact()" VALUE="Add Contact">
</spring:bind>

for each bind ur not close the path ... check that No " > this symbol after path ending ...
befor start input type so do like this !!

<spring:bind path="commandMap.model['config'].supportNotificationDistribution">">

by: dravidnsrPosted on 2009-09-17 at 23:50:09ID: 25363334

sorry for previeous command ..
ur correct only ...

<input type="hidden" name="_<c:out value="${status.expression}"/>">

check that the error is there ??

by: dravidnsrPosted on 2009-09-17 at 23:52:22ID: 25363343

now i got correctly ..
the same error!!

<input type="text" id="distList" readonly name="distList" value="${commandMap.model['config'].supportNotificationDistribution}">
<INPUT TYPE="BUTTON" OnClick="addContact()" VALUE="Add Contact">

ur not close this input tag ... so that only its not bind thae value ...
give like this

<input type="text" id="distList" readonly name="distList" value="${commandMap.model['config'].supportNotificationDistribution}" />

each input u give like this only .....

by: dravidnsrPosted on 2009-09-17 at 23:52:50ID: 25363345

/ u must give after finish !!

by: radsaPosted on 2009-09-18 at 04:02:11ID: 25364589

Hi dravidnsr,

Thanks for the reply, i tried closing all the input tags and i still get the same behaviour. The modified values in the text boxes are not reflecting in the HashMapCommand object of the onSubmit method in the controller. Below is my controller. Should i do the binding in the initBinder method, if so could you please let me know how to do it.

public class ModifyConfigController extends SimpleFormController{
 
    protected final Log logger = LogFactory.getLog(getClass());
    
    @Override
    protected ModelAndView onSubmit(Object command) throws ServletException {
    	HashMapCommand commandMap = (HashMapCommand)command;
    	Configuration config = (Configuration)commandMap.getModel().get("config");
    	Session.getConfigrationManager().getConfigDAO().modifyConfiguration(config);
        return new ModelAndView(new RedirectView(getSuccessView()));
    }
    
    protected Object formBackingObject(HttpServletRequest request) throws ServletException {
    	
    	HashMapCommand command = new HashMapCommand();
        command.getModel().put("userName", Session.getUserManager().getCurrentUser().getPerson());
        command.getModel().put("userRole", Session.getUserManager().getCurrentUser().convertRolesToString());
        if(Session.getUserManager().getCurrentUser().getDefaultConfiguration()!=null)
        	command.getModel().put("userConfig", Session.getUserManager().getCurrentUser().getDefaultConfiguration().toString());
        else
        	command.getModel().put("userConfig", "NONE");
	
   	Configuration config;
		String configName = request.getParameter("configName");
		Session.getConfigrationManager().loadConfiguration(configName);
		config = Session.getConfigrationManager().getConfiguration();
		command.getModel().put("config", config);
        return command;
    }
}

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:

Select all Open in new window

by: dravidnsrPosted on 2009-09-18 at 04:22:09ID: 25364689

Hi radsa,

R u submit the page??

then only its go to onsubmit method ...

check ur onsubmit method give system.out.println there ??

by: dravidnsrPosted on 2009-09-18 at 04:23:11ID: 25364695

formBackingObject doest not need ?? command object that no use ....

if u checked in formBackingObject u get null value only ...

by: dravidnsrPosted on 2009-09-18 at 04:24:30ID: 25364704

try to use this ....

protected ModelAndView onSubmit(HttpServletRequest request,
HttpServletResponse response, Object command, BindException errors)
throws Exception { }

by: radsaPosted on 2009-09-18 at 05:58:52ID: 25365433

I will try that, I used formbackingobject since the form has to be prepopulated with the existing values from the database and the user can modify and click on update. The control is going to OnSubmit for the update button, but does not reflect the user changes, it just has the database values as i sent in the formbackingobject.

by: radsaPosted on 2009-09-18 at 06:04:30ID: 25365476

It still is the same,

i changed the onsubmit method signature to this
protected ModelAndView onSubmit(HttpServletRequest request,
HttpServletResponse response, Object command, BindException errors)
throws Exception {
.........
}

by: dravidnsrPosted on 2009-09-18 at 06:21:17ID: 25365611

is it .. ur page going to controller
after submit the page ????

<<<<<<< <INPUT TYPE="SUBMIT" OnClick="" VALUE="Update"> i think not ??
onclick u metion "" so that go any where remove and check !!

by: dravidnsrPosted on 2009-09-18 at 06:27:05ID: 25365668

I am sure the value is coming or its will say error ......

BCZ after submit the page it will go to validator only ... then only it coming to controller
if command value is null means u cant check any value ....

by: dravidnsrPosted on 2009-09-18 at 06:32:48ID: 25365742

what value is not bind ??
is all value ??

by: dravidnsrPosted on 2009-09-18 at 06:50:35ID: 25365905

oh my dear ....

u made silly mistake .... i think sooo

u never load spring taglib!!
<%@ taglib prefix="spring" uri="http://www.springframework.org/tags" %>

put it in ur jsp and try now (i think u msut got the solution .... )

all the best ...

by: radsaPosted on 2009-09-18 at 07:41:50ID: 25366461

Sorry to say, but still the same error, i did add the taglib to the jsp

Below is my validator. The control is going to the validator, still no changes to the values. It has the same values from the database, no changes are reflected. I am using
<form:form method="post" commandName="commandMap"> but using spring:bind is this fine. Should i only use <form:input path="">. If i do that, then how could i prepopulate the form, since there is no value parameter??

public class ConfigValidator implements Validator {
 
    HashMapCommand hashMapCommand;
 
    public boolean supports(Class clazz) {
        return HashMapCommand.class.isAssignableFrom(clazz);
    }
 
    public void validate(Object commandObject, Errors errors) {
    	System.out.println("Inside config validator");
    	hashMapCommand = (HashMapCommand)commandObject;
    	if(hashMapCommand.getModel().containsKey("config"))
    	{
    		PVCConfiguration c = (PVCConfiguration)hashMapCommand.getModel().get("config");
    		System.out.println(c.getSupportNotificationBody());
    		System.out.println(c.getSupportNotificationDistribution());
    		System.out.println(c.getSupportNotificationSubject());
    	}
    	
		
    }

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:

Select all Open in new window

by: radsaPosted on 2009-09-18 at 07:44:38ID: 25366490

The command value is not null, it just does not have the reflected changes which made in the form. It still has the same values which i sent using the formbackingobject

by: radsaPosted on 2009-09-18 at 08:43:03ID: 25367140

The checkbox in the form is binding correctly. At the begining the formbackingobject the test values are false and when the form shows up i clicked on the text box and hit update, the boolean value is showing as true now.

So the textboxes and the textarea are only not binding correctly.

Any help is greatly appreciated.

by: radsaPosted on 2009-09-18 at 09:40:37ID: 25367693

Got it working
Thanks for your help

by: dravidnsrPosted on 2009-09-18 at 23:03:12ID: 25371675

ur seeting the checkbox default value as true ...

<input type="checkbox" name="<c:out value="${status.expression}"/>" value="true"
<c:if test="${status.value}">checked</c:if>/>

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

For individual users
Instant access to solutions
Ask your tech questions
Start your 30-day Free Trial

Business Accounts

Perfect for organizations
Multiple users
Save over 36%
Create a Business Account

Answer for Membership

Earn free access
Showcase your knowledge
No credit card required
Sign Up to Answer

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...

Question

Spring binding not reflected in the controller

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

Java Server Pages (JSP)

Spring

Apache Tomcat Application Server

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Need individual assistance?

Our experts are ready to help.

Want to learn from the best?

Read articles from industry experts.

Working on a long term project?

Store your work and research.

What Makes Experts Exchange Unique?

Trusted by the world's most respected brands.

Faithfully serving IT professionals since 1996.

Related Solutions

Free Tech Articles

Cloud Class Webinars

Join the Community

Give a Little. Get a Lot.

Answers

3 Ways to Join

The Experts

The Experts

Testimonials

Testimonials

Testimonials

Business Clients

Business Clients

In the Press

In the Press

In the Press