Question

Passing Connection objects between servlets

Asked by: whitej8

I have a servlet that needs to access the functionality of another servlet.  The two servlets, user and annotation, are very similiar each opens a connection to the database during init().

I need to get user information out of the database while processing the annotation.  I open the connection in the annotation and then pass it to method contained within the user.cUser class.  When I then try to query the database from the user.cUser object I get a java.sql.SQLException: Before start of result set

What's the problem?

From the doGet method of annotation.java
            //TO DO test for user_id and oai_id

            //get user name
            user.SQLParam user_param = new user.MySQLParam();
            cUser mUser = new cUser(conn, user_param, Long.parseLong(request.getParameter("user_id")));

            session.setAttribute("user_name",   mUser.user_name);
            session.setAttribute("user_id", mUser.getUserIDString());

The constructor
    public cUser(Connection con, SQLParam param, long UserID){
        Statement stmt = null;
        try {
            System.out.println("cUser.getUser " + param.getSelectByIDStatement(UserID));

            stmt = con.createStatement();
            ResultSet rs=stmt.executeQuery(param.getSelectByIDStatement(UserID));

            user_id          = UserID;
            user_name        = rs.getString("user_name");
            alias            = rs.getString("alias");
            user_bio         = rs.getString("user_bio");
            user_bio_short   = rs.getString("user_bio_short");

        } catch (SQLException e) {
            System.out.println(e);
            System.out.println("throwing SQLException from cUser.cUser(Connection con, SQLParam param, int UserID)");
        }
    }


This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2003-01-09 at 08:37:34ID20449908
Topics

Java Programming Language

,

Java Servlets

Participating Experts
2
Points
200
Comments
13

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Difference Between doPost and doGet
    I need to know the real difference between doPost and doGet methods.. And how exactely this two works in context of Java Servlets? Thanks ...
  2. Servlet
    I want to invoke a servlet thru servlet and pass some values from this servlet without involving the html content.I want to submit a information from a sevlet to another servlet along with values.Its very urgent.Please help me soon.
  3. Passing ResultSet in Applet-Servlet Communication..
    How to pass a ResultSet in a typical Applet<->Servlet communication from servlet to applet? I am getting notSerilizable object Exception while passing ResultSet. That is because ResultSet does not extend Serializable. But I need to pass it. Any solution??? Storing all ...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: whitej8Posted on 2003-01-09 at 08:37:59ID: 7695114

Entire cUser class

package annotation;
import java.io.*;
import java.util.zip.*;
import java.util.*;
import java.lang.*;
import java.awt.event.*;
import javax.servlet.*;
import javax.servlet.http.*;
import java.sql.*;

import db.*;
import ns.*;
import search.*;
import user.*;

public class Annotation extends HttpServlet
{
    public final static String SESSION_SINGLE_METADATA="search.SingleMetadata";
    public final static String SESSION_SINGLE_METADATA_ARCHIVE="search.SingleMetadataArchive";
    public final static String SESSION_SINGLE_METADATA_NEXT="search.SingleMetadataNext";
    public final static String SESSION_SINGLE_METADATA_PREV="search.SingleMetadataPrev";
    public final static String SESSION_SINGLE_ANNOTATION_METADATA="search.SingleAnnotationMetatdata";
    public final static String SESSION_DBSEARCHER="search.dbsearcher";

    public final static String SESSION_USER_INFO = "user.user_info";
   
    public final static String APP_ANNOTATION_CONN = "annotation_connection";


    private ConnectionPool cpool;
    private static Connection conn;
    private int dbtype;

    private Vector fieldlist;
    private Hashtable fieldhash;
    private Hashtable err;
   
    public final static String SESSION_CONN="annotation.conn";
    public final static String APP_ANNOTATION_FIELDS="annotation.fieldlist";

    //////////////////////////////////////////////////////
    public void doGet (HttpServletRequest request, HttpServletResponse response)
    throws ServletException, IOException    
    {
        String formname=request.getParameter("formname")!=null?request.getParameter("formname"):"";
        HttpSession session = request.getSession(true);
        response.setContentType("text/html");

        conn=cpool.getConnection();
        SQLParam param = new MySQLParam();


        if (formname.equals("save_annotation")){
            // Annotation is ready to be saved
            System.out.println("Starting Annotation");

            try{                              
                cAnnotation m_annotation = new cAnnotation(request);
   
                m_annotation.Save(conn,param,m_annotation,false);  //we cannot update from this form update is an admin feature and must use a different form

            } catch (Exception e){
                //redirect and display errors
                System.out.println("Error");
                response.sendRedirect(request.getContextPath()+"/error.jsp");
                return;
            }

        } else if (formname.equals("user_annotation")) {
          // user has enter annotation and it is ready for preview
           
            cAnnotation m_annotation = new cAnnotation(request);
           
            //return current values to form
            session.setAttribute("user_id",     m_annotation.getUserIDString());
            session.setAttribute("element",     m_annotation.element);
            session.setAttribute("value",       m_annotation.value);
            session.setAttribute("oai_id",      m_annotation.oai_id);

            //is input valid
            if (!isValid(m_annotation)){
                 session.setAttribute("err", err);
                 response.sendRedirect(request.getContextPath() + "/annotation.jsp");    
            } else {
           
                // get search results for annotated record then display annotation_preview.jsp
                String id=null;
               
                try
                {
                    id=java.net.URLDecoder.decode(request.getParameter("oai_id"));
                    System.out.println("id="+id);
                }
                catch (Exception e)
                {
                    throw new ServletException("annotation preview page");
                }
               
                SearchParam search_param=null;
                search_param = new BookBagParam(request);
   
                DBSearcher os = new DBSearcher(search_param);    
   
                CMetaData metadata=DBSearcher.getMetaData(conn,id);
   
                Vector annotation=DBSearcherAnnotation.getAnnotationMetaData(conn,id);
               
                if (metadata==null)
                {
                    throw new ServletException("annotation preview page");
                }
   
                session.setAttribute(SESSION_SINGLE_METADATA, metadata);
                session.setAttribute(SESSION_SINGLE_ANNOTATION_METADATA, annotation);
   
                int index = os.getIndex (id);
                int hits = os.GetNumHits ();
               
                if (index+1<hits)
                {
                      
                      CMetaData next=os.getMetaData(conn,index+1);
                      session.setAttribute(SESSION_SINGLE_METADATA_NEXT,next.id);
                }
                else
                      session.setAttribute(SESSION_SINGLE_METADATA_NEXT,null);
                      
                if (index-1>=0)
                {
                      
                      CMetaData prev=os.getMetaData(conn,index-1);
                      session.setAttribute(SESSION_SINGLE_METADATA_PREV,prev.id);
                }
                else
                {
                      session.setAttribute(SESSION_SINGLE_METADATA_PREV,null);      
               
                    cpool.close(conn);    
                    response.sendRedirect(request.getContextPath()+"/annotation_preview.jsp");
                }
            }  //end validation
        } else { //formname not set load annotation page for the first time
            //TO DO test for user_id and oai_id

            //get user name
            user.SQLParam user_param = new user.MySQLParam();
            cUser mUser = new cUser(conn, user_param, Long.parseLong(request.getParameter("user_id")));

            session.setAttribute("user_name",   mUser.user_name);
            session.setAttribute("user_id", mUser.getUserIDString());
           
            response.sendRedirect(request.getContextPath()+"/annotation.jsp?oai_id=" + request.getParameter("oai_id"));
        }

    }


    //////////////////////////////////////////////////////
    public void doPost (HttpServletRequest request, HttpServletResponse response)
    throws ServletException, IOException    
    {
        doGet(request,response);
    }

    //////////////////////////////////////////////////////
    public void init (ServletConfig config) throws ServletException
    {

        //Open DB Connectionafreader
        ServletContext context=config.getServletContext();
        Object o=context.getAttribute(ConnectionServlet.KEY);
        if (o==null){
            throw new ServletException("ConnectionServlet not started");
        }

        cpool=(ConnectionPool)o;
       
        conn =(Connection) cpool.getConnection ();

        dbtype=cpool.getDBType();


        //Get field information for new annotations
        AnnotationFieldReader afreader=new AnnotationFieldReader(cpool, dbtype);
        afreader.init();
      fieldlist=afreader.getFieldList();
        fieldhash=afreader.getHashedFieldlist();

        context.setAttribute(APP_ANNOTATION_CONN, conn);

      context.setAttribute(APP_ANNOTATION_FIELDS,fieldlist);

        System.out.println("Started Annotations");
           
    }

    //////////////////////////////////////////////////////
    public void destroy()
    {
        if (cpool!=null)
            cpool.destroy();
        super.destroy();
    }

    //////////////////////////////////////////////////////
    public String getServletInfo() {
        return "The Annotation Servlet";
    }


    public boolean isValid(cAnnotation m_annotation) {
        if (err==null) err = new Hashtable();
       
        err.clear();  //clear any previous errors
         if (m_annotation.oai_id.equals("")) {
            err.put("oai_id", "Fatal Error: No oai id");
        }
 
        if (m_annotation.element.equals("")) {
            err.put("element", "Please select a field to annotate");
        }

        AFInfo af = (AFInfo)fieldhash.get(m_annotation.element);
        int maxlength = Integer.parseInt(af.field_length); //get maxlength for element

        if (m_annotation.value.equals("") || m_annotation.value.length() > maxlength) {
            err.put("value", "Annotations for " + af.field_label + " must be between 1 and " + maxlength + " characters.");
        }
       
        System.out.println(Boolean.toString(err.isEmpty()));        
        return err.isEmpty();
    }

}

 

by: whitej8Posted on 2003-01-09 at 08:38:32ID: 7695117

Entire cUser class

    public cUser(Connection con, SQLParam param, long UserID){
        Statement stmt = null;
        try {
            System.out.println("cUser.getUser " + param.getSelectByIDStatement(UserID));

            stmt = con.createStatement();
            ResultSet rs=stmt.executeQuery(param.getSelectByIDStatement(UserID));

            user_id          = UserID;
            user_name        = rs.getString("user_name");
            alias            = rs.getString("alias");
            user_bio         = rs.getString("user_bio");
            user_bio_short   = rs.getString("user_bio_short");

        } catch (SQLException e) {
            System.out.println(e);
            System.out.println("throwing SQLException from cUser.cUser(Connection con, SQLParam param, int UserID)");
        }
    }

 

by: whitej8Posted on 2003-01-09 at 08:39:05ID: 7695119

try again

package user;

import javax.servlet.http.*;
import java.sql.*;


public class cUser
{
   
    public long user_id;
    public String user_name;
    public String alias;
    public String user_bio;
    public String user_bio_short;
    public String status;


    public cUser(HttpServletRequest request)
    {
       user_id          = Long.parseLong(request.getParameter("user_id"));
       user_name        = request.getParameter("user_name");
       alias            = request.getParameter("alias");
       user_bio         = request.getParameter("user_bio");
       user_bio_short   = request.getParameter("user_bio_short");
    }

    public cUser(Connection con, SQLParam param, long UserID){
        Statement stmt = null;
        try {
            System.out.println("cUser.getUser " + param.getSelectByIDStatement(UserID));

            stmt = con.createStatement();
            ResultSet rs=stmt.executeQuery(param.getSelectByIDStatement(UserID));

            user_id          = UserID;
            user_name        = rs.getString("user_name");
            alias            = rs.getString("alias");
            user_bio         = rs.getString("user_bio");
            user_bio_short   = rs.getString("user_bio_short");

        } catch (SQLException e) {
            System.out.println(e);
            System.out.println("throwing SQLException from cUser.cUser(Connection con, SQLParam param, int UserID)");
        }
    }


    public void Insert(Connection con, SQLParam param, cUser u) throws SQLException {
        Statement stmt = null;
        try {
            System.out.println("cUser.Insert " + param.getInsertStatement(u));

            stmt = con.createStatement();
            stmt.execute(param.getInsertStatement(u));
        } catch (SQLException e) {
            System.out.println(e);
            System.out.println("throwing SQLException from cUser.Insert(Connection con, SQLParam param, cUser u)");
            throw e;
        }
    }

    public String getUserIDString(){
        return Long.toString(user_id);
    }
}

 

by: objectsPosted on 2003-01-09 at 12:37:07ID: 7696686

can you post the full stack trace of the exception.

 

by: whitej8Posted on 2003-01-09 at 13:35:21ID: 7697078

java.sql.SQLException: Before start of result set
throwing SQLException from cUser.cUser(Connection con, SQLParam param, int UserID)
java.sql.SQLException: Before start of result set
        at com.mysql.jdbc.ResultSet.checkRowPos(Unknown Source)
        at com.mysql.jdbc.ResultSet.getString(Unknown Source)
        at com.mysql.jdbc.ResultSet.getString(Unknown Source)
        at user.cUser.<init>(Unknown Source)
        at annotation.Annotation.doGet(Unknown Source)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:740)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:853)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:247)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:193)
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:243)
        at org.apache.catalina.core.StandardPipeline.invokeNext(StandardPipeline.java:566)
        at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:472)
        at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:943)
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:190)
        at org.apache.catalina.core.StandardPipeline.invokeNext(StandardPipeline.java:566)
        at org.apache.catalina.valves.CertificatesValve.invoke(CertificatesValve.java:246)
        at org.apache.catalina.core.StandardPipeline.invokeNext(StandardPipeline.java:564)
        at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:472)
        at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:943)
        at org.apache.catalina.core.StandardContext.invoke(StandardContext.java:2347)
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:180)
        at org.apache.catalina.core.StandardPipeline.invokeNext(StandardPipeline.java:566)
        at org.apache.catalina.valves.ErrorDispatcherValve.invoke(ErrorDispatcherValve.java:170)
        at org.apache.catalina.core.StandardPipeline.invokeNext(StandardPipeline.java:564)
        at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:170)
        at org.apache.catalina.core.StandardPipeline.invokeNext(StandardPipeline.java:564)
        at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:468)
        at org.apache.catalina.core.StandardPipeline.invokeNext(StandardPipeline.java:564)
        at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:472)
        at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:943)
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:174)
        at org.apache.catalina.core.StandardPipeline.invokeNext(StandardPipeline.java:566)
        at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:472)
        at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:943)
        at org.apache.catalina.connector.http.HttpProcessor.process(HttpProcessor.java:1027)
        at org.apache.catalina.connector.http.HttpProcessor.run(HttpProcessor.java:1125)
        at java.lang.Thread.run(Thread.java:536)

 

by: conickPosted on 2003-01-09 at 13:45:59ID: 7697160

In your cUser constructor you create a ResultSet and then go right into rs.getString() without first calling rs.next(). You need to call next() before grabbing information (even if there is only one record that matches the query).

Use something like: if (!rs.next()) throw an exception. Then do your rs.getString().

You may want to consider moving some of the shared functionality out of a servlet into another (non-servlet) class. In fact I would move all of the DB related code to other classes (like the User class).

 

by: objectsPosted on 2003-01-09 at 14:01:58ID: 7697283

You need to call rs.next() to move cursor to first row:

ResultSet rs=stmt.executeQuery(param.getSelectByIDStatement(UserID));
if (rs.next())
{
     user_id          = UserID;
     user_name        = rs.getString("user_name");
     ...

           

 

by: whitej8Posted on 2003-01-10 at 07:07:57ID: 7702028

Can I access the ServletConfig in the object init method?  If not how can I open a connection?

 

by: conickPosted on 2003-01-10 at 07:13:34ID: 7702074

Yes. ServletConfig can be retreived by calling getServletConfig();

 

by: conickPosted on 2003-01-10 at 07:18:11ID: 7702102

Oh wait, you meant in the User object didn't you?

No, it would have to be passed to the object. However, why would you need it?

If youre talking about the Connection pool, I would set that up in the init method of the login servlet (if the pool doesnt currently exist already). Then you can call Pool.getConnection() from your User class.

 

by: whitej8Posted on 2003-01-10 at 07:27:47ID: 7702158

Can you explain this  a little more?

 

by: conickPosted on 2003-01-10 at 07:50:19ID: 7702338

Im not familiar with your ConnectionPool class or how its implemented. You can create a class that instantiates a single instance of the ConnectionPool. static methods can be used to get and free Connections.

//heres an example how it might work:

private static ConnectionPool pool;

//called from init() method of first servlet
public synchronized static void init(...) throws IOException {
if (pool == null) {
pool = new ConnectionPool(...);
}
}

//called from any class to get a Connection
public synchronized static Connection getConnection() {
  return pool.getConnection();
}

//called after Connection is done
public synchronized static void freeConnection(Connection conn) {
  pool.freeConnection(conn);
}

//called from servlet destroy() method
public synchronized static void destroy() {
  pool.destroy();
}
}

You can then call getConnection(), freeConnection(), from anywhere.

 

by: whitej8Posted on 2003-01-10 at 08:16:39ID: 7702534

thanks for the help

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...