Hi All,
I have a java class which contains classes within that class.
Like this:
public class myClass()
{
int num;
class subClass()
{
num = 4;
}
System.out.println(num);
}
subClass uses variables which myClass also uses.
I want to re-write this java class and seperate all of the classes into new files.
I'd like some pointers/tips to achieve this.
Am I right in thinking that having multiple classes within one file is a bad practice?
Thanks
This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.
Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.
If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.
Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.
Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.
Access the answers to your technology questions today.
30-day free trial. Register in 60 seconds.
Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.
Try it out and discover for yourself.
30-day free trial. Register in 60 seconds.
Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.
> Am I right in thinking that having multiple classes within one file is a bad practice?
Java allows you to define more than one class in a file, as long as there is exactly one public class whose name matches the name of the file.
this can be good for small classes that dont need to be accessible outside the package,
having multiple classes in one file could reduce the code readability
> Am I right in thinking that having multiple classes within one file is a bad practice?
It depends. Sometimes you nested classes are local to enclosing class and no other class is interested. Sometimes they are small and heavily connected to enclosing class. Sometimes you don't want to pollute package namespace with names specific to certain context. Sometimes you just need to register listener for events, forwarding them to enclosing class method.
There is a rule about multiple _top-level_ classes. It is a good practice to name java files by classes they contain, no matter whether that classes package local or public. IMHO, this rule doesn't apply to nested classes becauses it focuses on easy way to get source file from the class name, and for nested class you always have enclosing class name.
Sample by hoomanv is correct, but I would start rewriting only if it helps me and others to understand source code, e.g. if there are too many nested classes, or thea are too large.
You might want to add a few more constraints on who can access and change your data members (like "num"). Youhave MANY options here and you should do a little research on java terms like "public", "protected", "private", and "package protected".
Working with the good example given to you by hoomanv:
// in a file called "MyClass.java"
public class MyClass
{
// private means no direct access is granted to other classes
private int num;
// allows other classes to get the value of num
public int getNum()
{
return num;
}
// allows other classes to set the value of num
public void setNum(int inNum)
{
num = inNum;
}
}
// in a file called "SubClass.java"
public class SubClass
{
private MyClass mc;
SubClass(MyClass mc) {
this.mc = mc;
}
void f() {
// note that the "setNum()" method is called here
// because there is no direct access to num from other classes
mc.setNum(4);
}
}
You could also consider inheritance which is very powerful but should be used carefully. Inheritance would look like this:
// in a file called "MyClass.java"
public class MyClass
{
// protected means direct access to "num"is granted only to child and package classes
protected int num;
}
// in a file called "SubClass.java"
// The "extends" keyword in the class decleration that flags SubClass is a child of MyClass
// SubClass is a child class of MyClass so it has direct access to any
// "public" and "protected" variables and methods.
public class SubClass extends MyClass
{
SubClass() {
super(); // calls the default constructor for the parent class (MyClass)
}
void f() {
num = 4; // child class has direct access to parent's "protected" members
}
}
The example by hoomanv is good and is the most simple,but these others might also help if your situation is a little more complicated. It is also worth noting that having more than one class in a file is not always bad, as stated by both hoomanv and bazarny. You just need to give thought to what your class is supposed to do and what it will need to get that done. The more it can stand on its own the fewer connections it will need to other classes.
Business Accounts
Answer for Membership
by: hoomanvPosted on 2006-05-17 at 02:51:45ID: 16697672
// MyClass.java
public class MyClass
{
public int num;
}
// SubClass.java
public class SubClass
{
private MyClass mc;
SubClass(MyClass mc) {
this.mc = mc;
}
void f() {
mc.num = 4;
}
}