Deleting from arraylist

Maybe the editiontoCreate string is not in the array. An extra space can go unnoticed and cause problems, especially if dealing with text files.

add some debug - check if editionstoAdd contains the string you're trying to remove
I bet the strings are different.

Sorry about the sloppy indenting.

     if (itemIdandEditionIdinDB.contains(editiontoCreate))  
               {

  if(editionsToAdd.contains(editiontoCreate)){
System.out.println("editionstoAdd contains " + editiontoCreate + " REMOVE" );
                    editionsToAdd.remove(editiontoCreate);
}else{
System.out.println("editionstoAdd doesn't contain " + editiontoCreate + " so don't REMOVE" );

}



                    System.out.println("Names in editionsToAdd"+editionsToAdd.size());
               }

>>Maybe the editiontoCreate string is not in the array

Even if it is, it's editionsToAdd.size() that's being called

ok, i put a for loop for the remove statement , still no luck

if (itemIdandEditionIdinDB.contains(editiontoCreate))  
                  {
                        for(int h=0;h<editionsToAdd.size();h++)
                        {
            //Remove the editions with same ItemId and EditionId so that editionsToAdd contains only the brand new report editions
                              editionsToAdd.remove(editiontoCreate);
                              System.out.println("Names in editionsToAdd"+editionsToAdd.size());      
                        }
                        
                  }

not sure where you're going with this CEHJ

He's doing this:

editionsToAdd.remove(editiontoCreate);
System.out.println("Names in editionsToAdd"+editionsToAdd.size());


He's trying to remove an object from the ArrayList and then check its size.
He's expecting an object to be removed and its not (most likely 'cause the string isn't in the arraylist)

Nothing to do with what's in a loop or editionsToAdd.size() being called

Maybe I'm missing something . . .

>>Maybe I'm missing something . . .

Sorry - it's me (losing concentration)

jaggernat - that last bit of code is confusing.

You are looping once for each item in the "edidtionsToAdd" ArrayList
In each time the loop runs you try to remove the same thing from the ArrayList.

>>
You are looping once for each item in the "edidtionsToAdd" ArrayList
In each time the loop runs you try to remove the same thing from the ArrayList.
>>

That's why i drew attention to the loop above

Ok,

Jaggernat - how about you explain in english exactly what you're trying to achieve with the loops and Lists and either CEHJ or myself will produce the code.

Sound good?

sorry guys  , my bad.
actually  editionsToAdd  contains something like
RIINF0010-8092-03-06-1.PDF
and
editiontoCreate  contains something like
RIINF0010-8092-03-06

that is why i think
editionsToAdd.remove(editiontoCreate);
 is not able to remove.

what say you?

Sounds like a good reason to me for it not to work

so now the problem is i want to remove RIINF0010-8092-03-06-1.PDF from editionsToAdd  if
editiontoCreate is RIINF0010-8092-03-06?

ideas?

thanks

would something as simple as this work for you?

editionsToAdd.remove(editiontoCreate + "-1.PDF");

>>so now the problem is i want to remove RIINF0010-8092-03-06-1.PDF from editionsToAdd  if

You'll have to iterate and substring them

i dont think it will work aflat, its not just one string. Let me explain with some sample data.



editionsToAdd contains
RIINF0010-8092-03-06-1.PDF
RIINF0010-8092-03-06-2.PDF
RIINF0010-8092-03-06-3.PDF
RIINF0010-7062-03-06-1.PDF
RIINF0010-7062-03-06-2.PDF
RIINF0010-7062-03-06-3.PDF
RIINF0010-6062-03-06-3.PDF
..
editionsToAdd  is generated dynamically

editiontoCreate (also generated dynamically) contains
RIINF0010-8092-03-06
RIINF0010-7062-03-06
..more

Now since "part of editionsToAdd" and "editiontoCreate"  is exactly the same , i want to delete all common entries from editionsToAdd
so i want to delete
RIINF0010-8092-03-06-1.PDF
RIINF0010-8092-03-06-2.PDF
RIINF0010-8092-03-06-3.PDF
RIINF0010-7062-03-06-1.PDF
RIINF0010-7062-03-06-2.PDF
RIINF0010-7062-03-06-3.PDF

from editionsToAdd so that editionsToAdd   is just left with RIINF0010-6062-03-06-3.PDF ,(the uncommon string)

The above data is just sample, editionsToAdd would actually contain lots and lots of names.

any ideas greatly appreciated
thanks
J

It won't work. You need to substring if you don't follow my last suggestion

>>You need to substring

can you tell me what i have to substring?

thanks
J

look at the code example I posted @ 10/10/2006 01:31PM CDT  - this is what cehj was talking about.

You already know - you've been doing it in your other q ;-)

used substring and got it running.

thank you cehj and aflat.

J