Do not use on any
shared computer
September 7, 2008 12:50am pdt
 
[x]
Attachment Details

Client / Server problem . Client recieves incorrect data.

Tags: Java
Hi, i'm building a client / server chat program. I've got a weird bug. When a users JOINS the server the server broadcasts this to all users (code 1.0)...

Log window shows:

User joined server: Testclient131
Log message: Testclient131 was send:[Testclient131]
User joined server: Testclient193
Log message: Testclient131 was send:[Testclient131, Testclient193]
Log message: Testclient193 was send:[Testclient131, Testclient193]
User joined server: Testclient764
Log message: Testclient131 was send:[Testclient131, Testclient193, Testclient764]
Log message: Testclient193 was send:[Testclient131, Testclient193, Testclient764]
Log message: Testclient764 was send:[Testclient131, Testclient193, Testclient764]

Clients are listening for the broadcast using code snipped 1.1 .

PROBLEM, Client 1 (testclient131) recieves

Nickname list: :[Testclient131]
Nickname list: :[Testclient131]

(Two users joined, 2 broadcasts recieved)

Client 2 (Testclient193) recieves

Nickname list: :[Testclient131, Testclient193]

(Only recieved one nickname list because one user joined after this user).

Normally the nickname list SHOULD be

Nickname list: :[Testclient131, Testclient193, Testclient764]

on all broadcasts.
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:
118:
119:
// Code 1.0, Server broadcasting
 
public void run() {
        try {
            //wachten op inkomende message
            boolean stop = false;
 
            while (!stop) {
 
                Object messageObject = istream.readObject();
 
                //controle op offlinePlayer   
                if (messageObject instanceof String) {
                    String s = (String) messageObject;
                    if (s.equals("offlinePlayer")) {
                        stop = true;
                    } else if (s.equals("IDENT")) {
                        userJoined();    // --------> BROADCASTING HERE
                    } else if (s.equals("SAY")) {
                        chatRecieved();
                    } else if (s.equals("LIST TABLES")) {
                        sendTables();
                    } else if (s.equals("CREATE TABLE")) {
                        createTable();
                    }
                }
            }
        } catch (IOException ex) {
            Status.change(ex.getMessage());
        } catch (ClassNotFoundException ex) {
            Status.change(ex.getMessage());
        } finally {
            try {
                if (link != null) {
                    //stap 5: connectie sluiten (gebeurt nu door clienthandler)
                    ostream.writeObject("QUIT!!!");
 
                    server.removeClientHandler(this);
                    cPokerServer.setClientCount(server.getClientCount() - 1);
 
                    link.close();
                }
            } catch (IOException e) {
                e.printStackTrace();
            }
        }
    }
 
 
 private synchronized void userJoined() throws IOException, ClassNotFoundException {
        Object messageObject = istream.readObject();
        if (messageObject instanceof Speler) {
            setThisPlayer((Speler) messageObject);
            server.getActivePlayers().add(getThisPlayer());
            server.frmMain.addUserOnlineEvent(getThisPlayer());
            Vector<Speler> tmpListOfAllPlayers = server.getActivePlayers();
            for (Iterator<PokerPlayerConnection> itTmpSpeler = server.getClientHandlers().iterator(); itTmpSpeler.hasNext();) {
                PokerPlayerConnection tmpPlayer = itTmpSpeler.next();
                tmpPlayer.sendObject("LIST");
                tmpPlayer.sendObject(server.getActivePlayers());
                server.frmMain.addGeneralLogEvent(tmpPlayer.getThisPlayer().getPassIdentiteitskaart().getSNickname() + " was send:" + server.getActivePlayers());
            }
        }
    }
 
 
// Code 2, client recieving userlist
 
 @Override
    public void run() {
 
 
        try {
 
            //wachten op inkomende message
            boolean stop = false;
 
            while (!stop) {
 
                Object messageObject = istream.readObject();
 
 
                if (messageObject instanceof String) {
                    String s = (String) messageObject;
                    if (s.equals("LIST")) {
                        recievePlayerList();     // -----> RECIEVING
                    } else if (s.equals("SAY")) {
                        sendChatMessage();
                    } else if (s.equals("TABLE LIST")) {
                        recieveTableList();
                    }
 
                }
            }
 
 
        } catch (IOException ex) {
            ex.printStackTrace();
        } catch (ClassNotFoundException ex) {
            ex.printStackTrace();
        } finally {
            try {
                if (link != null) {
                    //stap 5: connectie sluiten (gebeurt nu door clienthandler)
                    ostream.writeObject("QUIT!!!");
                    link.close();
                }
            } catch (IOException e) {
                e.printStackTrace();
            }
        }
    }
 
 
    private synchronized void recievePlayerList() throws IOException, ClassNotFoundException {
        Object messageObject = (Vector<Speler>) readObject();
        frmTheMainForm.fillUpPlayerList((Vector<Speler>) messageObject);
        frmTheMainForm.addChatMessage("Nickname list: ", messageObject.toString());
    }
Start your free trial to view this solution
[x]
The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

  • The Grade of the Solution
  • The Zone Rank of the Expert Providing the Solution
  • The Number of Author and Expert Comments
  • The Number of Experts Contributing
  • The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!

Question Stats
Zone: Programming
Question Asked By: ikjop
Solution Provided By: krakatoa
Participating Experts: 1
Solution Grade: B
Views: 0
Translate:
Loading Advertisement...
 
[+][-]Expert Comment by krakatoa

Rank: Guru

Expert Comment by krakatoa:

All comments and solutions are available to Premium Service Members only.

Start your 7-day free trial and see for yourself why Experts Exchange is the easiest and most proven technology resource in the world. Get Started

Already a member? Login to view this solution.

 
 
[+][-]Author Comment by ikjop
Author Comment by ikjop:

All comments and solutions are available to Premium Service Members only.

Start your 7-day free trial and see for yourself why Experts Exchange is the easiest and most proven technology resource in the world. Get Started

Already a member? Login to view this solution.

 
 
[+][-]Expert Comment by krakatoa

Rank: Guru

Expert Comment by krakatoa:

All comments and solutions are available to Premium Service Members only.

Start your 7-day free trial and see for yourself why Experts Exchange is the easiest and most proven technology resource in the world. Get Started

Already a member? Login to view this solution.

 
 
[+][-]Author Comment by ikjop
Author Comment by ikjop:

All comments and solutions are available to Premium Service Members only.

Start your 7-day free trial and see for yourself why Experts Exchange is the easiest and most proven technology resource in the world. Get Started

Already a member? Login to view this solution.

 
 
[+][-]Author Comment by ikjop
Author Comment by ikjop:

All comments and solutions are available to Premium Service Members only.

Start your 7-day free trial and see for yourself why Experts Exchange is the easiest and most proven technology resource in the world. Get Started

Already a member? Login to view this solution.

 
 
[+][-]Expert Comment by krakatoa

Rank: Guru

Expert Comment by krakatoa:

All comments and solutions are available to Premium Service Members only.

Start your 7-day free trial and see for yourself why Experts Exchange is the easiest and most proven technology resource in the world. Get Started

Already a member? Login to view this solution.

 
 
[+][-]Author Comment by ikjop
Author Comment by ikjop:

All comments and solutions are available to Premium Service Members only.

Start your 7-day free trial and see for yourself why Experts Exchange is the easiest and most proven technology resource in the world. Get Started

Already a member? Login to view this solution.

 
 
[+][-]Expert Comment by krakatoa

Rank: Guru

Expert Comment by krakatoa:

All comments and solutions are available to Premium Service Members only.

Start your 7-day free trial and see for yourself why Experts Exchange is the easiest and most proven technology resource in the world. Get Started

Already a member? Login to view this solution.

 
 
[+][-]Expert Comment by krakatoa

Rank: Guru

Expert Comment by krakatoa:

All comments and solutions are available to Premium Service Members only.

Start your 7-day free trial and see for yourself why Experts Exchange is the easiest and most proven technology resource in the world. Get Started

Already a member? Login to view this solution.

 
 
[+][-]Accepted Solution by krakatoa

Rank: Guru

Accepted Solution by krakatoa:

All comments and solutions are available to Premium Service Members only.

Start your 7-day free trial and see for yourself why Experts Exchange is the easiest and most proven technology resource in the world. Get Started

Already a member? Login to view this solution.

 
 
[+][-]Expert Comment by krakatoa

Rank: Guru

Expert Comment by krakatoa:

All comments and solutions are available to Premium Service Members only.

Start your 7-day free trial and see for yourself why Experts Exchange is the easiest and most proven technology resource in the world. Get Started

Already a member? Login to view this solution.

 
 
Loading Advertisement...
20080723-EE-VQP-34 / EE_QW_2_20070628