Question

Memory leak when concatenating strings

Asked by: sburck

I'm working on upgrading an old program for an old employer of mine.  The project produces Postscript based on input files (layout files and data files, producing printer-ready ID cards).  The original project was in Delphi 1.0 and Visual C++ 1.5; later on I wrote a Delphi component which does the Postscript generation in Delphi 5, and this was used in subsequent projects.

Now I have been called back to rewrite the front end, using Delphi 5 and the Delphi 5 component (with some minor additions to support Unicode).  During testing, some major memory leaks were found, which apparently have always been there, but never been noticed before.  The new card layout, which uses lots of graphics, has exacerbated the problem.

I downloaded AQTime (http://www.automatedqa.com) (which, at this point, let me highly recommend; I will be buying it when I finally get paid for this project) to search for the source of the memory leaks.  It showed me a few which were simple to solve, but the bulk of them point to this or something like this:

             Fpage.FActualPostscriptData.Strings[FPage.FCurrentIDSide-1] :=
                 Fpage.FActualPostscriptData.Strings[FPage.FCurrentIDSide-1] +
                 TTF.ProducePostscript;

TTF is a method which generates and returns a very large string (it can be several hundred K), and the stringlist Fpage.FActualPostscriptData contains the strings, per ID, of each of the cards).  The leak is actually on the concatenation, where the AQTime shows the concatenation calling to LStrCat3, which calls eventually to VirtualAlloc in GetMem.Inc; and this memory is never freed.

I have tried to move the concatenation to local strings, and made the method function returning a string to a method procedure operating on a string which belonged to the object:

              TTF.ProducePostscript;
              helper := Fpage.FActualPostscriptData.Strings[FPage.FCurrentIDSide-1];
              helper1 := TTF.ProducedPostscript;
              Fpage.FActualPostscriptData.Strings[FPage.FCurrentIDSide-1]  := helper + helper1;

Here, too the leak occurred on the concatenation.  I tried concat(helper, helper1).  No good.  I tried delete and insert.

              TTF.ProducePostscript;
              helper := Fpage.FActualPostscriptData.Strings[FPage.FCurrentIDSide-1];
              helper1 := TTF.ProducedPostscript;
              Fpage.FActualPostscriptData.Delete(FPage.FCurrentIDSide-1);
              Fpage.FActualPostscriptData.Insert(helper+helper1,FPage.FCurrentIDSide-1);

Didn't help.  Tried using a dynamic array to avoid the concatenation:

var
      copier : array of char; (this is local to the procedure doing this)
...
             SetLength(Copier,
                  Length(Fpage.FActualPostscriptData.Strings[FPage.FCurrentIDSide-1])
                + Length(TTF.ProducedPostscript));
             Move(Fpage.FActualPostscriptData.Strings[FPage.FCurrentIDSide-1][1],Copier[0],
                Length(Fpage.FActualPostscriptData.Strings[FPage.FCurrentIDSide-1]));
             Move(TTF.ProducedPostscript[1],
                  Copier[Length(FPage.FActualPostscriptData.Strings[FPage.FCurrentIDSide-1])],
                  Length(TTF.ProducedPostscript));
             SetLength(helper,Length(Copier));
             Move(Copier[0],helper[1],Length(Copier));
             SetLength(Copier,0);
             Copier := nil;
             FPage.FActualPostscriptData.Strings[FPage.FCurrentIDSide-1] := helper;
             helper := '';

Now AQTime shows the memory of the first SetLength(Copier, etc.) as unreleased, despite the SetLength(Copier,0) and Copier := nil.  It's actually worse than the string version.

I am at a loss here - what could cause these leaks?

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2007-01-14 at 11:40:14ID22122295
Tags

leak

,

memory

,

delphi

Topic

Delphi Programming

Participating Experts
4
Points
500
Comments
13

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. TTF Tool
    Where can we find tools for TTF file? For example,there were sources code of Delphi C++ Builder or Visual C++ with good GUI. Thank you if you help me.
  2. PostScript N,up printing on Win 95/98
    The only really good free PS N-up utility I've heard about is the Angus Duggan's PSUtils (http://www.dcs.ed.ac.uk/home/ajcd/psutils) but – unfortunately – it were written for UNIX. There is a downloadable precompiled version for WIN32, but it works fine only on NT4; on win9x ...
  3. Searching for apple ttf
    Hi! Does anyone know where I can get this great Font apple uses for ads. It must be truetype for windows..... Thanx
  4. Pdf Printing Memory Leak
    We have a memory leak with an application using Crystal Reports 7 and Adobe PDF Writer version 4 to print multiple reports in pdf-format. The application is a combination of a server app written in Delphi and another seperate application also written in Delphi. The serve...
  5. view postscript and (.pdf)file IN DELPHI???
    i have to view postscript (.ps and .pdf)files in .dxf formats. I tried WITH SOFTWARES LIKE ghostscript,pstoedit.... but some errors. to view the postscript and (.pdf) files? If you can kindly send this information with a refrence it will be greatly appreciated. NICK ...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: Ivanov_GPosted on 2007-01-14 at 14:12:15ID: 18313001

I don't know about AutomatedQA. I had bad experience with it. Later I moved to MemCheck - http://v.mahon.free.fr/pro/freeware/memcheck/ . A simple unit which acts as a Memory Manager and blow an exception whenever you make a leak. Just add the unit and MemChk; like. When a memory is not freed, it will throw an exception. Try with it, maybe it will give you some more information to identify the leak.

 

by: Ivanov_GPosted on 2007-01-14 at 14:14:52ID: 18313014

            SetLength(Copier,0);
             Copier := nil;

This is interesting... Why you do this? If Copier is local variable, it will be freed when you leave the procedure/function.

 

by: mokulePosted on 2007-01-14 at 18:10:30ID: 18313688

Hi,
I hardly believe that concat can do such a things.
Could You try not to use TTF.ProducePostscript;

Does something like this also causes leaks?
For me, using D7, it's ok.

            Fpage.FActualPostscriptData.Strings[FPage.FCurrentIDSide-1] :=
                 Fpage.FActualPostscriptData.Strings[FPage.FCurrentIDSide-1] +
                 stringOfChar('b',120000);

 

by: alkisgPosted on 2007-01-14 at 21:14:26ID: 18314287

Is Fpage.FActualPostscriptData a simple stringlist or is it a TWideStringList implemented in a custom unit?

 

by: sburckPosted on 2007-01-15 at 00:18:36ID: 18314929

Comments on the comments:

1.  I'll download memchk today and try it later, see what it can do.
2.  Why  SetLength(Copier,0);
             Copier := nil;

     Because of the strange leaks showing up in strange places, I did a lot of testing with a lot of overkill for removing them.

3.  TTF.ProducePostscript - That's what I've been looking at since I wrote the request here.  I'm guessing that somewhere there there's some bizarre memory overwrite which is confusing the memory manager farther down the road.  I'll replace the call to it with instead filling in a large buffer of data, and see if it helps.

4.  Fpage.FActualPostscriptData is a simple stringlist.  When I process Wide text data (it's Chinese)  , I have to convert it to graphics to send it to the printer, as there are no Chinese Postscript fonts on the printer.  What I do is put a windows font to a graphic DC, and make a Postscript imagemask (or image, depending on data file parameters), and send the graphic result as part of the ID.   So no need for wide data in the actual Postscript data (I don't know if PS would handle UTF data, even).

That's it for now...I'll be in later tonight - today have to work on other things.

 

by: sburckPosted on 2007-01-16 at 01:31:08ID: 18322448

It took me a while to get Memcheck to work, after I did, it is not reporting ANY of the leaks - it reports exactly one leak, which occurs 5 times, and each eats 28 bytes -  it seems that the JVOutlookBarButtonActionLinks which are autocreated are not freed.

I wish it were right - however, when I run Process Explorer and run my program, every time I create a page of Postscript, my "Private Bytes" uses increases by another 130K

I am also having some problems with AQTime's reporting.  One of the leaks that it found was a leak in Strings.SaveToFile - the bug is in Classes.pas, and is documented here:
http://www.kyler.com/content/view/19/47/

I fixed this, and that leak went away.  Now I am running AQTime with the modified code, and it is again finding the old leak in classes - but when tracing the code through the debugger, I can see that it is using the modified classes.pas, and that the memory is being released.

 

by: sburckPosted on 2007-01-16 at 02:28:50ID: 18322623

I just attempted with AQTime to remove the "Check System Memory Allocations" checkbox before running - it then only found the same leak that MemCheck found; the tiny one I'm not concerned about.

 

by: Ivanov_GPosted on 2007-01-16 at 03:35:16ID: 18322905

It is not good idea to modify the Borland's units. This will make your code extremely un-portable...

JVOutlookBarButtonActionLinks is not your component, right?

 

by: sburckPosted on 2007-01-16 at 04:20:02ID: 18323153

JVOutlookBarButtons are JEDI components.  

 

by: alkisgPosted on 2007-01-16 at 04:42:25ID: 18323290

> I wish it were right - however, when I run Process Explorer and run my program, every time I create a page of Postscript, my "Private Bytes" uses increases by another 130K

Even if your program is OK (without taking the smaller leaks into account) and everything is deallocated properly, it may be the ***Delphi memory manager*** who asks Windows for more RAM instead of reusing the already allocated memory. This may be due to performance reasons and it's not necessarily a bad thing.

Try to generate 100 postscript pages:
for i := 1 to 100 do
begin
  CreatePage;
  FreePage;
end;

and see if "Private Bytes" report 100*130K.

 

by: sburckPosted on 2007-03-12 at 13:03:25ID: 18705299

I had to stop the project for a while - I'm getting back to this soon, and will report my findings and award points assuming there is something valid.

 

by: Computer101Posted on 2008-03-15 at 22:55:58ID: 21135835

Forced accept.

Computer101
EE Admin

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...