Question

call method once

Asked by: firekiller15

delphi
Is there anyway that i can change this code to more efficieny manner.
i called same method in Tcontrol A too many times.Is there anyway that i can call the method one time and produce same logic that i have now.

function TControl.CheckHoliday(ADate: TDateTime):TDateTime;
var
  i,j : integer;
  vThisDate: TDateTime;
begin
  vThisDate := ADate;
  if IsAHoliday(vThisDate) = true then
  result := vThisDate;
end;
 
function TControl.CheckWeekEnd(ADate: TDateTime): TDateTime;
var
  vThisDate: TDateTime;
begin
  vThisDate := ADate;
  if (DayOfWeek(vThisDate) = 1) or (DayOfWeek(vThisDate) = 7) then
    vThisDate := vThisDate - 1;
    result := vThisDate;
end;
 
function TControl.A(ADate: TDateTime): TDateTime;
var
  n, i: Integer;
  vThisDate: TDateTime;
begin
  vThisDate := ADate;
  n := 0;
 
  while n < 2 do
  begin //while n != 2
 
    n := n + 1;
    vThisDate := vThisDate - 1;
 
 
    vThisDate := CheckHoliday(vThisDate);
    vThisDate := CheckHoliday(vThisDate);
    vThisDate := CheckHoliday(vThisDate);
    vThisDate := CheckWeekEnd(vThisDate);
    vThisDate := CheckWeekEnd(vThisDate);
    vThisDate := CheckHoliday(vThisDate);
    vThisDate := CheckHoliday(vThisDate);
    vThisDate := CheckHoliday(vThisDate);
  end;
  result := vThisDate;
end;

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2008-04-01 at 21:07:19ID23288081
Tags

delphi

Topics

Delphi Programming

,

Delphi IDE

Participating Experts
4
Points
0
Comments
8

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Producer/ Consumer Example
    Hi All I AM SURE EVERYBODY OVER HERE HAS GONE THROUGH THE PRODUCER/CONSUMER EXAMPLE THAT IS USED TO DESCRIBE THE WAIT/NOTIFY MODEL. NOW MY QUESTION IS THE CALL TO WAIT() IS A BLOCKING CALL I MEAN IT WAITS UNTILL NOTIFY IS CALLED THEN WHY WE NEED WHILE while (available == fal...
  2. how to set property value for all of one kind of TControl
    Dear Adviser ! I create a from with several Tedit, several button, serveral DBgrid .... I want to set Enabled with False for all TEdit. I know how to get the Tcontrol, but i dont know the kind of control ChildCotrol : TControl For i:= 1 to Form.ControlCount do ...
  3. Making a component inherited from TControl and TCustompa…
    Hi , I wanna make my own component that should have the functions as follow: contains a image component to display image contains a label for display text when mouse move on & move out ,change the background color What I have done: 1.try to write a component inher...
  4. java.sql.SQLException : No resultset was produced
    i m inserting a tuple in my oracle database connected through jdbc odbc driver. now when i insert it gives me java.sql.SQLException : No ResultSet was produced. now for insert query no result set is produced. how to solve this please reply soon......
  5. Consumer / Producer Program
    This is a program for a class I'm taking in which I need help with char Buffer[3] char Input[30] = {PPPPPPCCCPCCPCCCCCCPPPPPPCCCCCCPCPCCPPPPCPPPCPPCCCCPPCCCCPPCCCPCPCPCPPPPPPPPPPPPPPPP} main() { for(i=0;i<30;i++){ if(input==P) Producer(); ...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: Geert_GruwezPosted on 2008-04-01 at 22:11:49ID: 21260322

Try reading some books about Delphi.  You will get a lot further a lot quicker.  You do not have a working knowledge of the basics of Delphi.  It doesn't matter what book you use.  Once you get to chapter 10 of any Delphi book you will understand all the basics you need.  Try Sam's Delphi in 24 days for instance.
Not only will it help you, but it will also let you better understand the solutions people provide ...

 

by: MerijnBPosted on 2008-04-01 at 23:24:18ID: 21260537

I'm afraid I have to agree with Geert_Gruwez, most of the code you post here suggest that you just don't grasp most of it.

What is it you want to achieve with the function TControl.A?

 

by: firekiller15Posted on 2008-04-01 at 23:53:57ID: 21260638

i have found the salution already. thank you

 

by: ThievingSixPosted on 2008-04-02 at 18:15:28ID: 21269052

I hope not to be offensive in any way, but out of all the questions you have posted, some of them are the same question twice, and others are deleted after someone has tried to answer. I'm just confused and would like your input on why you chose to delete this question. If you found your answer, what was the solution?


I answered my own question, what do I do?
 
You will be required to post your solution in your original question. A Moderator will post a notice of your request which will give the participants four days to object to the refund. Note that if it resembles one of the suggested comments, the likelihood is that your request will not be granted, but rather, the points will be awarded to the Expert who makes the suggestion.

                                              
1:
2:
3:
4:

Select allOpen in new window

 

by: firekiller15Posted on 2008-04-02 at 22:56:44ID: 21269984

this is my solution .
Is it possible to do this without looping and get the same value.

function TControl.CheckHoliday(ADate: TDateTime):TDateTime;
var
  i : integer;
  vThisDate: TDateTime;
begin
  vThisDate := ADate;
    for i:= 0 to 5 do
    begin
    if (IsAHoliday(vThisDate) = true) or (DayOfWeek(vThisDate) = 1) or (DayOfWeek(vThisDate) = 7) then
    vThisDate := vThisDate - 1;
    end;
    result := vThisDate;
end;
 
 
function TControl.CalculateExDivDate(ADate: TDateTime): TDateTime;
var
  n: Integer;
  vThisDate,vexdiv: TDateTime;
begin
  vThisDate := ADate;
   readholidays();
 
    n := 0;
  ReadHolidays();
  while n < 2 do
  begin //while n != 2
    n := n + 1;
    vThisDate := vThisDate - 1;
    vThisDate := CheckHoliday(vThisDate);
  end;
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:

Select allOpen in new window

 

by: Vee_ModPosted on 2008-04-07 at 04:01:59ID: 21295640

Closed, 250 points refunded.
Vee_Mod
Experts Exchange Moderator

 

by: Geert_GruwezPosted on 2008-04-15 at 15:16:07ID: 21363307

You probably still need to review your code as you write some bugs now and then
And the thing is also that you must try and formulate a decent question ...
I can't completely grasp what you are trying to do
I believe you are trying to find the day before a holiday.
At least that's what the code is doing

function TControl.CalculateExDivDate(ADate: TDateTime): TDateTime;
var
  n: Integer;
  vThisDate: TDateTime;
begin
  ReadHolidays();
  vThisDate := ADate;
  for n := 1 to 2 do
  begin
    vThisDate := vThisDate - 1;
    vThisDate := CheckHoliday(vThisDate);
  end;
  

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:

Select allOpen in new window

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...