Coloring DGBrid Rows - Odd

Thanks Geert,

your example solves adding record in dbGrid, but now there are problems pressing PgUp and PgDn - some lines are doubled and when you go line by line again some are changed from A color to B color ...

(About making it generic, yes i just copied from related solution :)

Can we fix PageUp and PageDown?

I have descendant from TDBGrid

and override:
procedure DrawColumnCell(const Rect: TRect; DataCol: Integer; Column: TColumn; State: TGridDrawState); override;

then i use (Self as TDBGid).

I dont use onDrawColumnCell.

if you are using Ado queries or tables then it's a bug
you can fix it using the AbsolutePosition property
TAdoQuery(DataSet).Recordset.AbsolutePosition;

RecNo doesn't work correctly for first and last record

you could set the editing to a special color ...
for index = -1

procedure TForm1.DBGrid1DrawColumnCell(Sender: TObject; const Rect:  Trect;
        DataCol: Integer; Column: TColumn; State: TGridDrawState);
var Color : TColor;
  aRow: Integer;
begin
  if not(gdSelected in state) then
  begin
    aRow := TAdoTable(TDBGrid(Sender).DataSource.DataSet).Recordset.AbsolutePosition;
    if (aRow mod 2)=1 then
      Color := RGB(224, 231, 223)   //a color
    else
      Color := RGB(254, 255, 239); //another color
    TDbgrid(Sender).Canvas.Brush.Color := Color;
    TDbgrid(Sender).Canvas.FillRect(Rect);
  end;
  TDbgrid(Sender).DefaultDrawColumnCell(Rect, DataCol, Column, State);
end;

                                              

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:

You can also look at using the grids from JVCL (it's free and opensource) - stuff like the TJvDBGrid or TJvAdvanceGrid etc - I think these grids actually have properties in the Object Inspector which allow you set each alternate line a different colour so you don't have to program it -- but last time I check it was slightly buggy - maybe the latest version of JVCL is better though :)

Listening

Umm a problem I encountered with Geert_Gruwez code is that when clicking on one row and then clicking on another row the previous row or rows clicked revert to the current brush, bummer. Any work around will earn another 500 pts

>>CrazeOne
you mean with the AbsolutePosition ?
or the other, the problem is getting the correct rownumber, RecNo doesn't allways work.

One way would be to add a calculated field, or like in other using a row_number ranking function

SELECT A.*, ROW_NUMBER() OVER (ORDER BY PRIMAIRYKEYFIELDS) ROWNR
FROM TABLE A

then use the ROWNR as an indicator

it's a real pity Borland/CodeGear/Embarcadero provide such a nice grid with so many problems

Yeah with the AbsolutePosition. I have the same problem with a DirectoryListBox when it comes to selecting items and then moving the mouse to another item. Its frustrating.

try TJvDBGrid etc

I did and I didnt see a property or event that alternates row colors

Look I will say again my problem is simple.

I use local table. So simple. I use TDBGrid. So Simple. All aplications i use color odd and even lines ... So it souldnt be so hard! Why somebody suggests using TJvDBGrid - if they can do it ... there is a solution...

I dont have problems with identifying odd and even row in table:
row:=grid.DataSource.DataSet.RecNo;

This works 100%. Problem is when user goes beyond last line. Grid goes in edit mode and all lines are drawn in the same color ...

No ADO, no SQL, ...
row:=grid.DataSource.DataSet.RecNo;
if Odd(row) then Canvas.Brush.Color:=ClLineOdd
                    else Canvas.Brush.Color:=ClLineEven;

Look properly!

I just opened a project of mine that use a TJvDBGrid it has some of these properties:
AlternateRowColor

AlternateRowFontColor

Color

FixedColor

So not only does it allow you to customise the row colours, but also the headers and row labels.

ok, DKropf3Date, what database are you using and what component do you use to connect ?
i'll look in TDBGrid and see if i can find a solution

I use Accuracer (and EasyTable). But you will have the same result with any local table.

DKropf3Date u say it works until the edit mode but I have the problem when the user selects with the mouse a row then moves the mouse to another row all the other rows in between revert to the current brush color.

rfwoolf nope don't see the AlternateRowColor perhaps you can open that pas file and post the code to the property and the events attached to it so we can see what they are doing.

CrazyOne : You obviously have an old version of the JVCL. The one I have (and all subsequent later versions) have this ability.

The TJvDBUltimGrid also has this ability

DKropf3 u might want to at least check out the JVCL and look at the code to see how they are doing the Alternate color

Did you try this: {originally posted to the Borland
newsgroups by Sebastian Garde}


// Write an OnDrawColumnCell handler like this:
procedure TForm1.DBGrid1DrawColumnCell(Sender: TObject; const Rect: TRect;
 DataCol: Integer; Column: TColumn; State: TGridDrawState);
begin
 if ((((Rect.Top div (Rect.Bottom - Rect.Top)) mod 2) <> 1))
    and (not (gdSelected in State)) then
 begin
     DBGrid1.Canvas.Brush.Color :=$00FFC8C1;
 end;
 DBGrid1.DefaultDrawColumnCell(Rect, DataCol, Column, State);
end;

// set the afterscroll for your dataset like this:
// I used a TADOQuery to test...
procedure TForm1.ADOQuery1AfterScroll(DataSet: TDataSet);
begin
 DBGrid1.Repaint;
end;