Each Thread Wait 2 Second

no if you put sleep(2000); its freeze the application, and if 10 thread are created its wait 2 second and after 10 thread created immediately no waiting, and me i want it sleep on each thread

thank you

man, I added the sleep in the right place. you application WILL NOT freeze. have you even bothered testing with the code I wrote?

do you know your are creating threads inside the same thread type ?
what's that good for ?

use a class procedure instead
or a procedure in some other object (like a form)

and why do you type 2 exact same pieces of code except for a parameter and maybe some display procedure

btw you are using a parameter across thread boundaries
you need to synchronise the parameter access

and creating the progresbar inside the thread will certainly produce errors !

let's say you want to display the code in 2 different webbrowser windows
and you call a timing thread with Button1 and Button2
This timing thread will create a new thread every 2 secs to create a loading thread
you could use code below from a form like  

type
  TForm1 = class(TForm)
    WebBrowser1: TWebBrowser;
    WebBrowser2: TWebBrowser;
    Button1: TButton;
    Button2: TButton;
    procedure Button1Click(Sender: TObject);
    procedure Button2Click(Sender: TObject);
  end;

procedure TForm1.Button1Click(Sender);
begin
  TTimingThread.Create('http//www.site1.com', 10);
end;

procedure TForm1.Button2Click(Sender);
begin
  TTimingThread.Create('http//www.site2.com', 20);
end;

unit ThreadsOverHttp;
 
const 
  THREADSLEEP = 2000;
 
type
  TTimingThread = class(TThread)
  private
    fTimes: Integer;
    fUrl: string;
  protected
    procedure Execute; override;
  public 
    constructor Create(aUrl: string; nTimes: Integer); 
  end;
 
  TMyThread = class(TThread)
  private
    fHTTP: TIdHTTP;
    fUrl: string;
    fRs: String;
    fWebBrowser: TWebBrowser;
    procedure Display;
  protected
    procedure Execute; override;
  public
    constructor Create(aUrl: string; aWebbBrowser: TWebBrowser);
    destructor Destroy; override;
  end;
 
constructor TMyThread.Create(aUrl: string; aWebbBrowser: TWebBrowser);
begin
  inherited Create(False);
  fWebbrowser := aWebBrowser;
  fIdHTTP := TIdHTTP.Create(Application);
  fIdHTTP.HandleRedirects := true;
  FreeOnTerminate := true;
end;
 
destructor TMyThread.Destroy;
begin
  FreeAndNil(fIdHTTP);
  inherited Destroy;
end;
 
procedure TMyThread.Display;
begin
  // just my guess at your code
  fWebbrowser.InnerHtml := fRs;
end;
 
procedure TMyThread.Execute;
begin
  try
    Sleep(THREADSLEEP);
    fRs := fIdHttp.Get(fUrl);
  except
    on e:exception do
      fRs := e.Message;
  end;
  Synchronize(Display);
end;
 
constructor TTimingThread.Create(aUrl: string; nTimes: Integer);
begin
  inherited Create(False);
  fTimes := nTimes;
  fUrl := aUrl;
  FreeOnTerminate := True;
end;
 
procedure TTimingThread.Execute;
var g:integer;
begin
  for g:=1 to nTimes +1 do
  begin
    Sleep(THREADSLEEP);
    TMyThread.Create(aUrl);
  end;
end;
 
                                              

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:

i test it man not working it not sleep 10 time only 1 time anf after 10 thread are created ! and me i want 10 time if i created 10 thread it sleeo 2 second

look, my code sleeps 2 seconds for each thread before getting the page.
that means that it will create all 10 threads at once, in the same second, but each thread will wait for 2 seconds before getting the webpage. so the entire operation is finished in aproximatly 2-4 seconds (maybe more, depends how long it takes to get the url).
geerts code sleeps twice as much, meaning it sleep 4 seconds for each thread: 2 seconds before it creates the thread and 2 seconds before it gets the web page.
more exactly, it will take 20 seconds to create the 10 threads and each one will wait 2 seconds before getting the webpage. the aprocimate time for the entire operation to finish is around 22-24 seconds, depending on how long it takes for the url to be downloaded.

so, I understood one thing from your post, geert probably something else. but both his and my code will wait 2 second for each thread as you asked, but you didn't mention when that waiting should happen. so geert placed it in both possible locations :) good thinking geert ;)

so, in worse case scenario, geerts code should work just fine (except if waiting 4 seconds to get a page is too much).

og, forgot to mention something about geerts code. here is a timeline:
2 seconds: thread 1 created
4 seconds: thread 1 gets the url, thread 2 created
6 seconds: thread 2 gets the url, thread 3 created
8 seconds: thread 4 gets the url, thread 4 creates
and so on.
so, as you can see, there is actually 2 seconds between each url donwload, but 4 seconds unitl the first one is done.

>> in both possible locations :) good thinking geert ;)

i assumed the idea was to load different pages so something like an animated gif would be possible
but then with webpages

little bit extravagant way to load eh ?

putting a redirect in the browser header and start it after 2 secs would be a lot easier
don't even need delphi code for that ;)

i search 1000 webpage with 60 thread this is exactely what i do that why i need to wai t 2 second on each thread.

someone can make me a simple demo how it work with 2 webbrowser looking different page

thank for you patience

500 point i give for demo example

I load a List of website in Memo1 and use this code to find all webpage who in the source as astrology or ASTROLOGY i use this and it very slow someone have a better idea to make it faster ?

procedure TForm1.Button7Click(Sender: TObject);
 var
  S1: TStringList;
i: Integer;
 position : Integer;
  begin
   S1 := TStringList.Create;
    try
     for i:=0 to Memo1.Lines.Count  do
       begin
         try
          S1.Clear;
            label4.Caption:=(IntToStr(i));
               memo1.lines[i] := StringReplace( memo1.lines[i],'http://','',[rfReplaceAll]);
                 S1.Add(IdHttp1.Get('http://'+memo1.Lines[i]));
                     except on e:exception do
S1.Clear;
 end;
  position := AnsiPos('astrology', S1.text);
   if position = 0 then
    else
     memo2.Lines.Add(memo1.Lines[i]);
       label1.Caption:=(IntToStr(memo2.Lines.Count -0));

  position := AnsiPos('ASTROLOGY', S1.text);
   if position = 0 then
    else
     memo2.Lines.Add(memo1.Lines[i]);
      label1.Caption:=(IntToStr(memo2.Lines.Count -0));
        end;

finally
 AssignFile(myFile, 'URL.dat');
  ReWrite(myFile);
   WriteLn(myFile, memo2.text);
    CloseFile(myFile);
      end;
       end;

Thank You

wow, you're using incremental indentation
what's that good for ?
please try and format the code in a delphi way
seems silly to format your code,
but i use formatting to find memory leaks
I can spot memory leaks at a glance with just formatting :)
your formatting is useless

you wanted threads
but now you're doing it in the main thread ?

Better yet, the asker should take the time to address his PREVIOUS OPEN question regarding threaded downloads. The reason I offered up my wininet wrapper (in that q) is that the asker would get the benefits of a threaded download with ZERO hassle.

C'est la vie