Advertisement

[x]
Attachment Details

SQL variable is always 0

[x]
The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

  • The Grade of the Solution
  • The Zone Rank of the Expert Providing the Solution
  • The Number of Author and Expert Comments
  • The Number of Experts Contributing
  • The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!

9.2
Hi all,

I'm creating this stored procedure to calculate a users score in an assessment. The correct answers are stored in a table and the users answer are in a another table, the key that links them is the questionID. However, @score is always 0...

Can you see any glaring errors?
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
alter PROCEDURE sp_recordAssessmentScore
	-- Add the parameters for the stored procedure here
	@assessmentID int,
	@score decimal(2,2) output,
	@userID int
AS
BEGIN try
	-- SET NOCOUNT ON added to prevent extra result sets from
	-- interfering with SELECT statements.
	SET NOCOUNT ON;
 
    -- Insert statements for procedure here
	declare @questionID int;
	declare @scalarAnswer varchar(max);
	declare @totalRight int;
	declare @totalWrong int;
	declare @totalAnswers int;
 
	declare d_curs cursor fast_forward for
		select questionID, scalarAnswer
			from dbo.trn_assessmentSubmittedAnswers
			where assessmentID = @assessmentID
 
	open d_curs
 
	fetch next from d_curs
		into @questionID, @scalarAnswer
 
	if(@@fetch_status = 2)
	begin
		close d_curs
		return
	end
 
	while (@@fetch_status = 0)
	begin
		set @totalAnswers = @totalAnswers + 1
 
		declare @rightAnswer varchar(max)
	
		set @rightAnswer = (select answerText from dbo.trn_assessmentAnswers where correct = 1 and questionID = @questionID)
 
		if @rightAnswer = @scalarAnswer
		begin
			set @totalRight = @totalRight + 1
		end
		else
		begin
			set @totalWrong = @totalWrong + 1
		end
 
		fetch next from d_curs
			into @questionID, @scalarAnswer
	end
 
	close d_curs
 
	set @score = @totalAnswers / 100 * @totalRight
 
	-- Record score
	Exec dbo.sp_logEntry 'Assessment Score', @userID, @assessmentID, @score
END try
 
begin catch
	If @@TRANCOUNT > 0
		ROLLBACK
	Declare @errMsg nvarchar(4000), @errSeverity int, @errProcedure nvarchar(4000), @errLine int
	Select @errMsg = ERROR_MESSAGE(), 
		@errSeverity = ERROR_SEVERITY(), 
		@errProcedure = ERROR_PROCEDURE(),
		@errLine = ERROR_LINE()
	Exec dbo.sp_logEntry 'SYSTEM ERROR', @errMsg, @errSeverity, @errProcedure, @errLine
end catch
Related Solutions
Related Solutions
 
Loading Advertisement...
 

Rank: Genius

Accepted Solution by chapmandew:

All comments and solutions are available to Premium Service Members only.

Start your 7-day free trial and see for yourself why Experts Exchange is the easiest and most proven technology resource in the world. Get Started

Already a member? Login to view this solution.

 
 
Author Comment by G0ggy:

All comments and solutions are available to Premium Service Members only.

Start your 7-day free trial and see for yourself why Experts Exchange is the easiest and most proven technology resource in the world. Get Started

Already a member? Login to view this solution.

 
 
Assisted Solution by G0ggy:

All comments and solutions are available to Premium Service Members only.

Start your 7-day free trial and see for yourself why Experts Exchange is the easiest and most proven technology resource in the world. Get Started

Already a member? Login to view this solution.

 
 

Rank: Genius

Expert Comment by chapmandew:

All comments and solutions are available to Premium Service Members only.

Start your 7-day free trial and see for yourself why Experts Exchange is the easiest and most proven technology resource in the world. Get Started

Already a member? Login to view this solution.

 
 
Administrative Comment by ForestDenizen:

All comments and solutions are available to Premium Service Members only.

Start your 7-day free trial and see for yourself why Experts Exchange is the easiest and most proven technology resource in the world. Get Started

Already a member? Login to view this solution.

 
 
Administrative Comment by ForestDenizen:

All comments and solutions are available to Premium Service Members only.

Start your 7-day free trial and see for yourself why Experts Exchange is the easiest and most proven technology resource in the world. Get Started

Already a member? Login to view this solution.

 
Loading Advertisement...
20080924-EE-VQP-40 / EE_QW_2_20070628