[x]
Posted via EE Mobile

Search, ask, and monitor your questions on the go with EE Mobile. Visit Experts Exchange from your mobile device and never be out of touch again.

Question
[x]
Attachment Details
[x]
The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

  • The Grade of the Solution
  • The Zone Rank of the Expert Providing the Solution
  • The Number of Author and Expert Comments
  • The Number of Experts Contributing
  • The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!

8.8

T-SQL Transaction and rollback

Asked by conradvdp in SQL Query Syntax, SQL Server 2005

Tags: t-sql

I have a stored procedure that exists in 2 parts:
1st part is a simple INSERT statement
2nd part is looping through a comma delimited string with invoiceID's

In this loop another stored procedure is called that does a few checks and updates with each invoiceID.

An error happened in the second stored procedure, yet no rollback occured and the 1st part got executed many times where it's not supposed to on error...

The rollback failed because no error was raised in the first stored procedure. How can I program these 2 usp's so that a rollback occurs whether errors appear in the first or in the second usp?

I attached the first stored procedure only (not sure if the second stored procedure is relevant but let me know and I'll post)
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
ALTER PROCEDURE [dbo].[usp_ATFT_FIN_setTransactionsPaid] 
	-- Add the parameters for the stored procedure here
	@companyID				INT
	,@accountparentID		INT
	,@accountsubID			INT
	,@checkvalue			DECIMAL(18,2)
	,@strInvoiceIDs			VARCHAR(100)
	,@description			VARCHAR(250)
	,@documentID			INT
	,@TransactionNumber		INT
	,@TransactionDate		DATETIME
AS
 
SET NOCOUNT ON;	
BEGIN TRANSACTION 
 
DECLARE @err INT 
SET @err = @@ERROR
 
		-- insert bank account debit transaction
		INSERT INTO
			dbo.tbl_FIN_Transaction 
				(							
				companyID
				,ClientID
				,TransactionNumber
				,TransactionName
				,TransactionDate
				,AccountParentNumber
				,AccountSubNumber
				,DocumentID
				,DocumentType
				,Debit	
				,Credit
				) 
			VALUES
				(													
				@companyID
				,0
				,@TransactionNumber
				,@description
				,@TransactionDate
				,@AccountParentID
				,@AccountSubID
				,@DocumentID
				,'JNL'
				,@checkvalue	
				,0
				)
 
	-- insert individual A/R transactions per invoice
	-- set invoices to isPaid = 1
	-- comma separated string with invoiceID's
	DECLARE @values TABLE (id INT) 
    DECLARE @id INT 
    INSERT INTO @values (id ) SELECT VALUE FROM ufn_ParmsToList(@strInvoiceIDs) 
    WHILE @@rowcount > 0 
    BEGIN 
      SELECT TOP 1 @id = id FROM @values 
      IF @@rowcount > 0 
      BEGIN 
            EXEC usp_ATFT_FIN_setInvoicesPaid @id ,@TransactionNumber,@description, @accountsubID, @checkvalue, @companyID
      END 
      DELETE @values WHERE id = @id 
    END
 
IF @err <> 0 
	BEGIN
		ROLLBACK TRANSACTION 
	END
 
SELECT @err AS intError
COMMIT TRANSACTION
[+][-]09/08/09 04:05 PM, ID: 25286923Expert Comment

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 30-day free trial to view this Expert Comment or ask the Experts your question.

 
[+][-]09/08/09 04:11 PM, ID: 25286952Author Comment

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 30-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]09/08/09 04:14 PM, ID: 25286970Expert Comment

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 30-day free trial to view this Expert Comment or ask the Experts your question.

 
[+][-]09/08/09 04:28 PM, ID: 25287063Author Comment

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 30-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]09/08/09 09:21 PM, ID: 25288198Accepted Solution

View this solution now by starting your 30-day free trial. Setting up your free trial is quick, easy, and secure. We will return you to this solution, unlocked, when you're done.

About this solution

Zones: SQL Query Syntax, SQL Server 2005
Tags: t-sql
Sign Up Now!
Solution Provided By: BrandonGalderisi
Participating Experts: 2
Solution Grade: A
 
[+][-]09/09/09 12:55 PM, ID: 25294927Author Comment

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 30-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]09/09/09 12:55 PM, ID: 25294934Author Comment

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 30-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]09/09/09 01:01 PM, ID: 25294989Expert Comment

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 30-day free trial to view this Expert Comment or ask the Experts your question.

 
 
Loading Advertisement...
20091021-EE-VQP-81 - Hierarchy / EE_QW_3_20080625