Question

T-SQL Transaction and rollback

Asked by: conrad2010

I have a stored procedure that exists in 2 parts:
1st part is a simple INSERT statement
2nd part is looping through a comma delimited string with invoiceID's

In this loop another stored procedure is called that does a few checks and updates with each invoiceID.

An error happened in the second stored procedure, yet no rollback occured and the 1st part got executed many times where it's not supposed to on error...

The rollback failed because no error was raised in the first stored procedure. How can I program these 2 usp's so that a rollback occurs whether errors appear in the first or in the second usp?

I attached the first stored procedure only (not sure if the second stored procedure is relevant but let me know and I'll post)

ALTER PROCEDURE [dbo].[usp_ATFT_FIN_setTransactionsPaid] 
	-- Add the parameters for the stored procedure here
	@companyID				INT
	,@accountparentID		INT
	,@accountsubID			INT
	,@checkvalue			DECIMAL(18,2)
	,@strInvoiceIDs			VARCHAR(100)
	,@description			VARCHAR(250)
	,@documentID			INT
	,@TransactionNumber		INT
	,@TransactionDate		DATETIME
AS
 
SET NOCOUNT ON;	
BEGIN TRANSACTION 
 
DECLARE @err INT 
SET @err = @@ERROR
 
		-- insert bank account debit transaction
		INSERT INTO
			dbo.tbl_FIN_Transaction 
				(							
				companyID
				,ClientID
				,TransactionNumber
				,TransactionName
				,TransactionDate
				,AccountParentNumber
				,AccountSubNumber
				,DocumentID
				,DocumentType
				,Debit	
				,Credit
				) 
			VALUES
				(													
				@companyID
				,0
				,@TransactionNumber
				,@description
				,@TransactionDate
				,@AccountParentID
				,@AccountSubID
				,@DocumentID
				,'JNL'
				,@checkvalue	
				,0
				)
 
	-- insert individual A/R transactions per invoice
	-- set invoices to isPaid = 1
	-- comma separated string with invoiceID's
	DECLARE @values TABLE (id INT) 
    DECLARE @id INT 
    INSERT INTO @values (id ) SELECT VALUE FROM ufn_ParmsToList(@strInvoiceIDs) 
    WHILE @@rowcount > 0 
    BEGIN 
      SELECT TOP 1 @id = id FROM @values 
      IF @@rowcount > 0 
      BEGIN 
            EXEC usp_ATFT_FIN_setInvoicesPaid @id ,@TransactionNumber,@description, @accountsubID, @checkvalue, @companyID
      END 
      DELETE @values WHERE id = @id 
    END
 
IF @err <> 0 
	BEGIN
		ROLLBACK TRANSACTION 
	END
 
SELECT @err AS intError
COMMIT TRANSACTION
                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-09-08 at 15:55:35ID24716563
Tags

t-sql

Topics

SQL Query Syntax

,

SQL Server 2005

Participating Experts
2
Points
500
Comments
8

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Rollback
    Should I use just one large rollback segment or multiple rollback segments when import to a large database?. Say the db size is 500 GB. What is the advantage of using just one rolllback segment? What is the advantage of using multiple rollback segment? Or Does it really mat...
  2. rollback
    what does the term rollback means in VB?
  3. Multiple Transaction Rollback
    Is there a way to rollback several independent transactions ?
  4. Transaction Rollback
    Transaction(s) will not be rolled back in the case of checked exceptions (application exceptions ) in general ,which is the Spring's transaction rollback rule in the default case ... what is the idea behind it , what is the state of the transaction in the contain...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: aneeshattingalPosted on 2009-09-08 at 16:05:45ID: 25286923

try this way

ALTER PROCEDURE [dbo].[usp_ATFT_FIN_setTransactionsPaid]
-- Add the parameters for the stored procedure here
@companyID int
,@accountparentID int
,@accountsubID int
,@checkvalue decimal(18,2)
,@strInvoiceIDs varchar(100)
,@description varchar(250)
,@documentID int
,@TransactionNumber int
,@TransactionDate datetime
AS
BEGIN
SET NOCOUNT ON ;
      DECLARE @err int, @i int
      SET @err = @@ERROR
      -- insert individual A/R transactions per invoice
      -- set invoices to isPaid = 1
      -- comma separated string with invoiceID's
      DECLARE @values TABLE ( i int identity, id int )
      DECLARE @id int
      INSERT  INTO   @values ( id )
      SELECT VALUE
      FROM ufn_ParmsToList ( @strInvoiceIDs )
      SELECT @i = @@ROWCOUNT
                  
      BEGIN TRANSACTION
      BEGIN
            -- insert bank account debit transaction
            INSERT  INTO dbo.tbl_FIN_Transaction ( companyID ,ClientID,TransactionNumber,TransactionName,TransactionDate
                              ,AccountParentNumber,AccountSubNumber,DocumentID,DocumentType ,Debit,Credit )
            VALUES  (@companyID,0,@TransactionNumber,@description,@TransactionDate
                        ,@AccountParentID,@AccountSubID,@DocumentID,'JNL',@checkvalue,0 )

            WHILE @i > 0
            BEGIN
                  SELECT @id = id
                  FROM  @values
                  WHERE i = @i
                   EXEC usp_ATFT_FIN_setInvoicesPaid @id , @TransactionNumber , @description , @accountsubID ,
                                                           @checkvalue , @companyID
                  IF @err <> 0
                  BEGIN
                         ROLLBACK TRANSACTION
                         SELECT @err AS intError
                         RETURN
                  END
                  SET @i = @i - 1
            END
            COMMIT TRANSACTION
      END
END


alternatively you can change the inner sp to accept the csv

 

by: conrad2010Posted on 2009-09-08 at 16:11:14ID: 25286952

@aneeshattingal:
is the idea that there are 2 transactions in the one sproc? I understand what you're suggesting but there's still a part of the code missing, i.e. the INSERT that also needs to be rolled back in case of an error...

 

by: aneeshattingalPosted on 2009-09-08 at 16:14:23ID: 25286970

it will rollback in case of an error

 

by: conrad2010Posted on 2009-09-08 at 16:28:37ID: 25287063

@

I tested the proposed solution "as is" and was able to recreate the same behavior, i.e. the second stored proc doesn't gets executed (or rolled back) but the INSERT statement in the first sproc doesn't get rolled back...

i.e. this part:
INSERT  INTO dbo.tbl_FIN_Transaction (companyID ,ClientID,TransactionNumber,TransactionName,TransactionDate,AccountParentNumber,AccountSubNumber,DocumentID,DocumentType ,Debit,Credit )
VALUES  (@companyID,0,@TransactionNumber,@description,@TransactionDate,@AccountParentID,@AccountSubID,@DocumentID,'JNL',@checkvalue,0 )

 

by: BrandonGalderisiPosted on 2009-09-08 at 21:21:02ID: 25288198

What about using try/catch instead of checking @err

ALTER PROCEDURE [dbo].[usp_ATFT_FIN_setTransactionsPaid]
-- Add the parameters for the stored procedure here
@companyID int
,@accountparentID int
,@accountsubID int
,@checkvalue decimal(18,2)
,@strInvoiceIDs varchar(100)
,@description varchar(250)
,@documentID int
,@TransactionNumber int
,@TransactionDate datetime
AS
BEGIN
SET NOCOUNT ON ;
      DECLARE @err int, @i int
      SET @err = @@ERROR
      -- insert individual A/R transactions per invoice
      -- set invoices to isPaid = 1
      -- comma separated string with invoiceID's
      DECLARE @values TABLE ( i int identity, id int )
      DECLARE @id int
      INSERT  INTO   @values ( id )
      SELECT VALUE
      FROM ufn_ParmsToList ( @strInvoiceIDs )
      SELECT @i = @@ROWCOUNT
begin try                  
      BEGIN TRANSACTION
      BEGIN
            -- insert bank account debit transaction
            INSERT  INTO dbo.tbl_FIN_Transaction ( companyID ,ClientID,TransactionNumber,TransactionName,TransactionDate
                              ,AccountParentNumber,AccountSubNumber,DocumentID,DocumentType ,Debit,Credit )
            VALUES  (@companyID,0,@TransactionNumber,@description,@TransactionDate
                        ,@AccountParentID,@AccountSubID,@DocumentID,'JNL',@checkvalue,0 ) 
            WHILE @i > 0
            BEGIN
                  SELECT @id = id
                  FROM  @values
                  WHERE i = @i
                   EXEC usp_ATFT_FIN_setInvoicesPaid @id , @TransactionNumber , @description , @accountsubID ,
                                                           @checkvalue , @companyID 
                  SET @i = @i - 1
            END
            COMMIT TRANSACTION
      END
end try
begin catch
  if xact_state()<>-1
    select @err as intError
    rollback transaction
declare @em nvarchar(255)
set @em = error_message()
raiserror(@em,16,1)
end catch 
END

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:

Select allOpen in new window

 

by: conrad2010Posted on 2009-09-09 at 12:55:17ID: 25294927

@BrandonGalderisi:

your solution seems to work fine...

one last question: this sproc is called from a datareader in C#... how can we add a return value from the sproc back to the datareader?

something like 0 (ok) or 1 (error) so I can alert the user something went wrong...

 

by: conrad2010Posted on 2009-09-09 at 12:55:57ID: 25294934

oops... just saw it in there in a different location than I was looking... never mind...

 

by: BrandonGalderisiPosted on 2009-09-09 at 13:01:07ID: 25294989

Inside of the begin/end catch, you can simply do a return 1.  By default, if no return is made or no value is specified, 0 is returned.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...