Focus on radio buttons

Hmm..i just gave that a try, and it didn't work..Form still got submitted.

try putting return false first. Like this also don't forget the ;

adv= -1
                      for (i=0; i<form.advice.length; i++) {
                      if (form.advice[i].checked) {
                      adv=i
                      }
                      }
                      if (adv == -1) {
                      alert ('Are you an independant financial adviser? Please select yes or no')
                      return false;
                      form.advice.focus() ;
                      }

OK, that stops the form from submitting, but it still doesnt focus on the radio...

Could you post your entire code. I'll try to fix it.

Im just using the code you gave me - ive taken out everything else and just validating that one field

change
form.advice.focus();
to
documents.forms[0].advice.focus() ;

no difference, sorry :-(

How about a link to the script.

I cant because its on our local server. Ok...all I am using is what you gave me just now. So i have..

<script language="javascript">
function chkFields() {
adv= -1
                      for (i=0; i<form.advice.length; i++) {
                      if (form.advice[i].checked) {
                      adv=i
                      }
                      }
                      if (adv == -1) {
                      alert ('Are you an independant financial adviser? Please select yes or no')
                      return false;
                      form.advice.focus() ;
                      }
}
</script>

Then:
form name="subscription" onSubmit="return chkFields()">

etc etc.

The focus works fine for all the other form elements. It just wont focus on the radio button.

Oh, as an aside. I can't get it to focus on any radio button in the form. Its not just this one.

I'm not 100% sure but we might be trying to do something that is not possible. Atleast not using any of the above ways.

Maybe. The focus() works for every other form field. Apparently all form elements except "hidden" support it.

Still Checking.

I cant because its on our local server. Ok...all I am using is what you gave me just now. So i have..

<script language="javascript">
function chkFields() {
adv= -1
                      for (i=0; i<form.advice.length; i++) {
                      if (form.advice[i].checked) {
                      adv=i
                      }
                      }
                      if (adv == -1) {
                      alert ('Are you an independant financial adviser? Please select yes or no')
                      return false;
                      form.advice.focus() ;
                      }
}
</script>

Then:
form name="subscription" onSubmit="return chkFields()">

etc etc.

The focus works fine for all the other form elements. It just wont focus on the radio button.

Ok, sorry, that didn't work either. Hope you didn't waste many points finding that out ;-)

I think youre right and maybe we are trying to do the impossible...

I wouldn't call it a waste. I got to the point were I wanted to know the answer too.
Good Luck

Thanks, and you...if i find out anything more i'll let you know.

I have a page that does this.  Check out my amazing work ;-)
http://www.royalmail.com/queenmother/ and then go to competition.

The code you need is in there. I can extract it if you can't find it exactly.

your problem is that you are using onSubmit event. It does not prevent form from submission even if your data validation fails. Try using instead of "type=submit"
regular button,
<input type='button' value=submit onclick='chkFields()'>
 and then manually submit
your form
script language="javascript">
function chkFields() {
adv= -1
                      for (i=0; i<form.advice.length; i++) {
                      if (form.advice[i].checked) {
                      adv=i
                      }
                      }
                      if (adv == -1) {
                      alert ('Are you an independant financial adviser? Please select yes or no')

                      form.advice.focus() ;
                      return false;
                      }
else {
  document.form.submit();
 return;
}
}
</script>

you overlooked one small detail:

form.advice.focus()

should be

form.advice[0].focus();

remember form.advice is an array containing the same number of radio buttons you have.

you didn't get the return false to work because there was an error before that.

when CUTTHEMUSIC reversed the order of the return and focus it only disabled the focus part since the return doesn't execute anything after it.

please try this, i hope it works.

Nothing seems to have happened here for a while so here's a fully working page.  You should be able to extract what you want.

<html>
<head>
<script language="JavaScript" type="text/javascript">
var b, buttonvalue, everythingok
function validateform(form) {
    var nogo = false
    for (i=1;i<2;i++) {
        if (!cycleButtons(form.whenborn)) {alert("Please select which day you think HM The Queen Mother was born on in 1900");nogo=true;form.whenborn[0].focus();break;}
        if (!cycleButtons(form.whenmarried)) {alert("Please select when you think The Queen Mother married HRH Duke of York");nogo=true;form.whenmarried[0].focus();break;}
        if (!cycleButtons(form.howmany)) {alert("Please select how many official engagements you believe HM The Queen Mother fulfilled in 1997");nogo=true;form.howmany[0].focus();break;}
        if (form.username.value == "") {alert("Please enter your name");nogo=true;form.username.focus();break;}
        else {textvalidator(form.username)}
        if (everythingok == false) {alert("Please enter a name with only letters");nogo=true;form.username.focus();break}
    }
    if (nogo) {
        return false;
    }
}
function cycleButtons(buttonNum) {
      buttonchecked = false
      for (b = 0; b < buttonNum.length; b++) {
            if (buttonNum[b].checked) {
                  buttonchecked = true;
            }
      }
      if (buttonchecked == false) {return false}
      else {return true}
}
function textvalidator(field) {
    //do text validation for input box
}
</script>
</head>
<body>
<form method="post" action="mynewpage.asp">
<p>1. HM The Queen Mother was born on which day in 1900?:<br>
<input type="radio" name="whenborn" value="3">3rd August<input type="radio" name="whenborn" value="4">4th August<input type="radio" name="whenborn" value="5">5th August</p>
<p>2. HM The Queen Mother married HRH Duke of York in which year?<br>
<input type="radio" name="whenmarried" value="21">1921<input type="radio" name="whenmarried" value="22">1922<input type="radio" name="whenmarried" value="23">1923</p>
<p>3. In 1997, HM The Queen Mother fulfilled how many official engagements?<br>
<input type="radio" name="howmany" value="37">37<input type="radio" name="howmany" value="44">44<input type="radio" name="howmany" value="58">58</p>
<p>Name: <input type="text" name="username" size="30"></p>
<input type="submit" name="submitbutton" value="Submit" onclick="return validateform(this.form)">
</form>
</body>
</html>

Lisa, was this ever resolved?  I gave code that works.  You never gave any feedback so I don't know if you need any other changes made.

If you found a solution here then accept the relevent comment as an answer.  We are here to help and leaving questions until they automatically get deleted won't help others if they want to use the PAQ's.