Question

syntax error in JavaScript

Asked by: bkhendershot

Hi.  I keep getting a syntax error on this line of my javascript and I do not understand what the trouble is with it:

onClick='MarkToDelete(269, 'testt.doc'); return false';  

Where 'MarkToDelete' is a function I have defined to take 2 parameters.  I've tried putting "" around MarkToDelete instead of ' but that doesn't work either.  If I do not put '' around testt.doc then the javascript does not error until it gets to function 'MarkToDelete' and it tells me that 'testt.doc' is undefined.  Both 269 and testt.doc are brought into Javascript using VB calls to a SQL Database.  

Also, the return false; is NOT performing properly.  Instead its pulling up another page.  I dont know if that is also caused from the javascript error or not :(

I'd really apprectiate any suggestions!

Thank you.

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2002-11-04 at 06:02:25ID20389679
Topic

JavaScript

Participating Experts
1
Points
25
Comments
21

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. javascript "this"
    Why does the "this" object sometimes work with onclick, but not with href="javascript:"? please look at the following example. case 1 <a onclick="xy(this)" class="a">... case 2 <a href="javascript:xy(this) class="a...
  2. OnClick
    Hi Experts, I am trying to create a web page where users can select one of too teams and place a bet. The following is an example of the first column in the table where I would like to click. Currently when I click It fails and says ColA_Click is undefined. Also I would l...
  3. JavaScript Undefined error
    below is my code in which it displays all the pictures in the directory and user get to check mark only one picture and hit submit, so it should put that picture in my JavaScript text editor, so it does everything, but it just does not put the image name. Instead I get this ...
  4. javascript onclick
    how can i get <a href="javascript:.myclick(' + i + ')">'test'</a> to load dynamically. I would like each button that loads up in a datagrid to be onclick(0), onclick(1), onclick(2) and so fourth. But so far this only loads the first on if it is like ...
  5. What is the correct syntax with <a.... and onclick / j…
    Hello, I need to make a link that will call a javascript function with AJAX. I don't want to use <a href="#"... because it go to the top of the page. I need something like this: <a onClick="javafunction()" href=????>xxxxx</a> without the hre...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: knightEknightPosted on 2002-11-04 at 06:03:30ID: 7405694

quotes .... try this:


onClick='MarkToDelete(269, "testt.doc"); return false';  

 

by: knightEknightPosted on 2002-11-04 at 06:04:11ID: 7405695

or this:

onClick='MarkToDelete(269,\'testt.doc\'); return false';  

 

by: bkhendershotPosted on 2002-11-04 at 06:11:00ID: 7405725

Thanks so much for the quick response.  The first comment you offered caused it to give me an ASP error 'expected end of line' and the second on returns invalid character.  Any other thoughts??  

It will take the 269 argument twice.  So the problem isn't with 2 parameters being passed.. its' something with that filename.  However, even that still causes return false to not act right.   I'm not even processing with it in MarkToDelete.  All I want to use it for is a popup to say are you sure you want to delete testt.doc.  

 

by: knightEknightPosted on 2002-11-04 at 06:14:51ID: 7405737

I see now, so this line is being generated with ASP?  Can you show me the ASP code ?

 

by: knightEknightPosted on 2002-11-04 at 06:17:20ID: 7405743

off the bat, I'd say you should add "return false;" to the bottom of the MarkToDelete function, then do this:

onClick='return MarkToDelete(269,\'testt.doc\');'

what is this onclick handler in anyway?  an Anchor tag?  a button?

 

by: bkhendershotPosted on 2002-11-04 at 06:23:50ID: 7405768

I never posted in here.. so I hope this code isn't horrible to read! :)


Set objComp = Session("DataObj").GetRecords("tblQuoteUploadHistory", strWhere2, "", Application("UDL"))
               
If Not objComp.EOF Then blnHasFiles = true
If blnHasFiles Then
While Not objComp.EOF
   
  Response.Write "<td><input type='image'  
  src='images/SmallRedX.gif' alt='Delete File' border='0'
  onClick='MarkToDelete(" & objComp("TransactID") & ", '"  
  & objComp("ServerFileName") & "'); return    
  false';></input>&nbsp;&nbsp;</td></tr>"

ObjComp.MoveNext
WEnd
Else
  Response.Write"<tr><td colspan='5' align='center'  
  class='nsWHead' bgcolor='#770000'><i>No Files Associated
  With This Quote</i></td></tr>"
End if
objComp.Close
Set objComp = Nothing


Here is the javascript function:

function MarkToDelete(sQuoteID, sFileName)
{    

if(!confirm("Are you sure you want to delete" + sFileName + "?"))
{
return false;
} // end if

window.open("QuoteDeleteFile.asp?QuoteID=" + sQuoteID + "&Action=Delete", "MarkedDel","height=80,width=350,status=no,toolbar=no,menubar=no,location=no,scrollbars=no");
}  // end MarkToDelete()

 

by: knightEknightPosted on 2002-11-04 at 06:26:54ID: 7405780

try this:

Response.Write "<td><input type='image'  
 src='images/SmallRedX.gif' alt='Delete File' border='0'
 onClick='MarkToDelete(""" & objComp("TransactID") & """, '"  
 & objComp("ServerFileName") & "'); return    
 false';></input>&nbsp;&nbsp;</td></tr>"

 

by: bkhendershotPosted on 2002-11-04 at 06:30:56ID: 7405796

That give me ASP error 'expected end of statement'.... I also tried moving the return false, but that had no effect......

 

by: knightEknightPosted on 2002-11-04 at 06:32:54ID: 7405803

you did un-word-wrap that line, correct?

i.e., it should all be on one line.

 

by: bkhendershotPosted on 2002-11-04 at 06:33:11ID: 7405804

Actually what I think  that did  was this:  'MarkToDelete("" & objComp("TransactID") & "", '"... that ' is now acting as a comment and it doens't process the rest of the line.

 

by: bkhendershotPosted on 2002-11-04 at 06:35:12ID: 7405817

Yep, it is all on one line.

I also tried:

onClick="MarkToDelete(" & objComp("TransactID") & ", ' " & objComp("ServerFileName") & " ')"; return false;>

And that had the same effect... with that ' turning everything into a comment.

 

by: knightEknightPosted on 2002-11-04 at 06:35:43ID: 7405820

in VBScript (ASP) if you double a double-quote character, it is printed as a quote ... like this:

response.write "She said ""Hello"" to me!"

 

by: knightEknightPosted on 2002-11-04 at 06:36:47ID: 7405827

therefore:

onClick='MarkToDelete(""" & objComp("TransactID") """, '" & objComp("ServerFileName") & "'); return false';

 

by: knightEknightPosted on 2002-11-04 at 06:38:10ID: 7405833

oh wait!  we left out a & ...

onClick='MarkToDelete(""" & objComp("TransactID") & """, '" & objComp("ServerFileName") & "'); return false';

 

by: knightEknightPosted on 2002-11-04 at 06:38:40ID: 7405837

correction, I did.

 

by: knightEknightPosted on 2002-11-04 at 06:39:49ID: 7405844

DOH!  Actually, I quoted the wrong thing!


onClick='MarkToDelete( " & objComp("TransactID") & ", '""" & objComp("ServerFileName") & """'); return false';

 

by: knightEknightPosted on 2002-11-04 at 06:40:35ID: 7405849

I just can't get it right ...

onClick='MarkToDelete( " & objComp("TransactID") & ", """ & objComp("ServerFileName") & """); return false';

 

by: bkhendershotPosted on 2002-11-04 at 06:46:42ID: 7405877

THANK YOU SOOOO MUCH!!!!!

Works like a charm :)  I NEVER would have realized that about the double quotes!

Thanks again :)

 

by: bkhendershotPosted on 2002-11-04 at 06:47:28ID: 7405879

Very quick and dependable help.  :)

 

by: knightEknightPosted on 2002-11-04 at 06:48:39ID: 7405889

dependable except I had to redo it 10 times to get it right :)

Thanks for the A!

 

by: bkhendershotPosted on 2002-11-04 at 06:51:20ID: 7405901

hehe... too darn many '''''""""'""'"' 's that's all :)  

MUCH better than the java forums off of Sun and several others I've been in!!  I and 2 other people have been staring at that error since Friday!

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...