Dutch Phonenumber Validator (Regular Expressions) - Quick answer required

tnx! -- i'll check on that in half an hour -- havin a break now ;)

tnx in advance

I dont know if there is a better way, but this works..

function checkLocal(phoneNo)
{
var separator = '-';
var stringArray = phoneNo.split(separator);
var pre=stringArray[0];
var len=pre.length;
eval("var phoneRE = /^\\d{"+(len)+",4}-\\d{"+(10-len)+",10}/;");
document.write("|"+phoneRE+"|-"+phoneNo);

 if (phoneNo.match(phoneRE)) {
   document.write("valid! <br/>");
   return true;
 } else {
 document.write("invalid! <br/>");
   //alert("The phone number entered is invalid!");
   return false;
 }
}

venkat.

Having all your comments in mind, I have created the function which I think is capable of doing what I want. This is the code:
function checkNumber(num){
      // Remove dashes and spaces
      num = num.replace(/[-.\s]/gi, "");
      // Replace + with 00
      num = num.replace(/[+]/gi, "00");
      num = num.replace(/\D/gi, "");
      
      if (num.substr(0, 1)!="0"){
            // Invalid number
            return false;
      }
      else{
            if (num.substr(0, 2)=="00"){
                  // International Number
                  if (num.substr(2,2)=="31"){
                        // Dutch numbers don't need 31
                        num = "0" + num.substr(4);
                        return (num.length==10)?num:false;
                  }
                  else{
                        // Others do.
                        return (num.length==13)?num:false;
                  }
            }
            
            
      }
      return num;
}

I hope this is clear -- and I am curious whether or not this function works. Can anyone please try it? thanx.

I am now checking the e-mail address section.

The email address section:
I have taken the function of alambres, and slightly modified it, into this function:

    function valMail(obj)
     {
     
      
          var re = /^\w+(\.\w+)*@\w+(\.\w+)+$/;
         
         
          // Translated:
          //
          // must start with one or more (+) text characters (\w)
          // (can be followed by a . (\.) and one or more text characters (\w) zero or more times (*))
          // then there must be a @sign, followed by one ore more text characters.
          // (can be followed by a . (\.) and one or more text characters (\w) one or more times (+))
         
          return re.test(obj);
     }

Please tell me whether this is the right way to do this.

Greetz, PiZZaMeTSaLaMi

that email validation allows _______@_____.com is this what you want?

eeuhm -- i'll check on that -- tnx :D

actually it allows

______@______.___

New version:

function valMail(obj){
var re = /^([a-zA-Z0-9])+((\.|_)[a-zA-Z0-9]+)*@[a-zA-Z0-9]+((\.|\-)[a-zA-Z0-9]+)*(\.[a-zA-Z0-9]{2,3})$/;
return re.test(obj);
}

unless your sure your audience is not going to have a domain that is either .info, or .name then its ok but if you are not sure you should change the last part to {2,4}

and here is a correction on the one i submitted
[com|net|org|biz|gov|info|name|sr|us|nu|ws|tv|de]$/i;

also domains as of now and probally will not end with numbers so

this
(\.[a-zA-Z0-9]{2,3})

should be

(\.[a-zA-Z]{2,3})

oh here is one zvonko did yesterday or the day before and i just added the ending to it

var re =/^[a-z][a-z0-9]*([\.\-\_][a-z][a-z0-9]*)*\@([a-z][a-z0-9]*\.)*([a-z][a-z0-9]*)\.[com|net|org|biz|gov|info|name|sr|us|nu|ws|tv|de]$/i;

your right it was a copy paste error

var re =/^[a-z][a-z0-9]*([\.\-\_][a-z][a-z0-9]*)*\@([a-z][a-z0-9]*\.)*([a-z][a-z0-9]*)\.(com|net|org|biz|gov|info|name|sr|us|nu|ws|tv|de)$/i;

And you left out uk!

But, more importantly, you left out 'nl' which is going to be regularly used by people with Dutch phone numbers.
And, given national stereotypes, I'd have thought there'd be a few who will soon have email address ending in xxx...

So, maybe it's just safer to allow 2 to 4 alphabetic characters at the end of an email address after all...

var re =/^[a-z][a-z0-9]*([.-_][a-z][a-z0-9]*)*@([a-z][a-z0-9]*.)*([a-z][a-z0-9]*).([a-z]{2}|com|net|org|biz|gov|info|name)$/i;


This is care of Zvonko

Sorry jAy, I sent you a wrong line.
Now I see that dot to underscore is marked as range by dash.
It has to be rewritten to this:
var re =/^[a-z][a-z0-9]*([.\-_][a-z][a-z0-9]*)*@([a-z][a-z0-9]*.)*([a-z][a-z0-9]*).([a-z]{2}|com|net|org|biz|gov|info|name)$/i;

Still too restrictive, elminating 'edu'.  That's a lot of unhappy young folk...
And hey... there's a 'museum' tld too (not that I've ever seen an email address ending in .museum, but why rule it out?)


From http://www.icann.org/tlds/
In the 1980s, seven gTLDs (.com, .edu, .gov, .int, .mil, .net, and .org) were created. Domain names may be registered in three of these (.com, .net, and .org) without restriction; the other four have limited purposes.

Over the next twelve years, various discussions occurred concerning additional gTLDs, leading to the selection in November 2000 of seven new TLDs for introduction. These were introduced in 2001 and 2002. Four of the new TLDs (.biz, .info, .name, and .pro) are unsponsored. The other three new TLDs (.aero, .coop, and .museum) are sponsored.

>>>Still too restrictive

That is why you should know your audience

that is priority number 1 in designing

know who your audience will be

Well thanx for the complete discussion here :) I just came home and saw these comments. Just before I reward my points I would like to know what you fellows thought about my comments containing the code I am using at this moment.

Please post the ins and outs of this code, and it's raining points time!

Dissection of your code:
function checkNumber(num){
     // Remove dashes and spaces
     num = num.replace(/[-.\s]/gi, "");
-- no need for the case-insensitivity
     // Replace + with 00
     num = num.replace(/[+]/gi, "00");
-- no need for character class or case-insensitivity
-- replaces + ANYWHERE in the string... is that valid?
     num = num.replace(/\D/gi, "");
-- ditto
-- they could all be chained together in Zvonko style as:
     num = num.replace(/[-.\s]/g, "").replace(/\+/g, "00").replace(/\D/g, "");
     
     if (num.substr(0, 1)!="0"){
-- this can/will throw a javascript error if the user hasn't entered anything, or, if they entered '--abc.d.e.f---'
          // Invalid number
          return false;
     }
     else{
          if (num.substr(0, 2)=="00"){
-- this can/will throw a javascript error if the user only entered a zero on it's own
               // International Number
               if (num.substr(2,2)=="31"){
-- this can/will throw a javascript error if the user only entered '123'
                    // Dutch numbers don't need 31
                    num = "0" + num.substr(4);
                    return (num.length==10)?num:false;
               }
               else{
                    // Others do.
                    return (num.length==13)?num:false;
               }
          }
         
         
     }
     return num;
}

-- this can/will throw a javascript error if the user only entered '123'
should have read
-- this can/will throw a javascript error if the user only entered '012'

Also, if the phone number entered is not international, you (pizzametsalami) just seem to accept it as valid?
e.g. 012345

if ( num.substr(0, 1) != "0" ) {
  // Invalid number
  return false;
} else {
  if ( num.substr(0, 2) == "00" ) {
  ....both paths have return statement...
  }
  // else number did not start with 00, and you don't check anthing about it.. e.g. length...
}
return num;  

i contribute this for the phone numbers via regex:

function checkPhone(num){
  return /\s*?(?:(?:0[^0]\d{8})|(?:00[^0]\d{10}))\s*?$/.test(num.replace(/\+/,"00").replace(/\-/,""));
}

as for the email, theres just tpo many possibilities to tie it all to just one "general purpose" regex.  there is a lot of info about email regex's and a few good examples: http://www.experts-exchange.com/Q_20900341.html

This discussion has given me enough base to get myself thinking of a good working example. I will work out all things that have been said, and I'll post my finally used code. Thank you all for competing in this question, and pleaz tell me, who wants the points? ;)

pizzametsalami,

You can split the points between the people whose comments helped you - you don't need to choose one person to receive all the points.
http://www.experts-exchange.com/help.jsp#hi19

And perhaps is the better question: who wants to be helped next time when he needs solutions?

You cannot give away points: you do not hold some.
This is a experts exchange board and the points are only a symbolic Thank You, not more and not less. Keep that in mind.
 
I do not need your points.