Question

onClick display block/none

Asked by: flow79

hello all!  I think this should be a pretty easy one.

I have the following code.  When the user clicks on the div containing the word "Menu", the lower div (id = dropper) displays as a block (which is fine).  However, when the user clicks on the "Menu" div again, the dropper div does not revert back to display:none.   Any thoughts?

<CODE>

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

<html>
<head>
<title>Untitled</title>

<style type="text/css">
<!--
#dropper { display: none; }
-->
</style>

<script language="JavaScript" type="text/javascript">
<!--
function toggleDiv(element){
      if(document.getElementById(element).style.display = 'none')
      {
        document.getElementById(element).style.display = 'block';
      }
      else if(document.getElementById(element).style.display = 'block')
      {
        document.getElementById(element).style.display = 'none';
      }
}
//-->
</script>

</head>
<body>
      <div onClick="toggleDiv('dropper');">Main</div>

      <div id="dropper">
            <ul>
                        <li>1</li>
                        <li>2</li>
            </ul>
      </div>
</body>
</html>


<ENDCODE>

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2005-06-30 at 07:51:17ID21476358
Tags

display

,

javascript

,

onclick

,

block

,

none

Topic

JavaScript

Participating Experts
2
Points
500
Comments
12

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. CSS onclick show hide divs
    I have the following divs and stylesheet my problem is the following: firefox: when the current div is clicked, the new one shows as supposed to, but the current one sits underneath the same size but as whitespace underneath the new div that is shown. there is unnecessary wh...
  2. onclick
    I am writing a script that need to change the onclick attribute of DIVs. I can't simply use: var myvar='aa'; my_div.onclick="myfunction(myvar)"; not sure why, but it doesn't work. I am going to be using a loop and changing a bunch of onclick attributes at once, ...
  3. Problem using <UL> or <LI> with onclick event
    Hi, I'd like to use onclick event into a list but the problem is the following: Here the sample: <ul style='margin-left:0;'> <li id="fd" onclick="DisplaySku(DisplaySkuForm,'ZZZ 11.1','','','');" >ZZZ 11.1</li><!-- * FATHER * --> &...
  4. onClick change css class
    Hi I have an expand/collapse list, and I'd like to amend it to include a plus/minus image in the background of the span. Presumably this means changing the script so that it changes the span class (I can handle the css side of things it's the script I need help with please):...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: archrajanPosted on 2005-06-30 at 07:58:31ID: 14338867

here u go:
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

<html>
<head>
<title>Untitled</title>

<style type="text/css">
<!--
#dropper { display: none; }
-->
</style>

<script language="JavaScript" type="text/javascript">
<!--
function toggleDiv(element){
     if(document.getElementById(element).style.display == 'none')
     {
       document.getElementById(element).style.display = 'block';
     }
     else if(document.getElementById(element).style.display == 'block')
     {
       document.getElementById(element).style.display = 'none';
     }
}
//-->
</script>

</head>
<body>
     <div onClick="toggleDiv('dropper');">Main</div>

     <div id="dropper" style = "display:none">
          <ul>
                    <li>1</li>
                    <li>2</li>
          </ul>
     </div>
</body>
</html>

 

by: ShelfieldCollegePosted on 2005-06-30 at 07:59:36ID: 14338875

Hi flow79,

try this:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

<html>
<head>
<title>Untitled</title>

<style type="text/css">
<!--
#dropper { display: none; }
-->
</style>

<script language="JavaScript" type="text/javascript">
<!--
function toggleDiv(element){
     var el;
     el = document.getElementById(element);
     if(el.style.display != 'block')
     {
       el.style.display = 'block';
     }
     else
     {
       el.style.display = '';
     }
}
//-->
</script>

</head>
<body>
     <div onClick="toggleDiv('dropper');">Main</div>

     <div id="dropper">
          <ul>
                    <li>1</li>
                    <li>2</li>
          </ul>
     </div>
</body>
</html>


Cheers!

-Matt-

 

by: ShelfieldCollegePosted on 2005-06-30 at 08:01:06ID: 14338888

Soz, didn't mean to repost another answer, shoulda refreshed before I posted.

Cheers

-Matt-

 

by: flow79Posted on 2005-06-30 at 08:05:08ID: 14338936

arch,
Yours works well, but just one question for you.  to get something like this to work, will I have to always use inline styles?  I would much prefer to keep the style portion in the <style> tag, and not inline.  any thoughts?

 

by: archrajanPosted on 2005-06-30 at 08:09:36ID: 14338987

No Problem: Try this then:
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

<html>
<head>
<title>Untitled</title>

<style type="text/css">
<!--
#dropper { display: none; }
-->
</style>

<script language="JavaScript" type="text/javascript">
<!--
function toggleDiv(element){
     if(document.getElementById('hid').value == 'none')
     {
       document.getElementById(element).style.display = 'block';
         document.getElementById('hid').value = 'block'
     }
     else if(document.getElementById('hid').value == 'block')
     {
       document.getElementById(element).style.display = 'none';
         document.getElementById('hid').value = 'none'
     }
}
//-->
</script>

</head>
<body>
     <div onClick="toggleDiv('dropper');">Main</div>

     <div id="dropper">
          <ul>
                    <li>1</li>
                    <li>2</li>
          </ul>
     </div>

       <input type = "hidden" id = "hid" value = "none">
</body>
</html>

 

by: flow79Posted on 2005-06-30 at 08:18:27ID: 14339085

arch, why did you add a hidden field?  can you explain why this all works?

 

by: archrajanPosted on 2005-06-30 at 08:34:37ID: 14339252

Ok sure
since u have the style sheet which hides the display
u initially have a hidden variable with id 'hid' with the value 'none'

function toggleDiv(element){
     if(document.getElementById('hid').value == 'none') //checking whether the hiden variable value is none which means the element is invisible

     {
       document.getElementById(element).style.display = 'block'; // now making the element visible
        document.getElementById('hid').value = 'block' //since the element is visible changing the hidden variable value to 'block'
     }
     else if(document.getElementById('hid').value == 'block') // now checking if the value of the hidden variable is block
     {
       document.getElementById(element).style.display = 'none'; // now making the element invisible again
        document.getElementById('hid').value = 'none' // again toggling the value of the hidden variable
     }
}

 

by: flow79Posted on 2005-06-30 at 08:37:42ID: 14339287

is there any way to do so without having to use the seperate variable (and still not use inline styles)?
 
I dont mean to be a pest, but the cleaner, shorter the code, the better

 

by: flow79Posted on 2005-06-30 at 08:42:20ID: 14339340

i actually am a big fan of the way SheffieldCollege is doing it.  no hidden fields, and works with the stylesheet (no inline styling).  sorry i missed your post for a few minutes Shelfield.

 

by: archrajanPosted on 2005-06-30 at 08:43:35ID: 14339356

yup his code is much cleaner and the best way to go:

 

by: archrajanPosted on 2005-06-30 at 08:45:38ID: 14339386

Award points to SheffieldCollege

But just for the records this works too :)
<script language="JavaScript" type="text/javascript">
<!--
function toggleDiv(element){
     if(document.getElementById(element).style.display == 'block')
     {
       document.getElementById(element).style.display = 'none';
     }
     else
     {
      
       document.getElementById(element).style.display = 'block';
     }
}
//-->
</script>

 

by: ShelfieldCollegePosted on 2005-07-02 at 11:31:11ID: 14355046

Soz for the late delay, i dont have internet access from home. Thanks for the points, basically I'd written a similar thing earlier that day for hiding/showing a row in a table and just changing it a little to work with your DIV, glad it worked out OK :)

Cheers all

-Matt-

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...