Question

Javascript Syntax Error?

Asked by: rschaeferhig

I'm getting a syntax error pointing to the "function" line of the following code:

     function valform() {
           if (document.mySurvey.R1.checked) || (document.mySurvey.R2.checked) || (document.mySurvey.R3.checked) {
         alert("Q1 answered");
         if (document.mySurvey.R1.checked) || (document.mySurvey.R2.checked) {
            if (document.mySurvey.R21.checked) || (document.mySurvey.R22.checked) ||  
                           (document.mySurvey.R23.checked) || (document.mySurvey.R24.checked) {
                  alert("Q2 answered");
            }
            else {
                  alert("Q2 Not Answered);
                  return false;
            }            
         }
                }
      else {
        alert("Q1 not answered");
        return false;
      }
     }

I know this isn't the most elegant or efficient way to do this but that's another posting....

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2005-07-20 at 06:55:51ID21498098
Tags

javascript

,

syntax

,

error

Topic

JavaScript

Participating Experts
3
Points
125
Comments
15

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Blackberry OS API-File System Q1: Q2: What record s…
    Q2: What record sizes allow the system to work optimally?
  2. the efficiency of the select javascript programming !
    i want to write a javasrcript to meet with the demand :select from one slect object to another select object and it support multiple chocie(that is user can select one more time), my javascript program as following : function addSrcToDestList() { destList = wi...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: justinbilligPosted on 2005-07-20 at 07:02:08ID: 14484670

the Q2 not answered alert is missing a "

and you should put parentheseiss around your if statemetns ( The whole if statement )

function valform()
{
      if ((document.mySurvey.R1.checked) || (document.mySurvey.R2.checked) || (document.mySurvey.R3.checked) )
      {
              alert("Q1 answered");

              if ((document.mySurvey.R1.checked) || (document.mySurvey.R2.checked) )
            {
                  if ((document.mySurvey.R21.checked) || (document.mySurvey.R22.checked) || (document.mySurvey.R23.checked) || (document.mySurvey.R24.checked) )
                  {
                        alert("Q2 answered");
                       }
                       else
                  {
                             alert("Q2 Not Answered");
                             return false;
                       }          
              }
      }
      else
      {
            alert("Q1 not answered");
            return false;
      }
}

 

by: rschaeferhigPosted on 2005-07-20 at 07:03:18ID: 14484687

Arrgghhhh... I must have read this code 20 times. The old "2nd set of eyes" adage. Thanks.

 

by: rkannan2000Posted on 2005-07-20 at 07:16:18ID: 14484829

Make sure that the Form name is exactly "mySurvey"

Try using
document.mySurvey.elements[0].checked
document.mySurvey.elements[1].checked
instead of document.mySurvey.R1.checked
let me know ...

 

by: rschaeferhigPosted on 2005-07-20 at 07:18:22ID: 14484844

I fixed the quotes and added the "outside" parenthesis and that fixed the problem.

 

by: justinbilligPosted on 2005-07-20 at 07:42:23ID: 14485129

Awesome. Please close the question if you are done.

 

by: jouwstrmPosted on 2005-07-20 at 08:10:35ID: 14485448

-- attempt to answer future question :)

What I always do is label the radio or checkboxes with the same name.
then in my javascript i can loop through them.

<script>
function chksurvey()
{
   pass = false;
   for(i=0;i<document.mySurvey.question1.length;i++)
   {
      if(document.mySurvey.question1[i].checked == true)
         pass = true;
   }
   if(!pass)
   {
      alert("Please answer Question 1");
      return false;
   }
   return true;
}
</script>

<form name='mySurvey' onsubmit='return chksurvey();'>
Question 1: ...
<input type='radio' name='question1' value='A'> A
<input type='radio' name='question1' value='B'> B
<input type='radio' name='question1' value='C'> C
</form>

 

by: rschaeferhigPosted on 2005-07-20 at 08:38:22ID: 14485794

Yup. I tried that. I'm developing in VS2003 and when I type "document.mySurvey." the drop-down doesn't list "question1" as an object I can select. It lists the values from the ID tags (R1, R2) in the radio buttons, but not the NAME tag(q1). Wierd. I even tried just ignoring Intellisense and typed "alert(document.mySurvey.q1[0].value);" and got a missing object error.  Here's the HTML:

<input type="radio" name="q1" value ="1" id="R1" onClick="showQs(1,1)"> 1-3 times / week</input>
<input type="radio" name="q1" value ="2" id="R2" onClick="showQs(1,2)"> 3 or more times / week</input>
<input type="radio" name="q1" value ="3" id="R3" onClick="showQs(1,3)"> Do not use cafeteria services</input>

So I should be able to iterate through for(i=0;i<document.mySurvey.q1.length;i++), but like I said above, when I get to the Intellisense drop-down for mySurvey it doesn't list "q1" anywhere.

Any thoughts

 

by: jouwstrmPosted on 2005-07-20 at 09:01:14ID: 14486081

I dont use VS2003... im a dreamweaver person.
I used VS a lil while ago and I know what you're talking about.
Some of the fields would show up in the auto popup thingie when your typing script, and some wont.
I basically ignored it and developed the page the way it should and it still seemed to work.

So I guess I don't know why VS2003 would be ignoring some of your fields.
But your alert of q1[0].value should still work.. heh wierd.

what if you alert(document.mySurvey.q1.length)? what do you get?

 

by: jouwstrmPosted on 2005-07-20 at 09:02:37ID: 14486111

I dont use VS2003... im a dreamweaver person.
I used VS a lil while ago and I know what you're talking about.
Some of the fields would show up in the auto popup thingie when your typing script, and some wont.
I basically ignored it and developed the page the way it should and it still seemed to work.

So I guess I don't know why VS2003 would be ignoring some of your fields.
But your alert of q1[0].value should still work.. heh wierd.

what if you alert(document.mySurvey.q1.length)? what do you get?

 

by: rschaeferhigPosted on 2005-07-20 at 09:35:58ID: 14486487

"undefined"

 

by: jouwstrmPosted on 2005-07-20 at 10:38:11ID: 14487238

when you check the length of a field, it will give you a "undefined" result if there is only one field with that name.
so, if question 1 only has one field, q1.length wont return 1, it will return undefined.
question 1 needs atleast 2 fields with the same name for q1.length to return atleast 2.

 

by: jouwstrmPosted on 2005-07-20 at 10:40:10ID: 14487268

that may also be why q1[0].value wouldnt work for you before.
im sure if you add another field with the same name, different value... you'll be able to reference them as an array.

 

by: rschaeferhigPosted on 2005-07-20 at 10:42:50ID: 14487296

HTML as posted above. Shouldn't this result in an array with the name "q1"?

<input type="radio" name="q1" value ="1" id="R1" onClick="showQs(1,1)"> 1-3 times / week</input>
<input type="radio" name="q1" value ="2" id="R2" onClick="showQs(1,2)"> 3 or more times / week</input>
<input type="radio" name="q1" value ="3" id="R3" onClick="showQs(1,3)"> Do not use cafeteria services</input>

 

by: jouwstrmPosted on 2005-07-20 at 10:46:09ID: 14487335

the below code returns '3' for me.

-----------
<html>
<head>
<script>
function chk()
{
      alert(document.myform.q1.length);
}
</script>
</head>

<body>
<form name='myform'>
<input type="radio" name="q1" value ="1" id="R1" onClick="showQs(1,1)"> 1-3 times / week</input>
<input type="radio" name="q1" value ="2" id="R2" onClick="showQs(1,2)"> 3 or more times / week</input>
<input type="radio" name="q1" value ="3" id="R3" onClick="showQs(1,3)"> Do not use cafeteria services</input>

<input type='button' value='Check' onclick='chk();'>
</form>
</body>
</html>

 

by: rschaeferhigPosted on 2005-07-20 at 10:58:02ID: 14487432

Oy!

Now it works... Maybe I mis-typed something.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...