Optimize ps1 script

# Fix the object array, ensure all objects within the 
# array contain the same members (required for Format-Table / Export-CSV)
 
$Members = $Report | Select-Object `
  @{n='MemberCount';e={ ($_ | Get-Member).Count }}, `
  @{n='Members';e={ $_.PsObject.Properties | %{ $_.Name } }}
$AllMembers = ($Members | Sort-Object MemberCount -Descending)[0].Members
 
ForEach ($Entry in $Report) {
  ForEach ($Member in $AllMembers)
  {
    If (!($Entry | Get-Member -Name $Member))
    { 
      $Entry | Add-Member -Type NoteProperty -Name $Member -Value ""
    }
  }
}

                                              

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:

$Report = Get-Datacenter | %{
 
  # Store the DC Name ($_ will not be the same in the next loop)
  $DCName = $_.Name
 
  $_ | Get-Cluster | %{
 
    # Store the Cluster Name ($_ will not be the same in the next loop)
    $ClusterName = $_
 
    # Select only the first returned host
    $_ | Get-VMHost | Select-Object -First 1 | %{
 
      # Store the Host ID
      $HostID = $_ | Get-View
      $_ | Get-VirtualSwitch | %{
 
        # Create an instance of the $NetworkConfig object. Store values for DCName, ClusterName, vSwitchName ($_), vSwitchNic and the number of ports
 
        $NetworkConfig = $_ | Select-Object `
          @{n='Datacenter';e={ $DCName }}, `
          @{n='Cluster';e={ $ClusterName }}, `
          @{n='vSwitch';e={ $_.Name }}, `
          @{n='vmNIC';e={ $_.NIC }}, `
          @{n='Ports';e={ $_.NumPorts }}
 
        # Store details of this Virtual Switch
 
        $NetworkSystem = Get-View $HostID.ConfigManager.NetworkSystem
        $VSwitch = $NetworkSystem.NetworkConfig.VSwitch | ?{ $_.Name -eq $NetworkConfig.VSwitch }
        $NetworkConfig | Add-Member -Type NoteProperty -Name "Host" -Value $Hostid.Name
        $NetworkConfig | Add-Member -Type NoteProperty -Name "AllowPromiscuous" -Value $VSwitch.Spec.Policy.Security.AllowPromiscuous
        $NetworkConfig | Add-Member -Type NoteProperty -Name "MacChanges" -Value $VSwitch.Spec.Policy.Security.MacChanges
        $NetworkConfig | Add-Member -Type NoteProperty -Name "ForgedTransmits" -Value $VSwitch.Spec.Policy.Security.ForgedTransmits
        $NetworkConfig | Add-Member -Type NoteProperty -Name "ActiveNic" -Value "$($VSwitch.Spec.Policy.NicTeaming.NicOrder.ActiveNic)"
        $NetworkConfig | Add-Member -Type NoteProperty -Name "StandbyNic" -Value "$($VSwitch.Spec.Policy.NicTeaming.NicOrder.StandbyNic)"
 
        # A simple ID for the Port Group (used for column / member name)
        $i = 1
 
        # Get the port groups from the current vSwitch
        $_ | Get-VirtualPortGroup | %{
          $PortGroup = $_
          $PortGroupConfig = $NetworkSystem.NetworkConfig.PortGroup | ?{ $_.Spec.Name -eq $PortGroup.Name }
 
          # Store details of this Port Group using ID $i
 
          $NetworkConfig | Add-Member -Type NoteProperty -Name "PGName$i" -Value $PortGroup.Name
          $NetworkConfig | Add-Member -Type NoteProperty -Name "PGVLanId$i" -Value $PortGroup.VLanId
          $NetworkConfig | Add-Member -Type NoteProperty -Name "PGAllowPromiscuous$i" -Value $PortGroupConfig.Spec.Policy.Security.AllowPromiscuous
          $NetworkConfig | Add-Member -Type NoteProperty -Name "PGMacChanges$i" -Value $PortGroupConfig.Spec.Policy.Security.MacChanges
          $NetworkConfig | Add-Member -Type NoteProperty -Name "PGForgedTransmits$i" -Value $PortGroupConfig.Spec.Policy.Security.ForgedTransmits
 
          # Check for Null value on ActiveNic
 
          If ($PortGroupConfig.Spec.Policy.NicTeaming.NicOrder.ActiveNic) {
 
            # If the value is not null, store it
 
            $NetworkConfig | Add-Member -Type NoteProperty -Name "PGActiveNic$i" `
              -Value "$($PortGroupConfig.Spec.Policy.NicTeaming.NicOrder.ActiveNic)"
 
          } Else {
 
            # Assuming at least one ActiveNic
 
            $NetworkConfig | Add-Member -Type NoteProperty -Name "PGActiveNic$i" -Value "Inherited"
          }
          
          # Check for Null value on StandbyNic
 
          If ($PortGroupConfig.Spec.Policy.NicTeaming.NicOrder.StandbyNic) {
 
            # If the value is not null, store it
 
            $NetworkConfig | Add-Member -Type NoteProperty -Name "PGStandbyNic$i" `
              -Value "$($PortGroupConfig.Spec.Policy.NicTeaming.NicOrder.StandbyNic)"
 
          } Else {
 
            # Check to see if the number of ActiveNics in the Port Group equals the number of Nics on the Virtual Switch
            # If it does, all Nics are Active, no standby Nics exist
 
            If (([Array]$VSwitch.Spec.Policy.NicTeaming.NicOrder.ActiveNic).Count -eq `
              ([Array]$PortGroupConfig.Spec.Policy.NicTeaming.NicOrder.ActiveNic).Count)
            {
 
              # If all NICs are Active
              $NetworkConfig | Add-Member -Type NoteProperty -Name "PGStandbyNic$i" -Value "None"
 
            } Else {
 
              # Otherwise inherit
              $NetworkConfig | Add-Member -Type NoteProperty -Name "PGStandbyNic$i" -Value "Inherited"
            }
          }
 
          # Increment the port group counter
          $i++
        }
 
        # Return the $NetworkConfig object to the pipeline (added to $Report)
        $NetworkConfig
      }
    }
  }
}
 
# Fix the object array, ensure all objects within the 
# array contain the same members (required for Format-Table / Export-CSV)
 
$Members = $Report | Select-Object `
  @{n='MemberCount';e={ ($_ | Get-Member).Count }}, `
  @{n='Members';e={ $_.PsObject.Properties | %{ $_.Name } }}
$AllMembers = ($Members | Sort-Object MemberCount -Descending)[0].Members
 
ForEach ($Entry in $Report) {
  ForEach ($Member in $AllMembers)
  {
    If (!($Entry | Get-Member -Name $Member))
    { 
      $Entry | Add-Member -Type NoteProperty -Name $Member -Value ""
    }
  }
}
                                              

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:
118:
119:
120:
121:
122:
123:
124:
125: