Optimize ps1 script

Experts Exchange

	[x] Posted via EE Mobile
	Search, ask, and monitor your questions on the go with EE Mobile. Visit Experts Exchange from your mobile device and never be out of touch again.

Question

	[x] Attachment Details

[x]

The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

The Grade of the Solution
The Zone Rank of the Expert Providing the Solution
The Number of Author and Expert Comments
The Number of Experts Contributing
The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!

9.3

Optimize ps1 script

Asked by ryder0707 in Scripting Languages, Powershell

This question is needed to optimize the output of script created in http://www.experts-exchange.com/Programming/Languages/Scripting/Q_24776225.html

There is a problem with the output at "port group" when vmnics are not assigned to both PGActiveNic & PGStandbyNic
For example, if there are only 2 vmnics, but both vmnic0 & vmnic1 are assigned as the active adapters, meaning there are no adapter left for the standby

The expected output is
PGActiveNic1 : vmnic0 vmnic1
PGStandbyNic1 : None <----------- The string "none"

But the output from the script is
PGActiveNic1 : vmnic0 vmnic1
PGStandbyNic1 : Inherited

It is normal for the output to be like below, if both Active & Standby are not assigned with vmnics, since they will inherit the settings from vSwitch (this is already done in below script)
PGActiveNic1 : Inherited
PGStandbyNic1 : Inherited

View the Solution FREE for 30 Days

         
           
             1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:

           
           
             $Report = Get-Datacenter | %{
 
  $DCName = $_.Name
  $_ | Get-Cluster | %{
 
    $ClusterName = $_
    # Select only the first returned host
    $_ | Get-VMHost | Select-Object -First 1 | %{
 
      $HostID = $_ | Get-View
      $_ | Get-VirtualSwitch | %{
 
        $NetworkConfig = $_ | Select-Object `
          @{n='Datacenter';e={ $DCName }}, `
          @{n='Cluster';e={ $ClusterName }}, `
          @{n='vSwitch';e={ $_.Name }}, `
          @{n='vmNIC';e={ $_.NIC }}, `
          @{n='Ports';e={ $_.NumPorts }}
 
        # Virtual Switch information from the Host
 
        $NetworkSystem = Get-View $HostID.ConfigManager.NetworkSystem
        $VSwitch = $NetworkSystem.NetworkConfig.VSwitch | ?{ $_.Name -eq $NetworkConfig.VSwitch }
        $NetworkConfig | Add-Member -Type NoteProperty -Name "Host" -Value $Hostid.Name
        $NetworkConfig | Add-Member -Type NoteProperty -Name "AllowPromiscuous" -Value $VSwitch.Spec.Policy.Security.AllowPromiscuous
        $NetworkConfig | Add-Member -Type NoteProperty -Name "MacChanges" -Value $VSwitch.Spec.Policy.Security.MacChanges
        $NetworkConfig | Add-Member -Type NoteProperty -Name "ForgedTransmits" -Value $VSwitch.Spec.Policy.Security.ForgedTransmits
        $NetworkConfig | Add-Member -Type NoteProperty -Name "ActiveNic" -Value "$($VSwitch.Spec.Policy.NicTeaming.NicOrder.ActiveNic)"
        $NetworkConfig | Add-Member -Type NoteProperty -Name "StandbyNic" -Value "$($VSwitch.Spec.Policy.NicTeaming.NicOrder.StandbyNic)"
 
        # Port Group Information from each Virtual Switch       
 
        # A simple ID for the Port Group (used for column / member name)
        $i = 1
 
        $_ | Get-VirtualPortGroup | %{
          $PortGroup = $_
          $PortGroupConfig = $NetworkSystem.NetworkConfig.PortGroup | ?{ $_.Spec.Name -eq $PortGroup.Name }
 
          $NetworkConfig | Add-Member -Type NoteProperty -Name "PGName$i" -Value $PortGroup.Name
          $NetworkConfig | Add-Member -Type NoteProperty -Name "PGVLanId$i" -Value $PortGroup.VLanId
          $NetworkConfig | Add-Member -Type NoteProperty -Name "PGAllowPromiscuous$i" -Value $PortGroupConfig.Spec.Policy.Security.AllowPromiscuous
          $NetworkConfig | Add-Member -Type NoteProperty -Name "PGMacChanges$i" -Value $PortGroupConfig.Spec.Policy.Security.MacChanges
          $NetworkConfig | Add-Member -Type NoteProperty -Name "PGForgedTransmits$i" -Value $PortGroupConfig.Spec.Policy.Security.ForgedTransmits
 
          # Testing for Null
          #
 
          If ($PortGroupConfig.Spec.Policy.NicTeaming.NicOrder.ActiveNic) {
            $NetworkConfig | Add-Member -Type NoteProperty -Name "PGActiveNic$i-Null" `
              -Value "$($PortGroupConfig.Spec.Policy.NicTeaming.NicOrder.ActiveNic)"
          } Else {
            $NetworkConfig | Add-Member -Type NoteProperty -Name "PGActiveNic$i-Null" -Value "Inherited"
          }
          
          If ($PortGroupConfig.Spec.Policy.NicTeaming.NicOrder.StandbyNic) {
            $NetworkConfig | Add-Member -Type NoteProperty -Name "PGStandbyNic$i-Null" `
              -Value "$($PortGroupConfig.Spec.Policy.NicTeaming.NicOrder.StandbyNic)"
          } Else {
            $NetworkConfig | Add-Member -Type NoteProperty -Name "PGStandbyNic$i-Null" -Value "Inherited"
          }
 
          $i++
        }
 
        $NetworkConfig
      }
    }
  }
}
 
$Report

           
         

Optimize ps1 script

Asked by ryder0707 in Scripting Languages, Powershell

About this solution