Question

How to add a new method to the controller

Asked by: witgrefe

I want to add a method called delete_all to my controller but defining it there doesn't allow it to be called.  What am I doing wrong?

Thanks

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2008-03-21 at 08:49:26ID23259927
Topic

Ruby Scripting Language

Participating Experts
3
Points
150
Comments
17

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Using Execute method of Internet Transfer control
    I'm using this control to perform FTP file transfers with the OpenURL method and everything works fine. However, if I want to delete a remote file, the Execute method must be used, but I can never establish the connection before timing out. I had the same problem with Execu...
  2. The Render Method of a Picture Control
    If you place a picture control (Picture1) on a form, the picture control's picture property has a Render() method. Can anyone explain what this is for because if I press F1 in the VB IDE when this method is selected I get the Keyword Not Found error in MSDN? If you search fo...
  3. No overload for method
    Hi can anyone help me solve this problem I have the function below decimal ReturnVat( decimal decBudget, string strCountryValue) { decimal decGetVat; if(strCountryValue == "GB") { decGetVat = decBudget * 17.5 /100; } else { decGetV...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: GertonePosted on 2008-03-21 at 08:54:07ID: 21180779

do you mean as a controller action,
so that root/controller/delete_all works?

If you add the method definition in the controller, you should be able to do so
make sure that the method definition does not come after a PRIVATE

 

by: witgrefePosted on 2008-03-22 at 02:57:54ID: 21185470

I thought that was the case but when I do, I get this error:
Status: 500 Internal Server Error Content-Type: text/html
500 Internal Server Error

 

by: GertonePosted on 2008-03-22 at 06:09:36ID: 21186062

what is in the method?

 

by: witgrefePosted on 2008-03-22 at 07:28:25ID: 21186412

def destroy_all
    my_count = PayPeriod.count
     for w in 1..my_count
     @pay_periods = PayPeriod.find(:first)
     i=@pay_periods.id
     @pay_period = PayPeriod.find(i).destroy
    end

    respond_to do |format|
      format.html { redirect_to(pay_periods_url) }
      format.xml  { head :ok }
    end
  end

 

by: witgrefePosted on 2008-03-25 at 04:34:03ID: 21200906

Hello Again,
I have inspected the console output (in Aptana) and this is what it says:
Status: 500 Internal Server Error
  delete_all, accepted HTTP methods are delete, head, get, options, post, and put

I get the same error on my PC at home as well.

Regards

 

by: bobbit31Posted on 2008-03-25 at 17:20:44ID: 21207729

can you post your routes.rb?

 

by: witgrefePosted on 2008-03-27 at 04:27:32ID: 21220197

Here it is:

ActionController::Routing::Routes.draw do |map|
  map.connect 'pay_periods_controller/delete_all', :controller => 'pay_periods_controller', :action => 'delete_all'
  map.resources :work_schedules
  map.resources :daynames
  map.resources :phols
  map.resources :pay_periods
  map.resources :abreviations
  map.resources :sections
  map.resources :employees
  map.resources :programs
  map.resources :groups
  map.resources :welcomes
  map.resources :mains
  map.resources :bureaus
  map.root :controller => "welcomes"
  map.connect ':controller/:action/:id'
  map.connect ':controller/:action/:id.:format'
end


 

by: JESiiPosted on 2008-03-27 at 07:37:37ID: 21221795

You might try simplifying your code -- maybe using the delete_all method directly, such as the following (this assumes that you don't have any dependent records... destroy actually instantiates the object first and the destroys it, using any callbacks you may have created). delete_all is much more efficient and might make it easier to debug.

It may also have to do with your using a method name which already exists in ActiveRecord, so I've change the name of the method to avoid possible confusion.

You'll have to change your routes to implement this and you'll have to get the related employee id into the condition clause.

HTH...jon


def delete_all_pay_periods
  # Find the related employee id here
  ee_id = ...
  PayPeriod.delete_all "employee_id = ?", ee_id
end
                                              
1:
2:
3:
4:
5:

Select allOpen in new window

 

by: witgrefePosted on 2008-03-27 at 07:51:15ID: 21221991

Thanks a lot JESii for your input.
I have no problem deleting all the records in one operation using the Destroy method/action in the controller, the problem is getting the RoR to recognise "delete_all_pay_periods" (in my case delete_all).  Everything I do results in the 500 error.
Status: 500 Internal Server Error
  delete_all, accepted HTTP methods are delete, head, get, options, post, and put

 

by: bobbit31Posted on 2008-03-27 at 10:01:06ID: 21223562

shouldn't this:
map.connect 'pay_periods_controller/delete_all', :controller => 'pay_periods_controller', :action => 'delete_all'

be:
map.connect 'pay_periods_controller/delete_all', :controller => 'pay_periods_controller', :action => 'delete_all_pay_periods'

 

by: JESiiPosted on 2008-03-27 at 10:18:28ID: 21223762

@witgrfe: Try renaming the method to delete_all_pay_periods to make sure that you aren't getting into trouble duplicating an existing ActiveRecord method.

 

by: witgrefePosted on 2008-03-28 at 01:19:05ID: 21228653

Hello, I have tried everything and still get the 500 error.  This is what I have:

in routes.rb I have tried various combinations:
map.connect 'work_schedules/:delete_all_scheds', :controller => 'work_schedules', :action => 'delete_all_scheds'  
map.connect 'work_schedules/delete_all_scheds', :controller => 'work_schedules', :action => 'delete_all_scheds'  
map.connect 'work_schedules/:delete_all_scheds', :controller => 'work_schedules_controller', :action => 'delete_all_scheds'  
map.connect 'work_schedules/delete_all_scheds', :controller => 'work_schedules_controller', :action => 'delete_all_scheds'  
map.connect 'work_schedules_controller/:delete_all_scheds', :controller => 'work_schedules_controller', :action => 'delete_all_scheds'  
map.connect 'work_schedules_controller/delete_all_scheds', :controller => 'work_schedules_controller', :action => 'delete_all_scheds'  

In the work schedules controller:
def delete_all_scheds
  my_count = WorkSchedule.count
      if my_count >0
        my_count.times do
          @work_schedules = WorkSchedule.find(:first)
          @work_schedule = WorkSchedule.find(@work_schedules.id).destroy
        end
    end
      respond_to do |format|
        format.html { redirect_to(work_schedules_url) }
       format.xml  { head :ok }
      end
  end

In the work schedules view:
<td><%= link_to 'Delete Scheds', work_schedule, :confirm => 'Are you sure?', :method => :delete_all_scheds %></td>

Can it be that it is just not possible to have any action in the controller other than the default ones?

 

by: JESiiPosted on 2008-03-28 at 05:28:52ID: 21229711

@witgrefe... Two things to try:

1. Have you looked at the development log to see what the last thing was that executed successfully? That will give you more information. You can find the logs under the log directory under your appliation: the file is development.log (assuming this is still in development).

2. Rather than looping through the items, just give the array of schedules to destroy, as in the code snippet. destroy and friends can all delete a group of elements, not just a single one, so you  don't have to take a count and do them one-by-one... as long as you limit the find() to the specific set of records that you want. I am assuming that you have something like Employees have_many WorkSchedules.

Cheers...jon

def delete_all_scheds
# Get the related employee id however you need to:
ee_id = ...
@work_schedules = WorkSchedule.find(:all, :conditions => ['employee_id = ?, ee_id]).destroy
end

                                              
1:
2:
3:
4:
5:

Select allOpen in new window

 

by: bobbit31Posted on 2008-03-28 at 12:38:57ID: 21233525

in routes.rb:

map.resources :work_schedules,
   :collection => {
       :delete_all => :delete
   }

In your view:

<%= link_to 'Delete Scheds', delete_all_work_schedules_path, :confirm => 'Are you sure?', :method => :delete %>

 

by: bobbit31Posted on 2008-03-28 at 12:40:08ID: 21233535

oh and your controller action should be called delete_all

 

by: JESiiPosted on 2008-03-29 at 12:53:27ID: 21237855

@witgrefe: I tested the following code in my application and it definitely deletes all the associated records wihtout error. I have a list of assets associated with a user (user has_many assets).

I created a route to delete_all_assets and then added the code below... Note that I save the user id in the session -- you probably have the employee name stored somewhere else as well.

You'll have to change this to match your Classes and attributes... I've given you a sample below.

Make sure you use the redirect_to, since you probably want to send them back to a generic listing after you've deleted the work schedules...

// Code I tested... and works
  def delete_all_assets
    Asset.destroy_all(["user_id = ?", session['user']['id']])
    redirect_to( :action => 'list' )
  end
 
// Code partly modified for your Classes/Attributes
  def delete_all_schedules
    WorkSchedules.destroy_all(["employee_id = ?", session['employee_id']])
    redirect_to( :action => 'list' )
  end

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:

Select allOpen in new window

 

by: witgrefePosted on 2008-03-31 at 03:12:16ID: 31441798

Thank you both for your help and patience, you have helped me understand more about how RoR works.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...