Question

Store command output into variable

Asked by: kickenchicken57

I am new to bash scripting and linux. I have a bash script that I have been working on that will take a path to a dd disk image file and pass it into fdisk to parse out some information. The issue that I am having is after I use sed to get the text that I want, I can't figure out how to save it into a variable. Instead I just keep getting an error:

 "/bin/timeline: line 49: /media/USB: No such file or directory"

This error appears to originate from the line where I set the temp variable:

temp=`$line|sed "s/.*\.001p[[:digit:]][^[:digit:]]\{0,\}\([[:digit:]]\{1,\}\).*/\1/"`

I have tried surrounding the command in bacticks like above and with $() but I still get the same error message. Below is what the output looks like from running the command:

[root@SIFTWorkstation /]# timeline /media/USB\ 500GB/Images/6RX99BCP/6RX99BCP.001
-------------------------------------------
/media/USB 500GB/Images/6RX99BCP/6RX99BCP.001p1   *          63   109980989    54990463+   7  HPFS/NTFS
-------------------------------------------
63
/bin/timeline: line 49: /media/USB: No such file or directory
count = 1
-------------------------------------------
/media/USB 500GB/Images/6RX99BCP/6RX99BCP.001p2       109980990   156296384    23157697+   7  HPFS/NTFS
-------------------------------------------
109980990
/bin/timeline: line 49: /media/USB: No such file or directory
count = 2
partition_offsets[0] = 1
temp =
[root@SIFTWorkstation /]#

#!/bin/bash
 
#Check that there is one argument passed in
 
if [ $# -ne 1 ]
then
	echo "Usage: $(basename "$0") path"
	echo "  path: path to the image file"	
	exit 1
fi
 
 
 
#Check that the image file exists
 
if [ ! -f "$1" ]
then
	echo "File: "$1" does not exist"
	exit 1
fi
 
 
 
#Grab the basename of the file
 
filename=$(basename "$1")
#echo "Filename: $filename"
 
 
 
#Store the file name without the extension as the case name
 
casenum=`echo $filename | sed "s/\..*//"`
#echo "Case number = $casenum"
 
 
 
#Get the details about the disk image
 
declare -a partition_offsets
partition_offsets[0]=1
count=0
fdisk -ul "$1" 2>/dev/null | grep "6RX99BCP\.001p" | while read line
do
	echo "-------------------------------------------"
	echo "$line"
	echo "-------------------------------------------"
	echo $line | sed "s/.*\.001p[[:digit:]][^[:digit:]]\{0,\}\([[:digit:]]\{1,\}\).*/\1/"
	temp=`$line|sed "s/.*\.001p[[:digit:]][^[:digit:]]\{0,\}\([[:digit:]]\{1,\}\).*/\1/"`
	count=$[$count + 1]
	echo "count = $count"
done
 
echo -n "partition_offsets[0] = "
echo ${partition_offsets[0]}
echo "temp = $temp"

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-10-30 at 08:20:29ID24858319
Tags

linux

,

bash

,

shell

,

fedora

Topics

Bourne-Again Shell (bash)

,

Linux Programming

,

Fedora Linux

Participating Experts
2
Points
500
Comments
12

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. sed using varaibles
    I want to delete the top two and bottom two lines of a text file which alters in size so I would use e.g. : sed '50,52d' textfile. How do I use a variable in place of a number for the eof marker in sed?
  2. SED Question
    I need to SED a file and replace: Transport Hostname="cscx1001" with: Transport Hostname="9.9.9.9" Here is the whole command: cat plugin-cfg.xml | sed "s/Transport Hostname="cscx1234"/Transport Hostname="10.9.9.9"/g"...
  3. Variable in sed
    Hi, I've the problem with my shell script: -------------- search_word=SEARCH replace_word=REPLACE sed 's/$search_word/$replace_word/g' testfile ------------- cat testfile SEARCH How do I make sed take variables $seach_word and $replace_word instead of "SEARCH" ...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: amit_gPosted on 2009-10-30 at 08:25:59ID: 25703896

temp=`$line|sed "s/.*\.001p[[:digit:]][^[:digit:]]\{0,\}\([[:digit:]]\{1,\}\).*/\1/"`
should instead be
temp=`echo $line|sed "s/.*\.001p[[:digit:]][^[:digit:]]\{0,\}\([[:digit:]]\{1,\}\).*/\1/"`

 

by: kickenchicken57Posted on 2009-10-30 at 08:34:29ID: 25703984

That gets rid of the error "/bin/timeline: line 49: /media/USB: No such file or directory" but the temp variable is still null when I run the script :(

 

by: amit_gPosted on 2009-10-30 at 08:39:20ID: 25704022

Where are you checking the temp variable? Add an echo before

count=$[$count + 1]

echo $temp

It should be within the loop.

also

count=$[$count + 1]
should be
count=$(($count + 1))

 

by: kickenchicken57Posted on 2009-10-30 at 08:50:14ID: 25704141

Ok, I can see the temp variable now, but I have defined partition_offsets outside of the loop and if i assign the output to "partition_offsets[$count]=output from command" I still only see partition_offsets holding the correct value while inside the loop and not outside of the loop. What must I do to get the output stored inside of the loop to be visible after I leave the loop? I really need to fill the partition_offsets array inside of the loop for a later use.

 

by: amit_gPosted on 2009-10-30 at 10:13:29ID: 25704992

It should be available after the loop also unless it is reset somehow. Post the complete script and output from it.

 

by: kickenchicken57Posted on 2009-10-30 at 12:42:16ID: 25706187

It appears that if you use a loop fed by a piped command the loop will perform within a sub-shell which is why I am seeing this issue.

http://www.nucleardonkey.net/blog/2007/08/variable_scope_in_bash.html
http://nion.modprobe.de/blog/archives/531-Altering-a-variable-outside-the-scope-of-a-loop-influenced-by-a-subshell.html

I have included my modified script. I changed it to make use of the partition_offsets array rather than the temp variable. Below is the output.

[root@SIFTWorkstation /]# timeline /media/USB\ 500GB/Images/6RX99BCP/6RX99BCP.001
-------------------------------------------
/media/USB 500GB/Images/6RX99BCP/6RX99BCP.001p1   *          63   109980989    54990463+   7  HPFS/NTFS
-------------------------------------------
63
count = 0
partition_offsets[0] = 63
-------------------------------------------
/media/USB 500GB/Images/6RX99BCP/6RX99BCP.001p2       109980990   156296384    23157697+   7  HPFS/NTFS
-------------------------------------------
109980990
count = 1
partition_offsets[1] = 109980990
-----outside of loop-----
partition_offsets[0] =
[root@SIFTWorkstation /]#

I have tried changing this to store the fdisk and grep command results to a variable and do a "for line in $lines" style of loop but the loop didn't appear to treat the result of the grep as multiple lines like the current while loop that I am using.

#!/bin/bash
 
#Check that there is one argument passed in
 
if [ $# -ne 1 ]
then
	echo "Usage: $(basename "$0") path"
	echo "  path: path to the image file"	
	exit 1
fi
 
 
 
#Check that the image file exists
 
if [ ! -f "$1" ]
then
	echo "File: "$1" does not exist"
	exit 1
fi
 
 
 
#Grab the basename of the file
 
filename=$(basename "$1")
#echo "Filename: $filename"
 
 
 
#Store the file name without the extension as the case name
 
casenum=`echo $filename | sed "s/\..*//"`
#echo "Case number = $casenum"
 
 
 
#Get the details about the disk image
 
declare -a partition_offsets
count=0
fdisk -ul "$1" 2>/dev/null | grep "6RX99BCP\.001p" | while read line
do
	echo "-------------------------------------------"
	echo "$line"
	echo "-------------------------------------------"
	echo $line | sed "s/.*\.001p[[:digit:]][^[:digit:]]\{0,\}\([[:digit:]]\{1,\}\).*/\1/"
	partition_offsets[$count]=$(echo $line|sed "s/.*\.001p[[:digit:]][^[:digit:]]\{0,\}\([[:digit:]]\{1,\}\).*/\1/")
	#count=$[$count + 1]	
	echo "count = $count"
	echo -n "partition_offsets[$count] = "
	echo "${partition_offsets[$count]}"
	count=$(($count + 1))
done
 
echo "-----outside of loop-----"
echo -n "partition_offsets[0] = "
echo ${partition_offsets[0]}

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:

Select allOpen in new window

 

by: amit_gPosted on 2009-10-30 at 13:00:08ID: 25706319

Can you add the following line in the end and see what you get?

echo "partition_offsets = " ${partition_offsets[*]}

 

by: simon3270Posted on 2009-11-01 at 04:09:49ID: 25713450

This is a common problem with bash (Posix shell usually gets it right, and remembers the varialevalues outside the loop),

There are a couple of solutions.  One is to use the "exec" command.  Put the data you want to read in a file.  Then run "exec" using that file as standard input.  The "while" loop then reads from that file:

fdisk -ul "$1" 2>/dev/null | grep "6RX99BCP\.001p" > /tmp/tmpfile.$$
exec < /tmp/tmpfile.$$
while read line
do
      echo "-------------------------------------------"
      echo "$line"
      echo "---------------------------------------

and so on.  Delete /tmp/tmpfile.$$ when the loop finishes.

The other way is to store variables in files (e.g "echo $count > /tmp/tmpcount") within the loop, then read the files outside the loop.  This works fine for simple variables, but would be very difficult for your arrays.  The "exec" method is the way to do it here.

 

by: kickenchicken57Posted on 2009-11-02 at 06:30:40ID: 25719586

I have raised the points to 500 to split between you two.

amit_q: I have tried your suggestion but it still printed out nothing. just "partition_offsets = "

simon3270: the exec command seems to do the trick although I don't fully understand why it works. If you would be kind enough to explain why or at least point me to a good source of information on this subject I would apreciate it.

 

by: kickenchicken57Posted on 2009-11-02 at 06:32:35ID: 31648057

Thank you both for the assistance!

 

by: simon3270Posted on 2009-11-02 at 13:08:09ID: 25723745

The "exec" line says that from that point on in the script, standard input comes from the file you specify, not from the keyboard.  Then the "read line" bit, which would normally read from standard input, reads from the file instead.

If your script needed the real standard input later on, there is a way to remember the actual stdin, and reset it after you have read the file (see link below).

I'm not sure where I learnt this - it's just one of the things I have picked up over the years - but I did find a good description on http://www.linuxtopia.org/online_books/advanced_bash_scripting_guide/x13082.html
 
Thanks for the points - made me up to a Qualified Expert!

 

by: kickenchicken57Posted on 2009-11-03 at 09:43:11ID: 25731463

Thanks again, this was a difficult one to figure out.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...