Question

excel vba - export import bas module as bas file - Run-Time error 91 - Subscript out of range - trying to set Workbook as filename and path

Asked by: natdacruz

Im stuck,

Apart from locking a file I've spent a good few nights working on (by duplicating a Sub name in a module - sleep deprivation is never a good thing) I find my self stuck setting an application.workbooks(filename&path)

I have tried a number of combinations of the folder/filepath etc but no joy

I have added the code if anyone can spot the error Ive points a plenty - Im sure its something vsimple... as usual

also if anyone knows how to uncrash an excel file that is well and truly skuppered - ie it wont open at all (when you open it in Visual Basic Editor - it freezes as soon as th code window with the duplicated sub name pops up - so no guesses where the problem is there)
Points galore for that one too :)

Dealines are looming and sleep still evades ... all help gratefully accepted...

code is:

Option Explicit

Sub CopyModule()
       
' copies a module from one workbook to another
' example:
   
Dim strFolder As String
Dim strTempFile As String
Dim wb1 As Excel.Application
Dim wb2 As Excel.Application
Dim TargetFile As String
Dim SourceFile As String
Dim TargetWB As Workbook
Dim SourceWB As Workbook
Dim strModuleName As String
Dim strModuleName1 As String
Dim strModuleName2 As String
Dim strModuleName3 As String
Dim strModuleName4 As String
Dim strModuleName5 As String
Dim strModuleName6 As String
Dim module As Integer

SourceFile = "TS4.0 Control Panel - Backup.xls"
TargetFile = "Code Dump.xls"

Set wb1 = CreateObject("Excel.Application")
Set wb2 = CreateObject("Excel.Application")


    strFolder = "C:\Users\lrc\Desktop\TS4.0 Stable"
    Set TargetWB = wb1.Workbooks(strFolder & "\" & TargetFile)
    Set SourceWB = wb2.Workbooks(strFolder & "\" & SourceFile)

   
    strModuleName1 = "format_Control"
    strModuleName2 = "format_Extracts"
    strModuleName3 = "reportControl"
    strModuleName4 = "format_Control"
    strModuleName5 = "setParameters"
    strModuleName6 = "Module1"
'    If Len(strFolder) = 0 Then strFolder = CurDir

For module = 1 To 6

strModuleName = "strModuleName" & module

    strFolder = strFolder & "\"
    strTempFile = strFolder & strModuleName & ".bas"
    On Error Resume Next
    SourceWB.VBProject.VBComponents(strModuleName).Export strTempFile
    TargetWB.VBProject.VBComponents.Import strTempFile
    Kill strTempFile
    On Error GoTo 0

Next module

MsgBox ("All Done")
   
End Sub


 

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. EXCEL VBA New Workbook
    How can I create a new Workbook and rename the sheets inside the workbook inside of a Excel VBA. I can use the below code that will work if I run it as a maco, but it wont work as a program? Workbooks.Add Sheets("Sheet1").Select Sheets("Sheet1").Name = &q...
  2. Move Workbook in VBA
    Ola, I have opened a workbook in VBA using this stament Workbooks.Open Filename:=iStrNewWorkBookFullPath Sometimes the code decides the workbook should be moved to a sub directory. How do I do that?
  3. One workbook VBA interferes with other workbook
    I have a function in a VBA module that is part of a formula in cells in a spreadsheet column. Therefore, whenever a cell is changed on the spreadsheet the formula and function run in case the formula references the changed cell. If there were say 100 rows, then the function...
  4. Workbook Open
    Hello All Trying to set a command button to open a existing workbook, Is there a way to open that workbook in a new excel window, separate from the existing one that is already opened. My workbook is located in \\wain\hh\text.xls
  5. Deleting a workbook via VBA
    Hi All I'm using Excel 2007. I need to delete a workbook using VBA code. Can someone pls help me with the code for this? Thanks in advance Elmo
  6. renaming workbooks
    Hi, I've about 60 workbooks in a directory ;- C:\Reports\ Each workbook is a persons name and I need to change this instead of Salesperson1.xls, Salesperson2.xls, Salesperson3.xls etc, I need to put the words Report Document in front of each workbook so the na...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: bhwithunPosted on 2009-04-24 at 20:14:01ID: 24230650

Is your TargetWB supposed to reference a new file, or an existing file?

If it's supposed to be a new file, I seem to recall that you CANNOT name a workbook UNLESS you save it.

By that I mean, it will be called "Book1" (or "Book2" or whichever next sequential number) and you can't change that name except by actually saving it to disk.

Try creating your workbook using Workbooks.Add(), and then later .SaveAs() at which time you can give it a filename and path.

Read up on Application.DisplayAlerts, if you want Excel to stop prompting the user for a filename.

Set NewBook = Workbooks.Add
Do
    fName = Application.GetSaveAsFilename
Loop Until fName <> False
NewBook.SaveAs Filename:=fName

                                              
1:
2:
3:
4:
5:

Select allOpen in new window

 

by: natdacruzPosted on 2009-04-25 at 14:42:02ID: 24233650

Hi bhwithun sorry for getting back to you so late... I have already created and saved the target file... its in the same folder and pathway as the operating excel workbook and the source workbook.

I could create a new file as I dont mind where the bas file ends up ... in fact the bas file can stay in the source file directory for me to import into the appropriate file later.

This is where it stings - I am still getting the same problem with finding the source file... which is essential.

To cut things short though.... if i cant open the file manualy - will I have the same problem when I try and extract the module as a bas file. I think I may have to go back the drawing board and re-write the code from scratch ... ho hum

let me know if you can think of anything :)

Thanks

N

I

 

by: roryaPosted on 2009-04-25 at 15:42:32ID: 24233787

Your code does not appear to be opening the files. These lines:

Set TargetWB = wb1.Workbooks(strFolder & "\" & TargetFile)
   Set SourceWB = wb2.Workbooks(strFolder & "\" & SourceFile)

should be:

Set TargetWB = wb1.Workbooks.Open(strFolder & "\" & TargetFile)
   Set SourceWB = wb2.Workbooks.Open(strFolder & "\" & SourceFile)

Regards,
Rory

 

by: natdacruzPosted on 2009-04-25 at 15:51:53ID: 24233815

Ok Update...

I have tried to run the code again with the following...

    Set TargetWB = wb1.Workbooks.Open(strFolder & "\" & TargetFile)

it works fine... the problem is that I dont want to open the source file ... i need to extract the modules WITHOUT openning it as opening runs VB editor (or some other module checker and freezes when it reaches my corrupted module)

I have found some code that can extract data (cell values) from a file without openning it... I am sure there must be a way to reference a workbook.VBProject.VBComponents without opening it...

any ideas?

N

 

by: natdacruzPosted on 2009-04-25 at 16:12:01ID: 24233851

Using the

ExecuteExcel4Macro(Data)

I have extracted the cell values from the first sheet in the wb.... its only logical that i must be able to get access to the workbook.VBProject.VBComponents without opening the file...

i have pasted the code I have used to do this below:

ub GetDataDemo()
   
    Dim FilePath$, Row&, Column&, Address$
   
     'change constants & FilePath below to suit
    '***************************************
   Const FileName$ = "TS4.0 Control Panel - Backup.xls"
   Const SheetName$ = "Control"
   Const NumRows& = 50
   Const NumColumns& = 15
   FilePath = ActiveWorkbook.Path & "\"
    '***************************************
   
    DoEvents
   Application.ScreenUpdating = False
   If Dir(FilePath & FileName) = Empty Then
       MsgBox "The file " & FileName & " was not found", , "File Doesn't Exist"
       Exit Sub
   End If
   For Row = 1 To NumRows
       For Column = 1 To NumColumns
           Address = Cells(Row, Column).Address
           Cells(Row, Column) = GetData(FilePath, FileName, SheetName, Address)
           Columns.AutoFit
       Next Column
   Next Row
   ActiveWindow.DisplayZeros = False
End Sub

 
Private Function GetData(Path, File, Sheet, Address)
   Dim Data$
   Data = "'" & Path & "[" & File & "]" & Sheet & "'!" & _
   Range(Address).Range("A1").Address(, , xlR1C1)
   GetData = ExecuteExcel4Macro(Data) '<------------------------------------------------- this is magic button
End Function

 

any ideas... this is not looking simple

N

 

 

by: natdacruzPosted on 2009-04-25 at 16:34:51ID: 24233891

wow somehow it worked..... the code I used is:


Sub ExportCode()
Dim app As Excel.Application
Set app = New Excel.Application
Dim wb As Excel.Workbook
Set wb = Excel.Application.Workbooks.Add("C:\Users\lrc\Desktop\TS4.0 Stable\TS4.0 Control Panel - Backup.xls")
Dim strExt As String
Dim VBComp As Object
For Each VBComp In wb.VBProject.VBComponents
Select Case VBComp.Type
Case 2  ' Class module
strExt = ".cls"
Case 3  ' Form
strExt = ".frm"
Case 1  ' Standard module
strExt = ".bas"
Case 100  ' Document?
strExt = ".cls"
Case Else
Stop  ' What else is there?
strExt = ".cls"
End Select
VBComp.Export "C:\" & VBComp.Name & strExt
Next
wb.Close False
app.Quit
End Sub

for some reason it managed to get the bas files out before it crashed.... now i just need to find a way to get the sheets out ...ok muchas gracias and points to each and all of you :)

Ciao

N

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...