Question

vbscript to replace text in a file

Asked by: bobs6140

I am trying to update a file on a bunch of systems with a vbscript, the script finds the severs but it deletes the contents of the file, I read in the file, close it then write to it but it appears the write is not happening.

'====================
'
' Type:      VBScript
'
' NAME:      TSMFix.vbs
'
' AUTHOR:    Bob Smith
'
' PURPOSE:   This script will parse a list of servers, and modify the TSM
'            config. It requires servers.txt in the same folder as this script.
'            Servers.txt should contain one machine name per line.
'
' COMMENTS:    
'
' *****************************************************
' ~~~Begin Script~~~

Option Explicit
' Declare Everything!
Dim objFSO, objTextFile, objTextFile1, objTextFile2, objWMIService, objItem, objService, objChksrv, i
Dim strComputer, Line, strNextLine, Srvpad, colItems, colListOfServices, oDrives, WshNetwork
Dim drive, objShell

On Error Resume Next

Const ForReading = 1, ForWriting = 2

Set objFSO = CreateObject("Scripting.FileSystemObject")

' Opens the servers.txt file to find the server name(s)
' -----------------------------------------------------
Set objTextFile = objFSO.OpenTextFile("C:\TsmFix\servers.txt", ForReading)

Set WshNetwork = WScript.CreateObject("WScript.Network")
Set oDrives = WshNetwork.EnumNetworkDrives
Set objShell = WScript.CreateObject("WScript.Shell")

Do Until objTextFile.AtEndOfStream
strComputer = objTextFile.Readline
'Check if the Server is online and has TSM folder
' -----------------------------------------------------
Srvpad = "\\"&strComputer&"\c$\program files\TIVOLI\TSM\baclient"

IF objFSO.FolderExists(Srvpad) = FALSE THEN
WScript.Echo "Server " & strServer & " doesn't have TSM or is offline!"
WScript.Quit
END If

' Backup current TSM config
objFSO.CopyFile Srvpad & "\dsm.opt" , Srvpad &"\dsm.opt.old"

' Wait for copy to complete
WScript.Sleep 10000

' Set TSM Service name
' -----------------------------------------------------
Set objService = GetObject("WinMgmts:{impersonationLevel=impersonate}!//" _
& strComputer & "/root/cimv2:Win32_Service.Name='TSM Scheduler'")

' Stop TSM Scheduler
' -----------------------------------------------------
objService.StopService

' Set the file for Reading / Writing
' -----------------------------------------------------
Set objTextFile2 = objFSO.OpenTextFile(Srvpad & "\dsm.opt", ForReading)

       strText = objTextFile2.ReadAll
       objTextFile2.Close
       strNewText = Replace(strText, "HYDRA1", "James")

Set objTextFile2 = objFSO.OpenTextFile(Srvpad & "\dsm.opt", ForWriting)
objTextFile2.WriteLine strNewText
objTextFile2.Close
' -----------------------------------------------------
' Wait 10 seconds for things to settle down
WScript.Sleep 10000

' Start TSM Scheduler
objService.StartService
Wscript.Echo "The TSM Scheduler service on " & strComputer & " has restarted succesfully."

' Go get next computer name and start over...
Loop

objTextFile.Close

' -----------------------------------------------------
' Functions
' -----------------------------------------------------

'Read text file
Function GetFile(FileName)
If FileName<>"" Then
Dim FS, FileStream
Set FS = CreateObject("Scripting.FileSystemObject")
on Error resume Next
Set FileStream = FS.OpenTextFile(FileName)
GetFile = FileStream.ReadAll
End If
End Function

'Write text file.
Function WriteFile(FileName, Contents)
Dim OutStream, FS

on Error Resume Next
Set FS = CreateObject("Scripting.FileSystemObject")
Set OutStream = FS.OpenTextFile(FileName, 2, True)
OutStream.Write Contents
End Function

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2007-06-26 at 06:31:03ID22658189
Tags

vbscript

,

replace

,

text

,

file

Topics

VB Script

,

Microsoft Windows Operating Systems

Participating Experts
2
Points
250
Comments
11

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Permission Denied error using WScript.Shell in VBScript
    I have the same script running on 3 Windows 2000 Servers and I'm getting a Permission Denied error on 1. Here's the code (below) the problem is with WScript.Shell. I've checked and permissions in IIS and for the IUSR account are the same on all servers. Permission for \WIN...
  2. Simple Wscript.Shell question
    Hi I want to use WScript.shell Run command, to run a little EXE file on the server, like nslookup.exe , and then get all the results (what the EXE file returns) and show them in my page. As I am new to Windows Script Host, I don't know how to get the returned texts. I testes ...
  3. Redirect WScript.Echo Output
    New to scripting, how can I redirect the output from a message box to a file? The following code displays a message box for each element of the array. I'd like to capture it in a file. WScript.Echo "Members:" For Each strMember in arrMemberOf WScript.Echo strMe...
  4. restart services with VBScript
    I have a list of computers, these computers have an xml file that I need to replace by the one located on my desktop. I also need to restart a McAfee framework service in each computer. Can I have a vbscript that can do that? Thanks
  5. VBSCRIPT
    I have written a vbscript to Scans Lanier Folder And Copies Files To The Appropriate Departmental Directory. The script I wrote does reads and scans Lanier Folder on dirve c:\scans but it does not Copies Files To The Appropriate Departmental Directory. Please view my VBSRIP...
  6. VBScript objProcess.Methods error
    Good day everyone, I'm in the middle of writing a VBScript to connect to remote XP Professional workstations and start buy running an executable called TaskDeletor.exe that will delete Scheduled Task jobs when I run this script from my XP Professional Workstation. Here's the...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: DarkoLordPosted on 2007-06-26 at 06:41:22ID: 19363517

Hi,

first make sure that the file gets read. Put an echo after you read the file to see if you get anything:

Wscript.Echo strText

 

by: bobs6140Posted on 2007-06-26 at 06:48:41ID: 19363605

Thanks for the response, I does not appear to be reading the file, I have added in the echo and got nothing back.

'====================
'
' Type:      VBScript
'
' NAME:      TSMFix.vbs
'
' AUTHOR:    Bob Smith
'
' PURPOSE:   This script will parse a list of servers, and modify the TSM
'            config. It requires servers.txt in the same folder as this script.
'            Servers.txt should contain one machine name per line.
'
' COMMENTS:    
'
' *****************************************************
' ~~~Begin Script~~~

Option Explicit
' Declare Everything!
Dim objFSO, objTextFile, objTextFile1, objTextFile2, objWMIService, objItem, objService, objChksrv, i
Dim strComputer, Line, strNextLine, Srvpad, colItems, colListOfServices, oDrives, WshNetwork
Dim drive, objShell

On Error Resume Next

Const ForReading = 1, ForWriting = 2

Set objFSO = CreateObject("Scripting.FileSystemObject")

' Opens the servers.txt file to find the server name(s)
' -----------------------------------------------------
Set objTextFile = objFSO.OpenTextFile("C:\TsmFix\servers.txt", ForReading)

Set WshNetwork = WScript.CreateObject("WScript.Network")
Set oDrives = WshNetwork.EnumNetworkDrives
Set objShell = WScript.CreateObject("WScript.Shell")

Do Until objTextFile.AtEndOfStream
strComputer = objTextFile.Readline
'Check if the Server is online and has TSM folder
' -----------------------------------------------------
Srvpad = "\\"&strComputer&"\c$\program files\TIVOLI\TSM\baclient"

IF objFSO.FolderExists(Srvpad) = FALSE THEN
WScript.Echo "Server " & strServer & " doesn't have TSM or is offline!"
WScript.Quit
END If

' Backup current TSM config
objFSO.CopyFile Srvpad & "\dsm.opt" , Srvpad &"\dsm.opt.old"

' Wait for copy to complete
WScript.Sleep 10000

' Set TSM Service name
' -----------------------------------------------------
Set objService = GetObject("WinMgmts:{impersonationLevel=impersonate}!//" _
& strComputer & "/root/cimv2:Win32_Service.Name='TSM Scheduler'")

' Stop TSM Scheduler
' -----------------------------------------------------
objService.StopService

' Set the file for Reading / Writing
' -----------------------------------------------------
Set objTextFile2 = objFSO.OpenTextFile2(Srvpad & "\dsm.opt", ForReading)

       strText = objTextFile2.ReadAll
       Wscript.Echo strText       
       objTextFile2.Close
       strNewText = Replace(strText, "HYDRA1", "James")

Set objTextFile2 = objFSO.OpenTextFile(Srvpad & "\dsm.opt", ForWriting)
objTextFile2.WriteLine strNewText
objTextFile2.Close
' -----------------------------------------------------
' Wait 10 seconds for things to settle down
WScript.Sleep 10000

' Start TSM Scheduler
objService.StartService
Wscript.Echo "The TSM Scheduler service on " & strComputer & " has restarted succesfully."

' Go get next computer name and start over...
Loop

objTextFile.Close

' -----------------------------------------------------
' Functions
' -----------------------------------------------------

'Read text file
Function GetFile(FileName)
If FileName<>"" Then
Dim FS, FileStream
Set FS = CreateObject("Scripting.FileSystemObject")
on Error resume Next
Set FileStream = FS.OpenTextFile(FileName)
GetFile = FileStream.ReadAll
End If
End Function

'Write text file.
Function WriteFile(FileName, Contents)
Dim OutStream, FS

on Error Resume Next
Set FS = CreateObject("Scripting.FileSystemObject")
Set OutStream = FS.OpenTextFile(FileName, 2, True)
OutStream.Write Contents
End Function

 

by: bobs6140Posted on 2007-06-26 at 07:00:08ID: 19363709

OK I have wrapped some reponses around everything and the set objtextfile2 line seems to be the problem, any ideas, thank again for your help.

Bob Smith

Wscript.Echo Srvpad  <<<< this works got a response
Set objTextFile2 = objFSO.OpenTextFile(Srvpad & "\dsm.opt", ForReading)  <<<< this line seems to be the problem
Wscript.Echo objTextFile2  <<<< got no response

 

by: DarkoLordPosted on 2007-06-26 at 07:07:25ID: 19363777

Check if this returns true:

Wscript.Echo objFSO.FileExists(Srvpad & "\dsm.opt")

 

by: bobs6140Posted on 2007-06-26 at 07:52:55ID: 19364244

'====================
I found a similar script and modified and this works, thank you for your help.

Bob Smith'


' Type:      VBScript
'
' NAME:      TSMFix.vbs
'
' AUTHOR:    Bob Smith
'
' PURPOSE:   This script will parse a list of servers, and modify the TSM
'            config. It requires servers.txt in the same folder as this script.
'            Servers.txt should contain one machine name per line.
'
' COMMENTS:    
'
' *****************************************************
' ~~~Begin Script~~~
Option Explicit        ' Declare Everything!
Dim objFSO, objTextFile, objWMIService, objItem, objService, objChksrv, i
Dim strComputer, Srvpad, colItems, colListOfServices, oDrives, WshNetwork
Dim drive, objShell

On Error Resume Next

Const ForReading = 1

Set objFSO = CreateObject("Scripting.FileSystemObject")
Set objTextFile = objFSO.OpenTextFile("servers.txt", ForReading)
Set WshNetwork = WScript.CreateObject("WScript.Network")
Set oDrives = WshNetwork.EnumNetworkDrives
Set objShell = WScript.CreateObject("WScript.Shell")

Do Until objTextFile.AtEndOfStream
strComputer = objTextFile.Readline

'check if the server is online and has TSM folder
Srvpad = "\\"&strComputer&"\c$\program files\TIVOLI\TSM\baclient"
SET objChksrv = CreateObject("Scripting.FileSystemObject")
IF objChksrv.FolderExists(Srvpad) = FALSE THEN
WScript.Echo "Server " & strServer & " doesn't have TSM or is offline!"
WScript.Quit
END If

' Backup current TSM.opt
objFSO.CopyFile Srvpad & "\tsm.opt" , Srvpad &"\tsm.opt.old"

' Wait for copy to complete
WScript.Sleep 10000

' Set TSM Scheduler Service name
Set objService = GetObject("WinMgmts:{impersonationLevel=impersonate}!//" _
& strComputer & "/root/cimv2:Win32_Service.Name='TSM Scheduler'")

' Stop TSM Scheduler
objService.StopService

' *****************************************************
' Find and replace string

Dim FileName, Find, ReplaceWith, FileContents, dFileContents

Find = "serverold"
ReplaceWith = "servernew"
FileName = Srvpad &"\dsm.opt"

'Read source text file
FileContents = GetFile(FileName)
Wscript.Echo FileName

'replace all string In the source file
dFileContents = replace(FileContents, Find, ReplaceWith, 1, 1, 1)

'Compare source And result
if dFileContents <> FileContents Then
'write result If different
WriteFile FileName, dFileContents

Wscript.Echo "Replace done."
If Len(ReplaceWith) <> Len(Find) Then 'Can we count n of replacements?
Wscript.Echo _
( (Len(dFileContents) - Len(FileContents)) /(Len(ReplaceWith)-Len(Find)) ) & _
" replacements."
End If
Else
Wscript.Echo "Searched string Not In the source file"
End If

' ****************************************************
' Wait 10 seconds for things to settle down
WScript.Sleep 10000

' Start TSM service
objService.StartService
Wscript.Echo "The TSM Scheduler service on " & strComputer & " has restarted succesfully."

' Go get next computer name and start over...
Loop

objTextFile.Close

' *************************
' Functions
' *************************

'Read text file
Function GetFile(FileName)
If FileName<>"" Then
Dim FS, FileStream
Set FS = CreateObject("Scripting.FileSystemObject")
on Error resume Next
Set FileStream = FS.OpenTextFile(FileName)
GetFile = FileStream.ReadAll
End If
End Function

'Write text file.
Function WriteFile(FileName, Contents)
Dim OutStream, FS

on Error Resume Next
Set FS = CreateObject("Scripting.FileSystemObject")
Set OutStream = FS.OpenTextFile(FileName, 2, True)
OutStream.Write Contents
End Function

 

by: RobSampsonPosted on 2007-06-26 at 14:37:38ID: 19368057

In your original code, you were using ForWriting (Write) mode on the file in the first place, which would clear it's contents.  You can use ForAppending = 8 if you want to append to it.
Also, in your original code, you have the functions GetFile and WriteFile that you never use.
Do need more help with getting your original code to work?

Regards,

Rob.

 

by: bobs6140Posted on 2007-06-26 at 14:42:19ID: 19368099

Hi Rob

Yes I would like to debug the original so I know what I am doing wrong, still a newbie and would like to learn. I just had to hurry and deliver a solution.

Bob

 

by: RobSampsonPosted on 2007-06-26 at 20:45:48ID: 19369578

OK, I take it what you wanted to do (judging by your code that works) is just modify the existing file (not delte a re-create it), by replacing "serverold" with "servernew".
Also, by looking at your code again, I have realised that my statement before was invalid.  You were using Write mode after you read in the full contents, which is fine.

You are right though, the original code clears the text file for some reason.  I'll check it out.

Rob.

 

by: RobSampsonPosted on 2007-06-26 at 21:04:02ID: 19369639

OK, I think your main problem was that you didn't define strText and strNewText, which is why the ReadAll wasn't assigning it any text.  Put in a
Dim strText, strNewText
and it will all work.
Using Option Explicit and then having On Error Resume Next is bad practice, because you don't get the error that says "variable is undefined".  I rarely use On Error Resume Next, and never use it in testing unless I *know* something is likely to throw an error, in which case I turn on Error checking for that line only.  The way we do that, is something like this:
'================
Option Explicit
' some declarations
' normal code
On Error Resume Next
   ' a line of code that can produce an error like Access Denied
   objFSO.CreateTextFile("\\lockeddownserver\share\test.txt")
   If Err Then
      On Error GoTo 0 ' Turns error checking back on
      Err.Clear
      MsgBox "An error occurred"
      WScript.Quit ' if you want to
   Else
      On Error GoTo 0 ' Turns error checking back on
      ' do stuff with the file.
  End If
'=============

So in the above, error checking is ignored while creating a file, and then turned back on whether an error was raised or not, so you can deal with only that error.

Also, as I noted before, you do not need the GetFile or WriteFile functions if you use your original code.

I hope that helps.

Regards,

Rob.

 

by: bobs6140Posted on 2007-06-26 at 23:04:49ID: 19370043

Rob,

Thanks for explaining this, and for the tips.

Regards,
Bob Smith

 

by: RobSampsonPosted on 2007-06-26 at 23:16:08ID: 19370074

No problem.  I hope that helps.  Also, one other thing, if you haven't got a favourite VBS editor yet, have a go with VBSEdit 3.3 from www.vbsedit.com.

It's really good for helping you with syntax, and it has line numbering, and LOTS of samples.

Rob.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...