Error checking while reading a file : Microsoft, VBScript

May 17, 2008 12:12pm pdt

1. RobSampson 669,955
2. rorya 138,587
3. sungenwang 127,427
4. weellio 98,610
5. merowinger 93,100
6. zorvek 86,325
7. saurabh726 81,240
8. jeverist 57,096
9. Shift-3 45,870
10. sirbounty 44,935
11. chris_bo... 43,552
12. hielo 41,010
13. BlueDevi... 31,860
14. PaulHews 31,160
15. robberbaron 30,585

1. RobSampson 1,646,721
2. sirbounty 362,019
3. rorya 218,306
4. chandru_sol 182,049
5. zorvek 152,815
6. weellio 139,605
7. sungenwang 127,427
8. amit_g 108,710
9. merowinger 107,675
10. jeverist 107,296
11. Chris-Dent 105,637
12. BlueDevi... 95,210
13. matthews... 91,469
14. GrahamSkan 89,620
15. saurabh726 89,160

05.05.2008 at 10:36AM PDT, ID: 23377077

	[x] Attachment Details

[x]

The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

The Grade of the Solution
The Zone Rank of the Expert Providing the Solution
The Number of Author and Expert Comments
The Number of Experts Contributing
The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!

9.6

Error checking while reading a file

Zones: VB Script, Windows 2003 Server

Tags: Microsoft, VBScript

I have a script I got from here that reads a file, each line in the file corresponds to a computer name on my network. It then connects to each computer and inserts a domain group in the local admin group. The script works fine until it hits a computer not currently logged on.

I have tried a couple things, but to no avail. Been doing some reading this morning and it seems error control is lacking in VBScript.

Any help is appreciated, links to where to read up on it are fine as well.
Thanks!!

         
           
             1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:

           
           
             Dim objFSO
Dim objFile
Dim objNetwork
Dim objStream    
Dim strComputer
Dim strComputer2
Const intForReading = 1
 
Set objNetwork = CreateObject("WScript.Network")
strDomain = objNetwork.UserDomain
strGroupToAdd = strDomain & "/MS - IT Dept"
Set objFSO = CreateObject("Scripting.FileSystemObject")
Set objFile = objFSO.OpenTextFile("computers.txt", intForReading, False)
  
While Not objFile.AtEndOfStream
        'Read a Record
        strComputer = objFile.ReadLine
		Set objAdmins = GetObject("WinNT://" & strComputer & "/Administrators")
	
	    Set objGroup = GetObject("WinNT://" & strGroupToAdd)
        On Error Resume Next
        objAdmins.Add(objGroup.ADsPath)
        If Err.Number <> 0 Then
                Err.Clear
                On Error GoTo 0
                MsgBox "There was an error adding " & strGroupToAdd & " to " & objAdmins.ADsPath
        Else
                On Error GoTo 0
                MsgBox strGroupToAdd & " was added successfully to " & objAdmins.ADsPath
        End If
Wend
    
'Clean up file objects
objFile.Close
Set objFile = Nothing
Set objFSO = Nothing
MsgBox "Done"

           
         

Start your free trial to view this solution

Question Stats

Zone: Programming

Question Asked By: Salitorn

Solution Provided By: RobSampson

Participating Experts: 2

Solution Grade: A

Translate:

Loading Advertisement...

Microsoft

Internet Protocols
Applications

Development
OS

Hardware
Windows Security

Apple

Operating Systems
Hardware

Programming
Networking

Software

Internet

Search Engines
File Sharing
WebTrends / Stats
Spy / Ad Blockers

Web Browsers
New Net Users
Web Development
Chat / IM

Anti Spam
Web Servers
Anti-Virus
Email Clients

Gamers

Tips
Online / MMORPG
Puzzle
Emulators

Action / Adventure
Role Playing
Consoles
Game Programming

Strategy
Sports
Misc
Computer Games

Digital Living

Hardware
New Net Users
New Users

Software
Digital Music
Gaming World

Home Security
Apple
Networking Hardware

Virus & Spyware

Vulnerabilities
IDS
Encryption
Anti-Virus

Operating Systems Security
Software Firewalls
WebApplications
Cell Phones

Operating Systems
Internet
Hardware Firewalls

Hardware

Handhelds / PDAs
Displays / Monitors
Components
Networking Hardware

Peripherals
Laptops/Notebooks
Storage
Servers

Desktops
New Users
Misc
Apple

Software

System Utilities
Industry Specific
Network Management
Photos / Graphics
Page Layout
VMWare
Misc
Web Development

OS
CYGWIN
Voice Recognition
Message Queue
Quality Assurance
Security
Firewalls
MultiMedia Applications

Development
Database
Office / Productivity
Business Management
OS/2 Apps
Server Software
Internet / Email

ITPro

OS
Storage
Encryption
Operating Systems Security
Apple Hardware
Laptops & Notebooks
Servers
Networking Hardware
Peripherals

Devices
Displays / Monitors
WebTrends / Stats
Search Engines
Firewalls
WebApplications
IDS
Vulnerabilities
Email Clients

File Sharing
Spy / Ad Blockers
Web Browsers
Web Servers
Networking
Anti-Virus
Chat / IM
Anti Spam

Developer

Web Servers
Web Browsers
Game Programming
Dev Tools
Industry Specific
Office / Productivity

Database
CYGWIN
Web Development
Search Engines
File Sharing
WebTrends / Stats

Programming
Content Management
Application Servers
Protocols

Storage

Removable Backup Media
Storage Technology
Servers

Grid
Remote Access
Backup / Restore

Misc
Hard Drives

Miscellaneous
Security
Development
Linux
VMWare

MainFrame OS
Unix
Apple
OS / 2
AS / 400

BeOS
Microsoft
VMS / OpenVMS

Database

Oracle
Miscellaneous
MySQL
Software
Sybase
Contact Management
PostgreSQL
Data Manipulation
Clarion
InterSystems Cache

Siebel
MUMPS
OLAP
SQLBase
SAS
GIS & GPS
4GL
Berkeley DB
DB2
Informix

Interbase / Firebird
FoxPro
Reporting
LDAP
Filemaker Pro
MS SQL Server
dBase
MS Access

Security

Misc
Web Browsers
Software Firewalls
Operating Systems Security
File Sharing

Spy / Ad Blockers
Vulnerabilities
WebApplications
IDS
Anti-Virus

Encryption
Anti Spam
Email Clients
VPN
Chat / IM

Programming

Editors IDEs
Installation
Handhelds / PDAs
Multimedia Programming
System / Kernel

Algorithms
Game
Signal Processing
Project Management
Open Source

Database
Misc
Languages
Processor Platforms
Theory

Web Development

Scripting
Blogs
Web Servers
Software
Search Engines
Web Graphics
Images

Internet Marketing
Images and Photos
Components
Document Imaging
Web Languages/Standards
Illustration
WebApplications

Fonts
WebTrends / Stats
Authoring
Digital Camera Software
Miscellaneous

Networking

Protocols
Apple Networking
Network Management
Message Queue
Application Servers
Content Management
File Servers
Email Servers
Misc
Java Editors & IDEs

Wireless
Networking Hardware
Backup / Restore
System Utilities
ISPs & Hosting
Web Servers
Storage Technology
Removable Backup Media
Servers
Broadband

Grid
OS / 2
Novell Netware
Unix Networking
Windows Networking
Security
Telecommunications
Operating Systems
Linux Networking

Other

Community Advisor
Lounge
Community Support
New Net Users

Philosophy / Religion
Math / Science
Miscellaneous
URLs

Expert Lounge
Politics
Puzzles / Riddles

Community Support

Suggestions
New to EE
New Topics
Community Advisor

CleanUp
Announcements
General

Feedback
Input
EE Bugs

05.05.2008 at 10:40AM PDT, ID: 21501599

Salitorn:

Forgot to add, when it fails it is on line 18, Set objAdmins = GetObject("WinNT://" & strComputer & "/Administrators")

With this error DomainGroupToLocalAdmin.vbs(27,3) (null): The network path was not found.

I am thinking this is due to the computer stored in strComputer is not currently reachable.

05.05.2008 at 11:08AM PDT, ID: 21501800

Zinthose:

Try this =)

                       
                          
                             
                                1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:

                             
                             
                                Dim objFSO
Dim objFile
Dim objNetwork
Dim objStream    
Dim strComputer
Dim strComputer2
Const intForReading = 1
 
Set objNetwork = CreateObject("WScript.Network")
strDomain = objNetwork.UserDomain
strGroupToAdd = strDomain & "/MS - IT Dept"
Set objFSO = CreateObject("Scripting.FileSystemObject")
Set objFile = objFSO.OpenTextFile("computers.txt", intForReading, False)
 
On Error Resume Next  
	While Not objFile.AtEndOfStream
		'Read a Record
		strComputer = objFile.ReadLine
		
		Set objAdmins = GetObject("WinNT://" & strComputer & "/Administrators")
		
		If Not Err Then		        
			Set objGroup = GetObject("WinNT://" & strGroupToAdd)
 
			objAdmins.Add(objGroup.ADsPath)
			If Err Then
				Err.Clear
				MsgBox "There was an error adding " & strGroupToAdd & " to " & objAdmins.ADsPath
			Else
				MsgBox strGroupToAdd & " was added successfully to " & objAdmins.ADsPath
			End If
		Else
			'** Computer not found
		End If
	Wend
On Error Goto 0  
'Clean up file objects
objFile.Close
Set objFile = Nothing
Set objFSO = Nothing
MsgBox "Done"

                             
                          

                    

Open in New Window

Assisted Solution

05.05.2008 at 02:35PM PDT, ID: 21503225

Rank: Genius

RobSampson:

Try this. I've added a Ping function, so it can determine whether the computer is available before connecting to it.

Regards,

Rob.

                       
                          
                             
                                1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:

                             
                             
                                Dim objFSO
Dim objFile
Dim objNetwork
Dim objStream    
Dim strComputer
Dim strComputer2
Const intForReading = 1
 
Set objNetwork = CreateObject("WScript.Network")
strDomain = objNetwork.UserDomain
strGroupToAdd = strDomain & "/MS - IT Dept"
Set objFSO = CreateObject("Scripting.FileSystemObject")
Set objFile = objFSO.OpenTextFile("computers.txt", intForReading, False)
  
While Not objFile.AtEndOfStream
        'Read a Record
        strComputer = objFile.ReadLine
		If Ping(strComputer) = True Then
	        On Error Resume Next
			Set objAdmins = GetObject("WinNT://" & strComputer & "/Administrators")
			If Err.Number <> 0 Then
				Err.Clear
				On Error GoTo 0
				MsgBox "There was an error connecting to the Administrators group on " & strComputer
			Else
			    On Error Resume Next
			    Set objGroup = GetObject("WinNT://" & strGroupToAdd)
		        objAdmins.Add(objGroup.ADsPath)
		        If Err.Number <> 0 Then
		                Err.Clear
		                On Error GoTo 0
		                MsgBox "There was an error adding " & strGroupToAdd & " to " & objAdmins.ADsPath
		        Else
		                On Error GoTo 0
		                MsgBox strGroupToAdd & " was added successfully to " & objAdmins.ADsPath
		        End If
		    End If
	    Else
	    	MsgBox "Could not ping " & strComputer
	    End If
Wend
    
'Clean up file objects
objFile.Close
Set objFile = Nothing
Set objFSO = Nothing
MsgBox "Done"
 
 
Function Ping(strComputer)
      Dim objShell, boolCode
      Set objShell = CreateObject("WScript.Shell")
      boolCode = objShell.Run("Ping -n 1 -w 300 " & strComputer, 0, True)
      If boolCode = 0 Then
            Ping = True
      Else
            Ping = False
      End If
End Function

                             
                          

                    

Open in New Window

Accepted Solution

RobSampson

05.06.2008 at 03:51PM PDT, ID: 21511680

No problem. Thanks for the grade.

You can do Subs and Functions in VBScript, to perform those repetitive tasks, so it can make your code a lot neater....

It especially helps in cases such as iterating though a file system, to recurse subfolders. Because the amount of subfolders is unknown, you just use a recursive Sub procedure to go through the folders.

Anyway, have fun with it.

Regards,

Rob.

20080236-EE-VQP-29 / EE_QW_2_20070628