Question

Type mismatch: error

Asked by: TheInnovator

I have a .vbs file that was converted from a .asp file.
It's changed to a .vbs file so it can be run from the command line.

when I run it, I get the error:
Type mismatch: 'GenerateMagazineRequestThread'

the function is actually in "RequestThread.asp", which I tried to include as a include file in the .vbs file
I'm not sure if the method I used to include it was done the right way or not.

Dim FSO, ScriptFile
  Set FSO = CreateObject("Scripting.FileSystemObject")
  Set ScriptFile = FSO.OpenTextFile("RequestThread.asp",1)
  GetFileContents = ScriptFile.ReadAll
  Set ScriptFile = Nothing
  Set FSO = Nothing
 
 
 
sMailBody = ""
         sSql = "SELECT * FROM MAGAZINE_SUBSCRIPTION WHERE USER_ID = " & nUsrId 
         Set rs1=CreateObject("ADODB.Recordset") 
         rs1.Open sSql, dbConn
         If Not rs1.Eof Then
            Do While Not rs1.Eof  ' Loop for each subscribed MAGAZINE id
               nMAGAZINEId = rs1("MAGAZINE_Id")
 
               sMailBody = sMailBody & "<ol>"
               sMailBody = sMailBody & "<li>" & GenerateMAGAZINERequestThread(objConn, nMAGAZINEId, dStartTime) & "</li>"  <<<<---- error line
               sMailBody = sMailBody & "</ol>"
response.write "smailbody: " & sMailBody
               rs1.MoveNext
            Loop  ' MAGAZINE Id Loop
         End If

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:

Select all Open in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

Plus...

30 Day FREE access, no risk, no obligation
Collaborate with the world's top tech experts
Unlimited access to our exclusive solution database
Never be left without tech help again

Subscribe Now

Asked On: 2008-07-08 at 19:43:58ID23548958
Tags: vbscript
Topics: VB Script
,; Active Server Pages (ASP)
Participating Experts: 3
Points: 0
Comments: 22

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

"The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
"Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
"Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Free Tech Articles

WARNING: 5 Reasons why you should NEVER fix a computer for free.
It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
SCCM OSD Basic troubleshooting
SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
Create a Win7 Gadget
This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
Outlook continually prompting for username and password
There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
Backup Exchange 2010 Information Store using Windows Backup
There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

Avoiding Bugs in Microsoft Access
Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
Top 10 Best New Features in Visio 2010
Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
IT Consultant Business Secrets Revealed
Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
Disaster Recovery and Business Continuity
Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
Organize Your Visio Diagrams with Containers and Lists
Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
How to Us Objects, Properties, Events and Methods in Microsoft Access
Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Watch More

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

by: RobSampsonPosted on 2008-07-08 at 20:10:14ID: 21960307

Hi, you need a function in your VBS called
GenerateMAGAZINERequestThread

Perhaps in the ASP page, there's a Sub or Function called that......

Rob.

by: dosthPosted on 2008-07-09 at 00:30:33ID: 21961278

please post full code to see how you called the include

by: TheInnovatorPosted on 2008-07-09 at 05:58:43ID: 21963028

There is a function called "GenerateMAGAZINERequestThread" in the ASP file that I tried to include in my .vbs.

by: TheInnovatorPosted on 2008-07-09 at 07:57:54ID: 21964329

Below is the full code of the .asp and .vbs:

'-------------------
RequestThread.asp
'-------------------
Function GenerateMagazineRequestThread (dbConn, nMagazineId, dStartTime, callType)
  Dim sSQL
  Dim rs
  Dim sOut
  Dim bFirst
  Dim sRackTitle
 
  sOut = ""
 
  sSQL = "SELECT PT.ID from Magazine_TASK PT " _
       & "JOIN Magazine_TASK_REQUEST PTR ON  PTR.TASK_ID = PT.ID WHERE"
  if (NOT IsNull(dStartTime)) then
    sSQL = sSQL & " PTR.UPDATE_TIMESTAMP > '" & dStartTime & "' AND"
  end if
  
  sSQL = sSQL & " Magazine_ID = " & nMagazineId
 
	If callType = "WEB" Then
  	Set rs=Server.CreateObject("ADODB.Recordset") 
  Else
  	Set rs=CreateObject("ADODB.Recordset") '.vbs
  End If
  
  rs.Open sSql, dbConn
  bFirst = true
  do while Not rs.Eof
    if (bFirst) then
      bFirst = false
      sRackTitle = "To Do - Get the Correct Rack Title"
      sOut = sOut & "<h1 style=""font-size: large"">" & sRackTitle & "</h1>"
      sOut = sOut & "<ul>"
    end if
    sOut = sOut & GenerateMagThread (dbConn, rs("id").Value, dStartTime, NULL)
    rs.MoveNext
  loop
  rs.Close
  Set rs = Nothing
 
  if (sOut <> "") then
    sOut = sOut & "</ul>"
  end if
 
  GenerateMagazineRequestThread = sOut
End Function
 
 
 
Function GenerateMagThread (dbConn, nTaskId, dStartTime, sField)
  Dim sSQL
  Dim rs, commentRs
  Dim sOut
  Dim bShowAll
  Dim nReqId
  Dim sTaskTitle
  Dim sUser
  Dim dTime
  Dim sComment
  Dim sOldScheduleDate
  Dim sStatus
  Dim dReqDate
  Dim dSTANDDate
  Dim STANDTs
 
  sSql = "SELECT PTR.ID as TASK_REQUEST_ID, NAME, REQUEST_USERNAME, REQUEST_TIMESTAMP, PTR.COMMENT, NEW_DATE, SIGNING_SCHEDULE, BOOK_SCHEDULE, STAND_DATE, STAND_TIMESTAMP, REQUEST_TYPE, STATUS  FROM Magazine_TASK PT " _
       & "JOIN Magazine_TASK_REQUEST PTR ON PT.ID = PTR.TASK_ID " _
       & "WHERE PT.ID = " & nTaskId 
 
  if (NOT IsNull(dStartTime)) then
    sSQL = sSQL & " AND UPDATE_TIMESTAMP >= '" & dStartTime & "'"
  else
    sSQL = sSQL & " AND STATUS = 0"
  end if
 
  if (NOT IsNull (sField)) then
    sSQL = sSQL & " AND REQUEST_TYPE = '" & sField & "'"
  end if
 
	If callType = "WEB" Then
  	Set rs=Server.CreateObject("ADODB.Recordset") 
  Else
  	Set rs=CreateObject("ADODB.Recordset") '.vbs
  End If
  
  rs.Open sSql, dbConn
  if Not rs.Eof then
    nReqId = rs("TASK_REQUEST_ID").Value
    sTaskTitle = rs("NAME").Value
    sUser = rs("REQUEST_USERNAME").Value
    dTime = rs("REQUEST_TIMESTAMP").Value
    
    if (IsDate(rs("STAND_DATE"))) then
      dSTANDDate = rs("STAND_DATE")
      dSTANDTs   = rs("STAND_TIMESTAMP")
    else
      dSTANDDate = NULL
      dSTANDTs = NULL
    end if
 
    sComment = rs("COMMENT").Value
    dReqDate = rs("NEW_DATE").Value
    Select Case ucase(rs("Request_Type"))
      Case "SIGNING_SCHEDULE"
        sOldScheduleDate = rs("SIGNING_SCHEDULE")
	sField = "proposed"
      Case "BOOK_SCHEDULE"
        sOldScheduleDate = rs("BOOK_SCHEDULE")
	sField = "current"
      End Select
 
    if (NOT IsNull(dStartTime)) then
      if (rs("STATUS").Value = 0) then
        sStatus = "open"
      else
        sStatus = "closed"
      end if
    else
      sStatus = ""
    end if
 
    sOut = "<li>" _
         & sTaskTitle
    if (NOT IsNull(dStartTime)) then
      sOut = sOut & "&nbsp;(<a href=""ScheduleRequest.asp?taskId=" & nTaskId & "&field=" & rs("Request_Type") & """>view</a>)"
    end if
 
 
    if (NOT IsNull(dSTANDDate)) then
      sOut = sOut & "<br>Current STAND date is " & dSTANDDate & ", set at " & dSTANDTs
    end if
    sOut = sOut & "<br>" _
	 & "<span style=""font-weight: bold"">" & sUser & " " & dTime & "</span> " _
	 & "Request change to " & sField & " schedule from " & sOldScheduleDate & " to " & dReqDate _
	 & "<br>" _
	 & "<span style=""font-weight: normal"">" & sComment & "</span>" _
	 & "<ul>"
 
 
    sSql = "SELECT * FROM Magazine_TASK_REQUEST_COMMENT WHERE TASK_REQUEST_ID = " & nReqId
    
    if (NOT IsNull(dStartTime)) then
      sSQL = sSQL & " AND COMMENT_TIMESTAMP >= '" & dStartTime  & "'"
    end if
 
		'Alternate color
		colorset = split("White,#eeeeee",",")
		numcolors = ubound(colorset)+1
 
	If callType = "WEB" Then
  	Set rs=Server.CreateObject("ADODB.Recordset") 
  Else
  	Set rs=CreateObject("ADODB.Recordset") '.vbs
  End If
   
    commentRs.Open sSql, dbConn
    Do While Not commentRs.Eof  ' Loop for Task Request
      sUser = commentRs("COMMENT_USERNAME").Value
      dTime = commentRs("COMMENT_TIMESTAMP").Value
      sComment = commentRs("COMMENT").Value
      sOut = sOut & "<li style=""background:" & colorset(i mod numcolors) & ";"">"  _
           & "<span style=""font-weight:bold"">" & sUser & "(" & dTime & "):" & "</span>" _
	   & "<span style=""font-weight:normal"">&nbsp;" & sComment & "</span>" _
	   & "</li>"
      commentRs.MoveNext
    i = i + 1 'increment for Alternate Color
    loop
    sOut = sOut & "</ul></li>"
    commentRs.Close
    Set commentRs = Nothing
    rs.MoveNext
  end if
  rs.Close
  Set rs = Nothing
 
  GenerateMagThread = sOut
End Function
 
%>
 
 
 
'-----------------
Here's my .vbs file that I'm trying to run from the command line
'-------------------
 
 
 Dim sSql
   Dim rs,rs1
   Dim nUsrId
   Dim nMAGAZINEId
   Dim dStartTime
   Dim dEndTime
   Dim sMailBody
   Dim sMAGAZINEUser
   Dim connect 
   
   connect = "Provider='XXXX';Initial Catalog='ZZZZ';Data Source='XZXZXZXZ';user id='YYYYY';password='PPPPPP'"
   Set DbConn = CreateObject("ADODB.Connection")
   DbConn.Open connect
   
   sProfileName = "SOMETHING"
   sMailFormat = "HTML"
   sMAGAZINEUser="SOMEONE@somewhere.com"   
   ' This stored procedure will update the MAGAZINE_user table with start time
 
  
  Dim FSO, ScriptFile
  Set FSO = CreateObject("Scripting.FileSystemObject")
  Set ScriptFile = FSO.OpenTextFile("RequestThread.asp",1)
  GetFileContents = ScriptFile.ReadAll
  Set ScriptFile = Nothing
  Set FSO = Nothing
 
 
  
   sSql = "SELECT * FROM MAGAZINE_USER" 
   Set rs=CreateObject("ADODB.Recordset") 
   rs.Open sSql, dbConn
   If Not rs.Eof Then
      Do While Not rs.Eof  ' This loop is for each User
         nUsrId = rs("ID")
         'sMAGAZINEUser = rs("EMAIL_ADDRESS")
         dStartTime = rs("LAST_SENT_TIME")
         dEndTime = rs("SEND_WIP_TIME")
         If IsNull(dStartTime) Then
            dStartTime = CDate("6/4/2001 16:33:00")
         Else
            dStartTime = CDate(rs("LAST_SENT_TIME"))
         End If
         sMailBody = ""
         sSql = "SELECT * FROM MAGAZINE_SUBSCRIPTION WHERE USER_ID = " & nUsrId 
         Set rs1=CreateObject("ADODB.Recordset") 
         rs1.Open sSql, dbConn
         If Not rs1.Eof Then
            Do While Not rs1.Eof  ' Loop for each subscribed MAGAZINE id
               nMAGAZINEId = rs1("MAGAZINE_Id")
 
               sMailBody = sMailBody & "<ol>"
               sMailBody = sMailBody & "<li>" & GenerateMAGAZINERequestThread(DbConn, nMAGAZINEId, dStartTime, "VBS") & "</li>"   '<==== stops here
               sMailBody = sMailBody & "</ol>"
'WScript.Echo "smailBody: " & sMailBody
 
               rs1.MoveNext
            Loop  ' MAGAZINE Id Loop
         End If
         '--------
         ' Sending Mail Procedure should be called..
         '--------
 
 
         sSql = "exec mission.Rims_deliver_mail '" & sProfileName & "','" & sMAGAZINEUser & "','" & sMailSubject & "','" & Replace (sMailBody, "'", "''") & "','" & sMailFormat & "'"
 
         dbConn.Execute sSql
         rs1.Close
         Set rs1=Nothing
         rs.MoveNext
      Loop ' User Loop
   End If
   rs.Close
   Set rs=Nothing
   'Once the mail is sent to all the users the last sent date is updated with start time
   'dbConn.Execute "EXEC RIMS_MAGAZINE_USER_UPDATE 'SENT'"

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:
118:
119:
120:
121:
122:
123:
124:
125:
126:
127:
128:
129:
130:
131:
132:
133:
134:
135:
136:
137:
138:
139:
140:
141:
142:
143:
144:
145:
146:
147:
148:
149:
150:
151:
152:
153:
154:
155:
156:
157:
158:
159:
160:
161:
162:
163:
164:
165:
166:
167:
168:
169:
170:
171:
172:
173:
174:
175:
176:
177:
178:
179:
180:
181:
182:
183:
184:
185:
186:
187:
188:
189:
190:
191:
192:
193:
194:
195:
196:
197:
198:
199:
200:
201:
202:
203:
204:
205:
206:
207:
208:
209:
210:
211:
212:
213:
214:
215:
216:
217:
218:
219:
220:
221:
222:
223:
224:
225:
226:
227:
228:
229:
230:
231:
232:
233:
234:
235:
236:
237:
238:
239:
240:
241:
242:
243:
244:
245:
246:
247:
248:
249:
250:
251:
252:
253:
254:
255:
256:
257:
258:
259:
260:
261:
262:
263:
264:

Select all Open in new window

by: dosthPosted on 2008-07-09 at 08:11:57ID: 21964521

GenerateMAGAZINERequestThread(objConn, nMAGAZINEId, dStartTime)

you are passing 3 params

but the function has 4 params

by: TheInnovatorPosted on 2008-07-09 at 08:48:20ID: 21965025

I am passing in 3.
This is what I have in the latest code I posted:
GenerateMAGAZINERequestThread(DbConn, nMAGAZINEId, dStartTime, "VBS") & "</li>"

by: TheInnovatorPosted on 2008-07-09 at 09:10:28ID: 21965301

I mean I am passing in 4

by: dosthPosted on 2008-07-09 at 09:32:43ID: 21965562

can you just call

Please hard code all the values need to pass to this function

not other codes, just the include, active connection and hard coded values

Response.Write(GenerateMAGAZINERequestThread(DbConn, nMAGAZINEId, dStartTime, "VBS"))

by: TheInnovatorPosted on 2008-07-09 at 10:46:16ID: 21966311

This is what I did in my .vbs file:
I put it at the very top so it will execute first.

GenerateMAGAZINERequestThread("Provider='XXXX';Initial Catalog='ZZZZ';Data Source='XZXZXZXZ';user id='YYYYY';password='PPPPPP'", 1, "2008-07-09 09:53:00", "VBS"))

This is the error I get now:
yFile.vbs(2, 192) Microsoft VBScript compilation error: Cannot use parentheses when calling a Sub

by: TheInnovatorPosted on 2008-07-09 at 10:53:18ID: 21966372

This is what i actually used:
GenerateMAGAZINERequestThread("Provider='XXXX';Initial Catalog='ZZZZ';Data Source='XZXZXZXZ';user id='YYYYY';password='PPPPPP'", 1, "2008-07-09 09:53:00", "VBS")

without the extra closing parenthesis.

by: EDDYKTPosted on 2008-07-09 at 10:57:13ID: 21966422

either use

GenerateMAGAZINERequestThread "Provider='XXXX';Initial Catalog='ZZZZ';Data Source='XZXZXZXZ';user id='YYYYY';password='PPPPPP'", 1, "2008-07-09 09:53:00", "VBS"

or

call GenerateMAGAZINERequestThread("Provider='XXXX';Initial Catalog='ZZZZ';Data Source='XZXZXZXZ';user id='YYYYY';password='PPPPPP'", 1, "2008-07-09 09:53:00", "VBS")

by: TheInnovatorPosted on 2008-07-09 at 11:17:54ID: 21966617

Neither one of those worked.

I think the problem is that, my function ( GenerateMAGAZINERequestThread() ) is not being recognized.

Did I include the file correctly that has it?

This is the method I use to include:

Dim FSO, ScriptFile
Set FSO = CreateObject("Scripting.FileSystemObject")
Set ScriptFile = FSO.OpenTextFile("RequestThread.asp",1)
GetFileContents = ScriptFile.ReadAll
Set ScriptFile = Nothing
Set FSO = Nothing

When I add this line to the above 'ExecuteGlobal GetFileContents' ,
I get this error:
Expected Statement 800A0400 compilation error

In either case, it does not work whether or not I add 'ExecuteGlobal GetFileContents'

by: EDDYKTPosted on 2008-07-09 at 11:29:53ID: 21966753

wait a minute,

you try to call asp file from vbs file?
i don't think you can do that

by: TheInnovatorPosted on 2008-07-09 at 11:33:54ID: 21966805

Oh... really. I thought I could call an .asp file from within a vbs file.
Is that positive that I can't?
Is there documentation somewhere that says that?
Just proof to those who want it done.

by: EDDYKTPosted on 2008-07-09 at 11:35:50ID: 21966828

asp file is hold inside IIS you can not call from vbs directly.
You have to call from web

by: TheInnovatorPosted on 2008-07-09 at 11:57:00ID: 21967043

OK. What I will do is convert the .asp to .vbs?
What is the proper way to include a .vbs in another .vbs?
That way I'm not hit with any surprises. Or is the way I did it above the correct way?

by: TheInnovatorPosted on 2008-07-09 at 12:38:41ID: 21967463

This is starting to get frustrating now. I made some changes but I get the same error.

This is what I have for an include now:

Dim FSO, ScriptFile
Set FSO = CreateObject("Scripting.FileSystemObject")
Set ScriptFile = FSO.OpenTextFile("RequestThread.vbs",1)
GetFileContents = ScriptFile.ReadAll
Set ScriptFile = Nothing
Set FSO = Nothing

I'm including a .vbs file in a .vbs file now and I still get the same error.
Type mismatch: 'GeneratePhasingRequestThread'

I don't think my method of including a file is working.
Does anyone know another method?
Thanks.

by: EDDYKTPosted on 2008-07-10 at 03:25:08ID: 21971886

have you tried to add the whole function to one vbs?

by: RobSampsonPosted on 2008-07-10 at 17:02:38ID: 21978492

Try this.

Regards,

Rob.

Dim FSO, ScriptFile
Set FSO = CreateObject("Scripting.FileSystemObject")
Set ScriptFile = FSO.OpenTextFile("RequestThread.asp",1)
GetFileContents = ScriptFile.ReadAll
Set ScriptFile = Nothing
Set FSO = Nothing
 
sMailBody = ""
sSql = "SELECT * FROM MAGAZINE_SUBSCRIPTION WHERE USER_ID = " & nUsrId 
Set rs1=CreateObject("ADODB.Recordset") 
rs1.Open sSql, dbConn
If Not rs1.Eof Then
	Do While Not rs1.Eof  ' Loop for each subscribed MAGAZINE id
		nMAGAZINEId = rs1("MAGAZINE_Id")
		sMailBody = sMailBody & "<ol>"
		sMailBody = sMailBody & "<li>" & GenerateMAGAZINERequestThread(objConn, nMAGAZINEId, dStartTime, "VBS") & "</li>"
		sMailBody = sMailBody & "</ol>"
		response.write "smailbody: " & sMailBody
		rs1.MoveNext
	Loop  ' MAGAZINE Id Loop
End If
 
Function GenerateMagThread (dbConn, nTaskId, dStartTime, sField)
	Dim sSQL
	Dim rs, commentRs
	Dim sOut
	Dim bShowAll
	Dim nReqId
	Dim sTaskTitle
	Dim sUser
	Dim dTime
	Dim sComment
	Dim sOldScheduleDate
	Dim sStatus
	Dim dReqDate
	Dim dSTANDDate
	Dim STANDTs
 
	sSql = "SELECT PTR.ID as TASK_REQUEST_ID, NAME, REQUEST_USERNAME, REQUEST_TIMESTAMP, PTR.COMMENT, NEW_DATE, SIGNING_SCHEDULE, BOOK_SCHEDULE, STAND_DATE, STAND_TIMESTAMP, REQUEST_TYPE, STATUS  FROM Magazine_TASK PT " _
		& "JOIN Magazine_TASK_REQUEST PTR ON PT.ID = PTR.TASK_ID " _
		& "WHERE PT.ID = " & nTaskId 
 
	If (Not IsNull(dStartTime)) Then
		sSQL = sSQL & " AND UPDATE_TIMESTAMP >= '" & dStartTime & "'"
	Else
		sSQL = sSQL & " AND STATUS = 0"
	End If
 
	If (Not IsNull (sField)) Then
		sSQL = sSQL & " AND REQUEST_TYPE = '" & sField & "'"
	End If
 
	If callType = "WEB" Then
		Set rs=Server.CreateObject("ADODB.Recordset") 
	Else
		Set rs=CreateObject("ADODB.Recordset") '.vbs
	End If
  
	rs.Open sSql, DbConn
	If Not rs.Eof Then
		nReqId = rs("TASK_REQUEST_ID").Value
		sTaskTitle = rs("NAME").Value
		sUser = rs("REQUEST_USERNAME").Value
		dTime = rs("REQUEST_TIMESTAMP").Value
		
		If (IsDate(rs("STAND_DATE"))) Then
			dSTANDDate = rs("STAND_DATE")
			dSTANDTs   = rs("STAND_TIMESTAMP")
		Else
			dSTANDDate = Null
			dSTANDTs = Null
		End If
 
		sComment = rs("COMMENT").Value
		dReqDate = rs("NEW_DATE").Value
		Select Case ucase(rs("Request_Type"))
			Case "SIGNING_SCHEDULE"
				sOldScheduleDate = rs("SIGNING_SCHEDULE")
				sField = "proposed"
			Case "BOOK_SCHEDULE"
				sOldScheduleDate = rs("BOOK_SCHEDULE")
				sField = "current"
		End Select
		
		If (Not IsNull(dStartTime)) Then
			If (rs("STATUS").Value = 0) Then
				sStatus = "open"
			Else
				sStatus = "closed"
			End If
		Else
			sStatus = ""
    	End If
 
		sOut = "<li>" _
			& sTaskTitle
		If (Not IsNull(dStartTime)) Then
			sOut = sOut & "&nbsp;(<a href=""ScheduleRequest.asp?taskId=" & nTaskId & "&field=" & rs("Request_Type") & """>view</a>)"
		End If
 
		If (Not IsNull(dSTANDDate)) Then
			sOut = sOut & "<br>Current STAND date is " & dSTANDDate & ", set at " & dSTANDTs
		End If
		sOut = sOut & "<br>" _
			& "<span style=""font-weight: bold"">" & sUser & " " & dTime & "</span> " _
			& "Request change to " & sField & " schedule from " & sOldScheduleDate & " to " & dReqDate _
			& "<br>" _
			& "<span style=""font-weight: normal"">" & sComment & "</span>" _
			& "<ul>"
 
		sSql = "SELECT * FROM Magazine_TASK_REQUEST_COMMENT WHERE TASK_REQUEST_ID = " & nReqId
 
		If (Not IsNull(dStartTime)) Then
			sSQL = sSQL & " AND COMMENT_TIMESTAMP >= '" & dStartTime  & "'"
		End If
 
		'Alternate color
		colorset = split("White,#eeeeee",",")
		numcolors = ubound(colorset)+1
 
		If callType = "WEB" Then
			Set rs=Server.CreateObject("ADODB.Recordset") 
		Else
			Set rs=CreateObject("ADODB.Recordset") '.vbs
		End If
 
		commentRs.Open sSql, dbConn
		Do While Not commentRs.Eof  ' Loop for Task Request
			sUser = commentRs("COMMENT_USERNAME").Value
			dTime = commentRs("COMMENT_TIMESTAMP").Value
			sComment = commentRs("COMMENT").Value
			sOut = sOut & "<li style=""background:" & colorset(i mod numcolors) & ";"">"  _
				& "<span style=""font-weight:bold"">" & sUser & "(" & dTime & "):" & "</span>" _
				& "<span style=""font-weight:normal"">&nbsp;" & sComment & "</span>" _
				& "</li>"
			commentRs.MoveNext
			i = i + 1 'increment for Alternate Color
		Loop
		sOut = sOut & "</ul></li>"
		commentRs.Close
		Set commentRs = Nothing
		rs.MoveNext
	End If
	rs.Close
	Set rs = Nothing
 
	GenerateMagThread = sOut
End Function

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:
118:
119:
120:
121:
122:
123:
124:
125:
126:
127:
128:
129:
130:
131:
132:
133:
134:
135:
136:
137:
138:
139:
140:
141:
142:
143:
144:
145:
146:
147:
148:

Select all Open in new window

by: TheInnovatorPosted on 2008-07-15 at 08:14:16ID: 22007807

I found the solution.
It's a "type mismatch" b/c it's not recognizing my function and that's b/c I'm not including the file correctly.

Here is the proper way to add a .vbs into another .vbs file.

Dim FSO, ScriptFile
Set FSO = CreateObject("Scripting.FileSystemObject")
Set ScriptFile = FSO.OpenTextFile("RequestThread.vbs",1)
ExecuteGlobal ScriptFile.ReadAll
Set ScriptFile = Nothing
Set FSO = Nothing

once I made the change to the above, it worked.

Thanks guys.

by: RobSampsonPosted on 2008-07-15 at 16:35:36ID: 22012079

Well done. Please post a request to accept your latest comment as the answer.

Regards,

Rob.

by: RobSampsonPosted on 2008-07-15 at 16:36:17ID: 22012083

Well done. Please post a request to accept your latest comment as the answer.

Regards,

Rob.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

For individual users
Instant access to solutions
Ask your tech questions
Start your 30-day Free Trial

Business Accounts

Perfect for organizations
Multiple users
Save over 36%
Create a Business Account

Answer for Membership

Earn free access
Showcase your knowledge
No credit card required
Sign Up to Answer

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...

Question

Type mismatch: error

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

vbscript

VB Script

Active Server Pages (ASP)

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Need individual assistance?

Our experts are ready to help.

Want to learn from the best?

Read articles from industry experts.

Working on a long term project?

Store your work and research.

What Makes Experts Exchange Unique?

Trusted by the world's most respected brands.

Faithfully serving IT professionals since 1996.

Related Solutions

Free Tech Articles

Cloud Class Webinars

Join the Community

Give a Little. Get a Lot.

Answers

3 Ways to Join

The Experts

The Experts

Testimonials

Testimonials

Testimonials

Business Clients

Business Clients

In the Press

In the Press

In the Press