Question

vbscript read string in text file

Asked by: dan29

Hello.  I was looking for assistance with an issue Im having with a script trying to read strings in a text file.  Shown below is the script.   Basically, it's looking for the existence of the filenames listed in the array, writes the file names that are found into a text file.  Then the script opens the text file with the file names, and if it finds the particular string in the file, writes a cooresponding number to another text file.  Then the script reads the numbers in that file and sets a variable to the numbers read, then uses that variable as the exit code.  I'm using this exit code for reporting in Altiris Notification Server.  Everything appeared to work fine, but then I noticed it would inconsistantly work or not work.  For example in the script, the first string to search is Test1.exe.  Even though the file is on the systems and the first part of the script writes this to the logfile, my InStr function isn't working and not reading this from the file.  Is there a way to have my string searches work consistantly?  Let me know if you can assist.  Thank you.

ON ERROR RESUME NEXT
strComputer      = "."
Const ForReading = 1

Set objFSO     = CreateObject("Scripting.FileSystemObject")
Set objLogFile = objFSO.CreateTextFile("LogFile.txt")
Set objRS      = objFSO.CreateTextFile("RSFile.txt")

arrFileNames   = Array("'Test1'","'Test2'","'Test3'","'Test4'")
strQueryFilter = "FileName = " & Join(arrFileNames, " OR FileName = ")

strComputer = "."
Set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\cimv2")
Set colFiles = objWMIService.ExecQuery("SELECT * FROM CIM_DataFile WHERE " & strQueryFilter,, 48)

For Each objFile In colFiles
   objLogFile.write(objFile.FileName & "." & objFile.Extension & vbCrLf)
Next

objLogFile.close

Set objLogFile = objFSO.OpenTextFile("LogFile.txt", 1)

 Do Until objLogFile.AtEndOfStream
   strSearchThis = strSearchThis & objLogFile.ReadLine
 loop

   if instr(strSearchThis, "Test1.exe") > 0 then
     objRS.Write "1"
   end if

   if instr(strSearchThis, "test2.dll") > 0 Then
     objRS.Write "2"
   end if

   if instr(strSearchThis, "test3.ocx") > 0 Then
     objRS.Write "3"
   end if

   if instr(strSearchThis, "test4.exe") > 0 Then
     objRS.Write "4"
   end if

objLogFile.close
objRS.close


Set objRS = objFSO.OpenTextFile("RSFile.txt", 1)

 Do until objRS.AtEndOfStream
   strResult = strResult & objRS.ReadLine
 loop

objRS.Close


If strResult = "" Then
   wscript.quit(0)
 Else
   wscript.quit(strResult)
End if

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2008-09-08 at 06:55:21ID23712025
Tags

Microsoft

,

VBScript

,

Windows XP

Topics

VB Script

,

Windows XP Operating System

Participating Experts
2
Points
0
Comments
9

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. strComputer and CDO/HTML
    Hi guys hope you can help!! Okay, I have the following code that is just about 100% working, but Id like you nice people to examine it (see if there is anything that really isnt being done as per standard good programming practice etc). What it does is the following: Queri...
  2. WMI vbscript deploying
    I want to monitor if windows games like solitare minesweeper is played during work hours, hence ive come up with below vbscript which will log data when the applications open on ppl's PC's. Problem is i want to deploy this over GPO and when i put this as a Logon or startup s...
  3. Vbscript to write logfile
    Hello Experts, I would like a vbscript to retrive a RegestryKey values from Domain computers (I will CSVDE a list) and write the results to a logfile which can then have a File Compare run for Duplicates in the domain. I have some issues with WSUS clients not reporting in t...
  4. objFSO
    i have two different server one is a webserver and the other is a storage server, in my web page using vbscript, i was trying to read the files inside the storage server but i keep getting invalid directory or file not found this is the way i did it. could you tell me how to ...
  5. vbscript read logfiles with subroutine, and output help
    Experts, I have a vbscript that is given two arguments 1) a log file to parse 2) a variable name used as the SID throught the script. The script should do the following: 1) Create a report file to write results of this script into. 2) Use the logfile name passed to the scri...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: BrandonGalderisiPosted on 2008-09-08 at 08:03:20ID: 22418064

Ok.  I'm looking at this and I have a few suggestions:

Use regular expression testing instead of instr.
Use readall instead of readline.
Why write to file, just to read it?

I'm having a little trouble interpreting exactly what you are attempting to accomplish, but it looks like you were reading from a file, searching the file for 4 words, then opening the file to read and stream the results into a single value (strResult).

Does this work for you?

ON ERROR RESUME NEXT
strComputer      = "." 
Const ForReading = 1
 
Set objFSO     = CreateObject("Scripting.FileSystemObject")
Set objLogFile = objFSO.CreateTextFile("LogFile.txt")
Set objRS      = objFSO.CreateTextFile("RSFile.txt")
 
arrFileNames   = Array("'Test1'","'Test2'","'Test3'","'Test4'") 
strQueryFilter = "FileName = " & Join(arrFileNames, " OR FileName = ")
 
strComputer = "."
Set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\cimv2")
Set colFiles = objWMIService.ExecQuery("SELECT * FROM CIM_DataFile WHERE " & strQueryFilter,, 48)
 
For Each objFile In colFiles
   objLogFile.write(objFile.FileName & "." & objFile.Extension & vbCrLf)
Next
 
objLogFile.close
 
Set objLogFile = objFSO.OpenTextFile("LogFile.txt", 1)
strSeatchThis = objLogFile.readall
strResult = ""
 
if RegExpTest("Test1.exe", strSearchThis) > 0 then 
strResult  = strResult  & "1" & vbcrlf
 
if RegExpTest("test2.dll", strSearchThis) > 0 then 
strResult  = strResult  & "2" & vbcrlf
 
 
if RegExpTest("test2.dll", strSearchThis) > 0 then 
strResult  = strResult  & "3" & vbcrlf
 
if RegExpTest("test4.exe", strSearchThis) > 0 then 
strResult  = strResult  & "4" & vbcrlf
 
 
objLogFile.close
objRS.close
 
 
Set objRS = objFSO.OpenTextFile("RSFile.txt", 1)
 
 Do until objRS.AtEndOfStream
   strResult = strResult & objRS.ReadLine
 loop
 
objRS.Close
 
 
If strResult = "" Then
   wscript.quit(0)
 Else
   wscript.quit(strResult)
End if
 
 
Function RegExpTest(strMatchPattern, strPhrase)
    'create variables
    Dim objRegEx
    Set objRegEx = New RegExp 
    objRegEx.Global = True
    objRegEx.IgnoreCase = True
    objRegEx.Pattern = strMatchPattern 
     RegExpTest=objRegEx.test(strPhrase)
    'create the collection of matches
End Function 
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:

Select allOpen in new window

 

by: dan29Posted on 2008-09-09 at 07:12:21ID: 22427542

Brandon;

After briefly testing this out, and only placing two of the files on my system, it's still echoing all four numbers, instead of two.  You're correct though, there is no reason to write out the value returned from reading text strings into another file.  Basically, what Im trying to do is use this numeric value as the exit code of the script:  i.e.  wscript.quit(strResult).  Without having to create an additional reporting class in Altiris, I can create a collection in Altiris Notification Server based on this exit code from the script.  Just seem to have an issue reading text in the file correctly though.  I appreciate your assistance.

 

by: BrandonGalderisiPosted on 2008-09-09 at 07:23:48ID: 22427666

Instead of saying what your code is doing with the files, can you just post what you want to happen.  

Are you just looking to see if test1.exe,test2.dll,test3.ocx (typo in my script), and test4.exe exist, and return 1,2,3,4 as the exit code accordingly?

 

by: dan29Posted on 2008-09-09 at 08:28:15ID: 22428447

I want it to read the logfile, and find the strings that I specify then assign a value to the strings that are found in the logfile  "1" for test.exe, "2" for test2.dll and so on.  There's not an issue of writing it to the logfile, it just looks like when it's reading from the logfile it's skipping the first line.  

 

by: BrandonGalderisiPosted on 2008-09-09 at 08:48:12ID: 22428743

so you believe this:

Set objLogFile = objFSO.OpenTextFile("LogFile.txt", 1)
strSeatchThis = objLogFile.readall

is not getting the first like of your logfile?

or here?

 Do until objRS.AtEndOfStream
   strResult = strResult & objRS.ReadLine
 loop

Because that doesn't need to happen as I was building out strResult as it went along.


How about let's go back to the basics for my understanding.

You have 4 files.  Test1, Test2, Test3 and Test4.  You want these four files to be SEARCHED for Test1.Exe,Test2.dll,Test3.ocx and test4.exe.  So let's say for simplicity that test1.exe is ONLY in test1, test2.dll is ONLY in test2, and so on.

What would you expect your output to be?

N ERROR RESUME NEXT
strComputer      = "." 
Const ForReading = 1
 
Set objFSO     = CreateObject("Scripting.FileSystemObject")
Set objLogFile = objFSO.CreateTextFile("LogFile.txt")
Set objRS      = objFSO.CreateTextFile("RSFile.txt")
 
arrFileNames   = Array("'Test1'","'Test2'","'Test3'","'Test4'") 
strQueryFilter = "FileName = " & Join(arrFileNames, " OR FileName = ")
 
strComputer = "."
Set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\cimv2")
Set colFiles = objWMIService.ExecQuery("SELECT * FROM CIM_DataFile WHERE " & strQueryFilter,, 48)
 
For Each objFile In colFiles
   objLogFile.write(objFile.FileName & "." & objFile.Extension & vbCrLf)
Next
 
objLogFile.close
 
Set objLogFile = objFSO.OpenTextFile("LogFile.txt", 1)
strSeatchThis = objLogFile.readall
strResult = ""
 
if RegExpTest("Test1.exe", strSearchThis) > 0 then 
strResult  = strResult  & "1" & vbcrlf
 
if RegExpTest("test2.dll", strSearchThis) > 0 then 
strResult  = strResult  & "2" & vbcrlf
 
 
if RegExpTest("test2.dll", strSearchThis) > 0 then 
strResult  = strResult  & "3" & vbcrlf
 
if RegExpTest("test4.exe", strSearchThis) > 0 then 
strResult  = strResult  & "4" & vbcrlf
 
 
objLogFile.close
objRS.close
 
 
 
 
If strResult = "" Then
   wscript.quit(0)
 Else
   wscript.quit(strResult)
End if
 
 
Function RegExpTest(strMatchPattern, strPhrase)
    'create variables
    Dim objRegEx
    Set objRegEx = New RegExp 
    objRegEx.Global = True
    objRegEx.IgnoreCase = True
    objRegEx.Pattern = strMatchPattern 
     RegExpTest=objRegEx.test(strPhrase)
    'create the collection of matches
End Function 

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:

Select allOpen in new window

 

by: dan29Posted on 2008-09-12 at 07:50:12ID: 22460374

I've gone back and looked at my original script.  It appears as if I failed to look into detail how the InStr function works.  For each text string I'm looking for, I need to tell it what character to start the search on:

if instr(1,strSearchThis,"Test1.exe",1) > 0 then

instead of just :

if instr(strSearchThis,"Test1.exe") > 0 then

as well as tell the function to use vbTextCompare.  It appears to be working fine now.  Thank you once again for the assistance.

 

by: BrandonGalderisiPosted on 2008-09-12 at 08:31:42ID: 22460789

Read this description of the use of the instr function.

http://www.devguru.com/Technologies/vbscript/quickref/instr.html

The Starting Position is optional, unless you are using vbTextCompare compare method.  

I totally missed that, because I do that or upper() the string and test usually because I don't care about case sensitivity usually.


I still say the regex would be a cleaner method.

const SearchFor1 = "a"
const SearchFor2 = "A"
const searchin = "aA"
 
wscript.echo instr(searchin,searchfor1)
wscript.echo instr(searchin,searchfor2)
 
 
wscript.echo instr(1,searchin,searchfor1)
wscript.echo instr(1,searchin,searchfor2)
 
wscript.echo instr(1,searchin,searchfor1,1)
wscript.echo instr(1,searchin,searchfor2,1)
 
wscript.echo instr(1,searchin,searchfor1,vbTextCompare)
wscript.echo instr(1,searchin,searchfor2,vbTextCompare)
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:

Select allOpen in new window

 

by: ee_autoPosted on 2009-05-12 at 01:20:07ID: 24362200

Question PAQ'd, 250 points refunded, and stored in the solution database.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...