Question

Move File to New Directory Vbscript File exists Error

Asked by: worpx

Hi VBScript Gurus,

I'm trying to automate some tasks and have come up with the following code below. It is supposed to move all files with proper extensions to folders, but I am having difficulty moving the file when found...
I have tried .move .movefile and .copyfile with true at the end to no avail. It comes up with the error "File already exists" when there certainly are no avis in the folder. It correctly grabs the files within the folders and subfolders (since I left echos in), but no luck moving it AT ALL.

Any help is greatly appreciated!

'Vars
Dim objFSO, objFileCopy, objFileDelete, dot, files, file
Dim strFilePath, strDestination, folder, subfolder, fileCount, strTorrent
 
'Strings
strFilePath = "F:\DOWNLOADS\Temp"
strDestination = "F:\MOVIES"
strTorrent = "F:\DOWNLOADS"
 
    set objFSO = CreateObject("Scripting.fileSystemObject") 
    set folder = objFSO.getFolder(strTorrent) 
	
	    'Parent folder Subroutine
For Each file In folder.files
Set objFileCopy = objFSO.GetFile(file)
	   'dot = InStrRev(file.name,".")-1  ,(len(file.name)-dot)
	   If objFSO.GetExtensionName(file) = "avi" Then
        ' Move to the file destination
		
	   CheckExists(objFileCopy)
		wscript.echo objFileCopy		
		
		
        objFSO.MoveFile objFileCopy.Path, strDestination
		
		
		WSCript.Echo "Copied to " & strDestination
       End If
    Next 
 
Sub CheckExists(objFileCopy)
set folder = objFSO.getFolder(strDestination) 
 
If objFSO.FileExists(strDestination) Then
		wscript.echo objFileCopy
		WScript.Echo "Already there"
		wscript.quit
End If
End Sub

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-08-08 at 17:44:39ID24637566
Tags

vbscript

,

file exists

Topics

VB Script

,

VB Objects

,

Powershell

Participating Experts
3
Points
125
Comments
7

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Get Current Directory? in VBScript
    Running VBScript scripts with the Windows Script Host. How can I find out what the current directory is? In VB, I can use CurDir$ to get this, but it doens't do it in VBScript. How do I get it in VBScript? Thanks,
  2. Suggestion: use CopyFile or MoveFile (c++)
    Hello, I've got the following problem. The code is written in VC6.0 and is compiled in a MCF Extension DLL, running W2k To start off, the code IS working, but the CopyFile /DeleteFile action seems to take 1 minute! I was surprised to see that, for just a 4MB file. I was wond...
  3. CopyFile, MoveFile need to know if completed
    Hello, I am doing a CopyFile or MoveFile across the network, thus it is on a different volume and it fails on directory moves when the destination is on a different volume everytime as MSDN says it would. Is there anyway that I can do a copy or move and know if it actaully...
  4. VBScript FileSystemObject for copyfile.
    Hello experts, I am using the following VBScript code in Visual Builder to find a file recursively in a folder and then copy it to a different location. I am unable to understand how I can check if a File is not found in thie piece of code. Any ideas or suggestions will be ...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: pilozitePosted on 2009-08-09 at 01:21:32ID: 25053256

hello ,

you could do it with PowerShell as below, this is done with one line of code.

dir F:\DOWNLOADS -recurse -include *.mov|%{move-item $_.fullname F:\MOVIES}

                                              
1:

Select allOpen in new window

 

by: bvflorinPosted on 2009-08-09 at 01:40:16ID: 25053307

Please change the following lines:
strFilePath = "F:\DOWNLOADS\Temp"
strDestination = "F:\MOVIES"
strTorrent = "F:\DOWNLOADS"

objFSO.MoveFile objFileCopy.Path, strDestination

with:

strFilePath = UCase("F:\DOWNLOADS\Temp\")
strDestination = UCase("F:\MOVIES\")
strTorrent = UCase("F:\DOWNLOADS\")

objFSO.MoveFile UCase(objFileCopy.Path), UCase(strDestination)

Let me know the results!

 

by: bvflorinPosted on 2009-08-09 at 02:25:30ID: 25053436

OK. I took a look on your script and i modify a little bit the original. Please have a look on it! 

'Vars
Dim objFSO, objFileCopy, objFileDelete, dot, files, file
Dim strFilePath, strDestination, strTorrent, folder, subfolder, fileCount, 
 
'Strings
strFilePath = UCase("F:\DOWNLOADS\Temp\")
strDestination = UCase("F:\MOVIES\")
strTorrent = UCase("F:\DOWNLOADS\")
 
set objFSO = CreateObject("Scripting.fileSystemObject") 
set folder = objFSO.getFolder(strTorrent) 
 
'Parent folder Subroutine
For Each file In folder.files
	Set objFileCopy = objFSO.GetFile(file)
	strFileName = objFSO.GetFileName(file)
	
	If objFSO.GetExtensionName(file) = "avi" Then
		' Move to the file destination
		If objFSO.FileExists(strDestination & strFileName) Then
			WScript.Echo "File (" & strFileName & ") already exists on destination folder (" & strDestination & ")!"
		Else
			objFSO.MoveFile objFileCopy.Path, strDestination
			WSCript.Echo "File (" & strFileName & ") was moved to " & strDestination & "!"
		End If
	End If
Next

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:

Select allOpen in new window

 

by: bluntTonyPosted on 2009-08-09 at 04:06:57ID: 25053721

HI there,

I think it's simpler than that - you just need to add a '\' to the end of strDestination - otherwise it treats it as a file. So just change line 7 in your original script to

strDestination = "F:\Movies\"

Without the backslash, copyFile is trying to create a file called F:\Movies which already exists, hence your error.

Tony.

 

by: worpxPosted on 2009-08-09 at 16:43:48ID: 25056508

HI all,

THank you for the responses, I figured out why it wasn't copying...I did require an extra slash (\) for my designation, so thats what I put in. I also cleaned up my code a bit so its easier to read.

Anyone have an experience with winrar? I'm using it to extract all archives and want it to delete the file afterwards, any way to do this?

Also, any ideas on a cleaner loop for the subfolders? (Nested loops within parent loops??)

Thanks for the reponses.

'On Error Resume Next
Option Explicit
 
Dim strRarExe
strRarExe = """C:\Program Files\WinRar\rar.exe"""
 
'Unrar all downloads within specified directory using paths
CreateObject("WScript.Shell").Run strRarExe & " x -r " & "*.*" & " F:\DOWNLOADS\Extracted\", 1, True
 
'Vars
Dim objFSO, objFileDelete, dot, files, file
Dim strFilePath, strDestination, folder, subfolder, fileCount, strTorrent
 
'Strings
strFilePath = "F:\DOWNLOADS\Extracted"
strDestination = "F:\MOVIES"
 
set objFSO = CreateObject("Scripting.fileSystemObject") 
 
'==========DOWNLOADS FOLDER============
set folder = objFSO.getFolder(strFilePath) 
	'Parent folder Subroutine
For Each file In folder.files       
	   If LCase(objFSO.GetExtensionName(file)) = "avi" or LCase(objFSO.GetExtensionName(file)) = "mkv" or LCase(objFSO.GetExtensionName(file)) = "mpg" Then	   
        ' Move to the file destination	
		If Not objFSO.FileExists(strDestination) Then		
        objFSO.CopyFile file.Path, strDestination & "\", True
	    End If				
    End If
 Next 
 
 SubFolders(folder)
 
Sub SubFolders(folder) 
 For Each subfolder In folder.Subfolders	
	For Each file In SubFolder.Files	
	   If LCase(objFSO.GetExtensionName(file)) = "avi" or LCase(objFSO.GetExtensionName(file)) = "mkv" or LCase(objFSO.GetExtensionName(file)) = "mpg" Then	   
        ' Move to the file destination	
		If Not objFSO.FileExists(strDestination) Then		
        objFSO.CopyFile file.Path, strDestination & "\", True
	    End If				
    End If
	Next
 Next
 End Sub
 
	
	
    ' Delete file after being copied
    ' Set objFileCopy = objFSO.GetFile(strFilePath)
    ' objFileCopy.Delete ()
 
    wscript.echo "Extraction & Sort Complete!"
 
 
wscript.Quit

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:

Select allOpen in new window

 

by: bvflorinPosted on 2009-08-10 at 00:40:06ID: 25057766

1) You want to delete .rar files after extract?
2) What do you mean with "cleaner loop"? Cleaning what?

 

by: worpxPosted on 2009-08-10 at 12:13:02ID: 25063033

1. Yes, delete .rar after extraction.
2. Do you think it can be simplified to a couple nested loops so that I may get rid of the Sub?

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...