Question

How to execute a SQL INSERT INTO command using VBScript?

Asked by: TrishITGuru

I have the following script that works until the last part of the loop.
the objMSSQLDC1.Execut (strSQL) command stops after the first 23 records.
If I comment out that line and use just Wscript.Echo strSQL I get all 2589 records to show in the output.
Can someone tell me what I am missing?

'Open DB on server 2
Set objMSSQLDC1 = CreateObject("ADODB.Connection")
objMSSQLDC1.ConnectionTimeout = 60
objMSSQLDC1.CommandTimeout = 60
Set objRS1 = CreateObject("adodb.recordset")
 
strProvider1 = "Provider=SQLOLEDB;Data Source=xxxxx;Initial Catalog=xxxx;Connect Timeout=60;Network Library=dbmssocn;"
strDBUser1 = "xxxxx"
strDBPass1 = "xxxxx"
 
objMSSQLDC1.open strProvider1, strDBUser1, strDBPass1
 
 
'open DB on server2
Set objMSSQLDC = CreateObject("ADODB.Connection")
objMSSQLDC.ConnectionTimeout = 60
objMSSQLDC.CommandTimeout = 60
Set objRS = CreateObject("adodb.recordset")
 
strProvider = "Provider=SQLOLEDB;Data Source=xxxxxx;Initial Catalog=xxxx;Trusted_Connection=yes;Connect Timeout=60;Network Library=dbmssocn;"
strDBUser = "xxxxx"
strDBPass = "xxxxx"
 
objMSSQLDC.open strProvider, strDBUser, strDBPass
'get data from view
strSQL="SELECT * from vtbl1"
 
'set recordset
objRS.Open strSQL, objMSSQLDC, 0, 1
 
 
'walk through recordset, parse serverdn and update with new serverdn
	Do until objRS.EOF
		arrayServerDN=split(objRS("ServerDN"),"/")
		'WScript.Echo Replace(arrayServerDN(5), "cn=", "")
		serverName = Replace(arrayServerDN(5), "cn=", "")
		
		strSQL = "INSERT into tbl2 (DisplayName,PIN,PhoneNumber,Server,ServiceName)"
		strSQL = strSQL & "VALUES ('" & objRS.Fields("DisplayName") & "', '" & objRS.Fields("PIN") & "', '" & objRS.Fields("PhoneNumber") & "', '" & serverName & "', '" & objRS.Fields("ServiceName") & "');"
 
		'wscript.echo strsql
		objMSSQLDC1.Execute (strSQL)
		objRS.movenext
	Loop
 
 
objRS.close
objRS1.close
objMSSQLDC.close
objMSSQLDC1.close

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-08-10 at 10:43:52ID24640726
Topic

VB Script

Participating Experts
1
Points
0
Comments
9

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Paging ASP code for SQL DB error in strSQL
    I am trying to implement a paging code into my search results page and I keep getting this error when I click on the link to go to the next results page. I can't figure out what's wrong with this statement. I would appreciate feedback. Thank you for your help. Error Type...
  2. strSQL insert
    ' Build our SQL String strSQL = strSQL & "INSERT INTO scratch " strSQL = strSQL & "(text_field, integer_field) " & vbCrLf strSQL = strSQL & "VALUES (" strSQL = strSQL & "'" & strTextField & "'" strS...
  3. Conn.Execute(strSQL)
    Conn.Execute(strSQL) How can I tell if this was successful? Can I do an If THen around it and it will enter the block if it worked?
  4. Using VBScript and SQL
    I have almost no SQL experience, but I want to get started. I have a lot of VBScript experience, so I would like to create some vbscripts that perform queries on an SQL DB. Could someone give me some example code (vbscript) on how to do the following: 1. I want to return a...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: angelIIIPosted on 2009-08-10 at 10:46:52ID: 25062176

do you have some values with quotes in the data?
if yes, that could explain..

    strSQL = "INSERT into tbl2 (DisplayName,PIN,PhoneNumber,Server,ServiceName)"
            strSQL = strSQL & "VALUES ('" & replace(objRS.Fields("DisplayName"), "'", "''") & "', '" & replace(objRS.Fields("PIN"), "'", "''") & "', '" & replace(objRS.Fields("PhoneNumber"), "'", "''") & "', '" & replace(serverName, "'", "''") & "', '" & replace(objRS.Fields("ServiceName"), "'", "''") & "');"
 

                                              
1:
2:
3:

Select allOpen in new window

 

by: angelIIIPosted on 2009-08-10 at 10:47:24ID: 25062182

or possibly, some NULL values?

in which case, you must have ,NULL, instad of ,'data', in your strSQL...

 

by: TrishITGuruPosted on 2009-08-10 at 10:59:57ID: 25062298

like i mentioned, if i comment out the line objMSSQLDC1.Execute (strSQL) it will show all 2500+ rows of data.
and there are null values in the middle of the 23 records that get pulled with the Execute statement, so it isn't NULL that's a problem.

I'm not sure i have the Execute (strSQL) command correct for a loop.  I am running a loop to use a split function and update a field, then i want to insert all the data into the new table.  I don't know what the exectue command is and i found conn.Execute () on a website but it doesn't appear to be correct.

 

by: TrishITGuruPosted on 2009-08-10 at 12:00:49ID: 25062895

i was playing with it more and if i move the statment objMSSQLDC1.Execute (strSQL) out of the Loop, it will insert the last record (#2589) into the database, however, when i put inside the loop it will only insert the first 23 records.  So the array and SQL statement are doing what its supposed to, so its clearly how i am calling the insert statement, that's where i need help.

 

by: angelIIIPosted on 2009-08-10 at 12:04:33ID: 25062949

sorry, but I disagree.
with your method, you show that the .execute does insert 23 records, so the 24th record has "some problem".

please write the generated strSQL values into a log file to "see" what it is generating, with a row number ...

 

by: TrishITGuruPosted on 2009-08-10 at 12:15:59ID: 25063062

where would the null value come from? there are no nulls in the data i am pulling, and i've already put into a log file and on screen display and every record/field has data in it, no nulls.  i've even displayed the INSERT statement to very that what is to be inserted contains the right data, when displayed i get 2580 insert statements.  but as soon as i put the obj.execute inside the loop it becomes only 23, again no nulls.

 

by: angelIIIPosted on 2009-08-10 at 12:21:26ID: 25063121

what about the quotes?
do you have "on error " somewhere in your code?
any triggers on tbl2 ?

can you check the rows_affected return value?

dim rows_affected
objMSSQLDC1.Execute strSQL, rows_affected
WScript.Echo rows_affected & " rows for " & strSQL
                                              
1:
2:
3:

Select allOpen in new window

 

by: TrishITGuruPosted on 2009-08-10 at 12:32:27ID: 25063223

i figured it out.  after looking at each record in the DB there was a problem with the size of the field for the new database.  in tbl1 the size was 11, in tbl2 it was 10 so it was truncating and halting the rest of the query.  It also halted if there was an apostrophe in the name, i.e O'Doull, it would give an error and halt.

thanks for the input.

 

by: angelIIIPosted on 2009-08-10 at 12:35:40ID: 25063254

so long for pushing you to look closer :)

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...