Question

Folder copy in VBS - XCOPY syntax

Asked by: chris_bottomley

Within my script, I am setting a source and target folder as follows:

srcfolder = "c:\Documents and Settings\fred\Application Data\Microsoft\Internet Explorer\Quick Launch\"
tgtfolder = "F:\17BFR1J\2009-09\Quick Launch\*.*"

I want to call xcopy using something like:
objShell.Run "cmd /c xcopy " & srcfolder & " " & tgtfolder & " /Y/E/C/I/F/K >> " & dirname & "\logfile.txt"

i.e. shell the xcopy command which needs to append the output to a text file.
Objshell is defined as:
set objShell = createobject("wscript.shell")
and dirname is defined as:
dirname = "F:\folderx\" & year(date()) & "-" & Right("0" & month(date()), 2)

The idea behind using xcopy is it seems to be more efficient that the FSO functions and although I have a batch file using xcopy working, it falls over on ocassion so I am hoping to use the extended capabilities of vbs to work more interactively with my system.

Chris

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

Plus...

30 Day FREE access, no risk, no obligation
Collaborate with the world's top tech experts
Unlimited access to our exclusive solution database
Never be left without tech help again

Subscribe Now

Asked On: 2009-08-12 at 23:46:07ID24648937
Topic: VB Script
Participating Experts: 2
Points: 500
Comments: 11

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

"The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
"Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
"Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Free Tech Articles

WARNING: 5 Reasons why you should NEVER fix a computer for free.
It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
SCCM OSD Basic troubleshooting
SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
Create a Win7 Gadget
This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
Outlook continually prompting for username and password
There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
Backup Exchange 2010 Information Store using Windows Backup
There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

Avoiding Bugs in Microsoft Access
Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
Top 10 Best New Features in Visio 2010
Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
IT Consultant Business Secrets Revealed
Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
Disaster Recovery and Business Continuity
Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
Organize Your Visio Diagrams with Containers and Lists
Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
How to Us Objects, Properties, Events and Methods in Microsoft Access
Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Watch More

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

by: Tompa99Posted on 2009-08-13 at 04:13:46ID: 25087006

Hi there

I did write down more or less what you have here in one script that is working.
Since the logfile.txt folder may not exists I did add a check for that and create the folder
if I get false on foldercheck.

I hope this is giving you what you are looking for.

Best Regards Tompa

Dim sourceFolder
Dim targetFolder
Dim objWshShell 
Dim fso
Dim folderCheck
sourceFolder = "c:\test"
targetFolder = "c:\test2"
logFileFolder = "c:\temp\" & year(date()) & "-" & Right("0" & month(date()), 2)
Set objWshShell = WScript.CreateObject("WScript.Shell.1")
Set fso = WScript.CreateObject("Scripting.FileSystemObject")
folderCheck = fso.FolderExists(logFileFolder)
if folderCheck = false then
	fso.CreateFolder(logFileFolder)
end if 
objWshShell.Run "cmd /c xcopy " & sourceFolder & " " & targetFolder & "  /Y/E/C/I/F/K >> " & logFileFolder & "\logfile.txt"

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:

Select all Open in new window

by: Daz_1234Posted on 2009-08-13 at 04:18:59ID: 25087040

I think what you've got there is nearly Ok. I would tweak as below:

- Move the *.* from target to source
- Double up the quotes on the command line to cater for spaces in the paths
- Space out the XCopy switches
- Add 2>&1 so that errors are also written to the log
- Hmm that should be all!

Make sure that the dirname folder already exists or I'm not sure the logfile will get written / may cause an error.

Change the 1 on the Run line to 0 to hide the 'dos' style window.

Hope this helps,
Daz.

set objShell = CreateObject("WScript.Shell")
dirname = "F:\folderx\" & year(date()) & "-" & Right("0" & month(date()), 2)
 
srcfolder = "c:\Documents and Settings\fred\Application Data\Microsoft\Internet Explorer\Quick Launch\*.*"
tgtfolder = "F:\17BFR1J\2009-09\Quick Launch\"
 
objShell.Run "cmd /c XCopy """ & srcfolder & """ """ & tgtfolder & """  /Y /E /C /I /F /K >> """ & dirname & "\logfile.txt"" 2>&1", 1, True

1:
2:
3:
4:
5:
6:
7:

Select all Open in new window

by: chris_bottomleyPosted on 2009-08-13 at 04:47:02ID: 25087109

Tompa99

I supplied a snapshot of my script and yes I do ensure the log file pre-exists.

Daz_1234

I have modified as suggested but I still don't get any files copied. My log file shows:

c:\Documents and Settings\###\desktop
==========================================
0 files copied.

c:\Documents and Settings\###\Application Data\Microsoft\Internet Explorer\Quick Launch
============================================================================================
0 files copied.

For the two folders in my sample. The same folders have a number of files which via xcopy in a bat file copy over just fine.

Chris

by: Daz_1234Posted on 2009-08-13 at 04:50:28ID: 25087140

Would you mind, please, pasting in the lines from your batch file that contain the source, target and xcopy lines (or all of it)?

Cheers,
Daz.

by: Tompa99Posted on 2009-08-13 at 04:57:55ID: 25087179

Hi
My Mistake
Change the Run Command so you have all the correct """ for long file/ Folder Names

objWshShell.Run "cmd /c xcopy """ & sourceFolder & """ """ & targetFolder & """ /Y/E/C/I/F/K >> """ & logFileFolder & "\logfile.txt"

Best Regards Tompa

by: chris_bottomleyPosted on 2009-08-13 at 05:00:37ID: 25087196

Modified to protect the guilty ... path names but that's all.

Chris

' Force CSCRIPT ... at CLI use cscript //h:cscript
' Force WSCRIPT ... at CLI use wscript //h:cscript
dim fso
dim srcFolder
dim tgtFolder
dim arrPointer
dim FolderMasks()
dim folderSet
const srcfoldername = 0
const tgtfoldername = 1
const FolderMask = 2
dim dirName
dim logFile
dim screen
dim fn
dim datarec
dim filecount
dim objShell
Dim strCmd
 
set screen = wscript.stdout 
dirname = "F:\###\" & year(date()) & "-" & Right("0" & month(date())+1, 2)
 
redim foldermasks(0)
folderset = "c:\Documents and Settings\~~~\desktop," & dirname & "\Desktop,*.*"
	folderset = replace(folderset, " ", " ") : folderset = replace(folderset, ", ", ",")
	foldermasks(ubound(foldermasks)) = split(folderset, ",")
folderset = "c:\Documents and Settings\~~~\Application Data\Microsoft\Internet Explorer\Quick Launch," & dirname & "\Quick Launch,*.*"
	folderset = replace(folderSet, " ", " ") : folderset = replace(folderset, ", ", ",")
	redim preserve foldermasks(ubound(foldermasks)+1) : foldermasks(ubound(foldermasks)) = split(folderset, ",")
 
set fso = createobject("scripting.filesystemobject")
set objShell = createobject("wscript.shell")
if not fso.folderexists(dirname) then
	fso.createfolder(dirname)
	fso.createtextfile(dirName & "\logfile.txt")
end If
set logFile = fso.opentextfile (dirname & "\logfile.txt", 8, true)	' 8 = open for appending
underBoth("CB Backup.vbs activated on " & day(date()) & " " & monthname(month(date()), true) & " " & year(date()) & " at " & time())
for datarec = 0 To ubound(foldermasks)
	filecount = 0
	underboth foldermasks(datarec)(srcfoldername)
	screen.writeline("")
	If not fso.folderexists(foldermasks(datarec)(tgtfoldername)) then
		fso.createfolder(foldermasks(datarec)(tgtfoldername))
	end if
	srcfolder = foldermasks(datarec)(srcfoldername) & "\" & foldermasks(datarec)(FolderMask)
	tgtfolder = foldermasks(datarec)(tgtfoldername) & "\"
	objShell.Run "cmd /c XCopy """ & srcfolder & """ """ & tgtfolder & """  /Y /E /C /I /F /K >> """ & dirname & "\logfile.txt"" 2>&1", 1, True 
	'objShell.run "cmd /c xcopy.exe """ & srcFolder & """ """ & tgtFolder & """ /Y /E /C /I /F /K >> """ & dirname & "\logfile.txt"" 2>&1", 1, True
'	displayboth(filecount & " files copied.")
next
logfile.close
 
function displayBoth(str)
	screen.writeline str
	logfile.writeline str
end function
function underboth(str)
	displayboth("")
	displayboth(str)
	displayboth(string(len(str), "="))
end function

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:

Select all Open in new window

by: Daz_1234Posted on 2009-08-13 at 05:04:25ID: 25087218

My tests are working fine.

Can you double check that "c:\Documents and Settings\fred\Application Data\Microsoft\Internet Explorer\Quick Launch\" definitely has files in it?

How is your script generating c:\Documents and Settings\###\Application Data\Microsoft\Internet Explorer\Quick Launch ?

Please can you also attach the vbScript that you've created?

Cheers,
Daz

NB Tompa's second attempt would still fail because there are no extra quotes after logfile.txt

by: chris_bottomleyPosted on 2009-08-13 at 05:15:36ID: 25087300

IN fact Tompas second attempt is potentially good since I am getting the data from the quick launch folder copied over although the desktop isn't working so it's not yet a perfect fix .. it is the closest so far.

Chris

by: Daz_1234Posted on 2009-08-13 at 05:22:03ID: 25087335

I've added some debug lines to your code.
If Tompas is working then there must be a problem with how you are compiling the source folder variables.

If I haven't cocked up the debug lines then they should show you exactly what is being generated.

Let us know how it goes.

Daz.

' Force CSCRIPT ... at CLI use cscript //h:cscript
' Force WSCRIPT ... at CLI use wscript //h:cscript
dim fso
dim srcFolder
dim tgtFolder
dim arrPointer
dim FolderMasks()
dim folderSet
const srcfoldername = 0
const tgtfoldername = 1
const FolderMask = 2
dim dirName
dim logFile
dim screen
dim fn
dim datarec
dim filecount
dim objShell
Dim strCmd
 
set screen = wscript.stdout 
dirname = "F:\###\" & year(date()) & "-" & Right("0" & month(date())+1, 2)
 
redim foldermasks(0)
folderset = "c:\Documents and Settings\~~~\desktop," & dirname & "\Desktop,*.*"
        folderset = replace(folderset, " ", " ") : folderset = replace(folderset, ", ", ",")
        foldermasks(ubound(foldermasks)) = split(folderset, ",")
folderset = "c:\Documents and Settings\~~~\Application Data\Microsoft\Internet Explorer\Quick Launch," & dirname & "\Quick Launch,*.*"
        folderset = replace(folderSet, " ", " ") : folderset = replace(folderset, ", ", ",")
        redim preserve foldermasks(ubound(foldermasks)+1) : foldermasks(ubound(foldermasks)) = split(folderset, ",")
 
set fso = createobject("scripting.filesystemobject")
set objShell = createobject("wscript.shell")
if not fso.folderexists(dirname) then
        fso.createfolder(dirname)
        fso.createtextfile(dirName & "\logfile.txt")
end If
set logFile = fso.opentextfile (dirname & "\logfile.txt", 8, true)      ' 8 = open for appending
underBoth("CB Backup.vbs activated on " & day(date()) & " " & monthname(month(date()), true) & " " & year(date()) & " at " & time())
for datarec = 0 To ubound(foldermasks)
        filecount = 0
        underboth foldermasks(datarec)(srcfoldername)
        screen.writeline("")
        If not fso.folderexists(foldermasks(datarec)(tgtfoldername)) then
                fso.createfolder(foldermasks(datarec)(tgtfoldername))
        end if
        srcfolder = foldermasks(datarec)(srcfoldername) & "\" & foldermasks(datarec)(FolderMask)
        tgtfolder = foldermasks(datarec)(tgtfoldername) & "\"
    '### DEBUG
    Dim blExists
    blExists = fso.FolderExists(foldermasks(datarec)(srcfoldername))
    MsgBox "Source: " & srcfolder & vbCrlf & "Target: " & tgtfolder & vbCrLf & vbCrlf _
         & foldermasks(datarec)(srcfoldername) & " EXISTS = " & blExists,, "Path Check. datarec = " & datarec
    '### END DEBUG
        objShell.Run "cmd /c XCopy """ & srcfolder & """ """ & tgtfolder & """  /Y /E /C /I /F /K >> """ & dirname & "\logfile.txt"" 2>&1", 1, True 
        'objShell.run "cmd /c xcopy.exe """ & srcFolder & """ """ & tgtFolder & """ /Y /E /C /I /F /K >> """ & dirname & "\logfile.txt"" 2>&1", 1, True
'       displayboth(filecount & " files copied.")
next
logfile.close
 
function displayBoth(str)
        screen.writeline str
        logfile.writeline str
end function
function underboth(str)
        displayboth("")
        displayboth(str)
        displayboth(string(len(str), "="))
end function

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:

Select all Open in new window

by: chris_bottomleyPosted on 2009-08-13 at 05:34:57ID: 31615197

The execution time of the desktop activity is the issue that made me think the solution was partial. It works as stated and is complete therefore thanks to Tompa(( and since I cannot rule out DAz 1234 input as potentially useful a few points for you too.

Chris

by: Daz_1234Posted on 2009-08-13 at 05:41:17ID: 25087493

Ok I might have sussed it.

You are locking open the logfile so the xcopy fails because it can't write to it.

Try the amended code below.

Daz.

' Force CSCRIPT ... at CLI use cscript //h:cscript
' Force WSCRIPT ... at CLI use wscript //h:cscript
dim fso
dim srcFolder
dim tgtFolder
dim arrPointer
dim FolderMasks()
dim folderSet
const srcfoldername = 0
const tgtfoldername = 1
const FolderMask = 2
dim dirName
dim logFile
dim screen
dim fn
dim datarec
dim filecount
dim objShell
Dim strCmd
 
set screen = wscript.stdout 
dirname = "F:\###\" & year(date()) & "-" & Right("0" & month(date())+1, 2)
 
redim foldermasks(0)
folderset = "c:\Documents and Settings\~~~\desktop," & dirname & "\Desktop,*.*"
        folderset = replace(folderset, " ", " ") : folderset = replace(folderset, ", ", ",")
        foldermasks(ubound(foldermasks)) = split(folderset, ",")
folderset = "c:\Documents and Settings\~~~\Application Data\Microsoft\Internet Explorer\Quick Launch," & dirname & "\Quick Launch,*.*"
        folderset = replace(folderSet, " ", " ") : folderset = replace(folderset, ", ", ",")
        redim preserve foldermasks(ubound(foldermasks)+1) : foldermasks(ubound(foldermasks)) = split(folderset, ",")
 
set fso = createobject("scripting.filesystemobject")
set objShell = createobject("wscript.shell")
if not fso.folderexists(dirname) then
        fso.createfolder(dirname)
        fso.createtextfile(dirName & "\logfile.txt")
end If
 
'###
'## Don't open logfile here ==>  set logFile = fso.opentextfile (dirname & "\logfile.txt", 8, true)      ' 8 = open for appending
'## open and close logfile for each write from the displayBoth sub below
'###
 
underBoth("CB Backup.vbs activated on " & day(date()) & " " & monthname(month(date()), true) & " " & year(date()) & " at " & time())
for datarec = 0 To ubound(foldermasks)
        filecount = 0
        underboth foldermasks(datarec)(srcfoldername)
        screen.writeline("")
        If not fso.folderexists(foldermasks(datarec)(tgtfoldername)) then
                fso.createfolder(foldermasks(datarec)(tgtfoldername))
        end if
        srcfolder = foldermasks(datarec)(srcfoldername) & "\" & foldermasks(datarec)(FolderMask)
        tgtfolder = foldermasks(datarec)(tgtfoldername) & "\"
        objShell.Run "cmd /c XCopy """ & srcfolder & """ """ & tgtfolder & """  /Y /E /C /I /F /K >> """ & dirname & "\logfile.txt"" 2>&1", 1, True 
        'objShell.run "cmd /c xcopy.exe """ & srcFolder & """ """ & tgtFolder & """ /Y /E /C /I /F /K >> """ & dirname & "\logfile.txt"" 2>&1", 1, True
'       displayboth(filecount & " files copied.")
next
 
'###
'## no need to close here now ==>  logfile.close
'###
 
function displayBoth(str)
        screen.writeline str
        set logFile = fso.opentextfile (dirname & "\logfile.txt", 8, true)
        logFile.writeline str
        logFile.Close
end function
function underboth(str)
        displayboth("")
        displayboth(str)
        displayboth(string(len(str), "="))
end function

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:

Select all Open in new window

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

For individual users
Instant access to solutions
Ask your tech questions
Start your 30-day Free Trial

Business Accounts

Perfect for organizations
Multiple users
Save over 36%
Create a Business Account

Answer for Membership

Earn free access
Showcase your knowledge
No credit card required
Sign Up to Answer

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...

Question

Folder copy in VBS - XCOPY syntax

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

VB Script

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Need individual assistance?

Our experts are ready to help.

Want to learn from the best?

Read articles from industry experts.

Working on a long term project?

Store your work and research.

What Makes Experts Exchange Unique?

Trusted by the world's most respected brands.

Faithfully serving IT professionals since 1996.

Related Solutions

Free Tech Articles

Cloud Class Webinars

Join the Community

Give a Little. Get a Lot.

Answers

3 Ways to Join

The Experts

The Experts

Testimonials

Testimonials

Testimonials

Business Clients

Business Clients

In the Press

In the Press

In the Press