Question

VBScript execute stored procedure with input params and return value

Asked by: Nigel_Taylor

Hi Guys,

I have the following stored procedure in SQL Server 2005 Express (Please see code area) which takes the brand name and time of call as input parameters and carries out a number of tests to see if the phone lines are open. This works fine in SQL management studio (please see code area) it returns the values that I expect. But when I go to execute it in vbs (please see code area) I get the error message "The conversion of a char data type resulted in an out-of-range datetime value". I understand what the error is saying but I am struggling on see what I have to do to fix it. Please can someone advise?

Also I need to be able to access the return value that is returned from the stored procedure. How do I do this?

Also if anyone can see any inefficiencies in the SQL then please shout as I will admit im a beginner.

Hope this makes sense and if you need any more informaiton then let me know.

Regards,

Nigel

ALTER PROCEDURE [dbo].[usp_PhoneCallCheck] 
	-- Add the parameters for the stored procedure here
	@Brand nvarchar(20),
	@TimeOfCall DateTime --nvarchar(8)
AS
BEGIN
	-- SET NOCOUNT ON added to prevent extra result sets from
	-- interfering with SELECT statements.
	SET NOCOUNT ON;
 
	DECLARE @BrandId nvarchar(2)
	DECLARE @DRStatus int
	DECLARE @ReturnValue int
 
	set @ReturnValue = 0
 
	SELECT @BrandId = fldId FROM tblBrands where fldBrand = @Brand		-- Get the Brand ID based upon the name of the brand that was passed in
		
	-- Below check the time and day of the incoming call and see if it can match 
 
	If Exists(
		SELECT * FROM tblOpeningTimes Where
		fldBrandId = @BrandId 
		AND
		CONVERT(datetime,'2009/09/14 ' + CONVERT(varchar(12),@TimeOfCall,114)) BETWEEN fldOpeningTime AND fldClosingTime
		)
		AND
		Exists(
		SELECT * FROM tblOpenDays Where fldBrandId = @BrandID AND fldDayOfWeek = DateName(WeekDay,getdate())
		)
		set @ReturnValue = 2
	Else
		set @ReturnValue = 3
 
	-- Check the DR state and override if we are in a DR mode
 
	If @ReturnValue = 2
	Begin
		SELECT @DRStatus = fldStatus FROM tblDR where fldId = 1				-- Get the DR status of the call center
 
		If @DRstatus = 1													-- If the DR status = 1 then we are closed and set the return value = 1
			set @ReturnValue = 1
	End
	
	Return(@ReturnValue)
END
 
 
******************************************************************
******************************************************************
 
USE [CallControl]
GO
 
DECLARE	@return_value int
 
EXEC	@return_value = [dbo].[usp_PhoneCallCheck]
		@Brand = N'Test Brand',
		@TimeOfCall = N'10:21:54'
 
SELECT	'Return Value' = @return_value
 
GO
 
*******************************************************************
*******************************************************************
 
Str_Connect = "Provider=SQLOLEDB.1;Persist Security Info=True;Initial Catalog=CallControl;Data Source=swyxsrv02\sqlexpress"
Set CnnSQL=CreateObject("ADODB.Connection")
CnnSQL.Open Str_Connect, "CallControl_User", "CallC0ntr0l"
 
 
  strSQL = "exec usp_PhoneCallCheck 'Test Brand','10:21:54' "
  CnnSQL.Execute(strSQL)
 
cnnSQL.Close
Set cnnSQL = Nothing

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-09-15 at 14:22:29ID24734537
Tags

VBScript

,

SQL

,

Stored Procedure

Topics

VB Script

,

SQL Query Syntax

,

Miscellaneous Programming

Participating Experts
1
Points
125
Comments
3

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. ActiveX - <param name...>
    How can I use, within an ActiveX Control, the data introduced with <param name...> from the HTML document? thanks crisoft
  2. activex params ?
    I'm working on delphi5 and I got a stupid newbie question: i got an activeform with a memo on it. i exported it as an activex component and implemented it on webpage. now the problem: how can I tell my activex-component that it has to change the text of the memo via html? ...
  3. vbscript/ado question... using the Param "SortDirecti…
    what does the "value =-1" mean in the parameter value for "SortDirection"? the field type is boolean. I thought it should be either 1 or 0; for true or false. see example below: <object classid="clsid:BD96C556-65A3-11D0-983A-00C04FC29E33&quo...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: BrandonGalderisiPosted on 2009-09-15 at 19:59:35ID: 25341463

SQL Server cannot parse '10:x:x' as a datetime value.  Try changing your input parameter to varchar(10) instead of datetime.

 

by: Nigel_TaylorPosted on 2009-09-16 at 04:36:57ID: 25344336

Hi Brandon,

I have tried changing the input parameter to varchar(10) but to no avail.

Regards,

Nigel

 

by: BrandonGalderisiPosted on 2009-09-16 at 05:07:03ID: 25344617

If you look at this article I wrote:

http://sqlservernation.com/blogs/howtos/archive/2009/03/05/changing-the-display-format-of-datetime-values.aspx

You will see that date format 114 is "14:01:23:123" (HH:MM:SS:ms) and you are passing in "10:21:54" (HH:MM:SS).  That is format code 24.

Try this.

ALTER PROCEDURE [dbo].[usp_PhoneCallCheck] 
        -- Add the parameters for the stored procedure here
        @Brand nvarchar(20),
        @TimeOfCall varchar(10)
AS
BEGIN
        -- SET NOCOUNT ON added to prevent extra result sets from
        -- interfering with SELECT statements.
        SET NOCOUNT ON;
 
        DECLARE @BrandId nvarchar(2)
        DECLARE @DRStatus int
        DECLARE @ReturnValue int
 
        set @ReturnValue = 0
 
        SELECT @BrandId = fldId FROM tblBrands where fldBrand = @Brand          -- Get the Brand ID based upon the name of the brand that was passed in
                
        -- Below check the time and day of the incoming call and see if it can match 
 
        If Exists(
                SELECT * FROM tblOpeningTimes Where
                fldBrandId = @BrandId 
                AND
                CONVERT(datetime,'2009/09/14 ' + @TimeOfCall, 120) BETWEEN fldOpeningTime AND fldClosingTime
                )
                AND
                Exists(
                SELECT * FROM tblOpenDays Where fldBrandId = @BrandID AND fldDayOfWeek = DateName(WeekDay,getdate())
                )
                set @ReturnValue = 2
        Else
                set @ReturnValue = 3
 
        -- Check the DR state and override if we are in a DR mode
 
        If @ReturnValue = 2
        Begin
                SELECT @DRStatus = fldStatus FROM tblDR where fldId = 1                         -- Get the DR status of the call center
 
                If @DRstatus = 1                                                                                                        -- If the DR status = 1 then we are closed and set the return value = 1
                        set @ReturnValue = 1
        End
        
        Return(@ReturnValue)
END
 
 
******************************************************************
******************************************************************
 
USE [CallControl]
GO
 
DECLARE @return_value int
 
EXEC    @return_value = [dbo].[usp_PhoneCallCheck]
                @Brand = N'Test Brand',
                @TimeOfCall = N'10:21:54'
 
SELECT  'Return Value' = @return_value
 
GO
 
*******************************************************************
*******************************************************************
 
Str_Connect = "Provider=SQLOLEDB.1;Persist Security Info=True;Initial Catalog=CallControl;Data Source=swyxsrv02\sqlexpress"
Set CnnSQL=CreateObject("ADODB.Connection")
CnnSQL.Open Str_Connect, "CallControl_User", "CallC0ntr0l"
 
 
  strSQL = "exec usp_PhoneCallCheck 'Test Brand','10:21:54' "
  CnnSQL.Execute(strSQL)
 
cnnSQL.Close
Set cnnSQL = Nothing

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:

Select allOpen in new window

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...