[x]
Posted via EE Mobile

Search, ask, and monitor your questions on the go with EE Mobile. Visit Experts Exchange from your mobile device and never be out of touch again.
Question
[x]
Attachment Details
[x]
The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

  • The Grade of the Solution
  • The Zone Rank of the Expert Providing the Solution
  • The Number of Author and Expert Comments
  • The Number of Experts Contributing
  • The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!
8.5

improve VBScript

Asked by resolver1 in VB Script, Scripting Languages

Help with the script.  Im looking at ways to improve the script, make it more readable, it works. Its the first time ive coded in 3 years and want to improve my practices. The aim of the script is to change permissions of files within website file locations so only certain users can access files.  

Heres what the script does:

The script gets the User Accounts (which is the folder name) and stores in an array

The array is then cycled (while loop) and the sub folders (which is the website) are stored in an array which stores the user account (the root sub folder) and the full path of the website

The 3rd loop cycles through the previous array and runs CACLS to assign permissions for the user account for that particular path.  

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:

'Ive created the script which will get the folder (user account) and the sub folder (website) 
Dim UserID 'stores user accounts (folder names) 
Dim nestedFolders 'stores the sub folder names (web sites) 
Dim strFullPath(100,1) ' stores the path of files and account numbers (which is also folder names)
dim IFullPath 'stores 
 
Set objFSO = CreateObject("Scripting.FileSystemObject") ' sets the file system object
objStartFolder = "C:\test" ' stores the starting folder
iCount = 0 'sets the count to 0
userID=ShowSubfolders(objFSO.GetFolder(objStartFolder)) ' stores the userID of each of the startFolders
IFullPath = 0 ' Searches sub folders 
 
' Searches sub folders
do until userID(icount) = ""
    Dim AppendCount ' counter for loop
    NestedFolders= ShowSubfolders (objFSO.GetFolder(objStartFolder & "\" & userID(icount))) ' displays nest subfolders
	AppendCount = 0 ' sets count to 0 
    do until NestedFolders(AppendCount) = ""
		strFullPath(iFullPath,0)= objStartFolder & "\" & userID(icount) & "\" & NestedFolders(AppendCount) ' concatanates folders 
		strFullPath(iFullPath,1)= userID(icount)
        AppendCount = AppendCount + 1 ' moves counter on one
		ifullPath=iFullPath + 1 ' Moves the counter on one
	LOOP
    icount = icount + 1 ' moves counter on one
loop
 
'loop through each of the folders and accounts stored in strFullPath 
Dim intCount ' counter for loop
intCount =0 ' sets counter to 0
do until strFullPath(intCount,0) = ""
	msgbox strFullPath(intcount,0) 
	msgbox strFullPath(intcount,1)
	msgbox "cacls " & strFullPath(intCount,0) & "\*.* /T /E /G staff\" & strFullPath(intcount,1) & ":F"
	run "cacls " & strFullPath(intCount,0) & "\*.* /T /E /G staff\" & strFullPath(intcount,1) & ":F"
	intCount=intCount +1 
 Loop
 
'searches location passed and returns array of sub folders
function ShowSubFolders(Folder)
    dim strFolders(100)
    Dim icount
    icount = 0
    For Each Subfolder in Folder.SubFolders
        'Wscript.Echo Subfolder.name
        strFolders(icount) = Subfolder.name
        icount =icount  + 1
    Next
    showSubfolders = strFolders
End function
 
'routine to run a program 
Sub Run(ByVal sFile)
	Dim shell
    Set shell = CreateObject("WScript.Shell")
    shell.Run sFile, 1, true
    Set shell = Nothing
End Sub
[+][-]10/07/09 03:57 AM, ID: 25513928Accepted Solution

View this solution now by starting your 30-day free trial. Setting up your free trial is quick, easy, and secure. We will return you to this solution, unlocked, when you're done.

About this solution

Zones: VB Script, Scripting Languages
Sign Up Now!
Solution Provided By: purplepomegranite
Participating Experts: 1
Solution Grade: A
 
[+][-]10/07/09 11:07 PM, ID: 25522618Author Comment

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 30-day free trial to view this Author Comment or ask the Experts your question.

 
 
Loading Advertisement...
20091111-EE-VQP-92 - Hierarchy / EE_QW_3_20080625