Question

Problem with a VB Macro

Asked by: garethmanuel

Hi there,
I have written this code (i have very basic knowledge of VB) to remove any items less than '100'
and it does not seem to remove anything.
have I written this completley wrong?
Please help

Sub go()
'
' go Macro
'
'
    Sheets("Sheet1").Select
    Cells.Select
    Selection.Copy
    Sheets("Sheet2").Select
    Application.Run "BLPLinkReset"
    Range("A1").Select
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
        :=False, Transpose:=False
    Range("A1").Select
    
      Dim i As Integer
 
  Range("C3").Select
 
    For i = 1 To 200
 
     If ActiveCell.Value > "100" Then
    
      Selection.Offset(1, 0).Select
  
    Else
    
    Selection.EntireRow.Delete
    
    End If
    
    Next i
 
    
    
End Sub

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-10-29 at 04:50:51ID24854209
Tags

Excel

,

VB

,

Macro

Topics

VB Script

,

VB Controls

,

Microsoft Applications

Participating Experts
2
Points
500
Comments
9

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. how to write a macro in VB
    1)How can I write a Macro in VB I mean like #DEFINE in [C] 2)can i load an operator (give a new meaning to an operator) Please add an example thanks Dvir.
  2. calling dll written in VB from JAVA
    Hi All, I'm new to JNI.I wann to call a dll written in VB from java.please guide me.
  3. VB DNS-less connection to a MySQL server
    I would like an excel 2000 worksheet to import data from a MySQL server. This worksheet is to be distributed to several places throughout the country, so I am not going to have much control over what obdc drivers different people may have. I would like to make it so that I ...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: jppintoPosted on 2009-10-29 at 05:02:08ID: 25692640

Sub remove_rows()
    Dim sh As Worksheet
    Set sh = ActiveSheet
    Dim cll As Range
    For Each sh In ActiveWorkbook.Sheets
        For Each cll In sh.UsedRange
           If cll.Value=100 Then
              cll.Select
              Selection.Delete Shift:=xlUp
           End If
        Next cll
    Next sh
End Sub

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:

Select allOpen in new window

 

by: byundtPosted on 2009-10-30 at 11:00:14ID: 25705375

When you are looping through a worksheet and deleting rows, it is better to work from the bottom up. Otherwise, your index counter gets off by one every time you delete a row.

You also need to remove the double quotes surrounding "100" in your If test, as also shown by jppinto.

Brad

Sub go()
 
' go Macro
    
    Dim i As Long
    Application.ScreenUpdating = False
    Application.Goto Sheets("Sheet2").Range("A1")
    Sheets("Sheet1").Cells.Copy
    'Application.Run "BLPLinkReset"
    ActiveCell.PasteSpecial Paste:=xlPasteValues
 
    For i = 203 To 3 Step -1
         If Cells(i, "C") < 100 Then Rows(i).EntireRow.Delete
    Next
    Application.ScreenUpdating = True
End Sub

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:

Select allOpen in new window

 

by: jppintoPosted on 2009-11-01 at 08:08:36ID: 25714153

Did you at least tryed my code?!?!

 

by: byundtPosted on 2009-11-01 at 08:31:04ID: 25714233

jppinto,
I looked at your code before posting, and noticed that:
1) It applied to every cell in the worksheet, not just C3:C203 as in Asker's original code. I realize that the question body implied deleting just the cell values, but felt the steps taken in the Asker's code were more illustrative of the Asker's intent.
2) It deleted only cell values that equalled 100, where the original code looked for values that were less than or equal 100. The question body confused matters somewhat by calling for deleting values less than 100.
3) It deleted just the cells, where the Asker's macro deleted the entire row
4) If you have a series of cells in a column that all have a value of 100, only the first, third, fifth, etc. will get deleted. This is because you didn't adjust the selection after deleting a cell. The preferred approach when deleting rows is to work from the bottom up, thereby avoiding the need to adjust the selection or loop index.

Brad

 

by: jppintoPosted on 2009-11-01 at 08:36:26ID: 25714254

Hello Brad,

No problem, but at least YOU gave me some feedback while the Author didn't say if my code was OK for what he wanted...

Regards,

jppinto

 

by: garethmanuelPosted on 2009-11-01 at 08:46:18ID: 25714292

A colleague of mine used my account to post this question while i was out of the office. He is new to EE and did not understand the etiquette used on this site. Agreed on Brad's comments. Thanks for both submissions.

 

by: jppintoPosted on 2009-11-01 at 08:51:06ID: 25714313

OK, no problem...

jppinto

 

by: byundtPosted on 2009-11-01 at 08:53:39ID: 25714324

João,
One of the benefits of trying to answer Experts-Exchange questions is improving your knowledge. I figure you will never again forget about looping from the bottom up when deleting cells or rows, so at least two people have been helped in this thread.

Putting on my Zone Advisor hat, I'm glad to see that you are participating in as many Excel questions as you are. Because many long-term experts reduce their site participation, we need to develop new experts on a continuing basis. Your contributions have been valuable and I hope that you continue to enjoy participating in EE threads in the future.

Brad

 

by: jppintoPosted on 2009-11-01 at 10:39:47ID: 25714799

Hello Brad,

Yes, it's true what you just said. When I started in EE, my primary target was win points to get up in ranks. With time I develop a passion to help others, as others had help me in the past here in EE. Helping others has made me try new things and learn a lot, specially with Excel. With the experience I have in EE I decided, one week ago, to start a "blog" where I can put some of the things that I've been learning here in the way that I can pass to others that knowledge. The link is below. Last month I spent a lot of my time here in EE, answered more that 100 questions and made 167,535 points. I'm proud in what I achieve and happy to see that I could help so many people. I will continue to be an active member of EE, at least whenever I have the time for this. Thanks a lot for your encouraging words.

Best regards,

João

http://excel-user.blogspot.com/

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...