Link to home
Start Free TrialLog in
Avatar of meverest
meverestFlag for Australia

asked on

whats wrong with this sockets function?

Hi folks,

this is just supposed to open a tcp connection to remote server:port and return the result of a string written to the remote.  if the server responds on connection (like if it is an smtp server banner etc) then it should also return that string as well:

CString DoComm(CString ServerName, long ServerPort, CString command)
{
      CSocketFile * sockFile = NULL;
      CSocket * sock = NULL;
      CString Response = "Bombed";

      try
      {
            char *BufPtr  = NULL;                // Error message buffer.
            int   MsgLen  = 0;                      // Error message length.
            DWORD Errnum;

//            printf("login1\n");

            CString OutputBuff;

//            char readBuf[256];

            UINT rc;

            CSocket sockCli;

            rc = sockCli.Create( );

            Errnum = GetLastError();

            rc = sockCli.Connect(ServerName, ServerPort);

            sockFile = new CSocketFile(&sockCli);

            char buf[256];

            while( rc=sockFile->Read(buf, 255) )
            {
                  buf[rc] = NULL;
//                  Buf = buf;
                  Response = Response + buf;
                  if ( rc < 255 ) break;
            }

            if( command != "")
            {
                  Response = Response + "\r\n";
                  OutputBuff.Format("%s\r\n", command);

                  sockFile->Write(OutputBuff, OutputBuff.GetLength( ) );

                  char buf[256];

                  while( rc=sockFile->Read(buf, 255) )
                  {
                        buf[rc] = NULL;
//                        Buf = buf;
                        Response = Response + buf;
                        if ( rc < 255 ) break;
                  }
            }

//            Response = Response + "!!!";

            return(Response);
      }
      catch ( ... )
      {
            Response="Encountered Exception"+Response;
            return(Response);
      }
}
Avatar of meverest
meverest
Flag of Australia image

ASKER

oh, i should have said - it seems to just hang.  i suspect that it is stuck in one of those while() loops, but i can't see why it doesn't break out?

regards,  Mike.
Avatar of Mafalda
Mafalda

Did you try to change to the following ?

rc=sockFile->Read(buf, 255);
while (rc < 255 && rc > 0)
{
  buf[rc] = NULL;
  Response = Response + buf;
  rc=sockFile->Read(buf, 255);
}
 
Sorry ... it was a stupid remark ... to much to drink ;o)
But you might have a do-while loop  and exit if the chars read are smaller than 255

do
{
  rc=sockFile->Read(buf, 255);
  buf[rc] = NULL;
  Response = Response + buf;
}
while (rc == 255);

I hope this time I am right ...
ASKER CERTIFIED SOLUTION
Avatar of itsmeandnobodyelse
itsmeandnobodyelse
Flag of Germany image

Link to home
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Start Free Trial
Look your logic over again....   Do you really want to keep on reading until Read() returns zero?


If it's set to block, it's going to hang waiting for data.

If it's set to not-block, then depending on timing it might or might not find anything to read.

In either case, the code is wrong.

You may want to change to some loop that does a non-blocking read, and times out of that after a few seconds.

BTW I hope this isnt a net snooper.....   :)



>> BTW I hope this isnt a net snooper.....   :)

well, kind of - it's part of a server status monitor.  it will poll all my servers and make sure that the various services are up and responding as expected.

i suppose it could be used for evil instead of good, but i hadn't intended that! ;-)

itsme & mafalda, i'll try those out and get back.  thanks!

cheers.

Guys,

after some trial-&-error debugging, i discover that it's actually this like where it hangs:

rc = sockCli.Create( );

it makes me think - do i need to initialise the tcpip[ stack or something - when i used to do this sort of stuff in old ansi C, i had to init the tcpip.  i'm doing nothing like that with this code - should I? how?

thanks & regards,  Mike.
I had a similar problem some years ago where i tried to connect to an Oracle database server. Locally all works fine but remote  access didn't work. It turned out that the system had chosen wrong network card where the IP mask didn't match to the IP address of the remote server.

If remote server had a firewall it could prevent using specific ports or nodes. Maybe you should use a sniffer like Microsoft Network Monitor, EthReal, or others  and check what happens. Did you get the error code returned?

Regards, Alex

Thanks for the suggestion (sorry for my late response - i didn't see the notification for some reason)

That wouldn't be the problem in this case - i have only one interface on both ends, and there's no firewall.

In fact telnets to the relevent ports work fine, just that my program hangs every time :(

cheers,  Mike.
as i suspected, i had not called WSAStartup()

duh!

i'll split points: most to itsme& and some to mafalda for your useful comments.  thanks.
that's funny - i thought we could split points from the interface these days.  never mind, points to itsme& - mafalda look for free Q for you.
oh - mafalda, tell me what topic area you watch most?
Hi meverest,
C++
Thanks.