Question

MFC radio button - simple question

Asked by: jimstar

I need to have three radio buttons and get the ID of the one selected upon the user clicking OK. I've read that I need to group the three radio buttons together and create a member variable, which will then have an integer value equal to the ID number of the radio button.

However, even though I added three radio buttons, when I right click on the radio button & create a variable, the window that appears defaults to IDCANCEL (my cancel button's ID) and won't let me create a variable for IDC_RADIO1.

Can someone tell me what I need to do, to ensure that (1) the radio buttons are grouped properly, and (2) that I can identify which one is selected?

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2007-04-22 at 17:22:06ID22526940
Tags

mfc

,

radio

,

button

Topic

Windows MFC Programming

Participating Experts
4
Points
250
Comments
13

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Simple radio button question
    All i have is three radio buttons in a dialog box.. how do i figure out which one was selected after the user presses OK?
  2. Disable Button and Radio in MFC
    In MFC, how can I enable and disable a button and a Radio?
  3. Checkbox and radio button
    I would like to know the name of MFC class thats responsible for checkbox and radio button. Thanks
  4. RADIO BUTTON
    Surname: Anderson Indicate Surname Initials Telephone No Division Branch Room Number Anderson Dr D 55535 AFE AFE F9 Anderson Mr J 55286 APS Z Post Grad Lab F35 Anderson Ms L 55319 FS M Food Pres Lab F20 Anderson Dr R 55347/55520 AES C Agri-Envir Grp ...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: jimstarPosted on 2007-04-22 at 17:29:04ID: 18955585

I changed the GROUP property on all three radio buttons to true and it allowed me to select Value for the variable type... seems to be closer than I got before to creating a variable.

However, now it only lets me create a BOOL, not an int. Additionally, when I run the dialog, it doesn't properly de-select the previously selected radio button when selecting a new one, whereas when I had GROUP set to false on all three radio buttons the selection/deselection worked fine across all three buttons.

 

by: PriyeshPosted on 2007-04-22 at 22:33:40ID: 18956408

For the first radio button in group, change the group property to true and tabstop to true. For the rest of the radio buttons in the group (the 2 others in your case) set both group and tabstop to false. Now create a variable for the first radio button and you will get an integer type. Also the selection should work correctly.

 

by: haroldxiousPosted on 2007-04-22 at 22:49:19ID: 18956438

i  didnt get your problem...but ive tried some codes..


ive made a new MFC dialog application(SampleApp), and then on that application ive added 3 radio buttons..
radio1 - the id is IDC_RADIO1
radio2 - the id is IDC_RADIO2
radio3 - the id is IDC_RADIO3

then on the properties of IDC_RADIO1 check the group checkbox, and dont check the group checkbox on the other radio button

then i declare it on the applications .h (SampleAppDlg.h)
CButton m_Radio1;
CButton m_Radio2;
CButton m_Radio3;

then put it on the void CSampleAppDlg::DoDataExchange(CDataExchange* pDX) function
DDX_Control(pDX, IDC_RADIO1, m_Radio1);
DDX_Control(pDX, IDC_RADIO2, m_Radio2);
DDX_Control(pDX, IDC_RADIO3, m_Radio3);

if(m_Radio1.GetCheck() == 1){
   int id = m_Radio1.GetDlgCtrlID();
}
if(m_Radio2.GetCheck() == 1){
   int id = m_Radio2.GetDlgCtrlID();
}
if(m_Radio3.GetCheck() == 1){
   int id = m_Radio3.GetDlgCtrlID();
}

i dont know if this is exactly what you need

 

by: AndyAinscowPosted on 2007-04-22 at 23:04:33ID: 18956477

In addition to Priyesh you also need the NEXT control in the tab order to have the group property set to true.  (I typically use a border/box for that)

 

by: jaime_olivaresPosted on 2007-04-23 at 05:54:07ID: 18958013

As a simple alternative, you can use this solutions which uses a ListBox but with appearance of radio buttons:
http://www.codeproject.com/combobox/RadioListBox.asp

 

by: jimstarPosted on 2007-04-26 at 17:37:05ID: 18986207

As Priyesh suggested, I set the GROUP and TABSTOP property to "true" for IDC_RADIO1, and both of those to "false" for IDC_RADIO2 and IDC_RADIO3. I right clicked on IDC_RADIO1 and created a variable (only AFTER unchecking "control variable" was I able to get "int" type available). The integer I created was m_reportType.

The results:
IDC_RADIO1 and IDC_RADIO2 both select/deselect properly, but IDC_RADIO3 appears to be part of a different group as it remains selected once I click on it (it operates independently of IDC_RADIO1 and IDC_RADIO2).

Also, the code below doesn't produce any message boxes, so it appears that the integer variable isn't getting set properly.

void CDialogName::OnBnClickedOk()
{
      if(this->m_reportType == 1)
            MessageBox(L"comp");
      if(this->m_reportType == 2)
            MessageBox(L"prog");
      if(this->m_reportType == 3)
            MessageBox(L"cust");

      OnOK();
}

I'm wondering if AndyAinscow's suggestion could solve this... but I'm not sure how to determine what control is the next one in the taborder... so I don't know how to figure out which one should have GROUP set to "true".

 

by: jimstarPosted on 2007-04-26 at 17:54:46ID: 18986269

In looking at haroldxious' suggestion, it seems like the code haroldxious provided does what MFC should do automatically. I was under the impression that by creating an integer variable in MFC, I could reference the variable in the OK event handler without needing to check each radio button's status.

 

by: PriyeshPosted on 2007-04-26 at 20:39:13ID: 18986685

Jim
Along with that, turn the tab order on in your dialog editor and make sure that the three radio buttons are in consecutive tab order. That's all i can think about and you shouldnt have to add any code normally to get the expected mutually exclusive button states.

 

by: jimstarPosted on 2007-04-26 at 21:13:37ID: 18986758

The mutually exclusive button states now work fine (I was able to find the tab order view finally and correct the misorder). However, it still always gives me zero (0) when I check the integer m_reportType in the OK button event handler, regardless of which radio button is selected.

I ripped out the m_reportType variable and re-inserted it... here are the steps I used:

1. In the Dialog Editor, select IDC_RADIO1.
2. Right click and select Add Variable.
3. Uncheck "control variable".
4. Select "int" from the dropdown list under Variable Type.
5. Name the variable "m_reportType".
6. Click finish.

Now, it's my understanding that when I reference this->m_reportType from the Ok button handler, it will return an integer representing the radio button ID that is selected. Or, am I missing a step?

Here's the code I have checking the variable from the button handler... and sure enough, regardless of which radio button is selected, every time it prints "zero detected" meaning that the member variable I added has a zero value.

void CDialogName::OnBnClickedOk()
{
      if(this->m_reportType == 0) MessageBox(L"zero detected.");
      OnOK();
}

 

by: PriyeshPosted on 2007-04-26 at 21:16:54ID: 18986773

Jim,
Almost there - see the following change.

void CDialogName::OnBnClickedOk()
{
      UpdateData(TRUE) ;//This transfers the control value to member var
      if(this->m_reportType == 0) MessageBox(L"zero detected.");
      OnOK();
}

 

by: jimstarPosted on 2007-04-26 at 21:26:54ID: 18986802

I added the UpdateData(TRUE) line, but it still gives me a zero regardless of which radio button is selected. Any other suggestions to try?

 

by: PriyeshPosted on 2007-04-26 at 21:56:42ID: 18986884

Jim,

Check your DoDataExchange function and see if it has a line like the following.

      DDX_Radio(pDX, IDC_RADIO1, m_reportType ) ;
If not, add it. There is a chance the wizard didnt do this.

 

by: jimstarPosted on 2007-04-26 at 22:01:54ID: 18986898

That did the trick. Thank you!

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...