Question

Need to disable PopUp Menu items

Asked by: GlennBrand

I need to disable the menu items that are not applicable at various places in the application.
The command messages are not being routed through the OnUpdate handlers.
I have looked at a few issues that talk about this. For example using "this" on the following does not work:
pPopup->TrackPopupMenu(TPM_LEFTALIGN | TPM_RIGHTBUTTON, point.x, point.y, this);
Attaching it to the mainframe does something but still not going through the handlers

void CEHRTreeCtrl::OnUpdatePopupPopulatenormalcase(CCmdUI* pCmdUI) 
{
	if (m_bWorkFlowTree || !IsPatientData())
		pCmdUI->Enable(false);
	else
		pCmdUI->Enable(true);
}
 
void CEHRTreeCtrl::OnContextMenu(CWnd*, CPoint point)
{
 
	// CG: This block was added by the Pop-up Menu component
	{
		if (point.x == -1 && point.y == -1){
			//keystroke invocation
			CRect rect;
			GetClientRect(rect);
			ClientToScreen(rect);
 
			point = rect.TopLeft();
			point.Offset(5, 5);
		}
 
		CMenu menu;
		VERIFY(menu.LoadMenu(CG_IDR_POPUP_EHRDECISION_TREE));
 
		CMenu* pPopup = menu.GetSubMenu(0);
		ASSERT(pPopup != NULL);
		CWnd* pWndPopupOwner = this;
 
		// this sets it for all menu items
		m_bHasChildren = IsNodeChildrenOnDemand();
		if(!m_bHasChildren)
		{
			pPopup->ModifyMenu( ID_EDIT_COPY, MF_BYCOMMAND, ID_EDIT_COPY, _T("&Copy Selected Item") );
			pPopup->ModifyMenu( ID_EDIT_CUT, MF_BYCOMMAND, ID_EDIT_CUT, _T("&Cut Selected Item") );
			CString strMenuItem = _T("&Delete Selected Item");
			if (GetSelectedCount() > 0)
			{
				 strMenuItem += _T("s");
			}
			pPopup->ModifyMenu( ID_EDIT_DELETE, MF_BYCOMMAND, ID_EDIT_DELETE, strMenuItem );
			pPopup->ModifyMenu( ID_EDIT_FIND, MF_BYCOMMAND, ID_EDIT_FIND, _T("&Find Item or Sub Tree") );
			pPopup->ModifyMenu( ID_EDIT_PASTE, MF_BYCOMMAND, ID_EDIT_PASTE, _T("&Paste Selected Item") );
		}
		
		pPopup->ModifyMenu( ID_POPUP_INSERTSUBTREE, MF_BYCOMMAND, ID_POPUP_INSERTSUBTREE, _T("&Insert Items After Selected Item") );
		
		if (!IsNodeManagementTree())
		{
			pPopup->DeleteMenu(ID_POPUP_ATTACHNODESTOSELECTEDFORM, MF_BYCOMMAND);
		}
		else if (IsFormManagementTree() || IsReportManagementTree())
		{
			pPopup->ModifyMenu( ID_POPUP_ADDSUBTREE, MF_BYCOMMAND, ID_POPUP_ADDSUBTREE, _T("&Add Multiple New Nodes") );
		}
		CWnd* pWnd = GetParent()->GetParent()->GetParent();
		pPopup->TrackPopupMenu(TPM_LEFTALIGN | TPM_RIGHTBUTTON, point.x, point.y,
			this);
	}
}

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-04-25 at 17:16:45ID24355548
Tags

MFC

Topics

Windows MFC Programming

,

Microsoft Visual C++

Participating Experts
2
Points
500
Comments
9

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Measure a Popup menu
    I am trying to measure the width and height of my Popup menu. I am trying the following code, but with no success. It does not give me an error but the values of Width and Height are wrong. void CPopUpMenuView::OnContextMenu(CWnd* pWnd, CPoint point) { // TODO: Add your me...
  2. Popup menu problems
    We have a problem with a popup menu in Visual C++ 6.0. We create it with the source shown below. It is a menu that appears when right clicking an element in a CListBox. The elements in the menu are not drawn - instead only a narrow vertical band is shown. Any ideas? CMen...
  3. How to get Popup menu item selected?
    How do know what menu item was selected when you have a popup menu? I made a msg map with the menu ID but it does not seem to catch it. Thanks, jer HMENU hMenu; CMenu mMenu; // Graph popup menu // Get the menu for the popup from the resource file mMenu.Load...
  4. Trouble with popup menu
    I use the code below to popup a menu i have, however, only the very left side of it shows, about 10 pixels in width. Is there something Im doing worng on my menu? Thanks, jer HMENU hMenu; // Menu Handle CMenu mMenu; // Graph popup menu // Get the menu for the popup...
  5. Popup menu hidding problem !
    when I right click on my tray icon, a popup menu appears. The problem is that when I click outside the menu, the menu is not killed. How can I make the menu to be killed when I click outiside the menu ? Here's the code : LRESULT CWindowHandlePickerDlg::OnNotifyTaskBarIcon(...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: DanRollinsPosted on 2009-04-25 at 18:08:39ID: 24234128

Have you seen this article:
  When Update Handlers Are Called
   http://msdn.microsoft.com/en-us/library/essk9ab2.aspx

I can't tell from your code, but... there has to be an ON_UPDATE_COMMAND_UI entry and (this is the most common oversight) there must also be an  ON_COMMAND entry somewhere with the same command ID

Also, command UI is usually in the MainFrame, so that's what you will typically used as the owning window in the TrackPopupMenu call

 

by: alb66Posted on 2009-04-26 at 00:52:22ID: 24235015

Instead of

                CWnd* pWnd = GetParent()->GetParent()->GetParent();
                pPopup->TrackPopupMenu(TPM_LEFTALIGN | TPM_RIGHTBUTTON, point.x, point.y,
                        this);

try to use

                CWnd* pWnd = GetParentFrame();
                pPopup->TrackPopupMenu(TPM_LEFTALIGN | TPM_RIGHTBUTTON, point.x, point.y,
                        pWnd);

See GetParentFrame details at
http://msdn.microsoft.com/en-us/library/6f45sskz.aspx

 

by: GlennBrandPosted on 2009-04-26 at 14:03:05ID: 24237595

I tried that and a frame window is returned but when I use it all the menu items are greyed out meaning that it can't find the message handlers that are working now in the tree. The frame window is to the property dialog box that contains the tree.

My question is why can it find all the message handlers for the messages them selles but not on the OnUpdate messages. It doesn't make sense.

Is there a way to redirect whatever messages to the tree itself?

 

by: DanRollinsPosted on 2009-04-26 at 15:38:40ID: 24237914

What you describe is symptomatic of having an ON_UPDATE_COMMAND_UI entry and no ON_COMMAND entry (see the article I cited, above).  

I suggest using Spy++ and watch for the WN_INITMENUPOPUP message.  A CFrameWnd-derived object should get that message and do the command U/I enabling.

 

by: GlennBrandPosted on 2009-04-26 at 15:55:35ID: 24237979

Yes I had one for each one. To no avail. Even tried redirecting the message to the tree itself but no luck.
I finally found another solution.
I had to do what I did in the OnContextMenu in the code snippet attached.
Thanks for trying. I know this is a problem for many people.

		if (IsFormManagementTree() || IsReportManagementTree() || m_bWorkFlowTree)
		{
			pPopup->EnableMenuItem(ID_POPUP_POPULATENORMALCASE, MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
			pPopup->EnableMenuItem(ID_POPUP_MOVESUBTREE, MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
			pPopup->EnableMenuItem(ID_EDIT_CUT, MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
		}
		if (m_bWorkFlowTree || IsDecisionTree())
		{
			pPopup->EnableMenuItem(ID_POPUP_ADDSUBTREE, MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
			pPopup->EnableMenuItem(ID_POPUP_INSERTSUBTREEBEFORE, MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
			pPopup->EnableMenuItem(ID_POPUP_INSERTSUBTREE, MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
			pPopup->EnableMenuItem(ID_POPUP_SHOWEDITOR, MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
			pPopup->EnableMenuItem(ID_POPUP_SHOWSCRIPTEDITOR, MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
		}
		if (!m_bWorkFlowTree && IsDecisionTree())
		{
			pPopup->EnableMenuItem(ID_POPUP_MODIFYITEMPROPERTIES, MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
			pPopup->EnableMenuItem(ID_POPUP_EDITITEMTEXT, MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
			pPopup->EnableMenuItem(ID_EDIT_CUT, MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
			pPopup->EnableMenuItem(ID_EDIT_COPY, MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
			pPopup->EnableMenuItem(ID_EDIT_DELETE, MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
			pPopup->EnableMenuItem(ID_POPUP_MOVESUBTREE, MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
			pPopup->EnableMenuItem(ID_EDIT_PASTE, MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
			pPopup->EnableMenuItem(ID_POPUP_PASTEBEFORESUBTREE, MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
			pPopup->EnableMenuItem(ID_POPUP_PASTEAFTERSUBTREE, MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
		}
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:

Select allOpen in new window

 

by: DanRollinsPosted on 2009-04-27 at 14:04:49ID: 24245656

For what it's worth:
I just looked at the source code for an old SDI project of mine.  It pops up a context menu when clicking on an item in a CTreeView-derived pane.  The enabling is done in the ON_UPDATE_COMMAND_UI handlers, and items are correctly enabled or disabled according to the specific context at the time of the pop up.

All I can say is that it does work as advertised in the MFC documentation.  I use:

  AfxGetApp()->m_pMainWnd

as the CWnd pointer in the fourth parameter in the TrackPopupMenu call (it is the pointer to my CFrameWnd-derived object.  In that module, CMainFrame, I have message map entries for both ON_COMMAND and ON_UPDATE_COMMAND_UI for each item in the popup menu.

My code in the CTreeView-derived object looks almost identical to yours (before you added the manual enabling).  All I can suggest is that you examine the actual values of constants such as ID_POPUP_MOVESUBTREE and see if they are unique (examine your resource.h file).  Also, each of my menu item command IDs is higher than 1000 (I vaguely recall that there was an issue with context help or something).  If you are not using CView- and CFrameWnd-derived objects, that might also affect the behavior.

In my case, the MainFrame gets a WM_INITMENUPOPUP message and breakpoints in the updateUI handlers immediately get hit.

 

by: GlennBrandPosted on 2009-04-27 at 15:09:29ID: 24246129

I tried using the main frame also. The menu changed completely with many greyed out options and some enabled functions. It was as if the main frame had other items it found with similar ID values. IN this case the tree is in a DLL so it is possible that some of the IDs are the same as in the main app.
But more importantly is it customary to use the main window then?
What is happening and how should I setup my handlers. None of the handlers seem to have been called in the tree class itself which currently works the way I coded it.

 

by: DanRollinsPosted on 2009-04-27 at 20:38:01ID: 24247411

It is the code in
   CFrameWnd::OnInitMenuPopup(...)
that cycles through the menu and calls the OnUpdateXxxx for each item.

CWnd::OnInitMenuPopup() is not a virtual function, so you can't override it in your view- or control- derived class object.

You can add a handler for WM_INITMENUPOPUP in some other window (such as your tree control).  It could be menu-specific (rather than generalized as is the one in CFrameWnd).  But it's lots more work, in that you need to decode the message parameters, walk the menu tree, etc.

So yes... it is customary (if not required) to put command handlers, and UI update handlers  in the main frame.   If doing so casues other menu items to be disabled unexpectedly, then you need to add command handlers and ui update handlers for them.

 

by: GlennBrandPosted on 2009-04-27 at 21:38:53ID: 31574587

My solution is the only other way from what I can tell besides what DanRollins writes.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...