Question

Comparing two sets of data in MS Excel using VBA

Asked by: Navgod

Hi,

I have a piece of code which compares data in two columns O and G.

For all data in Column O where it does not match Column G it changes the cel value to "DELETED"

Here is the code:

Sub UpdateDeleted()
Dim cel As Range, rngFound As Range
'Compare and flag off deleted pipes
For Each cel In Range("O14", Range("O14").End(xlDown))
Set rngFound = Nothing
Set rngFound = Range("G:F").Find(what:=cel.Value, LookIn:=xlValues, LookAt:=xlWhole)
If rngFound Is Nothing Then
cel.Value = "DELETED"
Else
End If
Next
End Sub

I am now trying to add an extra check whereby if the data in column G is not equal to O, it checks if the cel value is "ISSUED CANCELLED". If yes then it does not change the cel value of column O to "DELETED"

I am finding it hard to extract the cel value from the following line for column G to add this check.

Set rngFound = Range("G:F").Find(what:=cel.Value, LookIn:=xlValues, LookAt:=xlWhole)

I can ofcose just write an entire different loop to make it work but i am trying to avoid this so that i can embed it within this piece of code which loops through all the data in the two columns.

Please help.

Thanks,

Nav

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2008-01-16 at 05:43:32ID23086832
Tags

excel

,

two

,

vba

,

compare

,

columns

Topic

Microsoft Excel Spreadsheet Software

Participating Experts
2
Points
500
Comments
11

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Comparing Workbooks
    OK. I have a list that i need compared to multiple workbooks to find matching names. How can I do this?
  2. End(xlDown) without Selection
    Is there a way to use the End(xlDown) property without using selection in VBA code? I have this code: set ws = Sheets(1) ws.Range(ws.Range("A1"),ws.Range("A1").End(xlDown)).Value = 0 What it does is sets EVERY cell to 0, all the way down to A65536 even ...
  3. Converting cel formulas to cel values in a range.
    The sub below works great until I get to "cel.Formula = cel.Value", where i get an "Object variable or with block variable not set" error. Please correct. Thanks! John Sub FixThisWeek() Dim Row As Long Dim dt As Range Dim rng As Range Dim cel As Range S...
  4. Excel VBA Poor Code
    This is a long one. I have this code to reorganize excel worksheets. Let me say that I am new to VBA and much of the snipets have been written by you experts. I am very grateful to you all. However, there are bits and pieces that I wrote. I used the select command and ha...
  5. Excel VBA End xldown command
    I am using the End xldown command to activate a range. I first search for text in a cell, the header, and then offset down one row to get to the first cell in the range I want to activate. My problem arises in situations where there is only one row under the header that I w...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: roryaPosted on 2008-01-16 at 05:46:50ID: 20671682

Do you mean this:

Sub UpdateDeleted()
   Dim cel As Range, rngFound As Range
   'Compare and flag off deleted pipes
   For Each cel In Range("O14", Range("O14").End(xlDown))
      Set rngFound = Nothing
      Set rngFound = Range("G:F").Find(what:=cel.Value, LookIn:=xlValues, LookAt:=xlWhole)
      If rngFound Is Nothing Then
         If cel.Value <> "ISSUED CANCELLED" Then cel.Value = "DELETED"
      Else
      End If
   Next cel
End Sub

Regards,
Rory

 

by: saurabh726Posted on 2008-01-16 at 05:49:34ID: 20671706

Well do u meant this...

Sub Compare()
Dim a As Long

Range("O1").Select
a = 1
Do Until a > Cells(65536, "O").End(xlUp).Row
If (ActiveCell.Value <> ActiveCell.Offset(0, -8).Value) Then
ActiveCell.Value = "DELETED"
ActiveCell.Offset(1, 0).Select
a = a + 1
Else
ActiveCell.Offset(1, 0).Select
a = a + 1
End If
Loop

End Sub

Saurabh...

 

by: NavgodPosted on 2008-01-16 at 05:49:57ID: 20671708

Hi Rory,

No that is the opposite.

I want it to check if the cel value of column G is "ISSUED CANCELLED"

therefore the value would come from the find within the line below:

Range("G:F").Find(what:=cel.Value, LookIn:=xlValues, LookAt:=xlWhole)

I hope this helps,

Nav

 

by: NavgodPosted on 2008-01-16 at 05:52:18ID: 20671734

Hi Saurab,

I cannot use Offsets as the data in both columns is not order and can vary.

Thats why the Find works well in my case.

thanks,

Naval

 

by: saurabh726Posted on 2008-01-16 at 05:52:32ID: 20671738

Do this...this will do the trick for u...100%

Sub Compare()
Dim a As Long

Range("O1").Select
a = 1
Do Until a > Cells(65536, "O").End(xlUp).Row
If (ActiveCell.Value <> ActiveCell.Offset(0, -8).Value) Then
If (ActiveCell.Offset(0, -8).Value = "ISSUED CANCELLED") Then
ActiveCell.Offset(1, 0).Select
a = a + 1
Else
ActiveCell.Value = "DELETED"
ActiveCell.Offset(1, 0).Select
a = a + 1
Else
ActiveCell.Offset(1, 0).Select
a = a + 1
End If
Loop

End Sub

Saurabh

 

by: roryaPosted on 2008-01-16 at 05:56:09ID: 20671763

I don't get it - you're searching G as well, so if G is "ISSUED CANCELLED", then so is O? Or does it only apply if the value is found in F and the corresponding G value is "ISSUED CANCELLED"?

 

by: NavgodPosted on 2008-01-16 at 06:07:08ID: 20671876

Rory,

Sorry for the confusion, i have just realised that what i am trying to achieve is not possible as to how the range.find works.

I am now having to use an extra unique column to column O to make the second check.

Here goes...

First check, If cel.value in Column O is not found anywhere in column G then
second check, If cel.offset(0,-1).value is found in column F then cel.value for column O = cel.value for column F.offset(0,1).
else
....

I am not sure we can do this in the same loop.

Waht do you  think?

 

by: roryaPosted on 2008-01-16 at 06:24:39ID: 20672098

Um, do you mean this:

Sub UpdateDeleted()
   Dim cel As Range, rngFound As Range
   'Compare and flag off deleted pipes
   For Each cel In Range("O14", Range("O14").End(xlDown))
      Set rngFound = Nothing
      Set rngFound = Range("G:G").Find(what:=cel.Value, LookIn:=xlValues, LookAt:=xlWhole)
      If rngFound Is Nothing Then
         Set rngFound = Range("F:F").Find(what:=cel.Offset(0, -1).Value, LookIn:=xlValues, LookAt:=xlWhole)
            If Not rngFound Is Nothing Then
               cel.Value rngFound.Offset(0, 1).Value
            Else
               '...
            End If
      Else
         '
      End If
   Next cel
End Sub

If not, I'm lost! :)
Rory

 

by: NavgodPosted on 2008-01-16 at 06:42:05ID: 20672244

Hi Rory,

Sorry you are lost :)

No probs i got it to work as follows:

Sub UpdateDeleted()
Dim cel As Range, celx As Range, rngFound As Range
Dim shtNUM As String
'Compare and flag off deleted pipes
For Each cel In Range("O14", Range("O14").End(xlDown))
Set rngFound = Nothing
Set rngFound = Range("G:F").Find(what:=cel.Value, LookIn:=xlValues, LookAt:=xlWhole)
'Check if found or not?
If rngFound Is Nothing Then
'Now check if line does exist using Sheet Number
For Each celx In Range("C14", Range("C14").End(xlDown))

'Correct the string length
shtNUM = celx.Value
If Len(shtNUM) = 2 Then
shtNUM = "0" & shtNUM
End If
   
If Len(shtNUM) = 1 Then
shtNUM = "00" & shtNUM
End If

If shtNUM = cel.Offset(0, -4).Value Then
'If exists then copy pipe name over
cel.Value = celx.Offset(0, 4).Value
Exit For
End If
Next

'Now check again and if not found then flag off as deleted.
Set rngFound = Range("G:F").Find(what:=cel.Value, LookIn:=xlValues, LookAt:=xlWhole)
If rngFound Is Nothing Then
cel.Value = "DELETED"
End If
End If
Next
End Sub

There might be ways to shorten the code but this works fine at the moment.

Once again thanks for coming to my rescue. Appreciated.

Regards,

Naval

 

by: roryaPosted on 2008-01-16 at 06:46:22ID: 20672277

I confess I don't see how that bears any relation at all to what you said! Where did column C come into it?

 

by: NavgodPosted on 2008-01-16 at 06:48:00ID: 20672295

Sorry when i spoke about column F the data in my spreadsheet i was refering to was actually in column C. My mistake.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...