Question

Excel Macro help

Asked by: JAYRU

The  script way below labeled Previous question works great from a previous question i had.  Now i want the "for loop" to check for records that don't match rather than the ones that do.   I cannot get it to work correctly. I changed the for loop to read this:
________________________________
For i = 1 To RowsA
    For j = 1 To RowsB
        If ws1.Cells(i, 1) <> ws2.Cells(j, 1) Then
            ws2.Rows(i).EntireRow.Copy ws3.Cells(counter, 1)
            counter = counter + 1
_______________________________
Changing the for loop does pull the right information over to ws3 but multiple times.  All i want it to do is when it does the search and does not find a match to put the information from ws2 to ws3 for that row one time.

Previous question:
I'm not sure exactly how to ask this question but i'll give it a try.  Below is a script to search a sheet using criteria on another sheet and then putting the result set on a third sheet.  All works great thanks to the help of some EE people. However i need to add something and can't figure it out.  On the search criteria sheet in column "c" is a alpha character. its either B,H, OR N.  When the macro runs and finds a row that meets its search criteria i need the alpha character that was in column "c" of the searchcriteria sheet to be put in a fourth column on the results sheet coresponding to the match it found.


Sub CompareSheets2()
Dim ws1, ws2 As Worksheet
Dim RowsA, i, counter As Long

Set ws1 = Sheets("SampleData") ' your sample data sheet
Set ws2 = Sheets("Search criteria") ' your sheetname
Set ws3 = Sheets("Results") ' your sheetname

Application.ScreenUpdating = False
Application.Calculation = xlCalculationManual
RowsA = ws1.Cells(Rows.Count, 1).End(xlUp).Row
RowsB = ws2.Cells(Rows.Count, 1).End(xlUp).Row
counter = 1

'copy values
For i = 1 To RowsA
    For j = 1 To RowsB
        If ws1.Cells(i, 1) = ws2.Cells(j, 1) Then
            ws1.Rows(i).EntireRow.Copy ws3.Cells(counter, 1)
            counter = counter + 1
        End If
    Next j
    j = 1
Next i
Application.ScreenUpdating = True
Application.Calculation = xlCalculationAutomatic

End Sub

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2008-01-16 at 12:30:30ID23088301
Tags

Microsoft

,

Office

,

2003

,

excel

Topic

Microsoft Excel Spreadsheet Software

Participating Experts
1
Points
250
Comments
8

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. MACRO HELP
    I'm not sure exactly how to ask this question but i'll give it a try. Below is a script to search a sheet using criteria on another sheet and then putting the result set on a third sheet. All works great thanks to the help of some EE people. However i need to add something ...
  2. Excel VBA Macro
    Dear All, Here is the issue: I am attaching the spreadsheet with the macro. But the macro only works for the first line (line 6). I would like someone to help me with the macro that would not only for the first line 6 but work for as long as there is no empty line. I woul...
  3. run excel macro on multiple worksheets
    Hi, So I have some excel data that I need to plot on several worksheets, and they all are of the same format. I made a macro to graph the data on the first worksheet, but when I click on the next worksheet and run the macro it just creates a graph from the first worksheet a...
  4. Excel Macro
    My OS is Win Exp Prof, and my Excel is 2007. I have created the following macro which was from the help from this forum, but somehow it is not copying. What it does is it copies all the rows where the Column H is not colored. I place the cursor at the bottom of the spreads...
  5. Excel Macro
    My OS is win exp prof. I use Excel 2007. in Col 5, the data is about the different departments. Eg. KLN, MPIB, EXT, When I position my cursor at the end of the data list, and hit a macro, I would like to start from the top of this column, and then count the number of dept...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: spattewarPosted on 2008-01-16 at 12:34:52ID: 20675795

can you try this

For i = 1 To RowsA
    For j = 1 To RowsB
        If ws1.Cells(i, 1) <> ws2.Cells(j, 1) Then
            ws1.Rows(i).EntireRow.Copy ws3.Cells(counter, 1)
            counter = counter + 1
            Exit For
        End If
    Next j
    j = 1
Next i

 

by: JAYRUPosted on 2008-01-16 at 12:48:55ID: 20675931

Spattewar,
No that does not work.  Thats bringing data from ws1 to ws3.  If no match i need ws2 to go to ws3.  Changing the if statement to this did not work either:
If ws1.Cells(i, 1) <> ws2.Cells(j, 1) Then
            ws2.Rows(i).EntireRow.Copy ws3.Cells(counter, 1)
            counter = counter + 1


 

by: spattewarPosted on 2008-01-16 at 12:51:18ID: 20675961

should it be

If ws1.Cells(i, 1) <> ws2.Cells(j, 1) Then
            ws2.Rows(j).EntireRow.Copy ws3.Cells(counter, 1)
            counter = counter + 1

instead of i I have used j in the copy statement. try this out

 

by: JAYRUPosted on 2008-01-16 at 13:02:48ID: 20676092

I have done that as well and it does bring the right data but multiple times.  Wont be on till later tonight thanks for helping me....
Here is sample data that is in ws1:
A      B      C      D
1      CAT      1000      2000
2      DOG      3000      4000
3      BIRD      5000      6000
____________________________________
here is search data on ws2
9      beaver      bear
11      log      branch
______________________________
Here is the result in ws3
9      beaver      bear
11      log      branch
9      beaver      bear
11      log      branch
9      beaver      bear
11      log      branch
9      beaver      bear
11      log      branc
__________________________
Result should be:
9      beaver      bear
11      log      branch

Hope this helps.  That was using this code:
For i = 1 To RowsA
    For j = 1 To RowsB
        If ws1.Cells(i, 1) <> ws2.Cells(j, 1) Then
            ws2.Rows(j).EntireRow.Copy ws3.Cells(counter, 1)

            counter = counter + 1
        End If
    Next j
    j = 1
Next i
Application.ScreenUpdating = True
Application.Calculation = xlCalculationAutomatic

 

by: JAYRUPosted on 2008-01-18 at 10:25:35ID: 20692826

Bonus points of 50 more.  Anyone any ideas

 

by: spattewarPosted on 2008-01-18 at 10:33:49ID: 20692887

can we do it the other way round

Dim blnFound as Boolean
blnFound = False

For j = 1 To RowsB
    For i = 1 To RowsA
        If ws1.Cells(i, 1) = ws2.Cells(j, 1) Then
            blnFound = True
            Exit For
        End If
    Next i
    If not blnFound then
        ws2.Rows(j).EntireRow.Copy ws3.Cells(counter, 1)
        counter = counter + 1
    End If
    blnFound = False
Next j

 

by: JAYRUPosted on 2008-01-22 at 05:46:41ID: 20714079

Spattewar,
We are almost there.  Appears as tho when i use simple data to test it works okay using your last suggestion.  However when i use the live data which is about 5000 records and about 4000 records to match against the results come back as none of the 4000 records matching.  The result should be only about 200 at the most not matching.   Not sure if is a data formatting problem or not.  I have pasted values only and formatted as text and even tried formatting as number and get same result.  Gonna do some more testing.  I believe your macro is working but am a loss of why when using live data it does not.  If you have any ideas let me know.   I will award points after just a little more testing.  

 

by: JAYRUPosted on 2008-01-24 at 04:14:12ID: 31422248

VALUABLE CODE  THANKS.  Sorry took so long to accept.  Was testing and trying to make it work correctly.  Did not totally work but still good stuff

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...