Question

% Difference between two value

Asked by: keilah

Hi Experts

I have the following code but its not doing the right calculation.

Firstly, here is the VBA code

Sub CalcDiff_1()
Dim rResult As Range
Dim rWhole As Range
Dim NumOfRows As Long
Dim r As Range
Dim StartColmn As Long
Dim StartRow As Long

Sheets("Economic").Range ("E7:F20")
Set rResult = Sheets("Summary").Range("C7") 'where results will be put
Set rWhole = Range("E7:F20") 'Range with 2 columns to compare on the active sheet

'Set rWhole = Selection 'Uncomment this line if you just want to select the cells to compute
If rWhole.Columns.Count <> 2 Then Exit Sub

StartRow = rWhole.Cells(1, 1).Row
StartColmn = rWhole.Cells(1, 1).Column

NumOfRows = rWhole.Rows.Count
Set r = Cells(StartRow, StartColmn)
    For n = 1 To NumOfRows
        If r.Value > r.Offset(0, 1).Value Then
            If ((r.Value - r.Offset(0, 1).Value) / r.Value) * 100 >= 10 Then
                rResult.Value = r.Address(False, False) & ":" & r.Offset(0, 1).Address(False, False)
                rResult.Offset(0, 1).Value = ((r.Value - r.Offset(0, 1).Value) / r.Value) * 100 & "% difference"
                Set rResult = rResult.Offset(1, 0)
            End If
        ElseIf r.Offset(0, 1).Value > r.Value Then
            If ((r.Offset(0, 1).Value - r.Value) / r.Offset(0, 1).Value) * 100 >= 10 Then
                rResult.Value = r.Address(False, False) & ":" & r.Offset(0, 1).Address(False, False)
                rResult.Offset(0, 1).Value = ((r.Offset(0, 1).Value - r.Value) / r.Offset(0, 1).Value) * 100 & "% difference"
                Set rResult = rResult.Offset(1, 0)
            End If
       End If
       Set r = r.Offset(1, 0)
    Next n
End Sub

imagine two columns E and D

Say your first number is 16, and your second number is 15
How would you find the percent difference.....this would be (16-15)/15 x 100 = x%

when using the above VBA code, its not doing this.......i am trying to find a % diff of 10% in the range e7:f20.....there is a diff then putthe result in column c7 worksheet 'summary'.....

any ideas.....where i have gone wrong......or what wrong with the code....?????





This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2008-04-07 at 07:25:50ID23301436
Tags

microsoft

,

excel

,

2003

Topic

Microsoft Excel Spreadsheet Software

Participating Experts
2
Points
500
Comments
6

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Naming worksheets based on cell values
    Is there an easy way to name a worksheet based on the value in a cell on another sheet?
  2. Refer to another worksheet based on cell value?
    Hi all There must be a way to refer another worksheet based on a cell value without using a UDF or a VBA, only I can't seem to figure it out... I have a worksheet name in cell A1. I'm trying to make cell B1 show the sum of the C1:C3 cells, on the worksheet that its name sho...
  3. Need to count a worksheet If a value is in a cell
    I have worksheets that may or maynot have the value 1 in cell AZ1, I would like to count only the worksheets that have the value 1 and then place the total of worksheets that have the value 1 on another worksheet (quarterly1) in Cell L27.
  4. Match a cell value between worksheets and delete the row…
    Hi, I'm in the process of developing a solution to collate reporting files that are received from two host systems. The source files are both CSVs and I've scripted a solution to import the data from both sources into two separate worksheets in the same workbook. Now, I ne...
  5. Hiding and showing worksheets depending on value of cell
    I have a workbook " TComp" with 4 worksheets- A,B,C,D Worksheet "A" should always be visible as a rule.. I'd like to check tha value in cell G30 when the worksheet opens 1. If value of cell G30 is "No Chance", hide worksheets B,C, a...
  6. Most efficient way to move a lot of cells between workshe…
    Hello! I am using a VBA routine to move the entire contents of a worksheet into a different worksheet... Easy to do this, but I think there are more efficient ways that what I am doing which is basic cut and paste, clipboard, etc. That's ok for small amounts of info, but I ...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: jeffldPosted on 2008-04-07 at 07:48:14ID: 21297417

It seems to work ok when I tried your code other than the fact that I had to comment out the following line or I get an error.  I also used Sheet1 and Sheet2 so that I didn't have to rename the sheets :)

Sheets("Economic").Range ("E7:F20")

I've attached my sample file.  Can you see if this is doing what you expect?

 

by: MalicUKPosted on 2008-04-07 at 07:55:19ID: 21297495

Hi Keilah,

Try this different code:
Sub CalcDiff_2()
Dim i As Long, calc As Double
For i = 7 To 20
calc = (Cells(i, 5) - Cells(i, 6)) / Cells(i, 6)
If calc < 0 Then calc = -calc
With Sheets("Summary")
.Cells(i, 3).Value = calc
.Cells(i, 3).NumberFormat = "0%"
End With
Next
End Sub

Cheers,
MalicUK

 

by: keilahPosted on 2008-04-07 at 07:56:53ID: 21297509

Hi thanks for the feedback.....
slightly

I would like the macro to initial reference worksheet'Economic' range E7:F20.... if after lookiing in the range E7:F20 one item is greater than 10% as  percentage diff...only report that value (and post the result Cell ref (c7) and 5 diff (d7) worksheet 'summary) if not iteam is greater that 10%.

post ok into c7 worksheet 'summary'


 

by: jeffldPosted on 2008-04-07 at 08:32:42ID: 21297885

how about this one?  I moved the parenthesis over to include the multiplication of 100.


Sub CalcDiff_1()
Dim rResult As Range
Dim rWhole As Range
Dim NumOfRows As Long
Dim r As Range
Dim StartColmn As Long
Dim StartRow As Long
 
'Sheets("Sheet1").Range ("E7:F20")
Set rResult = Sheets("Sheet2").Range("C7") 'where results will be put
Set rWhole = Sheets("sheet1").Range("E7:F20") 'Range with 2 columns to compare on the active sheet
 
'Set rWhole = Selection 'Uncomment this line if you just want to select the cells to compute
If rWhole.Columns.Count <> 2 Then Exit Sub
 
StartRow = rWhole.Cells(1, 1).Row
StartColmn = rWhole.Cells(1, 1).Column
 
 
NumOfRows = rWhole.Rows.Count
Set r = Cells(StartRow, StartColmn)
    For n = 1 To NumOfRows
        
        If r.Value > r.Offset(0, 1).Value Then
            If ((r.Value - r.Offset(0, 1).Value) / r.Value * 100) >= 10 Then
                rResult.Value = r.Address(False, False) & ":" & r.Offset(0, 1).Address(False, False)
                rResult.Offset(0, 1).Value = ((r.Value - r.Offset(0, 1).Value) / r.Value) * 100 & "% difference"
                Set rResult = rResult.Offset(1, 0)
            End If
        ElseIf r.Offset(0, 1).Value > r.Value Then
            If ((r.Offset(0, 1).Value - r.Value) / r.Offset(0, 1).Value * 100) >= 10 Then
                rResult.Value = r.Address(False, False) & ":" & r.Offset(0, 1).Address(False, False)
                rResult.Offset(0, 1).Value = ((r.Offset(0, 1).Value - r.Value) / r.Offset(0, 1).Value) * 100 & "% difference"
                Set rResult = rResult.Offset(1, 0)
            End If
        End If
       
       
       Set r = r.Offset(1, 0)
    Next n
End Sub

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:

Select allOpen in new window

 

by: keilahPosted on 2008-04-08 at 01:20:44ID: 31446608

excellent

 

by: keilahPosted on 2008-04-08 at 01:20:53ID: 21303350

none

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...