Question

Trouble with Passing Userform to Function

Asked by: ryanjames3

I have been working on this code for about a week now and I'm almost there (thanks to rorya). What I am trying to do is import worksheets that the user selects from a listbox on a userform. I am attempting to pass a userform through 2 function (not sure if that is VBA legal) but it seems to work...until it gets to the part where it copies the sheets over.

It runs through without error but no worksheets get copied to the workbook. I think I am missing something with passing the userform (early/late binding?) but it may just be the copy worksheet code itself.

Sub importData()
   .... (Code)
   Call populateAndImport(FileLoc, frmSheetList)
   ....
End Sub
 
 
Function populateAndImport(ByVal FilePath As String, ByVal frm As Object)
     Dim wb As Workbook, ws As Worksheet
     
     Application.ScreenUpdating = False
     frm.ListBox1.Clear
     
     Set wb = Workbooks.Open(Filename:=FilePath, ReadOnly:=True)
 
     For Each ws In wb.Worksheets
          frm.ListBox1.AddItem ws.Name
     Next
 
   frm.Show
 
   Call importSheets(wb, frm)
     
     
     wb.Close
     wb = Nothing
     ws = Nothing
     
End Function
 
 
Function importSheets(ByVal wbk As Workbook, ByVal form1 As UserForm)
   Dim i As Integer
   
   If form1.ListBox1.ListIndex = -1 Then Exit Function
   
      For i = form1.ListBox1.ListCount - 1 To 0 Step -1
 
         If form1.ListBox1.Selected(i) Then
            wbk.Worksheets(form1.ListBox1.Selected(i)).Copy after:=("Book1.xls")
            Sheets(form1.ListBox1.Selected(i)).Visible = False
         End If
 
      Next i
      
End Function

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-04-02 at 20:27:31ID24291088
Tags

Microsoft Excel

,

VBA

,

functions

,

userform

Topics

Microsoft Excel Spreadsheet Software

,

VB Objects

,

Visual Basic v1.0.5.x

Participating Experts
1
Points
300
Comments
3

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. multiple workbooks and userforms
    I have two workbooks in the same excel session. In workbook1 I have a userform with a text box on it. Is it possible to write a macro in a module sheet in workbook2 that will change the entry in the text box and display the userform.
  2. Using UserForm with no Worksheets Visible
    Is there a VBA solution to the following problem? I wish to display a UserForm for the input of Data, but hide all the Worksheets and Menu Bars and still allow exchange of data between the hidden worksheets and the UserForm. I wanted the background exchange of data to be inv...
  3. Excel VBA userform control to view selection of worksheet…
    Anyone know if there's a control that can be inserted onto a VBA userform that allows the user to view a selection of data from another worksheet in the same workbook? I'm looking for something similar to a subform in Access. Thanks
  4. question about userform and worksheet actions
    good morning, I have a modeless userform with some buttons (query, clear, etc) that performs some functions on a worksheet. I want the userform to remain, but when a button is pushed that performs these actions, the userform always disappears, or hides. for example, the clea...
  5. Excel UserForm won't open on another worksheet in the s…
    First, I am completely incompetent at VBA, so absolutely any help is greatly appreciated. I've created an Excel VBA UserForm that allows the user to select a name from the 1st ComboBox & that in turn autopopulates the rest of the user form with the information related to...
  6. How to Open  a particular Worksheet from  an Userform But…
    Hi, I have a excel file (Workbook) with four work sheets. This workbook also has an Userform. I want to open a particulat worksheet in the command button click event of this userform. I tried searching the VBA code to open the worksheet. I found only the code to open ano...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: AvelanPosted on 2009-04-03 at 00:43:27ID: 24057497

Hey,

a couple of suggestions.

Is the form you're showing in populateAndImport a modal form or not?
Because if it's not, your importsheets function gets called before you do any selecting
on the form.

Also on this line:
wbk.Worksheets(form1.ListBox1.Selected(i)).Copy after:=("Book1.xls")
the after part should be like after:=Activeworkbook.Sheets(1) i think, defining a sheet
after which the sheet will be copied to.

And you're setting the copied sheets to invisible so you sure they're not copied? :P

-Avelan

 

by: ryanjames3Posted on 2009-04-03 at 18:52:30ID: 24065592

The userform is modal by default (haven't changed it) and I also modified that code and still no go. The sheets are hidden because it is an application that the user has where they do not need to see the sheets but calculations are done on the sheets in the background.

I was thinking, there is a userform that is displayed in the background before the frmSheetList userform is shown...would  another modal userform conflict with this one and would declaring frmSheetList as an object be the way to go?

 

by: ryanjames3Posted on 2009-04-05 at 18:13:59ID: 24073855

I can't believe I spent so much time trying to figure this out! The only change I needed to make was to change Selected(i) to List(i):

wbk.Worksheets(form1.ListBox1.Selected(i)).Copy after:=("Book1.xls")

to

wbk.Worksheets(form1.ListBox1.List(i)).Copy after:=("Book1.xls")

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...