Question

Loop Through EXCEL Files and Get Data

Asked by: techfanatic

Hi Experts!

I need a VBA code inside a Workbook to search other Excel files in the same directory and get data from them and then save the data in the original workbook.

The data will always be in the same cell addresses in the other workbooks but the filenames may be different. Is this doable with the filenames being different? If not due to limitations, please provide a code if there was a filenaming convention. Also, if data has been taken from the workbooks, they need to be moved to another folder.

I'm sorry if I'm not very clear. I have attached an image to help explain what I need.

Thanks a lot in advance!

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-11-03 at 14:19:24ID24869121
Tags

Excel VBA

Topics

Microsoft Excel Spreadsheet Software

,

Automation

Participating Experts
1
Points
160
Comments
6

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Calling Convention
    I have a routine in an Excel workbook that I want to call from VBA in Access. I am creating an object variable, opening the workbook, and populating it with data. I then want to call one of the macro routines in that workbook. The routine in question is in a Module. That is,...
  2. One workbook VBA interferes with other workbook
    I have a function in a VBA module that is part of a formula in cells in a spreadsheet column. Therefore, whenever a cell is changed on the spreadsheet the formula and function run in case the formula references the changed cell. If there were say 100 rows, then the function...
  3. Excel VBA running code from one workbook in another wor…
    I am working in Excel using VBA. I have a macro that is supposed to run through a folder of workbooks and do what the macro is designed for. The problem I have is it does open the first file but runs the macro on the workbook that contains the code, not the target workbook....
  4. Excel VBA - Run macro in anothe workbook
    Hi In Excel VBA, How would you run a macro or procedure in another Excel workbook Thanks
  5. Changing the same cell value in multiple excel workbooks (…
    Hi there, I have a folder with many excell workbooks which have the same individual calculation performed for 30 different people. The name of these workbooks is standardised: /.../..../Calculations - <name of person here> Now, what I need to do is change the value o...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: PatOBrienPosted on 2009-11-03 at 21:16:56ID: 25736608

try this...

may need some tweaking to suit your situation

Sub GatherData() 
Dim strPath As String
Dim strFileName As String
Dim wb As Workbook
Dim strSource As String
Dim rngSource As Range
Dim rngTarget As Range
Dim intRowCounter As Integer
Dim strTargetFolder As String 
'define where the files are to be copied here (hard coded)
strTargetFolder = "C:\temp" 
'or get the foldername from a ws cell  (uncomment the next line)
'strTargetFolder = ActiveSheet.Range("D1") ' or use a named range 

strSource = "A1"
strPath = ActiveWorkbook.Path
intRowCounter = 1
'this is where the data will be copied to
Set rngTarget = ActiveSheet.Range("A1") 
strFileName = Dir(strPath & "\*.xls") 
'make sure that the target folder name has a trailing slash
If Right(strTargetFolder, 1) <> "\" Then
    strTargetFolder = strTargetFolder & "\"
End If 
Do While strFileName <> ""
    'skip file if it matches the current workbook name
    If strFileName <> ActiveWorkbook.Name Then
        'open the wb
        Set wb = Workbooks.Open(strPath & "\" & strFileName, False, True)
        
        'set range of information to be copied
        Set rngSource = wb.Worksheets(1).Range(strSource)
        
        'copy data from source to target
        rngTarget.Offset(intRowCounter, 0) = rngSource.Value
        rngTarget.Offset(intRowCounter, 1) = rngSource.Offset(0, 1).Value
        'if you want the filename saved in the next column...
        rngTarget.Offset(intRowCounter, 2) = wb.Name
        
        
        'increment target row counter
        intRowCounter = intRowCounter + 1
        
        'close the source workbook with no save
        wb.Close False
        '
        'to do - maybe - test for existence of target folder
        '
        
        'copy the source wb to the target folder
        FileCopy strPath & "\" & strFileName, strTargetFolder & strFileName
        
        '
        'to do - maybe - test for existence of file in new target folder then if found, do the delete
        '  note: don't use the DIR command to test for the file.  It resets the dir list.
        
        'uncomment this line to delete the original - after testing is complete
        'Kill strPath & "\" & strFileName
    
    End If
    
    'get next file name
    strFileName = Dir
Loop 

MsgBox "Done." 
End Sub
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:

Select allOpen in new window

 

by: techfanaticPosted on 2009-11-04 at 02:41:00ID: 25737992

Hi PatOBrien, this is perfect! It works! I have one more question though, which part of the code should I change to add more cell values to be copied to the workbook? For example, I wanted to copy A3, G3, B4 (from source) to columns A, B, C of this workbook?

Thanks!

 

by: techfanaticPosted on 2009-11-04 at 03:13:05ID: 25738132

Hi PatOBrien, I played around your beautifully commented code and this is what I've changed. So far, it was able to display 4 columns of data correctly. Is this a correct way of modifying your code for multiple cell sources?

Sub GatherData()
Dim strPath As String
Dim strFileName As String
Dim wb As Workbook
Dim strSource1 As String
Dim rngSource1 As Range
Dim strSource2 As String
Dim rngSource2 As Range
Dim strSource3 As String
Dim rngSource3 As Range
Dim strSource4 As String
Dim rngSource4 As Range

Dim rngTarget As Range
Dim intRowCounter As Integer
Dim strTargetFolder As String
'define where the files are to be copied here (hard coded)
strTargetFolder = "C:\Documents and Settings\Ana and Elton\Desktop\Tribune\Looper Files\Done"
'or get the foldername from a ws cell  (uncomment the next line)
'strTargetFolder = ActiveSheet.Range("D1") ' or use a named range

strSource1 = "D3"
strSource2 = "G5"
strSource3 = "D5"
strSource4 = "G3"

strPath = ActiveWorkbook.Path
intRowCounter = 1
'this is where the data will be copied to
Set rngTarget = ActiveSheet.Range("A1")
strFileName = Dir(strPath & "\*.xls")
'make sure that the target folder name has a trailing slash
If Right(strTargetFolder, 1) <> "\" Then
    strTargetFolder = strTargetFolder & "\"
End If
Do While strFileName <> ""
    'skip file if it matches the current workbook name
    If strFileName <> ActiveWorkbook.Name Then
        'open the wb
        Set wb = Workbooks.Open(strPath & "\" & strFileName, False, True)
       
        'set range of information to be copied
        Set rngSource1 = wb.Worksheets(1).Range(strSource1)
        Set rngSource2 = wb.Worksheets(1).Range(strSource2)
        Set rngSource3 = wb.Worksheets(1).Range(strSource3)
        Set rngSource4 = wb.Worksheets(1).Range(strSource4)
       
        'copy data from source to target
        rngTarget.Offset(intRowCounter, 0) = rngSource1.Value
        rngTarget.Offset(intRowCounter, 1) = rngSource2.Value
        rngTarget.Offset(intRowCounter, 2) = rngSource3.Value
        rngTarget.Offset(intRowCounter, 3) = rngSource4.Value

 

by: PatOBrienPosted on 2009-11-04 at 11:53:58ID: 25743201

Yes, that is a perfectly acceptable way to do it.

However, if you're expecting to be constantly adding to the cells that are to be copied, you could reduce the amount of code that you have to change by using an array for the strSource text.  

But what you're doing is fine.

 

by: techfanaticPosted on 2009-11-05 at 05:41:34ID: 25749284

Thanks a lot!

 

by: techfanaticPosted on 2009-11-05 at 05:44:17ID: 31650473

I like the way he cleanly writes codes and how he comments them for easy use. Nowadays, there's no point reinventing the wheel. We sort of "copy" other people's codes and customize them to our needs. People like PatOBrien just makes lives for people like me 100 times easier. Sorry, I only had 160 points to give, I know you deserved better. Have a great one!

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...