Question

Excel not closing on first attempt

Asked by: numcrun

I have 6 workbooks open. All  have the code below in them, but only 1 has the Application.Quit line. When I click the top cross, and choose "Yes to All", they all save . But then they are all still open. So I click the top cross again and they all close without any more prompts.  I tried adding Application.Quit to all of them but no luck.

Don't worry too much about the code in the subs. This problem seems to occur no matter what is in the subs.

Private Sub Workbook_BeforeClose(Cancel As Boolean) 
gbClosing = True
gdCheckTime = Now + TimeSerial(0, 0, 1) 'Define time
Application.OnTime gdCheckTime, "CheckIfClosed" 'Schedule macro 
Application.Quit 
End Sub 
Private Sub Workbook_Deactivate() 
If gbClosing Then
   On Error Resume Next
   Me.Unprotect Password:="secret" 'so can access Ctrl Pnl when closed
   Application.CommandBars("Excel Control").Controls("Cut").Enabled = True
   Application.CommandBars("Shapes").Controls("Cut").Enabled = True
   Application.CommandBars("Edit").Controls("Delete...").Enabled = True
   Application.CommandBars("Edit").Controls("Cut").Enabled = True
   Application.CommandBars("Cell").Controls("Delete...").Enabled = True
   Application.CommandBars("Cell").Controls("Insert...").Enabled = True
   Application.CommandBars("Worksheet Menu Bar").Controls("Insert").Enabled = True 
   Call enable_toolbars_and_buttons 
   On Error GoTo 0
   'Delete scheduled macro
   Application.OnTime gdCheckTime, "CheckIfClosed", , False
   Application.EnableEvents = True
End If 
End Sub
                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-11-06 at 23:17:48ID24880089
Tags

Excel VBA

Topic

Microsoft Excel Spreadsheet Software

Participating Experts
2
Points
500
Comments
13

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Subs and functions such as Workbook_Open in Excel
    Where can I find a reference or list of all of the inherent subs/functions in Excel such as Workbook_Open?
  2. Shared WorkBook
    I want to create a file that access to everyone and it's a shared workbook. And due to security reason, I want them to supply their own passwords to verify that he is who he is. Now, each of them have different passwords. I need help on about doing this. Thanks in advance...
  3. excel - can excel issue prompt messages
    Can excel send prompt messages to either personell or specific PC's
  4. VBA: Suppress prompt to save open workbooks when Ex…
    Anybody know how to suppress Excel's prompt to save open workbooks when it exits? I can suppress the prompt when I close workbooks one at a time, whether by code in the workbook's BeforeClose event or by code in an add-in that monitors workbooks closing. However, when I exit...
  5. Prompt to choose from a list of open workbooks
    Hi All, I am writing a macro that needs to perform on one of several open workbooks. Can some one give me a piece of code that will present the user with a prompt box from which they can choose from all the currently open workbooks. (The workbook titles change weekly, so I ...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: numcrunPosted on 2009-11-06 at 23:31:52ID: 25765324

I just deleted all code from the 2 subs listed in all workbooks, but kept the stubs. Same problem.

 

by: numcrunPosted on 2009-11-06 at 23:34:28ID: 25765332

Points up...this has bugged me for ages....in both senses.

 

by: numcrunPosted on 2009-11-06 at 23:58:43ID: 25765392

I just deleted all the Workbook_BeforeClose stubs, leaving only the Workbook_Deactivate stubs, same problem.

 

by: numcrunPosted on 2009-11-07 at 00:06:11ID: 25765405

I just deleted all the Workbook_Deactivate stubs, problem gone. But I need the Workbook_Deactivate event.

 

by: numcrunPosted on 2009-11-07 at 00:12:18ID: 25765416

You can reproduce the problem from this post. It is someone with the same problem.

http://www.pcreview.co.uk/forums/thread-2582915.php

 

by: CbrinePosted on 2009-11-09 at 06:38:25ID: 25776249

Give these code revisions a try.

HTH
Cal

Private Sub Workbook_BeforeClose(Cancel As Boolean) 
gbClosing = True
gdCheckTime = Now + TimeSerial(0, 0, 1) 'Define time
Application.OnTime gdCheckTime, "CheckIfClosed" 'Schedule macro 
Application.enableevents =false
Application.Quit 
application.enableevents=true
End Sub 
Private Sub Workbook_Deactivate() 
application.enableevents=false
If gbClosing Then
   On Error Resume Next
   Me.Unprotect Password:="secret" 'so can access Ctrl Pnl when closed
   Application.CommandBars("Excel Control").Controls("Cut").Enabled = True
   Application.CommandBars("Shapes").Controls("Cut").Enabled = True
   Application.CommandBars("Edit").Controls("Delete...").Enabled = True
   Application.CommandBars("Edit").Controls("Cut").Enabled = True
   Application.CommandBars("Cell").Controls("Delete...").Enabled = True
   Application.CommandBars("Cell").Controls("Insert...").Enabled = True
   Application.CommandBars("Worksheet Menu Bar").Controls("Insert").Enabled = True 
   Call enable_toolbars_and_buttons 
   On Error GoTo 0
   'Delete scheduled macro
   Application.OnTime gdCheckTime, "CheckIfClosed", , False
   Application.EnableEvents = True
End If 
End Sub

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:

Select allOpen in new window

 

by: CbrinePosted on 2009-11-09 at 06:39:59ID: 25776264

Another possible issue is this

On Error Resume Next

Not sure if you are encountering and error in the deactivate event, which might be stoping the close.  Try remming the on error and see what is actually occuring.

 

by: numcrunPosted on 2009-11-09 at 22:27:57ID: 25782867

I tried various combinations of your first suggestion but it did not work. The error clause is not the problem because it just continues when it hits an error. This problem occurs in 2000 but not in 2003 so is probably a Microsoft bug.

 

by: numcrunPosted on 2009-11-09 at 22:28:21ID: 25782870

Sorry I mean it occurs in 2003 not 2000.

 

by: CbrinePosted on 2009-11-10 at 06:00:02ID: 25785360

I'm wondering what you are trying to accomplish.  It look's like you are trying to reactivate some controls that you disabled.  I've got a better way of doing this.  Why don't you try it.

Cal

Just add to the this workbook level of the workbook.
Sub Workbook_activate()
Application.CommandBars("Excel Control").Controls("Cut").Enabled = False
Application.CommandBars("Shapes").Controls("Cut").Enabled = False
Application.CommandBars("Edit").Controls("Delete...").Enabled = False
Application.CommandBars("Edit").Controls("Cut").Enabled = False
Application.CommandBars("Cell").Controls("Delete...").Enabled = False
Application.CommandBars("Cell").Controls("Insert...").Enabled = False
Application.CommandBars("Worksheet Menu Bar").Controls("Insert").Enabled = False
End Sub
Sub workbook_deactivate()
Me.Unprotect "secret"
Application.CommandBars("Excel Control").Controls("Cut").Enabled = True
Application.CommandBars("Shapes").Controls("Cut").Enabled = True
Application.CommandBars("Edit").Controls("Delete...").Enabled = True
Application.CommandBars("Edit").Controls("Cut").Enabled = True
Application.CommandBars("Cell").Controls("Delete...").Enabled = True
Application.CommandBars("Cell").Controls("Insert...").Enabled = True
Application.CommandBars("Worksheet Menu Bar").Controls("Insert").Enabled = True
End Sub
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:

Select allOpen in new window

 

by: numcrunPosted on 2009-11-10 at 16:00:05ID: 25791314

No I need the other code which tests if the user clicks cancel when closing all files. And the reduced code will not solve the problem either. Remember it fails with even a stub. If you want to test your solution, I suggest you follow the link above and create the files as suggested.

 

by: StellanRosengrenPosted on 2009-11-10 at 16:35:43ID: 25791496

Hi,
I have reproduced the problem by using 2 workbooks each with these procedures in ThisWorkbook

Private Sub Workbook_BeforeClose(Cancel As Boolean)
    Debug.Print "BeforeClose"
End Sub

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)
    Debug.Print "BeforeSave"
End Sub

Private Sub Workbook_Deactivate()
    Debug.Print "Deactivate"
End Sub

I found that when I close them one at a time (Yes to save) I get the events triggered in the order
BeforeClose
BeforeSave
Deactivate

But, when I close them by File->Close All, I get this order
BeforeClose (active wb)
BeforeClose (2nd wb)
Deactivate (2nd wb)

and then it stops. They are not even saved.
Same behaviour in Excel 2007 and 2003

I cannot explain this and I have not found any simple workaround. I can only think of 'disabling' the Close All command and maybe replace it with a macro.

Kind regards,
Stellan

 

by: numcrunPosted on 2009-11-10 at 21:32:36ID: 25792535

Thanks for setting that up and clarifying that, Stellan. Now if only Microsoft would take bug reports...

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...