Question

Excel97 - macro activates twice from toolbar

Asked by: PaultheGreat

I made a macro subroutine for Excel97 that with one parameter that I call from a custom toolbar with a few buttons.

the macro is in this format:

Public Sub myMacro(a As Integer)
    ...
End Sub

and then I have several buttons on my custom toolbar point to the macro:

'myWorkbookName'!ThisWorkbook.myMacro(n)

where n is a number that is specified differently depending on which button you press on the toolbar.
The macro activates fine... the only problem is that it activates twice for each single time that I press a button on the toolbar. Why? What can I do to prevent this happening?

Naturally I could do something like this...

Dim goneTwiceYet As Boolean
Public Sub myMacro(a As Integer)
    goneTwiceYet = Not goneTwiceYet
    If goneTwiceYet Then Exit Sub
    ...
End Sub

but I'd rather be able to set up my toolbar so that I don't have to edit my macro functions like that to fix the bug. Note: I do not want suggestions, as above; I would much rather have solutions, thank you.

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2003-07-02 at 13:49:18ID20666870
Topic

Microsoft Office Suite

Participating Experts
2
Points
50
Comments
6

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Toolbar not following code in Excel97
    I've written a couple of small programs, in Excel, that are activated upon selection of a toolbar button. I had no problem with the toolbar following program when I put it on a new computer. Since we upgraded to Office97, the toolbar no longer activates when I run the program...
  2. Excel97 and toolbars
    I have made a spesific toolbar for one workbook. How can I get this toolbar to appear everytime load the spesific workbook, and disappear when closing it. It would also be nice if the toolbar disappeared / appeard when using the Window menu to change wordkbook. I would als...
  3. Macro button on toolbar
    In MS Word is there a way to have a button (graphic or icon) on the toolbar for a macro rather than the textual name of the macro? I can do it in Excel but I can't find a way in Word.
  4. Put Excel97 Add-in on Toolbar
    I have a macro I made an Add-in. It loads, no problem. I want to start the program with a button on the toolbar. Whenever I do this, it refers to the original workbook (xls). When I run it, it open the workbook. The xla is already loaded, so why should it open the original wo...
  5. Excel97 Toolbars Won't Change/Adding New Macro
    okay, it's been a while, but I'm missing something. I have excel97 SR-2 running on Win NT. When I edit my toolbars, they recreate themselves as they were once I exit and restart excel. The end game here is that I'm trying to add a couple of new macros to the toolbar, but whe...
  6. Macro toolbar in Visio 2002
    Hi experts! Do you know how to create a Toolbar with access to Macros in Visio 2002? I already have the Macros for the document. Now, I add a Toolbar but find no way to insert customized button associated to my Macros in this toolbar. Thanks for the help!

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: jsemenakPosted on 2003-07-02 at 23:24:28ID: 8846648

Is macro activate with this same n parameter.
If you click on button having related macro it will be activated only one time.
Try check n parameter in double activation.

Maybe problem is that you have for example toolbar, click on which start macro
and second times macro is activated because click on button on toolbar. But it is only just
immediete idea.


 

by: smozgurPosted on 2003-07-03 at 07:28:17ID: 8849630

Hi PaultheGreat,

I have never found the exact reason of that when you assign a macro by using parameter. But I suggest another method which would let you to find the clicked button and execute a related command in your code instead using a parameter.

Just set the Tag properties of the Command Buttons that you are probably creating by code to 1,2,3 or however you like then use the code below instead.

Sub MyCode()
    Select Case Application.CommandBars.ActionControl.Tag
    Case "1"
        MsgBox "1"
    Case "2"
        MsgBox "2"
    Case "3"
        MsgBox "3"
    End Select
End Sub

I hope this helps.
Suat

 

by: PaultheGreatPosted on 2003-07-10 at 11:03:14ID: 8895206

Suat,

I haven't tried using your method, since my method is working fine with what I'm doing... I was really looking for the reason Excel doesn't facilitate passing of parameters to macros.

My issue was that I had several different buttons on the toolbar that would basically pass to the function the location of a certain cell; then the function would modify this cell in a certain way; thus, I could have the exact same code but just have the parameter passed to it determine which cell is being modified.


This is not a pressing issue, but I would like to find out what the deal is at some point, so if anyone knows why this happens and/or what can be done to prevent it (I still want to be able to pass the parameter when I click the button, not using the Tag property or anything) aside from what I have written before, please post here.

Please, no "alternative suggestions", I would like a solution!

Thanks,
Paul

 

by: PaultheGreatPosted on 2003-08-13 at 11:53:40ID: 9140906

To moderators:

This question might soon be considered an "abandoned question"... I already consider it as such. It doesn't seem as if I'll receive an answer to my question at this point... so if there is a time issue and this question needs to be closed, please just delete it. Thank you.

Thanks,
Paul

 

by: PaultheGreatPosted on 2003-08-21 at 06:47:05ID: 9195441

Thank you for your suggestion, Suat... thanks for trying to help. you can have the points for this post, my q was somewhat answered in http:Q_20714018.html.

Regards,
Paul

 

by: PaultheGreatPosted on 2003-12-03 at 12:37:07ID: 9869635

Attention PAQ viewers!

I found the actual solution searching on Google.
Originally I was calling my macro sub by setting the OnAction property of the CommandBarControl to something like this:
    "myMacro(myParam)"
That results in a illogical double-calling of the sub. However, if you call it like this:
    "'myMacro myParam'"
and that works! It's only called once!
(notice the inner set of quotes in there)
And to specify multiple parameters, space them out:
    "'myMacro param1, param2, param3'"
And to pass String params:
    "'myMacro ""blah blah""'"
And to pass variable params:
    "'myMacro " & myParamVar & "'"

Please check this link for more details:
http://www.exceltip.com/st/Pass_arguments_to_macros_from_buttons_and_menus_using_VBA_in_Microsoft_Excel/424.html

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...