Advertisement

10.15.2008 at 02:59PM PDT, ID: 23818611
[x]
Attachment Details
[x]
The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

  • The Grade of the Solution
  • The Zone Rank of the Expert Providing the Solution
  • The Number of Author and Expert Comments
  • The Number of Experts Contributing
  • The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!
9.3

How can I make my code more dry  = Dont Repeat Yourself

Asked by flashactions in ActionScript

Tags:

 Can you help compress my code? So I can make changes in the future easier than they would be at this time.  Im working on a widget that plays music, so I have alot of event listeners listening for mouse clicks on buttons.  Im working with 30 sounds on the first frame at this time.   I have added a volume and balance slider for each set of 5 sounds.  I am also adding tempo button to play faster samples.   There are about 1000 lines of code in my widget.  I plan on adding 5 times the amount of samples we currently have so by then my code will be 5000 lines.  So can you take a look at my code and the widget and give some pointers, hints, code replacement.      I pasted the first Block of code from my widget.  This code will play the first 5 sounds, and has a volume and balance slider.  I pasted this code in my widget 5 times to take care of all 30 sounds and just changed the function names.  If you can give me an idea of how I could compress that I can apply it to the rest of the code.  

The widget address is  http://www.buttonbeats.com/smaller_sequenceBIG.html

thanx.  Start Free Trial 
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:
118:
119:
120:
121:
122:
123:
124:
125:
126:
127:
128:
129:
130:
131:
132:
133:
134:
135:
136:
137:
138:
139:
140:
141:
142:
143:
144:
145:
146:
147:
148:
149:
150:
151:
152:
153:
154:
155:
156:
157:
158:
159:
160:
161:
162:
163:
164:
165:
166:
167:
168:
169:
170:
171:
172:
173:
174:
175:
176:
177:
178:
179:
180:
181:
182:
183:
184:
185:
186:
187:
188:
189:
190:
191:
192:
193:
194:

stop();
	//begining of event listeners for the first sliders samples.
	var myvolumebounds:Rectangle=new Rectangle(volumegroove_mc.x, volumegroove_mc.y, 1, volumegroove_mc.height);
var mybalancebounds:Rectangle=new Rectangle(balancegroove_mc.x, balancegroove_mc.y, balancegroove_mc.width, 1);
volume_mc.addEventListener(MouseEvent.MOUSE_DOWN, startdragvolume);
//volume_mc.addEventListener(MouseEvent.MOUSE_OUT, stopdrag);
volume_mc.addEventListener(MouseEvent.MOUSE_UP, stopdrag);
balance_mc.addEventListener(MouseEvent.MOUSE_DOWN, startdragbalance);
//balance_mc.addEventListener(MouseEvent.MOUSE_OUT, stopdrag);
balance_mc.addEventListener(MouseEvent.MOUSE_UP, stopdrag);
function startdragvolume(myevent:MouseEvent):void{
	myevent.target.startDrag(false, myvolumebounds);
}
function startdragbalance(myevent:MouseEvent):void{
	myevent.target.startDrag(false, mybalancebounds);
}
function stopdrag(myevent:MouseEvent):void{
	myevent.target.stopDrag();
	}
	
 
	a1.addEventListener(MouseEvent.CLICK,player1);
		function player1(event:MouseEvent){
var myRequest:URLRequest=new URLRequest ("a1.mp3");
var mySound:Sound = new Sound();
var myChannel:SoundChannel;
var newSetting:SoundTransform = new SoundTransform();
mySound.load(myRequest);
myChannel=mySound.play(0,9999);
		stage.addEventListener(Event.ENTER_FRAME, everyframe);
function everyframe(myevent:Event):void{
	var newvolume:Number = 1-((volume_mc.y-volumegroove_mc.y)/88);
	var newbalance:Number = ((balance_mc.x-balancegroove_mc.x)/20)-1;
	trace (newbalance);
	
	newSetting.volume=newvolume;
	newSetting.pan=newbalance;
	myChannel.soundTransform=newSetting;
}
stage.addEventListener(Event.ENTER_FRAME, everyframe2);
function everyframe2(event:Event):void {
	leftbar.scaleY=(myChannel.leftPeak);
	rightbar.scaleY=(myChannel.rightPeak);
}
stopper.addEventListener(MouseEvent.CLICK,killsound);
a1.addEventListener(MouseEvent.CLICK,killsound);
a2.addEventListener(MouseEvent.CLICK,killsound);
a3.addEventListener(MouseEvent.CLICK,killsound);
a4.addEventListener(MouseEvent.CLICK,killsound);
a5.addEventListener(MouseEvent.CLICK,killsound);
function killsound(event:MouseEvent){
	 myChannel.stop();
}
		}
		
		
		
a2.addEventListener(MouseEvent.CLICK,player01);
		function player01(event:MouseEvent){
var myRequest:URLRequest=new URLRequest ("a2.mp3");
var mySound:Sound = new Sound();
var myChannel:SoundChannel;
var newSetting:SoundTransform = new SoundTransform();
mySound.load(myRequest);
myChannel=mySound.play(0,9999);
		stage.addEventListener(Event.ENTER_FRAME, everyframe);
function everyframe(myevent:Event):void{
	var newvolume:Number = 1-((volume_mc.y-volumegroove_mc.y)/88);
	var newbalance:Number = ((balance_mc.x-balancegroove_mc.x)/20)-1;
	trace (newbalance);
	
	newSetting.volume=newvolume;
	newSetting.pan=newbalance;
	myChannel.soundTransform=newSetting;
}
stage.addEventListener(Event.ENTER_FRAME, everyframe2);
function everyframe2(event:Event):void {
	leftbar.scaleY=(myChannel.leftPeak);
	rightbar.scaleY=(myChannel.rightPeak);
}
stopper.addEventListener(MouseEvent.CLICK,killsound);
a1.addEventListener(MouseEvent.CLICK,killsound);
a2.addEventListener(MouseEvent.CLICK,killsound);
a3.addEventListener(MouseEvent.CLICK,killsound);
a4.addEventListener(MouseEvent.CLICK,killsound);
a5.addEventListener(MouseEvent.CLICK,killsound);
function killsound(event:MouseEvent){
	myChannel.stop();
}
		}		
		
		
		a3.addEventListener(MouseEvent.CLICK,player02);
		function player02(event:MouseEvent){
var myRequest:URLRequest=new URLRequest ("a3.mp3");
var mySound:Sound = new Sound();
var myChannel:SoundChannel;
var newSetting:SoundTransform = new SoundTransform();
mySound.load(myRequest);
myChannel=mySound.play(0,9999);
		stage.addEventListener(Event.ENTER_FRAME, everyframe);
function everyframe(myevent:Event):void{
	var newvolume:Number = 1-((volume_mc.y-volumegroove_mc.y)/88);
	var newbalance:Number = ((balance_mc.x-balancegroove_mc.x)/20)-1;
	trace (newbalance);
	
	newSetting.volume=newvolume;
	newSetting.pan=newbalance;
	myChannel.soundTransform=newSetting;
}
stage.addEventListener(Event.ENTER_FRAME, everyframe2);
function everyframe2(event:Event):void {
	leftbar.scaleY=(myChannel.leftPeak);
	rightbar.scaleY=(myChannel.rightPeak);
}
stopper.addEventListener(MouseEvent.CLICK,killsound);
a1.addEventListener(MouseEvent.CLICK,killsound);
a2.addEventListener(MouseEvent.CLICK,killsound);
a3.addEventListener(MouseEvent.CLICK,killsound);
a4.addEventListener(MouseEvent.CLICK,killsound);
a5.addEventListener(MouseEvent.CLICK,killsound);
function killsound(event:MouseEvent){
	myChannel.stop();
}
		}
		
a4.addEventListener(MouseEvent.CLICK,player04);
		function player04(event:MouseEvent){
var myRequest:URLRequest=new URLRequest ("a4.mp3");
var mySound:Sound = new Sound();
var myChannel:SoundChannel;
var newSetting:SoundTransform = new SoundTransform();
mySound.load(myRequest);
myChannel=mySound.play(0,9999);
		stage.addEventListener(Event.ENTER_FRAME, everyframe);
function everyframe(myevent:Event):void{
	var newvolume:Number = 1-((volume_mc.y-volumegroove_mc.y)/88);
	var newbalance:Number = ((balance_mc.x-balancegroove_mc.x)/20)-1;
	trace (newbalance);
	
	newSetting.volume=newvolume;
	newSetting.pan=newbalance;
	myChannel.soundTransform=newSetting;
}
stage.addEventListener(Event.ENTER_FRAME, everyframe2);
function everyframe2(event:Event):void {
	leftbar.scaleY=(myChannel.leftPeak);
	rightbar.scaleY=(myChannel.rightPeak);
}
stopper.addEventListener(MouseEvent.CLICK,killsound);
a1.addEventListener(MouseEvent.CLICK,killsound);
a2.addEventListener(MouseEvent.CLICK,killsound);
a3.addEventListener(MouseEvent.CLICK,killsound);
a4.addEventListener(MouseEvent.CLICK,killsound);
a5.addEventListener(MouseEvent.CLICK,killsound);
function killsound(event:MouseEvent){
	myChannel.stop();
}
		}
		
		
		a5.addEventListener(MouseEvent.CLICK,player05);
		function player05(event:MouseEvent){
var myRequest:URLRequest=new URLRequest ("a5.mp3");
var mySound:Sound = new Sound();
var myChannel:SoundChannel;
var newSetting:SoundTransform = new SoundTransform();
mySound.load(myRequest);
myChannel=mySound.play(0,9999);
		stage.addEventListener(Event.ENTER_FRAME, everyframe);
function everyframe(myevent:Event):void{
	var newvolume:Number = 1-((volume_mc.y-volumegroove_mc.y)/88);
	var newbalance:Number = ((balance_mc.x-balancegroove_mc.x)/20)-1;
	trace (newbalance);
	
	newSetting.volume=newvolume;
	newSetting.pan=newbalance;
	myChannel.soundTransform=newSetting;
}
stage.addEventListener(Event.ENTER_FRAME, everyframe2);
function everyframe2(event:Event):void {
	leftbar.scaleY=(myChannel.leftPeak);
	rightbar.scaleY=(myChannel.rightPeak);
}
stopper.addEventListener(MouseEvent.CLICK,killsound);
a1.addEventListener(MouseEvent.CLICK,killsound);
a2.addEventListener(MouseEvent.CLICK,killsound);
a3.addEventListener(MouseEvent.CLICK,killsound);
a4.addEventListener(MouseEvent.CLICK,killsound);
a5.addEventListener(MouseEvent.CLICK,killsound);
function killsound(event:MouseEvent){
	myChannel.stop();
}
		}
[+][-]10.15.2008 at 03:02PM PDT, ID: 22726450

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 7-day free trial to view this Expert Comment or ask the Experts your question.

 
[+][-]10.16.2008 at 02:17AM PDT, ID: 22729058

View this solution now by starting your 7-day free trial. Setting up your free trial is quick, easy, and secure. We will return you to this solution, unlocked, when you're done.

 

About this solution

Zone: ActionScript
Tags: action script 3
Sign Up Now!
Solution Provided By: blue-genie
Participating Experts: 2
Solution Grade: A
 
 
 
Loading Advertisement...
20080716-EE-VQP-32 / EE_QW_2_20070628