CFFile

filename = #SearchDept#_#Div#_#fdate#_#tdate#_#cdate#_#fname#.#cffile.ClientFileExt#

and what happens when you put that as destination filename?

Azadi

I currenly getting a error : Element SERVERFILEEXT is undefined in CFFILES.

I see I had a error I took the 'S" off of the #cffile.serverFileExt# ;  But i get the following error.

Attribute validation error for tag CFFILE.  
The value of the attribute source, which is currently D:\Inetpub\wwwroot\eas\coa_reports\report\amanda_reports_scripts13.txt, is invalid.  

Does coldfusion have full permissions for D:\Inetpub\wwwroot\eas\coa_reports\report\ ??

the error you see is a bit misleading in a way that it could just as well be a problem with destination, not just source. cf just shows same error for both... or at least it used to - and we don;t know which cf version you are on...

could be several things:
1) invalid filename - the name you are trying to rename the file to contains invalid characters like / or \ or others
2) permissions problem (unlikely, though, since it's the same directory the file is uploaded to...)
3) file locking - cf has not released the lock on the file after uploading it yet

to rule out 1) and 2) you can try doing copy+delete original instead of renaming:
<!--- copy file to a file with new name --->
<cffile  action = "copy"  
  source = "D:\Inetpub\wwwroot\eas\coa_reports\report\#cfile.serverfile#"  
  destination = "D:\Inetpub\wwwroot\eas\coa_reports\report\#SearchDept#_#Div#_#fdate#_#tdate#_#cdate#_#fname#.#cffile.ClientFileExt#">
<!--- delete original --->
<cffile action="delete" file="D:\Inetpub\wwwroot\eas\coa_reports\report\#cfile.serverfile#">

if it still does not work, then it's likely file locking...

Azadi

Yes it do.  
I changed the code to the follwowing: and still get the message:

Error Occurred While Processing Request  
Attribute validation error for tag CFFILE.  
The value of the attribute source, which is currently D:\Inetpub\wwwroot\eas\coa_reports\report\amanda_reports_scripts18.txt, is invalid.
 

<cfset fdate = ReplaceList(#Searchsdate#,"/","")>
<cfset tdate = ReplaceList(#Searchsdateto#,"/","")>
<cfset cdate = ReplaceList(#CreatedateFrom#,"/","")>
<cfset Renamed_File = "#SearchDept#_#Div#_#fdate#_#tdate#_#cdate#">
 
 
<cffile action="UPLOAD" 
  filefield="Form.FiletoUpload" 
  destination="D:\Inetpub\wwwroot\eas\coa_reports\reports"
  nameconflict="MAKEUNIQUE">
  
<!---Rename--->
<cffile  action = "rename"   
   source = "D:\Inetpub\wwwroot\eas\coa_reports\report\#cffile.serverfile#"  
   destination = "D:\Inetpub\wwwroot\eas\coa_reports\report\#Renamed_File#.#cffile.serverFileExt#" 
   attributes="normal">

                                              

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:

did you try copy+delete instead of rename?

if that does not work, try addign this line after <cffile action="upload" ...> line:

<cfset sleep(1500)>

that will make the thread pause for 1,5 seconds, which should be enough for the lock on the file to be released, if there is a file lock...

Azadi

oh, and if you have spaces in your new filename you may want to change them to - or _.
CF does not like spaces in filenames sometimes...

Azadi

Put a trailing slash at the end of your upload destination

destination="D:\Inetpub\wwwroot\eas\coa_reports\reports"

should be

destination="D:\Inetpub\wwwroot\eas\coa_reports\reports\"

heh

you are uploading to \coa_reports\reportS\

but reading from \coa_reports\report\

you are missing an S there

Azadi

hehe good thing that wasn't a snake!

[OT]
>> good thing that wasn't a snake!

hehe. i actually saw a python eat a cat at a bus stop last week!

Azadi

You should have taken some video of that!!

Thanks for  your Ideas I going to try the delete and see if that works I will let you know.

It worked thanks guys for all  your help.

Yes, that where the problem was thanks alot :)