Question

Uploading Gifs and Jpegs

Asked by: substand

In need of some help and I'm new to ASP.   I can't use one of the uploaders on the market because the client can't install the needed stuff, and plus I have this mostly working.  

I can upload seemingly just about any file, except a JPG.  I only want to allow extensions of GIF, JPG, and JPEG, and I can't figure out for the life of me why this code hangs when uploading a JPG, but GIF is working fine.

This wasn't my original code, but I can't remember where I found it.  I've changed it a bit, but like I said evthing but jpg works.  I know its a lot to sift through, but based on my experience in other web technologies, I would assume its a lot easier than 500 points would sugguest.

Thanks for all your help

Please advise.

Code for the form (choosefile.asp):

<!--#include file="header.asp"-->

      <form action="filePost.asp" enctype="multipart/form-data" method="post" name="f" id="f">
         Pick a file to upload:<br/>
         <input type="file" name="test" size="50" />
         <br />
         <!---input type="radio" name="filename" value="original" checked />
            Use filename from disk
         <br />
         <input type="radio" name="filename" value="userSpecified" />
            Use the following name:
         <input type="text" name="userSpecifiedName" value="" /--->
         input type="hidden" name="userSpecifiedName">
         <input type="hidden" name="filename" value="original">
         <br/>
         Link to: <br/>
         <input type="text" name="linkto" size="50" value="http://">
         <input type="submit" value="Upload Ad" />
      </form>
<!--#include file="footer.asp"-->


Code for the upload page (filepost.asp):


<!--#include file="header.asp"-->

<%
'Adjust this depending on the size of the files you'll
'be expecting; longer timeout for larger files!
Server.ScriptTimeout = 5400

Const ForWriting = 2
Const TristateTrue = -1
CrLf = Chr(13) & Chr(10)

'This function retreives a field's name
Function GetFieldName(infoStr)
      sPos = InStr(infoStr, "name=")
      EndPos = InStr(sPos + 6, infoStr, Chr(34) & ";")
      If EndPos = 0 Then
            EndPos = inStr(sPos + 6, infoStr, Chr(34))
      End If
      GetFieldName = Mid(infoStr, sPos + 6, endPos - _
            (sPos + 6))
End Function

'This function retreives a file field's filename
Function GetFileName(infoStr)
      sPos = InStr(infoStr, "filename=")
      EndPos = InStr(infoStr, Chr(34) & CrLf)
      GetFileName = Mid(infoStr, sPos + 10, EndPos - _
            (sPos + 10))
End Function

'This function retreives a file field's MIME type
Function GetFileType(infoStr)
      sPos = InStr(infoStr, "Content-Type: ")
      GetFileType = Mid(infoStr, sPos + 14)
End Function

'Yank the file (and anything else) that was posted
PostData = ""
Dim biData
biData = Request.BinaryRead(Request.TotalBytes)
'Careful! It's binary! So, let's change it into
'something a bit more manageable.
For nIndex = 1 to LenB(biData)
      PostData = PostData & Chr(AscB(MidB(biData,nIndex,1)))
Next

'Having used BinaryRead, the Request.Form collection is
'no longer available to us. So, we have to parse the
'request variables ourselves!
'First, let's find that encoding type!
ContentType = Request.ServerVariables( _
      "HTTP_CONTENT_TYPE")
ctArray = Split(ContentType, ";")
'File posts only work well when the encoding is
'"multipart/form-data", so let's check for that!
If Trim(ctArray(0)) = "multipart/form-data" Then
      ErrMsg = ""
      ' grab the form boundary...
      bArray = Split(Trim(ctArray(1)), "=")
      Boundary = Trim(bArray(1))
      'Now use that to split up all the variables!
      FormData = Split(PostData, Boundary)
      'Extract the information for each variable and its data
      Dim myRequest, myRequestFiles(9, 3)
      Set myRequest = CreateObject("Scripting.Dictionary")
      FileCount = 0
      For x = 0 to UBound(FormData)
            'Two CrLfs mark the end of the information about
            'this field; everything after that is the value
            InfoEnd = InStr(FormData(x), CrLf & CrLf)
            If InfoEnd > 0 Then
                  'Get info for this field, minus stuff at the end
                  varInfo = Mid(FormData(x), 3, InfoEnd - 3)
                  'Get value for this field, being sure to skip
                  'CrLf pairs at the start and the CrLf at the end
                  varValue = Mid(FormData(x), InfoEnd + 4, _
                        Len(FormData(x)) - InfoEnd - 7)
                  'Is this a file?
                  If (InStr(varInfo, "filename=") > 0) Then
                        'Place it into our files array
                        '(While this supports more than one file
                        'uploaded at a time we only consider the
                        'single file case in this example)
                        myRequestFiles(FileCount, 0) = GetFieldName( _
                              varInfo)
                        myRequestFiles(FileCount, 1) = varValue
                        myRequestFiles(FileCount, 2) = GetFileName( _
                              varInfo)
                        myRequestFiles(FileCount, 3) = GetFileType( _
                              varInfo)
                        FileCount = FileCount + 1
                  Else
                        'It's a regular field
                        myRequest.add GetFieldName(varInfo), varValue
                  End If
            End If
      Next
Else
      ErrMsg = "Wrong encoding type!"
End If

'Save the actual posted file
'If supporting more than one file, turn this into a loop!

'Set lf = server.createObject("Scripting.FileSystemObject")
      'file extension
      sPos = InStrRev(myRequestFiles(0, 2), ".")
      extension = mid(myRequestFiles(0, 2), sPos + 1)
      
      if lcase(extension) = "jpg" or lcase(extension) = "gif" or lcase(extension) = "jpeg" then
            
            Set cn = Server.CreateObject("ADODB.Connection")
            Set rs = Server.CreateObject("ADODB.Recordset")

            sql = "select max(id) from adverts "

            cn.Open connectString
            rs.Open sql, cn, 1
            
            if isnumeric(rs.fields(0)) then
                  newFileNum=rs.fields(0)+1
            else
                  newFileNum=1
            end if
            finalFileName="ad" & newFileNum & "." & extension
            FilePath = "./images/ad" & newFileNum & "." & extension
            response.Write("'" & filepath & "'")
            
            rs.close
            cn.close
            
            'SavePath = Server.MapPath(FilePath)
            'Set SaveFile = lf.CreateTextFile(SavePath, True)
            'SaveFile.Write(myRequestFiles(0, 1))
            'SaveFile.Close
            
            'insert the ad
            'Set objConn = Server.CreateObject("ADODB.Connection")
      
            ' -- Open the Connection
            'objConn.Open connectString
            'sql = "insert into adverts (aduserid,filename,linkto) values (" _
            '        & session("aduserid") & ", '" & finalFileName & "', '" & myRequest("linkto") & "')"
          ' - Execute
            'response.Write(sql)
          'objConn.Execute (sql)
   
          'objConn.Close
          'set objConn = Nothing
            
            
            

      else
            ErrMsg = "The advertisement must be a JPG or GIF."
            
      end if
      
      
'IIS may hang if you don't explicitly return SOMETHING.
'So, redirect to another page or provide some kind of
'feedback below...
%>




<% If ErrMsg = "" Then %>
      Your advertisement has been uploaded.  Don't forget to <a href="purchase.asp">purchase time</a> for it to display.
<% Else %>
      <%= ErrMsg %>
      Please <a href="javascript:history.go(-1);">go back</a> and correct the problem.
<% End If %>

<!--#include file="footer.asp"-->

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2005-11-23 at 10:16:42ID21641399
Topic

Active Server Pages (ASP)

Participating Experts
3
Points
500
Comments
6

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. What's the difference between a GIF and a JPEG?
    What's the difference between a GIF and a JPEG?
  2. Displaying a jpeg, gif
    I am trying to display a jpeg or gif file on static contol. I allow the user to select the file from a CFileDialog object than I get the pathname and try to 'set' the graphics in CStatic control. I tried setting the Control type to Enhanced Metafile and using the following c...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: substandPosted on 2005-11-23 at 10:25:05ID: 15352292

PS:  Crap, I forgot to uncomment the lines at the bottom that save the file and such, but that's not the problem.  I thought if I could comment them out, they might be causing the hang and it would work.  But even when they are commented out, the page hangs forever.

I think the smallest file I tested on was 134 k

...

Wow, just tested it on a tiny file and it worked.

I wasn't aware it would take 6+ mins (the longest I waited before restarting IIS)  to upload from my desktop to my local area network a 134k file.  

In that case, is there a way to speed up the process?  Do I need to make the timeout at the top longer?

 

by: leechoonhweePosted on 2005-11-23 at 10:30:20ID: 15352324

I tried making some upload modules like you did and I ended up having problems with big files and bmps. I would strongly recommend using a third party upload module as they can really speed things up.

 

by: SquareHeadPosted on 2005-11-23 at 13:43:00ID: 15353577

Maybe this would help:

It's a free asp upload class, no component required:

http://freeaspupload.net/

 

by: waddellgPosted on 2005-11-25 at 07:31:14ID: 15361071

Hi There,

Are you using IIS6.0 as your web serverif so, there is a setting on the server that controls the size of files you can upload.

To work around this problem, follow these steps:
1. At a command prompt, type net stop iisadmin. (You need to stop the service in order to update the file.)

2. locate your IIS metabase.xml file  see (http://www.microsoft.com/technet/prodtechnol/WindowsServer2003/Library/IIS/a0ea8e51-fb2a-4e80-9d5a-7fe3ae246570.mspx) for working with this file

3. Find the entry for AspMaxRequestEntityAllowed  and change this to a higher value.

4. save the changes and restart IIS.

 

by: substandPosted on 2005-11-29 at 11:11:18ID: 15382576

That free asp thing sounds good.  I'll test it this weekend and get back.

waddellg: thanks for that information (it may be useful at some point to me) but for this project i won't be allowed to touch IIS settings

 

by: substandPosted on 2005-12-26 at 08:48:13ID: 15551273

I just wanted to apologize for how long its been (a month!) ... Its been a busy time of year and this just hasn't been on the top of my list of things to do.

Just wanted to let everyone know I haven't abandoned the question.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...