Displaying the sum of a recordset column DEPENDING on the value of another field in the recordset

<%
Total_Buy_Price = 0
Total_No_Buy_Price = 0
Total_Price = 0
Do While not rs.EOF
%>

<tr>
<td valign="top" class="Normal_Text"><% Response.write rs("item") %></td>
<td valign="top" class="Normal_Text">£<%= FormatNumber(rs("price"),2) %></td>
<td valign="top" class="Normal_Text">
     
<% If rs("buy") = "Yes" Then
Total_Buy_Price = Total_Buy_Price + rs("price")
%>
<a href="Update_Buy_No.asp?ID=<% Response.write rs("entry_id") %>"><% Response.write rs("buy") %></a>
<% else
Total_No_Buy_Price = Total_No_Buy_Price + rs("price")
 %>
<a href="Update_Buy_Yes.asp?ID=<% Response.write rs("entry_id") %>"><% Response.write rs("buy") %></a>
<% end if %>

<%
Price_Total = Price_Total + rs("price")
rs.MoveNext
Loop
%>
<pre>
Total Yes Price :<%=Total_Buy_Price%><br>
Total No Price  :<%=Total_No_Buy_Price%><br>
Total Price       :<%=Total_Price%></pre>

"...but I would like it to display the sum of rs("price") IF rs("buy") = Yes"

You answered your own question here: "IF rs("buy")=Yes"

Now look at your code: "<% If rs("buy") = "Yes" Then %>"

You want to add something to the total only if it's "buy" and you have a conditional statement that gets executed if it equals "buy". So why not just put it there? :)

Also, it's good practice to not play with recordsets. Well, not iterate through them while displaying HTML n stuff. It's better to use GetRows() as this will copy a recordset into an array. And there are many advantages to doing it this way. Check out this link: http://www.learnasp.com/freebook/asp/whygetrows.aspx for more info.

And happy coding

I have tweaked it a bit to solve any logical errors....please find it pasted below...

<%
Dim Price_Total
Price_Total = ""

Do While not rs.EOF
%>

<tr>
<td valign="top" class="Normal_Text"><% Response.write rs("item") %></td>
<td valign="top" class="Normal_Text">£<%= FormatNumber(rs("price"),2) %></td>
<td valign="top" class="Normal_Text">
     
<%
If trim(rs("buy")) = "Yes" Then

Price_Total = Price_Total + rs("price")

%>
<a href="Update_Buy_No.asp?ID=<% Response.write rs("entry_id") %>"><% Response.write rs("buy") %></a>

<%
else
%>
<a href="Update_Buy_Yes.asp?ID=<% Response.write rs("entry_id") %>"><% Response.write rs("buy") %></a>

<%
end if

rs.MoveNext
Loop
%>

Change
            Price_Total = ""
To
            Price_Total = 0

So with the change in the TYPO, the code is revamped as below....

<%
Dim Price_Total
Price_Total = 0

Do While not rs.EOF
%>

<tr>
<td valign="top" class="Normal_Text"><% Response.write rs("item") %></td>
<td valign="top" class="Normal_Text">£<%= FormatNumber(rs("price"),2) %></td>
<td valign="top" class="Normal_Text">
     
<%
If trim(rs("buy")) = "Yes" Then

Price_Total = Price_Total + rs("price")

%>
<a href="Update_Buy_No.asp?ID=<% Response.write rs("entry_id") %>"><% Response.write rs("buy") %></a>

<%
else
%>
<a href="Update_Buy_Yes.asp?ID=<% Response.write rs("entry_id") %>"><% Response.write rs("buy") %></a>

<%
end if

rs.MoveNext
Loop
%>

Note the difference in the code...

Added trim() in the line below...

If trim(rs("buy")) = "Yes" Then

It's almost the same as what I already posted above..

trim is not compulsary here, it's not necessary if we know there is not extra space in field value.

@ryancys

Your comment is right and i don't intend to harm, so i wrote "I have tweaked it a bit to solve any logical errors." in my first post...

All i wanted was to remove any possible error cause, if thats wrong then i apologise...

@lefty_gardner
Make sure you don't choose my post as solution.


No hard feelings...

Cheers