Question

Error in adding record to database

Asked by: sts901

hi
I work in my project and I have a problem in the page that  will add the order to database here is my code
can anyone help me

<%
'Check if user is logged in
if Session("name") = "" then
	'If not, go to login page
response.write("<center><p>sorry you should login</p><a href='login.asp' target='main'> login </a></center>") 
else
'add the order to the database
%>
 
<html>
<body>
<%
desc=Request.QueryString("description")
pr=Request.QueryString("price")
 
set myconn=server.createobject("ADODB.Connection")
myconn.open "DSN=myconn"
SQL_query="SELECT * FROM order"
set rs = server.createobject("ADODB.recordset")
rs.open SQL_query,myconn,1,2
rs.addnew
rs("description")
= desc
rs("price")= pr
rs.update
%>
<h2>your order have been added</h2>
<center><a href="basket.asp" target="main">go to basket</a></center>
</body>
</html>
	
<%	 
end if
%>

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-05-27 at 17:18:47ID24443550
Topic

Active Server Pages (ASP)

Participating Experts
2
Points
200
Comments
28

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. DSN connection to an access databas
    I need example code of how to connect(through DSN)to an access databas(access 2000). I need too to show information from this databas(e.g economy.mdb) in text fields in a form. P.S. I know how to create the data name source through the control panel in windows.Thanks.

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: carrzkissPosted on 2009-05-27 at 18:03:37ID: 24488995

you need an INSERT statement like this.
Not what you are trying to use.

This gathers the information from a form and then INSERT into the database
Give it a shot

Carrzkiss

<%
desc = request.form("desc")
pr = request.form("pr")
sql = "INSERT INTO order(description, price) values('"&desc&"','"&pr&"')
myconn.execute sql
%>

                                              
1:
2:
3:
4:
5:
6:

Select allOpen in new window

 

by: ryancysPosted on 2009-05-27 at 18:16:49ID: 24489049

a quick fix will be change:

rs.open SQL_query,myconn,1,2

to:

rs.open SQL_query,myconn,3,3


else try use "Insert" statement as what carrzkiss suggested above, which is executed more faster than a Recordset's AddNew method.

cheers

 

by: carrzkissPosted on 2009-05-27 at 18:19:29ID: 24489061

so there is no confusion.
I left out a Quote at the end of line 4
Corrected below

Carrzkiss

<%
desc = request.form("desc")
pr = request.form("pr")
sql = "INSERT INTO order(description, price) values('"&desc&"','"&pr&"')"
myconn.execute sql
%>
                                              
1:
2:
3:
4:
5:
6:

Select allOpen in new window

 

by: sts901Posted on 2009-05-28 at 01:20:21ID: 24490651

hello
 but I don't want to use reguest.form beacuse the desc and price variables I get them from another page using url
can you help me

 

by: sts901Posted on 2009-05-28 at 01:37:58ID: 24490772

and the description ,price variable I get them from database via url and I want to add them to order table in this page ????

 

by: ryancysPosted on 2009-05-28 at 02:08:41ID: 24490947

then try use:

desc = request.querystring("desc")
pr = request.querystring("pr")

or:


desc = request("desc")
pr = request("pr")

instead ?

 

by: sts901Posted on 2009-05-28 at 02:32:38ID: 24491100

hi
I change my code  but the same problem appear

<%
'Check if user is logged in
if Session("name") = "" then
      'If not, go to login page
response.write("<center><p> sorry you should login</p><a href='login.asp' target='main'>login</a></center>")
else
'add the order to the database
%>

<html>
<body>
<%
desc = request.querystring("description")
pr = request.querystring("price")

set myconn=server.createobject("ADODB.Connection")
myconn.open "DSN=myconn"
sql = "INSERT INTO order(description, price) values('"&desc&"','"&pr&"')"
myconn.execute sql

%>
<h2>your order have been added<h2>
<center><a href="basket.asp" target="main">go to basket </a></center>
</body>
</html>
      
<%       
end if
%>

 

by: sts901Posted on 2009-05-28 at 02:53:56ID: 24491232

and I use this url to pass the variable to this page

response.write("<td><a href=""checklogin.asp?description=" & rs("description") & "&price=" & rs("price") & """ target=""main"">add to cart</a></td>")

 

by: ryancysPosted on 2009-05-28 at 02:57:04ID: 24491251

any error you get here?

You may need to encode the values before you process it on checklogin.asp....

 

by: sts901Posted on 2009-05-28 at 02:59:56ID: 24491264

no I don't get any error in this  page work fine but the the problem in the next page.....

 

by: carrzkissPosted on 2009-05-28 at 03:23:10ID: 24491378

One thing that we have neglected to ask in this question.

What is the error that you are getting?
If this is hosted on your own computer, it could be a problem with Permissions.
As the code should work (or) give you an accurate error and code to go by.
So please give this Error to us so we can better assist you in resolving this issue.

Carrzkiss

 

by: sts901Posted on 2009-05-28 at 03:33:49ID: 24491440

this code host in my computer I change the Permissions to full control and
the error is The website cannot display the page

 

by: sts901Posted on 2009-05-28 at 03:44:53ID: 24491503

when I use server.urlencode I get this error
HTTP Error 404.0 - Not Found
The resource you are looking for has been removed, had its name changed, or is temporarily unavailable.
maybe beacuse I use arabic language in my database

 

by: sts901Posted on 2009-05-28 at 04:18:12ID: 24491682

I change the language but it doesn't work
 Requested URL http://localhost:80/project/server.urlencode("checklogin.asp?description=shampoo
Physical Path C:\inetpub\project\server.urlencode("checklogin.asp
Logon Method Anonymous
Logon User Anonymous

 

by: ryancysPosted on 2009-05-28 at 08:38:41ID: 24494459

try something like this instead:


response.write("<td><a href=""checklogin.asp?description=" & server.urlencode(rs("description")) & "&price=" & server.urlencode(rs("price")) & """ target=""main"">add to cart</a></td>")

 

by: sts901Posted on 2009-05-28 at 10:20:33ID: 24495595

I discover the problem ,it in when I want to insert data  to database but I set all permission to full control and still doesn't work can you help me sorry if I make you tired

 

by: carrzkissPosted on 2009-05-28 at 10:28:09ID: 24495655

OK
sts901
I need to know the error that you are getting
>>HTTP Error 404.0 - Not Found
Only means that it cannot be found, which means that the page is not there.
Which means that it is not working.

Are you using a form?
Please provide the entire form that you are using to pass the variables to the Insert page.
And since it is a QueryString Insert that you are doing, it should be a method="get".

Once again, we need to know the error

(You have set the proper permission, what permission did you assign?)

Carrzkiss

 

by: sts901Posted on 2009-05-28 at 10:35:37ID: 24495748

Okay this is the code in  Previous page

<html>
<head></head>
<body background="background.jpg">
<h2>hometools<h2>
<%

set myconn=server.createobject("ADODB.Connection")
 
myconn.open "DSN=myconn"
 
SQL_query="SELECT * FROM hometools"
set rs = myconn.execute(SQL_query)
response.write("<table border=1 >")

while not rs.eof
response.write("<tr>")
response.write("<td><img src =" & rs("image") & ".bmp width=100 height=100 ></td>")

response.write("<td>" & rs("description") & "</td>")

response.write("<td> price " & rs("price") & "</td>")
 

response.write("<td><a href=""checklogin.asp?description=" & server.urlencode(rs("description")) & "&price=" & server.urlencode(rs("price")) & """ target=""main"">add to cart</a></td>")

response.write("</tr>")
rs.movenext
wend
response.write("</table>")
myconn.close
set myconn=nothing
%>
</body>
</html>

 

by: sts901Posted on 2009-05-28 at 10:40:39ID: 24495802

I mean the permission on the IIS7 ...

 

by: carrzkissPosted on 2009-05-28 at 11:02:34ID: 24496025

You are not passing a Form, how are you getting your information sent to the next page?

Lets look at your code ok. It is not properly done.
You need to have a Form, it needs to be a form in order for you to submit into the database.

The below code is a sample of what you need to do. You need to have a form.
Run this and you should be able to do the Insert without a problem.
---
Permission - IIS7
IIS7 Should have it set already, but we will deal with that, after we correct your non-working code.

Carrzkiss

=-=-=-=-=-Replace your code with this Form=-=-=-=-=-
<form action="checklogin.asp" method="get">
<table>
<tr>
<td>
<input name="price" type="hidden" value="<%=rs("price")%>" /></td>
</tr><tr><td>
<input name="description" type="hidden" value="<%=rs("description")%>" /></td>
</tr><tr><td>
<input name="" type="submit" value="add to cart"></td></tr>
</table>
</form>
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:

Select allOpen in new window

 

by: sts901Posted on 2009-05-28 at 11:24:58ID: 24496284

Sorry for the trouble I make it to you because I am beginner at asp

I change the code but still it doesn't work

response.write("<table border=1 >")
response.write("<form action="checklogin.asp" method="get">")
while not rs.eof

response.write("<tr><td>")
response.write("<input name="price" type="hidden" value="<%=rs("price")%>" /></td></tr><tr><td>")

response.write("<input name="description" type="hidden" value="<%=rs("description")%>" /></td></tr><tr><td>")
response.write("<input name="" type="submit" value="add to cart"></td></tr></table></form>")
 
 
rs.movenext
wend
response.write("</table>")

 

by: sts901Posted on 2009-05-28 at 11:40:10ID: 24496472

sorry like this
while not rs.eof
response.write("<table border=1 >")
response.write("<form action='checklogin.asp' method='get'>")
response.write("<tr><td>")
response.write("<input name='price' type='hidden' value='<%=rs("price")%>' /></td></tr><tr><td>")

response.write("<input name='description' type='hidden' value='<%=rs("description")%>' /></td></tr><tr><td")
response.write("<input name='' type='submit' value='add to cart'></td></tr>"")
 
response.write("</table></form>")
 
rs.movenext
wend

 

by: carrzkissPosted on 2009-05-28 at 12:12:30ID: 24496836

This should do it for you.

Carrzkiss

<%@LANGUAGE="VBSCRIPT" CODEPAGE="65001"%>
<html>
<head></head>
<body background="background.jpg">
<h2>hometools<h2>
<%
 
set myconn=server.createobject("ADODB.Connection")
 
myconn.open "DSN=myconn"
 
SQL_query="SELECT * FROM hometools"
set rs = myconn.execute(SQL_query)
response.write("<form action='checklogin.asp' method='get'>")
response.write("<table border=1 >")
 
while not rs.eof
response.write("<tr>")
response.write("<td><img src =" & rs("image") & ".bmp width=100 height=100 ></td>")
 
response.write("<td>" & rs("description") & "</td>")
 
response.write("<td> price " & rs("price") & "</td>")
 
 
response.write("<td><input name='Submit' type='submit' value='add to cart'></td>")
 
response.write("</tr>")
rs.movenext
wend
response.write("</table></form>")
myconn.close
set myconn=nothing
%>
</body>
</html> 

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:

Select allOpen in new window

 

by: carrzkissPosted on 2009-05-28 at 12:15:37ID: 24496875

May I also suggest?
If you are going to be passing a lot of information in the [description]
You really need to do a
request.form
Instead of
request.querystring.

2 reasons
#1: Makes your URL look crappy with a lot of %20 and all the other mess that is in the string.
#2: There is less confusion with interpreting the values when it is done through a form.

Anyway.
Good Luck
Carrzkiss

 

by: sts901Posted on 2009-05-28 at 12:31:17ID: 24497028

Thank you very much
but the insert won't work

 

by: carrzkissPosted on 2009-05-28 at 14:31:50ID: 24498054

Simple over site.
You are using a reserved word.  order
(More about reserved words) http://support.microsoft.com/?id=248738
As your Table name.
So. we have to change the INSERT code to reflect this issue
order
to
[order]

All statements that you make have to use the table name in Brackets.   [order]
(or) to get away from this issue, you can simple change your table name to MyOrder or something
Else that is not a reserved word.

http://ee.cffcs.com/Q_24443550/Q_24443550.asp
code
http://ee.cffcs.com/Q_24443550/Q_24443550.zip

This is an example of doing this in a Request.form and request.querystring.
(This example does not use your  hometools   table)

Good Luck
Carrzkiss

 

by: sts901Posted on 2009-05-28 at 16:43:35ID: 24498976

thank you so much ^-^

 

by: carrzkissPosted on 2009-05-28 at 17:00:13ID: 24499087

you are welcome.
It took a little while to catch on to the Reserved name issue.

Keep it up, you will catch on to it.
Just remember, in order to pass records properly and without issue, always use a form.

Have a good one.
Carrzkiss

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...