Question

Getting extra row before div - expand collapse code in ASP

Asked by: lakki

I need to create expand/collapse feature in ASP. Toggle works fine. I have put the content to be shown/hidden inside div tag. The div tag is shown/hidden using javascript method.
When the div is hidden, I am getting extra row. I noticed that div is inside <TR>. I am hiding/showing div but not doing anything about <TR>. That means the extra row is created by <TR>. If I put <TR> inside div toggle functionality does not work.



Please help how to fix this

<TABLE>
<TR><a href=# onClick="toggleDisplay('test')"><td colspan=2></td></tr>
<tr><td colspan=2>
    <div id='test'>
      <table>
       <tr><td>test1</td><td>test2</td></tr>
      </table>
    </div>
</td></tr>
</TABLE>
 
 
javascript method to toggle:
----------------------------
function toggleDisplay(id) {
  var obj = document.getElementById(id);    
  obj.style.display=(obj.style.display=="none")? "":"none"; 
  return false;
}

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2008-01-10 at 11:52:31ID23073679
Topics

Hypertext Markup Language (HTML)

,

Dynamic HTML (DHTML)

,

Active Server Pages (ASP)

Participating Experts
2
Points
0
Comments
18

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. divs
    I want to use javascripts with divs stuffs but my whole layout is in tables is there an easy way so they are all converted into divs?? <%@LANGUAGE="VBSCRIPT" CODEPAGE="1252"%> <!--#include file="Connections/spring_temp.asp" --> <% ...
  2. javascript toggle
    I have a javascript toggle function below, and I am trying to figure out how I can replace the images with plus and minus images based on the expanding and collapsing of the menu's. See code below: function Toggle(item) { obj=document.getElementById(item); visible=...
  3. Toggle on Div in repeater
    I have a toggleon/off div tag insode a repeater. It works...but ONLY toggles the top "repeated" div. Activater and action div both inside repeater
  4. Dynamic Div Styles on toggle
    I have a main div with a show/hide div within. When the show/hide div is toggled, I would like to change the main div's styling. Where currently the class is "recordwrapper closed" I would like to switch to "recordwrapper open" when 2nd div is displayed. ...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: SquareHeadPosted on 2008-01-10 at 12:06:14ID: 20630581

You try this instead:

obj.style.visibility=(obj.style.visibility=="hidden")? "":"hidden";

 

by: lakkiPosted on 2008-01-10 at 12:27:02ID: 20630817

Sorry Sage, it did not work.

 

by: SquareHeadPosted on 2008-01-10 at 12:32:36ID: 20630875

ah, I see what you mean... Sorry, didn't look at your code closely enough.

Try this: assign the onclick to the TR and not an HREF between the TR & TD... like this:

<TABLE>
<tr onClick="toggleDisplay('test')"><td colspan=2>
    <div id='test'>
      <table>
       <tr><td>test1</td><td>test2</td></tr>
      </table>
    </div>
</td></tr>
</TABLE>
 
 
 
 
<script>
function toggleDisplay(id) {
  var obj = document.getElementById(id);    
  obj.style.display=(obj.style.display=="none")? "":"none"; 
  return false;
}
 
</script>

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:

Select allOpen in new window

 

by: lakkiPosted on 2008-01-10 at 12:52:22ID: 20631081

I still have the same problem.
In my code snippet
line#2 <TR> is always visible. It has the toggle link/button. By clicking on it, user should be able to see TR in line3.
I tried removing <tr> in line 3 before <div>. Then toggle code does not work. Seems to me that <div> should be in a <TR> if it is embedded inside <table>

 

by: SquareHeadPosted on 2008-01-10 at 12:57:18ID: 20631128

I think you need to assign the ID to the TR, not the DIV.

 

by: SquareHeadPosted on 2008-01-10 at 12:59:06ID: 20631150

Like this:

<TABLE>
<tr onClick="toggleDisplay('test')"><td colspan=2>
hide TR</td></tr>
<tr ID="test"><td colspan=2>
    <div>
      <table>
       <tr><td>test1</td><td>test2</td></tr>
      </table>
    </div>
</td></tr>
</TABLE>

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:

Select allOpen in new window

 

by: lakkiPosted on 2008-01-10 at 13:00:45ID: 20631164

Before expand/collapse code this is how my code is:
<TABLE>
<TR><td>test1</td><td>test2</td></tr>
<tr><td>test3</td><td>test4</td></tr>
<tr><td>test5</td><td>test6</td></tr>
</TABLE>

The requirement is: When user toggles on row1 then only I need to show last two rows.
Then I started using div tag concept. Is there any other solution to achieve this

 

by: SquareHeadPosted on 2008-01-10 at 13:02:40ID: 20631182

like this:

<TABLE border="1">
<tr onClick="toggleDisplay('test');toggleDisplay('test2');"><td colspan=2>
hide TR</td></tr>
<tr ID="test"><td colspan=2>
    <div>
      <table>
       <tr><td>test1</td><td>test2</td></tr>
      </table>
    </div>
</td></tr>
<tr ID="test2"><td colspan=2>
    <div>
      <table>
       <tr><td>test1</td><td>test2</td></tr>
      </table>
    </div>
</td></tr>
</TABLE>

 

by: lakkiPosted on 2008-01-10 at 13:06:38ID: 20631226

how do I show/hide the <TR>

 

by: SquareHeadPosted on 2008-01-10 at 14:32:09ID: 20632108

in my example, you click the top row to hide or show the bottom 2 rows. Note that clicking on the text in the top row may not do anything... In which case, consider also using the onclick event for the text, too, to toggle the show/hide.

 

by: SquareHeadPosted on 2008-01-10 at 15:10:18ID: 20632373

Does my example do what you need it to?

 

by: lakkiPosted on 2008-01-11 at 11:12:08ID: 20639203


Right now I am using the idea of hiding/showing TR instead of div.

In your code snippet at line2
<tr onClick="toggleDisplay('test');toggleDisplay('test2');"><td colspan=2>
At this stage I do not know how many rows I have later. So I do not know about 'test' and 'test2' names

I have written javascript method. I have 2721 TR rows in one sample. Since I am using for loop , upon each toggle click it is taking a minute to process. Is there an easier way to fix this.

<TABLE border="1">
function toggleDisplay('testRow') {  
var trs = document.getElementsByTagName('TR');
var trsId
//alert(trs.length);//2721
 for(var i=0; i<trs.length; i++)
 {
   if (trs[i].id!="" && trs[i].id!="undefined") {
     trsId = trs[i].id;
   }	
   if (trsId.indexOf(idTest)!=-1) {         
	var obj = document.getElementById(trsId);  
	obj.style.display=(obj.style.display=="none")? "":"none"; 
   }
} 
}
return false;
 
	
}
</script>   

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:

Select allOpen in new window

 

by: SquareHeadPosted on 2008-01-11 at 13:33:49ID: 20640757

That's a lot of rows. Do you have to have your toggle control in one of the rows? Alternatives would include:

1. placing the toggle control outside the table that has all those rows, then hiding the table rather than individual rows.

2. keeping all rows that are to be hidden in their own table, then hiding that.

3. if your toggle must appear in a row, consider having two or more tables - one table for the toggle control row and other rows that are not to be hidden, and one table for only those rows to be hidden.

looping through a large number of anything and then taking some sort of action, can have a negative affect on performance, while acting on one single object, like a table with a bunch of rows, should be much faster.

 

by: lakkiPosted on 2008-01-11 at 13:51:14ID: 20640962

I could resolve the issues using <tbody> instead of <div>. Please see my code snippet

<table>
<tr><td><a href=# onClick=toggleDisplay('Always1')>Always1</a></td></tr>
<tbody id='Always1'>
      <tr><td>Toggle1</td></tr>
      <tr><td>Toggle2</td></tr>
</tbody>
<tr><td><a href=# onClick=toggleDisplay('Always2')>Always2</a></td></tr>
<tbody id='Always2'>
      <tr><td>Toggle3</td></tr>
      <tr><td>Toggle4</td></tr>
</tbody>
<tr><td>Always3</td></tr>
</table>
 
Javascript method
------------------------
function toggleDisplay(idTest) {
	if (idTest!="" && idTest!="undefined") {			
		var obj = document.getElementById(idTest);  
		if (obj!=null) {
			obj.style.display=(obj.style.display=="none")? "":"none"; 
		}
	}
	return false;
}

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:

Select allOpen in new window

 

by: SquareHeadPosted on 2008-01-11 at 14:42:36ID: 20641420

Not sure if that's valid html, having the tbody tag in that position... You can check by running it through the markup validator at w3.org:
http://www.w3.org/QA/Tools/#validators

 

by: lakkiPosted on 2008-01-16 at 12:25:13ID: 20675708

Thanks for the link. I have used the markup validator and the Cleaned-up Source Listing with "Tidy" gave the code similar to above. No complaints about the positioning of tbody.

<table>
<tr><td><a href="#" onclick="toggleDisplay('Always1')">Always1</a></td></tr>
<tbody id='Always1'>
	<tr><td>Toggle1</td></tr>
	<tr><td>Toggle2</td></tr>
</tbody>
<tr><td><a href="#" onclick="toggleDisplay('Always2')">Always2</a></td></tr>
<tbody id='Always2'>
	<tr><td>Toggle3</td></tr>
	<tr><td>Toggle4</td></tr>
</tbody>
<tr><td>Always3</td></tr>
</table>
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:

Select allOpen in new window

 

by: Computer101Posted on 2008-02-28 at 18:00:25ID: 21010061

PAQed with points refunded (250)

Computer101
EE Admin

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...